summaryrefslogtreecommitdiffstats
path: root/chrome/browser/download
Commit message (Collapse)AuthorAgeFilesLines
...
* Disables the download item on the download-shelf when the file is opened.jcampan@chromium.org2009-04-073-3/+15
| | | | | | | | | | | This is to mitigate against multiple clicks when a file takes some time to show anything to the user when opened (typically a setup.exe). By changing the title and disabling the button, we indicate to the user that an action was taken. BUG=7264 TEST=Download a file (image for example). In the download shelf, press the download item. The download item text should change to "Opening..." and it should be disabled (not responsive to clicks/drag and drops). Review URL: http://codereview.chromium.org/58014 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13273 0039d316-1c4b-4281-b951-d872f2087c98
* Switching things to FilePath:phajdan.jr@chromium.org2009-04-072-2/+1
| | | | | | | | | | | | | | | | Remove following deprecated wstring-using functions: net/net_util: FilePathToFileURL net/net_util: FileURLToFilePath Switch net/base/upload_data to FilePath. Switch upload-related parts of net/url_request/url_request to FilePath. Made necessary adjustments in rest of code (a lot). Review URL: http://codereview.chromium.org/63011 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13242 0039d316-1c4b-4281-b951-d872f2087c98
* First pass of refactoring dialogs.avi@chromium.org2009-04-064-18/+16
| | | | | | Review URL: http://codereview.chromium.org/60110 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13168 0039d316-1c4b-4281-b951-d872f2087c98
* Fix a crash when canceling a save page operation.paulg@google.com2009-04-061-3/+11
| | | | | | | | | | | | | | | | | This crash occurs under the following conditions: 1. Launch Chrome and navigate to any web page 2. Save that page (via ctrl+s or menu option) 3. Click cancel in the Save As dialog box that appears 4. Save the page again This fix checks to see if the SavePackage was initialized when handling a stop operation, and skips it if nothing has started. BUG=9738 (http://crbug.com/9738) Review URL: http://codereview.chromium.org/62048 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13148 0039d316-1c4b-4281-b951-d872f2087c98
* Remove some uses of custom tab contents types from some tests.brettw@chromium.org2009-04-041-33/+30
| | | | | | | | | | | | | | | This required redoing the tests that used it to use the new RenderViewHost test harness. This is mostly straightforward, but required more work for the NavigationController tests. I removed a few random places that were testing for the tab types. I also made different versions of a few functions that don't take tab contents types next to the existing ones that do, so my touched code won't have to be changed again when I remove the tab contents types. Review URL: http://codereview.chromium.org/62039 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13132 0039d316-1c4b-4281-b951-d872f2087c98
* Adds temporary warning when installing Chrome extensions. The warninggeorged@chromium.org2009-04-031-0/+16
| | | | | | | | | will be replaced with the final extension installation UI when available. Review URL: http://codereview.chromium.org/60079 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13103 0039d316-1c4b-4281-b951-d872f2087c98
* Only create one downloads tab per window. If there is already a Downloadsestade@chromium.org2009-04-021-1/+1
| | | | | | | | | | tab, then switch to it instead of creating new one. Introduce FOCUS_SINGLETON_TAB disposition. patch by Mohamed Mansour <http://codereview.chromium.org/50003/show> Review URL: http://codereview.chromium.org/60062 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13045 0039d316-1c4b-4281-b951-d872f2087c98
* Installing extensions (drag/drop, download crx file) will now begeorged@chromium.org2009-04-015-8/+73
| | | | | | | | | handled by the Chrome instance w/o shell execute. This will install the extension in the proper profile using the running bits. Review URL: http://codereview.chromium.org/55046 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13000 0039d316-1c4b-4281-b951-d872f2087c98
* Re-enable save package on linux, mac.estade@chromium.org2009-04-012-12/+16
| | | | | | Review URL: http://codereview.chromium.org/56153 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@12966 0039d316-1c4b-4281-b951-d872f2087c98
* Don't create an empty folder when saving complete html pages with no extra ↵estade@chromium.org2009-03-311-3/+3
| | | | | | | | | | resources to save. patch by Paul Robinson <http://codereview.chromium.org/57030> Review URL: http://codereview.chromium.org/56089 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@12897 0039d316-1c4b-4281-b951-d872f2087c98
* Delete downloads after updating observers.paulg@google.com2009-03-311-3/+7
| | | | | | | | | | | | | | | | | | The download page adds itself as an observer to in-progress and unconfirmed dangerous downloads, and removes itself when the download manager indicates its state has changed. This caused a crash when the downloads were deleted during a "clear browsing data" operation, since the delete happened before the download page was notified of a download manager state change. The download page then attempted to remove itself from a deleted item. BUG=9444 (http://crbug.com/9444) Review URL: http://codereview.chromium.org/56096 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@12874 0039d316-1c4b-4281-b951-d872f2087c98
* Mechanic change based on comment from previous code review.huanr@chromium.org2009-03-311-2/+2
| | | | | | | | | Rename RunCommand to RunCommandAsync and RunCommandSync to RunCommand. Review URL: http://codereview.chromium.org/57039 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@12836 0039d316-1c4b-4281-b951-d872f2087c98
* Remove Windows "Save As" dialogs from Save Page code.In this change:- ↵paulg@google.com2009-03-304-109/+137
| | | | | | | | convert SavePackage to use async SelectFileDialog- return the chosen filter index in the FileSelected callback- some clean up of save_package.ccBUG=8691 (http://crbug.com/8691) Review URL: http://codereview.chromium.org/45048 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@12799 0039d316-1c4b-4281-b951-d872f2087c98
* Move message flags into a separate header that can be usedtc@google.com2009-03-271-1/+2
| | | | | | | | | outside the views system. Mac will need this as well when implementing message boxes. Review URL: http://codereview.chromium.org/56026 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@12722 0039d316-1c4b-4281-b951-d872f2087c98
* Fix a race condition opening a downloaded file.paulg@google.com2009-03-271-6/+8
| | | | | | | | | | | | | | There is a potential race condition where we attempt to open, via the shell, a fast completing download before it has been renamed. This fix posts the rename operation before calling DownloadFinished, which posts the shell open. BUG=3954 (http://crbug.com/3954) Review URL: http://codereview.chromium.org/42685 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@12676 0039d316-1c4b-4281-b951-d872f2087c98
* Add an exception to DownloadManager::GenerateExtension() for .tar.gz files ↵thestig@chromium.org2009-03-252-1/+21
| | | | | | | | | with mime_type "application/x-tar". BUG=5772 Review URL: http://codereview.chromium.org/42622 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@12509 0039d316-1c4b-4281-b951-d872f2087c98
* Implement basic ShowItemInFolder for linux.estade@chromium.org2009-03-242-17/+5
| | | | | | | | | Note that this only works if you are using a gnome or kde session. Support for other sessions will be added in the future. Review URL: http://codereview.chromium.org/52034 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@12395 0039d316-1c4b-4281-b951-d872f2087c98
* Fix DCHECK in DownloadRequestDialogDelegateWin::DeleteDelegatefinnur@chromium.org2009-03-201-3/+0
| | | | | | | | | | | | | | | | | | | | | | This DCHECK occurs when we click Allow on the "This webpage is trying to download multiple files" dialog. When... DownloadRequestDialogDelegate ... and ... DownloadRequestDialogDelegateWin ... were created, both classes by accident contained a host_ member. This causes a DCHECK in... DownloadRequestDialogDelegateWin::DeleteDelegate() ... because the host_ in the child class is never initialized. I believe the intent is to check the host_ of the parent class, so I deleted the definition of host from xxxDelegateWin. Review URL: http://codereview.chromium.org/50072 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@12220 0039d316-1c4b-4281-b951-d872f2087c98
* Merge DOMUIContents into WebContents.brettw@chromium.org2009-03-171-3/+3
| | | | | | | I did a lot of cleanup of the DOM UI system as part of this. Review URL: http://codereview.chromium.org/42227 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11925 0039d316-1c4b-4281-b951-d872f2087c98
* Move controls into their own dir under chrome/views/controlsben@chromium.org2009-03-172-2/+2
| | | | | | | | TBR=sky Review URL: http://codereview.chromium.org/48058 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11841 0039d316-1c4b-4281-b951-d872f2087c98
* bustage fix - moved fileben@chromium.org2009-03-171-1/+1
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11829 0039d316-1c4b-4281-b951-d872f2087c98
* Removed unneeded includes of base/time.h.thestig@chromium.org2009-03-161-1/+0
| | | | | | Review URL: http://codereview.chromium.org/48019 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11766 0039d316-1c4b-4281-b951-d872f2087c98
* Implement DownloadFile::Rename() for posix. Downloads work on linux!estade@chromium.org2009-03-131-10/+8
| | | | | | Review URL: http://codereview.chromium.org/46020 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11659 0039d316-1c4b-4281-b951-d872f2087c98
* Removed unneeded includes of base/scoped_ptr.h. Reduce usage from ~800 files ↵thestig@chromium.org2009-03-132-2/+0
| | | | | | | | to ~400. Review URL: http://codereview.chromium.org/46039 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11651 0039d316-1c4b-4281-b951-d872f2087c98
* Reverting 11642.finnur@chromium.org2009-03-131-2/+2
| | | | | | | Reverting for now. Will try again later Review URL: http://codereview.chromium.org/46046 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11648 0039d316-1c4b-4281-b951-d872f2087c98
* Disabling a couple of UI tests while I investigate.finnur@chromium.org2009-03-131-2/+2
| | | | | | | TBR=ojan Review URL: http://codereview.chromium.org/46040 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11642 0039d316-1c4b-4281-b951-d872f2087c98
* Gtk dialogs, first cut.estade@chromium.org2009-03-122-6/+17
| | | | | | | | Only the Save As file selection dialog is implemented for now. Review URL: http://codereview.chromium.org/42152 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11594 0039d316-1c4b-4281-b951-d872f2087c98
* Remove logging.h from cc files that don't use it.thestig@chromium.org2009-03-122-2/+0
| | | | | | Review URL: http://codereview.chromium.org/42155 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11593 0039d316-1c4b-4281-b951-d872f2087c98
* Remove unneeded uses of logging.h in header files.thestig@chromium.org2009-03-121-0/+2
| | | | | | Review URL: http://codereview.chromium.org/43148 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11590 0039d316-1c4b-4281-b951-d872f2087c98
* Stop having renderers use both pids and a monotonically increasing ↵jam@chromium.org2009-03-122-4/+4
| | | | | | | | "host_id". This allows ResourceDispatcher to be used by child processes other than renderers. I've done minor related cleanup on the way to make the code simpler. Review URL: http://codereview.chromium.org/42054 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11509 0039d316-1c4b-4281-b951-d872f2087c98
* Change to make the 'save as...' dialog choose the default download path you ↵maruel@chromium.org2009-03-111-3/+12
| | | | | | | | | | | | | have selected in your prefs instead of always choosing the chrome::DIR_DEFAULT_DOWNLOADS path. This will only affect you if you have not used 'save as...' before and do not have a SaveFileDefaultDirectory set. Patch contributed by Paul Robinson <paulRobinson85@googlemail.com> BUG=8049 Review URL: http://codereview.chromium.org/43016 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11465 0039d316-1c4b-4281-b951-d872f2087c98
* Hopefully make DownloadTest.UnknownSize not-flaky.phajdan.jr@chromium.org2009-03-111-2/+1
| | | | | | | | http://crbug.com/7191 Review URL: http://codereview.chromium.org/43046 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11459 0039d316-1c4b-4281-b951-d872f2087c98
* Remove TabContents from scaffolding. Yay!pinkerton@chromium.org2009-03-111-1/+1
| | | | | | Review URL: http://codereview.chromium.org/43039 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11435 0039d316-1c4b-4281-b951-d872f2087c98
* NO CODE CHANGEdeanm@chromium.org2009-03-1018-18/+0
| | | | | | | | | Normalize end of file newlines in chrome/. All files end in a single newline. Review URL: http://codereview.chromium.org/42015 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11331 0039d316-1c4b-4281-b951-d872f2087c98
* Enable download_request_manager_unittest on linux.estade@chromium.org2009-03-091-4/+19
| | | | | | Review URL: http://codereview.chromium.org/41002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11288 0039d316-1c4b-4281-b951-d872f2087c98
* hook up history and download menu itemstc@google.com2009-03-091-5/+0
| | | | | | | | | | Small fix to get them to display (need to include webkit strings in our language pak files). Review URL: http://codereview.chromium.org/39296 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11286 0039d316-1c4b-4281-b951-d872f2087c98
* Test to see if we can reduce some crashes by deferring delegate destruction ↵ben@chromium.org2009-03-062-2/+2
| | | | | | | | until WM_NCDESTROY. This involves adding a specific method to allow delegates to destroy themselves to WindowDelegate, and moving all delete this calls into implementations of that method (to allow delegates to still respond to WM_DESTROY which is legit). Review URL: http://codereview.chromium.org/40192 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11132 0039d316-1c4b-4281-b951-d872f2087c98
* Refactor the download shelf context menu in preparation for porting.estade@chromium.org2009-03-064-252/+139
| | | | | | | | | | | * Delete DownloadDestinationContextMenu, which is not used anywhere. * Delete the unused download menu item types from the ContextMenuCommands enum. * Merge BaseContextMenu and DownloadShelfContextMenu, move them from download_util.{h,cc} to download_shelf.{h,cc} * Take the windows-specific code from the new DownloadShelfContextMenu and put it in DownloadShelfContextMenuWin in download_item_view.cc (the only place it's used). DownloadShelfContextMenuWin extends DownloadShelfContextMenu and Menu::Delegate. Review URL: http://codereview.chromium.org/40184 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11068 0039d316-1c4b-4281-b951-d872f2087c98
* NO CODE CHANGE.maruel@google.com2009-03-051-2/+2
| | | | | | | Split the lines >80 cols. (Part 1) Review URL: http://codereview.chromium.org/39206 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11032 0039d316-1c4b-4281-b951-d872f2087c98
* Fixes CRLF and trailing white spaces.maruel@chromium.org2009-03-052-4/+4
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@10982 0039d316-1c4b-4281-b951-d872f2087c98
* Basic download shelf implementation on linux.estade@chromium.org2009-03-043-4/+8
| | | | | | | | | | It shows and hides at appropriate times, and that's about it. TEST=navigate to a savable page and select "save page as" from the page menu. Click the x. Save the page again. The shelf should pop up, go away, pop up again. Review URL: http://codereview.chromium.org/38004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@10927 0039d316-1c4b-4281-b951-d872f2087c98
* Update clipboard classes to use string16 and FilePath instead of wstring.estade@chromium.org2009-03-041-3/+3
| | | | | | | | | | Update callers as well. This patch builds on a patch by mark.a.lindner@gmail.com which can be found at http://codereview.chromium.org/28294 Review URL: http://codereview.chromium.org/27370 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@10860 0039d316-1c4b-4281-b951-d872f2087c98
* Add FilePath setter/getter to pref service. Change callers to use it rather ↵estade@chromium.org2009-03-042-4/+4
| | | | | | | | | | | | | than the string methods. Update the pref service unit test and enable it on linux. Also switch over some wstrings to filepaths where appropriate. BUG=8154 Review URL: http://codereview.chromium.org/27354 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@10844 0039d316-1c4b-4281-b951-d872f2087c98
* Implement some chrome path getters for Mac OS and un-comment their uses in ↵pinkerton@chromium.org2009-03-031-11/+0
| | | | | | | | the download manager. Move chrome_paths_mac from a .cc to a .mm to allow Cocoa. Review URL: http://codereview.chromium.org/39041 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@10820 0039d316-1c4b-4281-b951-d872f2087c98
* Refactor download shelf and prepare for porting.estade@chromium.org2009-02-285-22/+95
| | | | | | | | Side effect of removing some views dependencies from places they don't belong. Review URL: http://codereview.chromium.org/28252 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@10657 0039d316-1c4b-4281-b951-d872f2087c98
* OS_MAC should be OS_MACOSX.wtc@chromium.org2009-02-261-1/+1
| | | | | | | R=brettw Review URL: http://codereview.chromium.org/28157 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@10438 0039d316-1c4b-4281-b951-d872f2087c98
* Coalesce more hardcoded schemes to using predefined constants.brettw@chromium.org2009-02-261-2/+5
| | | | | | Review URL: http://codereview.chromium.org/31008 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@10437 0039d316-1c4b-4281-b951-d872f2087c98
* Get save page working on posix.estade@chromium.org2009-02-251-8/+4
| | | | | | | | | | * rearrange some IFDEFs * trim whitespace on suggest name Also fix a relatively new bug in DomSerializer. Review URL: http://codereview.chromium.org/27106 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@10314 0039d316-1c4b-4281-b951-d872f2087c98
* Final step needed to get be able to download things on linux.estade@chromium.org2009-02-241-11/+15
| | | | | | | | There's still no UI though. Review URL: http://codereview.chromium.org/27097 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@10299 0039d316-1c4b-4281-b951-d872f2087c98
* Download request manager refactoring.estade@chromium.org2009-02-245-183/+260
| | | | | | | | | | Pull out the dialog delegate to a separate file so we can swap it out with other implementations on other platforms. Also, build download_request_manager.cc on POSIX. Review URL: http://codereview.chromium.org/27062 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@10270 0039d316-1c4b-4281-b951-d872f2087c98
generated by cgit v1.1 at 2025-02-12 05:39:31 +0000