summaryrefslogtreecommitdiffstats
path: root/chrome/browser/download
Commit message (Collapse)AuthorAgeFilesLines
* Remove unnecessary Profile parameter from GetPopup.mirandac@chromium.org2011-06-241-1/+1
| | | | | | | | | BUG=86361 TEST=active downloads tests. Review URL: http://codereview.chromium.org/7204052 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@90366 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 90228 - Next round of checks to figure out what invariant is failing.rdsmith@chromium.org2011-06-231-4/+0
| | | | | | | | | | | | | BUG=85408 TEST= Review URL: http://codereview.chromium.org/7215039 TBR=rdsmith@chromium.org Review URL: http://codereview.chromium.org/7249011 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@90248 0039d316-1c4b-4281-b951-d872f2087c98
* Get rid of a few FilePath tmp objects/copies.achuith@chromium.org2011-06-231-3/+3
| | | | | | | | | BUG=NONE TEST=NONE Review URL: http://codereview.chromium.org/7238005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@90247 0039d316-1c4b-4281-b951-d872f2087c98
* Next round of checks to figure out what invariant is failing.rdsmith@chromium.org2011-06-231-0/+4
| | | | | | | | | | BUG=85408 TEST= Review URL: http://codereview.chromium.org/7215039 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@90228 0039d316-1c4b-4281-b951-d872f2087c98
* Switch to GetConstrainingContentsWrapper.avi@chromium.org2011-06-233-43/+38
| | | | | | | | | BUG=76697 TEST=no visible change when downloading Review URL: http://codereview.chromium.org/7008019 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@90210 0039d316-1c4b-4281-b951-d872f2087c98
* Localize strings, speeds.avi@chromium.org2011-06-223-15/+16
| | | | | | | | | BUG=86527 TEST=run in non-English. For European languages, during a download the decimal separators should be commas (e.g. "0,0 MB"). (The speeds are in strings files and might take a little time to run through the translation machinery.) Review URL: http://codereview.chromium.org/7189076 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@90092 0039d316-1c4b-4281-b951-d872f2087c98
* Coverity: Null returns and negative returnskmadhusu@chromium.org2011-06-221-0/+1
| | | | | | | | | | CID = 14804, 16939, 16937, 16904, 16793, 16308, 14956, 15404, 11823 BUG=none TEST=none Review URL: http://codereview.chromium.org/7211019 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@90088 0039d316-1c4b-4281-b951-d872f2087c98
* Coverity Fixlet - PASS_BY_VALUEscr@chromium.org2011-06-222-3/+3
| | | | | | | | | | | CID=16438,16924 BUG= TEST= Review URL: http://codereview.chromium.org/7216023 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@90052 0039d316-1c4b-4281-b951-d872f2087c98
* Test download manager fetching CRXes.skerner@chromium.org2011-06-228-73/+445
| | | | | | | | | | | | | | | First round of tests for the download manager handling CRXes. Platform-specific UI interactions are not covered by these tests. It would be nice to test that animations are running. I can't see a way to do that without adding accessors to the platform-specific download item UI classes. Paweł, you expressed concern about *ForTesting() methods before. Is there a better way to test that animations are working? BUG=80010 TEST=DownloadTest.Crx* Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=89496 Review URL: http://codereview.chromium.org/7104060 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@90029 0039d316-1c4b-4281-b951-d872f2087c98
* Rename chrome/browser/cocoa to chrome/browser/mac.mark@chromium.org2011-06-201-1/+1
| | | | | | | | | | | | | | | | | chrome/browser/cocoa was created in r74529 under Carnitas to break non-UI files from chrome/browser/ui/cocoa out of that directory. These non-UI files for the most part have nothing to do with Cocoa. It would be more appropriate to name this directory "mac". Three shell scripts used only by files that now live in this directory never moved along with their associated files. I'm moving them to the proper location now. BUG=none, or whatever bug tracks Carnitas cleanups TEST=none Review URL: http://codereview.chromium.org/7204034 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@89742 0039d316-1c4b-4281-b951-d872f2087c98
* Make sure that the download is shown in the browser window of the correct ↵mirandac@chromium.org2011-06-201-1/+1
| | | | | | | | | | | profile. BUG=86361 TEST=download manager tests continue to not fail. Review URL: http://codereview.chromium.org/7202005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@89698 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 89496 - Test download manager fetching CRXes.cevans@chromium.org2011-06-208-442/+73
| | | | | | | | | | | | | | | | | First round of tests for the download manager handling CRXes. Platform-specific UI interactions are not covered by these tests. It would be nice to test that animations are running. I can't see a way to do that without adding accessors to the platform-specific download item UI classes. Paweł, you expressed concern about *ForTesting() methods before. Is there a better way to test that animations are working? BUG=80010 TEST=DownloadTest.Crx* Review URL: http://codereview.chromium.org/7104060 TBR=skerner@chromium.org Review URL: http://codereview.chromium.org/7205024 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@89635 0039d316-1c4b-4281-b951-d872f2087c98
* Treat ERR_CONNECTION_CLOSED as a succesful download.cbentzel@chromium.org2011-06-181-1/+6
| | | | | | | | | | | | | | | | | Some servers will send a Content-Length which exceeds the number of bytes sent in the message body. Although this violates the RFC spec, other major browsers permit it and treat a download as complete in that case. Chrome did as well prior to M12, and now some users are unable to access the item that they downloaded. BUG=85549 TEST=Go to server which advertises larger Content-Length than number of bytes sent, confirm that the download is no longer reported as interrupted. Review URL: http://codereview.chromium.org/7203004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@89600 0039d316-1c4b-4281-b951-d872f2087c98
* Added more UMA logging for interrupted downloads.ahendrickson@chromium.org2011-06-173-8/+55
| | | | | | | | | | BUG=None TEST=None Review URL: http://codereview.chromium.org/7191026 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@89542 0039d316-1c4b-4281-b951-d872f2087c98
* Test download manager fetching CRXes.skerner@chromium.org2011-06-178-73/+442
| | | | | | | | | | | | | | First round of tests for the download manager handling CRXes. Platform-specific UI interactions are not covered by these tests. It would be nice to test that animations are running. I can't see a way to do that without adding accessors to the platform-specific download item UI classes. Paweł, you expressed concern about *ForTesting() methods before. Is there a better way to test that animations are working? BUG=80010 TEST=DownloadTest.Crx* Review URL: http://codereview.chromium.org/7104060 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@89496 0039d316-1c4b-4281-b951-d872f2087c98
* New assertion checks for DownloadItem <-> DownloadManager queue consistency.rdsmith@chromium.org2011-06-163-9/+37
| | | | | | | | | | BUG=85408 TEST= Review URL: http://codereview.chromium.org/7191012 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@89372 0039d316-1c4b-4281-b951-d872f2087c98
* Re-land:ben@chromium.org2011-06-161-1/+1
| | | | | | | | | | | | | | Move private NativeWidget methods to new internal interface NativeWidgetPrivate. This should make it harder to abuse accidentally. BUG=72040 TEST=none Review URL: http://codereview.chromium.org/7170019 Review URL: http://codereview.chromium.org/7189012 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@89357 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 89216 - Move private NativeWidget methods to new internal interface ↵ben@chromium.org2011-06-151-1/+1
| | | | | | | | | | | | | | | NativeWidgetPrivate. This should make it harder to abuse accidentally. BUG=72040 TEST=none Review URL: http://codereview.chromium.org/7170019 TBR=ben@chromium.org Review URL: http://codereview.chromium.org/7097016 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@89232 0039d316-1c4b-4281-b951-d872f2087c98
* Move private NativeWidget methods to new internal interface NativeWidgetPrivate.ben@chromium.org2011-06-151-1/+1
| | | | | | | | | | This should make it harder to abuse accidentally. BUG=72040 TEST=none Review URL: http://codereview.chromium.org/7170019 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@89216 0039d316-1c4b-4281-b951-d872f2087c98
* Detect removed files and reflect the state in chrome://downloads and the ↵haraken@google.com2011-06-158-14/+234
| | | | | | | | | | | | | | | download shelf - Invalidate the links of removed files in chrome://downloads page - Label "Removed" for the removed files in the download shelf BUG=29093 TEST=Observe that in chrome://downloads, the downloaded and then removed files are labeled "Removed" and have no links, Observe that in the download shelf, the downloaded and then removed files are labeled "Removed", DownloadManagerTest.* Review URL: http://codereview.chromium.org/6905049 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@89148 0039d316-1c4b-4281-b951-d872f2087c98
* Add GRP to the dangerous file list.cevans@chromium.org2011-06-151-0/+1
| | | | | | | BUG=86133 Review URL: http://codereview.chromium.org/7170009 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@89123 0039d316-1c4b-4281-b951-d872f2087c98
* Remove most of the remaining test dependencies (other than chrome/test).jam@chromium.org2011-06-144-5/+5
| | | | | | | | | | | I moved FindPasteboard since it seemed like a core dependency of the clipboard APIs. I left its test behind because I didn't think we'd want to move cocoa_test_helper.h to content? I moved all the testing URLRequestObjects to content, since we'll want to have stuff like that for content tests. BUG=76697 Review URL: http://codereview.chromium.org/7149013 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@89063 0039d316-1c4b-4281-b951-d872f2087c98
* Hooking MHTML generation to the browser.jcivelli@chromium.org2011-06-143-0/+283
| | | | | | | | | | | | | | This CL adds a class that can be used to generate MHTML for the current page of a tab. It is not yet surfaced in the UI. BUG=None TEST=Run the browser tests. Review URL: http://codereview.chromium.org/7044095 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@89047 0039d316-1c4b-4281-b951-d872f2087c98
* Cleanup: base/scoped_ptr.h -> base/memory/scoped_ptr.h.thestig@chromium.org2011-06-142-2/+2
| | | | | | | | BUG=none TEST=none Review URL: http://codereview.chromium.org/7148006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@88967 0039d316-1c4b-4281-b951-d872f2087c98
* Move ui/gfx/image* to ui/gfx/image/.rsesek@chromium.org2011-06-131-1/+1
| | | | | | | | | BUG=none TEST=ui_unittests Review URL: http://codereview.chromium.org/6995155 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@88852 0039d316-1c4b-4281-b951-d872f2087c98
* Put in CHECK() statements confirm DownloadItem threading and destruction.rdsmith@chromium.org2011-06-103-3/+108
| | | | | | | | | | BUG=85408 TEST=Try bots. Review URL: http://codereview.chromium.org/7104091 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@88717 0039d316-1c4b-4281-b951-d872f2087c98
* Change DownloadProcessHandle to be more of an encapsulated class.rdsmith@chromium.org2011-06-0917-221/+223
| | | | | | | | | | BUG=None TEST=None Review URL: http://codereview.chromium.org/7112011 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@88585 0039d316-1c4b-4281-b951-d872f2087c98
* *Fixup about and chrome scheme URLs in URLFixerUpper::FixupURL.msw@chromium.org2011-06-081-2/+2
| | | | | | | | | | | | | | | | | | | | | | | | *Update AboutSource to use the source_name of each about/chrome page. *Make WillHandleBrowserAboutURL fix up schemes and handle chrome://foo/ -Redirect memory to memory-redirect (wasn't handling chrome://memory/). -Catalog all kChromeUI*Hosts in url_constants.cc -Simplify paths (credits, os-credits, ipc, settings, about/version). -Nix web_ui_util::ChromeURLHostEquals (use scheme & host comparison). -Favor GURL::SchemeIs and url_constants, update & expand tests. -Add and fixup chrome://chrome-urls (the about:about page). -Update special_tabs.py from Nirnimesh's codereview.chromium.org/6995057/. This change was reverted with r88166 for sync_integration_tests failures. These failures are a tangential issue, crbug.com/85294; I'll re-land this soon. BUG=55771 TEST=Access about:, about://, chrome:, chrome:// pages. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=88142 Review URL: http://codereview.chromium.org/7068007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@88367 0039d316-1c4b-4281-b951-d872f2087c98
* roll clang 131935:132017thakis@chromium.org2011-06-082-2/+2
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | clang recently added a warning that warns when invoking 'delete' on a polymorphic non-final class without a virtual destructor. This finds real bugs – see the bug referenced below for a few examples. However, one common pattern where it fires is this case: class SomeInterface { public: virtual void interfaceMethod() {} // or = 0; protected: ~SomeInterface() {} } class WorkerClass : public SomeInterface { public: // many non-virtual functions, but also: virtual void interfaceMethod() override { /* do actual work */ } }; void f() { scoped_ptr<WorkerClass> c(new WorkerClass); // simplified example } (See the 2nd half of http://www.gotw.ca/publications/mill18.htm for an explanation of this pattern.) It is arguably correct to fire the warning here, since someone might make a subclass of WorkerClass and replace |new WorkerClass| with |new WorkerClassSubclass|. This would be broken since WorkerClass doesn't have a virtual destructor. The solution that the clang folks recommend is to mark WorkerClass as |final| (a c++0x keyword that clang supports as an extension in normal c++ mode – like override). But chrome's base/OWNERS deemed that as too complicated and we decided to make virtual the destructors of leaf classes that implement these interfaces and that are deleted dynamically. All of the changes in this CL are to shut up the warning, not because of real problems (I fixed these in separate CLs). (For the gtk files, this is necessary because the CHROMEGTK_CALLBACK_ macros add virtual functions.) BUG=84424 TEST=none Review URL: http://codereview.chromium.org/7087028 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@88270 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 88142 to fix sync_integration_tests offline.msw@chromium.org2011-06-071-2/+2
| | | | | | | | | | | | | | | | | | | | | | *Fixup about and chrome scheme URLs in URLFixerUpper::FixupURL. *Update AboutSource to use the source_name of each about/chrome page. *Make WillHandleBrowserAboutURL fix up schemes and handle chrome://foo/ -Redirect memory to memory-redirect (wasn't handling chrome://memory/). -Catalog all kChromeUI*Hosts in url_constants.cc -Simplify paths (credits, os-credits, ipc, settings, about/version). -Nix web_ui_util::ChromeURLHostEquals (use scheme & host comparison). -Favor GURL::SchemeIs and url_constants, update & expand tests. -Add and fixup chrome://chrome-urls (the about:about page). BUG=55771 TEST=Access about:, about://, chrome:, chrome:// pages. Review URL: http://codereview.chromium.org/7068007 TBR=msw@chromium.org Review URL: http://codereview.chromium.org/7064052 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@88166 0039d316-1c4b-4281-b951-d872f2087c98
* *Fixup about and chrome scheme URLs in URLFixerUpper::FixupURL.msw@chromium.org2011-06-071-2/+2
| | | | | | | | | | | | | | | | | | *Update AboutSource to use the source_name of each about/chrome page. *Make WillHandleBrowserAboutURL fix up schemes and handle chrome://foo/ -Redirect memory to memory-redirect (wasn't handling chrome://memory/). -Catalog all kChromeUI*Hosts in url_constants.cc -Simplify paths (credits, os-credits, ipc, settings, about/version). -Nix web_ui_util::ChromeURLHostEquals (use scheme & host comparison). -Favor GURL::SchemeIs and url_constants, update & expand tests. -Add and fixup chrome://chrome-urls (the about:about page). BUG=55771 TEST=Access about:, about://, chrome:, chrome:// pages. Review URL: http://codereview.chromium.org/7068007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@88142 0039d316-1c4b-4281-b951-d872f2087c98
* Show that CRX unpacking is happening in the download shelfskerner@chromium.org2011-06-065-32/+112
| | | | | | | | | BUG=80010 TEST=manual for now Review URL: http://codereview.chromium.org/7047017 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@87981 0039d316-1c4b-4281-b951-d872f2087c98
* Better support for dangerous and in progress downloads, style cleanup.achuith@chromium.org2011-06-022-4/+8
| | | | | | | | | | | | | | | | | | | | | Support for window resize with variable width row elements. New text for dangerous downloads prompt, consistent with download shelf. Menus style cleanup. Use float:right, etc. Updated styles for dangerous downloads and in-progress downloads. Expand rows as needed accomodate new download text and progress text. Improve on default progress text. Support for DownloadItem::REMOVING. Code to hide/unhide menu as needed. Wrapper function for chrome.send. One popup for incognito and non-incognito profiles (also fix browser test for this). Fix loading of images in test mode. Generate better test data for cases: dangerous, in progress and complete. BUG=chromium-os:15360,chromium-os:15522,chromium-os:10765 TEST=Download large files and crx files - the downloads popup should have variable width rows. There should never be more than 5 rows visible, and the popup should change height correctly to accomodate all the rows. Review URL: http://codereview.chromium.org/6979028 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@87711 0039d316-1c4b-4281-b951-d872f2087c98
* Added 2 new Download.Counts enums START_COUNT and INTERRUPTED_COUNT to ↵benjhayden@chromium.org2011-06-024-7/+41
| | | | | | | | | | | | | | | | | | complement existing COMPLETED_COUNT and CANCELLED_COUNT. I wonder if START_COUNT will equal COMPLETED_COUNT + CANCELLED_COUNT + INTERRUPTED_COUNT, or if some of those will overlap, or if there's another termination case? Added a histogram of long times "Download.Time". Added a histogram_enum "Download.InterruptedError". Looks like there are already histogram_enums for Download.DangerousDownloadValidated, Download.Discard, and Download.UserDiscard. BUG=80574 TEST= Review URL: http://codereview.chromium.org/7064001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@87669 0039d316-1c4b-4281-b951-d872f2087c98
* Remove last safebrowsing references from content.jam@chromium.org2011-06-022-2/+3
| | | | | | | BUG=77089 Review URL: http://codereview.chromium.org/7108003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@87622 0039d316-1c4b-4281-b951-d872f2087c98
* SafeBrowsing: Include hash in digest malware hit pingback.mattm@chromium.org2011-05-313-9/+115
| | | | | | | | | BUG=83145 TEST=tcpdump, unittest Review URL: http://codereview.chromium.org/7069030 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@87348 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 87302 - Show that CRX unpacking is happening in the download shelfphajdan.jr@chromium.org2011-05-315-123/+25
| | | | | | | | | | | | BUG=80010 TEST=manual for now Review URL: http://codereview.chromium.org/7047017 TBR=skerner@chromium.org Review URL: http://codereview.chromium.org/7053045 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@87326 0039d316-1c4b-4281-b951-d872f2087c98
* Fix AutoOpen test to be correct on ChromeOS.rdsmith@chromium.org2011-05-311-1/+1
| | | | | | | | | | | | | | Also cleaned up ifdefs around ChromeOS Download UI visibility. R=achuith@chromium.org R=phajdan.jr@chromium.org BUG=84058 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=87317 Review URL: http://codereview.chromium.org/7074031 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@87321 0039d316-1c4b-4281-b951-d872f2087c98
* Factor load notification detail structs out of NavigationController and into pinkerton@chromium.org2011-05-311-0/+1
| | | | | | | | | | | their own file in the |content| namespace. Remove un-necessary includes of navigation_controller.h. BUG=none TEST=everything compiles Review URL: http://codereview.chromium.org/7008018 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@87319 0039d316-1c4b-4281-b951-d872f2087c98
* Fix AutoOpen test to be correct on ChromeOS. rdsmith@chromium.org2011-05-311-54/+39
| | | | | | | | | | | | | Also cleaned up ifdefs around ChromeOS Download UI visibility. R=achuith@chromium.org R=phajdan.jr@chromium.org BUG=84058 Review URL: http://codereview.chromium.org/7074031 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@87317 0039d316-1c4b-4281-b951-d872f2087c98
* Clang fix.skerner@chromium.org2011-05-311-1/+1
| | | | | | | | | | BUG=none TEST=clang compiles TBR=skerner Review URL: http://codereview.chromium.org/7096011 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@87304 0039d316-1c4b-4281-b951-d872f2087c98
* Show that CRX unpacking is happening in the download shelfskerner@chromium.org2011-05-315-25/+123
| | | | | | | | | BUG=80010 TEST=manual for now Review URL: http://codereview.chromium.org/7047017 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@87302 0039d316-1c4b-4281-b951-d872f2087c98
* Make sure we remove observers in drag-download.jianli@chromium.org2011-05-272-12/+29
| | | | | | | | BUG=82309 TEST=none Review URL: http://codereview.chromium.org/7062039 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@87078 0039d316-1c4b-4281-b951-d872f2087c98
* Disable DownloadTest.AutoOpen on CrOS.rdsmith@chromium.org2011-05-261-1/+7
| | | | | | | | | BUG=84058 TEST= Review URL: http://codereview.chromium.org/7077010 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@86842 0039d316-1c4b-4281-b951-d872f2087c98
* Fix auto-open behavior for Downloads.rdsmith@chromium.org2011-05-263-9/+95
| | | | | | | | | | | | (Broken by r84459; state entering DownloadItem::Completed() not COMPLETE.) BUG=82728 TEST=All known tests pass, new auto-open test passes. Review URL: http://codereview.chromium.org/7029033 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@86829 0039d316-1c4b-4281-b951-d872f2087c98
* Change GetVisitCountToHost() to GetVisibleVisitCountToHost(), and restrict ↵pkasting@chromium.org2011-05-251-7/+7
| | | | | | | | | | it to returning "user-visible" visits. This makes the Page Info bubble and the download system more restrictive about considering when someone "first visited" a site, so that they don't consider things like subframe navigations or redirects. BUG=81741 TEST=Page Info bubble should not say you've visited a site before today if your only visits in previous days were subframe navigations. Review URL: http://codereview.chromium.org/6990074 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@86695 0039d316-1c4b-4281-b951-d872f2087c98
* Fix leak of callback object in r86518.pkasting@chromium.org2011-05-252-1/+11
| | | | | | | | BUG=81741,83836 TEST=Memory bots go green Review URL: http://codereview.chromium.org/7053004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@86690 0039d316-1c4b-4281-b951-d872f2087c98
* Virtual destructors should have virtual keyword.hans@chromium.org2011-05-252-2/+2
| | | | | | | | | | | | | | | | | Make sure user-declared virtual destructors always have the virtual keyword. The Clang style-check plugin will check for this soon. No functionality change: virtual is only added to destructors that are already implicitly virtual. Also fix a couple of in-line destructor definitions. BUG=83408 TEST=none Review URL: http://codereview.chromium.org/7064033 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@86587 0039d316-1c4b-4281-b951-d872f2087c98
* For downloads requiring a user gesture, also require the user to have ↵pkasting@chromium.org2011-05-2410-55/+111
| | | | | | | | | | visited the site before today, to hamper attackers. BUG=81741 TEST=.exe downloads on Windows triggered by an explicit link click should prompt you to confirm iff they are hosted on a site you have not visited before today. Review URL: http://codereview.chromium.org/7065015 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@86518 0039d316-1c4b-4281-b951-d872f2087c98
* Fixed memory leaks in download manager unit tests.ahendrickson@chromium.org2011-05-241-31/+33
| | | | | | | | | | BUG=83638 TEST=Valgrind does not detect the leak. Review URL: http://codereview.chromium.org/6990044 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@86484 0039d316-1c4b-4281-b951-d872f2087c98
generated by cgit v1.1 at 2025-02-07 15:28:27 +0000