summaryrefslogtreecommitdiffstats
path: root/chrome/browser/errorpage_uitest.cc
Commit message (Collapse)AuthorAgeFilesLines
* Change bug reference for flaky testamit@chromium.org2011-04-201-3/+3
| | | | | | | | BUG=79412,19361 TBR=phajdan.jr@chromium.org Review URL: http://codereview.chromium.org/6880076 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@82348 0039d316-1c4b-4281-b951-d872f2087c98
* Fix typoamit@chromium.org2011-04-191-2/+2
| | | | | | | | | | Typo makes the test have MAYBE prefix TBR=cpu@chromium.org TEST=DNSError_GoBack2AndForward bug=19361 Review URL: http://codereview.chromium.org/6881057 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@82161 0039d316-1c4b-4281-b951-d872f2087c98
* Fixed a typojoshia@google.com2011-04-191-2/+2
| | | | | | | TBR=cpu Review URL: http://codereview.chromium.org/6879055 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@82151 0039d316-1c4b-4281-b951-d872f2087c98
* Disable flaky error page testsjoshia@google.com2011-04-191-5/+17
| | | | | | | | | BUG=19361 TEST=ErrorPageTest.* TBR=cpu Review URL: http://codereview.chromium.org/6878054 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@82149 0039d316-1c4b-4281-b951-d872f2087c98
* Mark ErrorPageTest.DNSError_GoBack2Forward2 as flaky on linux x64.ctguil@chromium.org2011-04-141-0/+6
| | | | | | | | BUG=79412 TEST=none Review URL: http://codereview.chromium.org/6852012 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@81514 0039d316-1c4b-4281-b951-d872f2087c98
* Replace an unnecessary "NavigateToURLBlockUntilNavigationsComplete" withmmenke@chromium.org2011-03-021-3/+2
| | | | | | | | | | | "NavigateToURL" in ErrorPageTest.Page404 BUG=36558 TEST=ErrorPageTest.Page404 Review URL: http://codereview.chromium.org/6591044 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@76541 0039d316-1c4b-4281-b951-d872f2087c98
* Only display Link Doctor page on 404 errors with no body.mmenke@chromium.org2011-02-241-40/+3
| | | | | | | | | | | | | Had to remove some of the old tests, since TestServer.py will not sent blank pages when there's an error code (On the trybots, at least). BUG=36558 TEST=ErrorPageTest.Page404 Review URL: http://codereview.chromium.org/6546069 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@75887 0039d316-1c4b-4281-b951-d872f2087c98
* Remove sleep_timeout_ms and fix all the callers.tfarina@chromium.org2011-01-111-2/+3
| | | | | | | | | | | (This was a TODO for phajdan.jr). BUG=None TEST=trybots Review URL: http://codereview.chromium.org/6187002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71038 0039d316-1c4b-4281-b951-d872f2087c98
* Move platform_thread to base/threading and put in the base namespace. I left abrettw@chromium.org2010-12-311-2/+3
| | | | | | | | | | | stub and "using" declarations in the old location to avoid having to change the entire project at once. TEST=it compiles BUG=none Review URL: http://codereview.chromium.org/6001010 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@70342 0039d316-1c4b-4281-b951-d872f2087c98
* Marking ErrorPageTest.IFrame404 as flaky on Windows builders, probably ↵robertshield@chromium.org2010-11-021-1/+8
| | | | | | | | | | | | related to the test server bugging out occasionally. BUG=60937 TEST=NONE. Review URL: http://codereview.chromium.org/4251003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@64778 0039d316-1c4b-4281-b951-d872f2087c98
* Test server cleanup patch of death:phajdan.jr@chromium.org2010-08-171-6/+4
| | | | | | | | | | | | | | - reduce the number of different classes - clean up the internal code - modify the interface to expose less internal details (this will allow more flexibility with port numbers) TEST=many BUG=49680 Review URL: http://codereview.chromium.org/3080029 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@56405 0039d316-1c4b-4281-b951-d872f2087c98
* GTTF: Move more test server code from net/url_request/url_request_unittest.hphajdan.jr@chromium.org2010-07-291-3/+3
| | | | | | | | | | | | | to net/test/test_server.h No code changes, just a move. TEST=none BUG=49680 Review URL: http://codereview.chromium.org/3034038 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@54201 0039d316-1c4b-4281-b951-d872f2087c98
* GTTF: test server cleanup:phajdan.jr@chromium.org2010-07-231-1/+1
| | | | | | | | | | | | | - simplify the public interface - remove unneeded methods - make it easier to understand TEST=none BUG=49680 Review URL: http://codereview.chromium.org/2881028 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@53509 0039d316-1c4b-4281-b951-d872f2087c98
* Remove the flaky mark from ErrorPage tests. Apparentlyphajdan.jr@chromium.org2010-05-051-22/+11
| | | | | | | | | | the tests are no longer flaky on the buildbots. TEST=ErrorPageTest.* BUG=22877 Review URL: http://codereview.chromium.org/1951007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@46470 0039d316-1c4b-4281-b951-d872f2087c98
* [GTTF] Various ui tests cleanups:phajdan.jr@chromium.org2010-03-261-2/+2
| | | | | | | | | | | | | | | | - unify timeout handling - remove unneccessary assertions that clutter the code They were mostly there because earlier the automation framework was less reliable. Now the same checks (or equivalent) are always done in the framework itself. TEST=none BUG=none Review URL: http://codereview.chromium.org/1377001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42767 0039d316-1c4b-4281-b951-d872f2087c98
* re-enable ErrorPage UI tests.tony@chromium.org2010-01-131-3/+3
| | | | | | | | | | | | They are fixed now and can be re-enabled. BUG=32125 TBR=johnnyg Review URL: http://codereview.chromium.org/542047 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@36086 0039d316-1c4b-4281-b951-d872f2087c98
* Webkit update to 53151.johnnyg@chromium.org2010-01-131-3/+3
| | | | | | | | | | TBR=atwilson BUG=none TEST=none Review URL: http://codereview.chromium.org/546020 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@36069 0039d316-1c4b-4281-b951-d872f2087c98
* Mark all ErrorPage tests as FLAKY.phajdan.jr@chromium.org2009-11-231-75/+21
| | | | | | | | | | | | | | | It's a race condition which used to manifest more frequently on XP, but in fact it exists on all platforms. People started adding even more #ifdefs and things when tests failed on Linux too, so let's just say they're all flaky. :-( TEST=none BUG=22877 Review URL: http://codereview.chromium.org/437016 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32849 0039d316-1c4b-4281-b951-d872f2087c98
* Mark Page404_GoBack as flaky on linuxtim@chromium.org2009-11-211-0/+6
| | | | | | | | | | TBR=phajdan.jr BUG=19361 TEST=ErrorPageTest Review URL: http://codereview.chromium.org/426011 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32733 0039d316-1c4b-4281-b951-d872f2087c98
* Mark ErrorPageTest.IFrameDNSError_GoBackAndForward as flaky since it failedmpcomplete@chromium.org2009-11-111-1/+2
| | | | | | | | | | on Linux. BUG=19361 Review URL: http://codereview.chromium.org/384050 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31689 0039d316-1c4b-4281-b951-d872f2087c98
* Use FilePath in URLRequestMocks.evan@chromium.org2009-10-141-16/+32
| | | | | | | | | BUG=24672 TEST=compiles Review URL: http://codereview.chromium.org/271066 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29013 0039d316-1c4b-4281-b951-d872f2087c98
* Coverity: Check return of TabProxy::GoForward, GoBack, etcmattm@chromium.org2009-10-071-14/+14
| | | | | | | | | | CID=5709,5708,5706,5705,5704,5703,5702,5701,5700 BUG=none TEST=ran the tests Review URL: http://codereview.chromium.org/256067 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28340 0039d316-1c4b-4281-b951-d872f2087c98
* Do not run ErrorPageTest on XP, too flaky.phajdan.jr@chromium.org2009-09-221-0/+58
| | | | | | | | | TEST=Um, none? BUG=19361 Review URL: http://codereview.chromium.org/212049 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26830 0039d316-1c4b-4281-b951-d872f2087c98
* Mock the LinkDoctor for tests. Should greatly decrease ErrorPage test flakiness.phajdan.jr@chromium.org2009-09-211-23/+12
| | | | | | | | | | | Not getting rid of WaitForTitleMatching because I have to add few more calls to the automation framework (http://crbug.com/19395) to wait properly after navigating back and forward. TEST=Covered by ui_tests and browser_tests. http://crbug.com/18365, http://crbug.com/19361 Review URL: http://codereview.chromium.org/174179 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26761 0039d316-1c4b-4281-b951-d872f2087c98
* Get more info in the logs when ErrorPageTest fails.phajdan.jr@chromium.org2009-09-101-0/+3
| | | | | | | | | TEST=none BUG=19361 Review URL: http://codereview.chromium.org/199076 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25875 0039d316-1c4b-4281-b951-d872f2087c98
* Wait correctly for all navigations that will happen in ErrorPageTest.phajdan.jr@chromium.org2009-08-281-12/+20
| | | | | | | | | | | Will it kill flakiness? I'm undisabling some tests on Linux to find out. TEST=none http://crbug.com/19361 Review URL: http://codereview.chromium.org/175006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@24703 0039d316-1c4b-4281-b951-d872f2087c98
* Revert r24606-24607. The tree didn't like them. :(phajdan.jr@chromium.org2009-08-271-16/+25
| | | | | | | | TBR=darin Review URL: http://codereview.chromium.org/173574 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@24608 0039d316-1c4b-4281-b951-d872f2087c98
* Wait correctly for navigations in ErrorPage UI test.phajdan.jr@chromium.org2009-08-271-4/+4
| | | | | | | | | | | TBR=darin TEST=none http://crbug.com/19361 Review URL: http://codereview.chromium.org/173571 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@24607 0039d316-1c4b-4281-b951-d872f2087c98
* Mock the LinkDoctor for tests. Should greatly decrease ErrorPage test flakiness.phajdan.jr@chromium.org2009-08-271-21/+12
| | | | | | | | | | | Not getting rid of WaitForTitleMatching because I have to add few more calls to the automation framework (http://crbug.com/19395) to wait properly after navigating back and forward. TEST=Covered by ui_tests and browser_tests. http://crbug.com/18365, http://crbug.com/19361 Review URL: http://codereview.chromium.org/174179 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@24606 0039d316-1c4b-4281-b951-d872f2087c98
* Fix another source of flakiness in ErrorPageTestphajdan.jr@chromium.org2009-08-261-13/+21
| | | | | | | | | | | | | | | | We need to wait for correct number of navigations when going back or forward to the LinkDoctor page. Re-enable previously disabled tests and remove the now-duplicate browser test. The test is still not very solid, because the LinkDoctor should be mocked. TEST=Covered by ui_tests. http://crbug.com/19361, http://crbug.com/19395 Review URL: http://codereview.chromium.org/174396 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@24446 0039d316-1c4b-4281-b951-d872f2087c98
* Disable the second Page404 ui_test - first was disabled earlier, this one ↵dimich@google.com2009-08-211-3/+4
| | | | | | | | | | | uses same code path. R=phajdan.jr BUG=19361 TEST=none Review URL: http://codereview.chromium.org/173227 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@24028 0039d316-1c4b-4281-b951-d872f2087c98
* Disable ErrorPageTest.Page404 on Linux. It's flaky. ph is working on it.mark@chromium.org2009-08-211-0/+5
| | | | | | | | TEST=yes BUG=19361 Review URL: http://codereview.chromium.org/173219 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@24003 0039d316-1c4b-4281-b951-d872f2087c98
* Revert "Mock the LinkDoctor for tests. Should greatly decrease ErrorPage ↵phajdan.jr@chromium.org2009-08-201-12/+21
| | | | | | | | | | test flakiness." TBR=darin Review URL: http://codereview.chromium.org/173165 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23916 0039d316-1c4b-4281-b951-d872f2087c98
* Mock the LinkDoctor for tests. Should greatly decrease ErrorPage test flakiness.phajdan.jr@chromium.org2009-08-201-21/+12
| | | | | | | | | | | Not getting rid of WaitForTitleMatching because I have to add few more calls to the automation framework (http://crbug.com/19395) to wait properly after navigating back and forward. TEST=Covered by ui_tests and browser_tests. http://crbug.com/18365, http://crbug.com/19361 Review URL: http://codereview.chromium.org/174179 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23906 0039d316-1c4b-4281-b951-d872f2087c98
* Add automation call to wait for multiple navigations.phajdan.jr@chromium.org2009-08-191-3/+2
| | | | | | | | | | | | | Convert one ErrorPage UI test to use it. The rest of the tests will require more work. TEST=Covered by ui_tests. http://crbug.com/19361, http://crbug.com/19395 Review URL: http://codereview.chromium.org/174015 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23729 0039d316-1c4b-4281-b951-d872f2087c98
* Revert "Add automation call to wait for multiple navigations."phajdan.jr@chromium.org2009-08-191-2/+3
| | | | | | | | | | Broke the page cyclers. TBR=tony Review URL: http://codereview.chromium.org/174065 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23717 0039d316-1c4b-4281-b951-d872f2087c98
* Add automation call to wait for multiple navigations.phajdan.jr@chromium.org2009-08-191-3/+2
| | | | | | | | | | | | | Convert one ErrorPage UI test to use it. The rest of the tests will require more work. TEST=Covered by ui_tests. http://crbug.com/19361, http://crbug.com/19395 Review URL: http://codereview.chromium.org/174015 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23711 0039d316-1c4b-4281-b951-d872f2087c98
* Convert parts of errorpage_uitest.cc to be not flaky.phajdan.jr@chromium.org2009-08-151-5/+10
| | | | | | | | | TEST=Covered by browser_tests. http://crbug.com/19361, http://crbug.com/19395 Review URL: http://codereview.chromium.org/169002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23500 0039d316-1c4b-4281-b951-d872f2087c98
* When loading an alternate 404 error page, always set 'replace' to true.darin@chromium.org2009-08-031-0/+17
| | | | | | | | | | | | | This is necessary because WebCore still loads an empty blank page when we postpone the data for the original 404 error page. R=tony BUG=18109 TEST=errorpage_uitest.cc Review URL: http://codereview.chromium.org/159801 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22301 0039d316-1c4b-4281-b951-d872f2087c98
* Move alternate error page loading out of WebFrame.darin@chromium.org2009-08-021-35/+126
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Make the RenderView be in charge of loading alternate error pages. While working on this change, I noticed several related bugs: 1- Loading an URL with an invalid host name from the new tab page results in an error page. If you hit back and then forward, you will be left with an empty location bar. In a debug build this trips an assertion in ClassifyNavigation because the given page_id is -1. This problem is caused by not duplicating the NavigationState of the failed load when creating a load for the error page. Hence, the pending_page_id of the forward navigation is lost. 2- Loading an URL with an invalid host name as a subframe results in an extra navigation in session history. One navigation for the main frame and one navigation for the error page load. This is another symptom of the problem described in #1. However, the solution is different. Here, we need to know that the subframe load is an AUTO_SUBFRAME load so that we load the error page using 'replace' semantics (so that WebCore does not generate a new session history entry). Finally, I decided to restrict alternative DNS error pages to only work for the main frame to match what we do for alternative 404 error pages. It doesn't seem worth it to show link doctor results for subframes since their primary purpose is to assist people who mis-type an URL. R=tony,brettw BUG=15648 TEST=covered by errorpage_uitest.cc Review URL: http://codereview.chromium.org/159575 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22253 0039d316-1c4b-4281-b951-d872f2087c98
* Move mock url request classes to a location when browser tests will be able ↵phajdan.jr@chromium.org2009-07-301-1/+1
| | | | | | | | | | | to use them too. TEST=none BUG=none Review URL: http://codereview.chromium.org/160366 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22056 0039d316-1c4b-4281-b951-d872f2087c98
* linux: pass a bunch more ui tests.evan@chromium.org2009-04-071-2/+2
| | | | | | | | Mostly random portability fixes: use portable functions, use FilePath, etc. Review URL: http://codereview.chromium.org/62117 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13302 0039d316-1c4b-4281-b951-d872f2087c98
* Provide the option for HTTPServer to be created with a specificsky@google.com2009-01-291-1/+1
| | | | | | | | | | | | | | | MessageLoop. I'm going to need this when running ui tests in process. In this case I'll pass in the IO thread. I'll change all callers to use the new method, but before doing that wanted to make sure you're ok with it. BUG=none TEST=none Review URL: http://codereview.chromium.org/19039 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@8915 0039d316-1c4b-4281-b951-d872f2087c98
* Remove timeout constants from ui_tests. All tests will nowpaulg@google.com2009-01-161-2/+2
| | | | | | | | | use accessors for various timeouts which can be set (via command line parameters) to values appropriate to the test environment, such as longer timeouts when running under purify. Review URL: http://codereview.chromium.org/18109 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@8164 0039d316-1c4b-4281-b951-d872f2087c98
* Add FTP unit test in preparation for portable FTP implementation.erikkay@google.com2009-01-081-2/+4
| | | | | | | | | | | | Clean up test server code. Originally from issue 12939, written by Ibrar Ahmed (ibrar.ahmed@gmail.com) (take 2) Review URL: http://codereview.chromium.org/17040 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@7755 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 7508.7509 and 7510nsylvain@chromium.org2008-12-301-4/+2
| | | | | | Review URL: http://codereview.chromium.org/17030 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@7514 0039d316-1c4b-4281-b951-d872f2087c98
* Add FTP unit test in preparation for portable FTP implementation.erikkay@google.com2008-12-301-2/+4
| | | | | | | | | | | Clean up test server code. Originally from issue 12939, written by Ibrar Ahmed (ibrar.ahmed@gmail.com) Review URL: http://codereview.chromium.org/16490 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@7508 0039d316-1c4b-4281-b951-d872f2087c98
* Disable alternate error pages on frames and iframes. This istc@google.com2008-09-291-0/+27
| | | | | | | | | a request from the link doctor team. Add a UI test that verifies that no link doctor page is loaded. Review URL: http://codereview.chromium.org/5032 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@2684 0039d316-1c4b-4281-b951-d872f2087c98
* Use a more compact license header in source files.license.bot2008-08-241-28/+4
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@1287 0039d316-1c4b-4281-b951-d872f2087c98
* Add chrome to the repository.initial.commit2008-07-261-0/+58
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15 0039d316-1c4b-4281-b951-d872f2087c98
generated by cgit v1.1 at 2025-02-19 06:06:06 +0000