| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
SyncExtensionFunction and AsyncExtensionFunction derivates now expose RunSync
and RunAsync respectively. New extension function implementations should just
implement Run directly.
BUG=365732
R=rockot@chromium.org
TBR=dmazzoni@chromium.org
Review URL: https://codereview.chromium.org/257333002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@268033 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
AsyncApiFunction now inherits UIThreadExtensionFunction directly, rather
than depending on ChromeAsyncExtensionFunction. It's also been moved from
chrome/browser/extensions/api/api_function.{h,cc} to
extensions/browser/api/async_api_function.{h,cc}.
With the exception of notifications API functions, anything which previously
depended on AsyncApiFunction's inheritance of ChromeAsyncExtensionFunction
was doing so only for GetProfile. In all cases, GetProfile() has been replaced
with ExtensionFunction::browser_context() (renamed from context()).
Finally, ApiFunction has been removed since it was identical to
ChromeAsyncExtensionFunction.
BUG=346949
TBR=dmazzoni@chromium.org,mfoltz@chromium.org,fgorski@chromium.org,courage@chromium.org,dewittj@chromium.org,rpaquay@chromium.org,kalman@chromium.org
Review URL: https://codereview.chromium.org/177003015
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@254113 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
TBR=sky@chromium.org
BUG=162530
Review URL: https://codereview.chromium.org/64273006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@234673 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=305911
TEST=new tests
Review URL: https://codereview.chromium.org/33173002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@230241 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
With this change, the user only needs to specify the properties to be changed. This patch does not change the way that the toast is updated by recreating the views. It will be addressed in next patch.
BUG=170924
TEST=new tests added
TBR=sky@chromium.org
Review URL: https://chromiumcodereview.appspot.com/20136004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@213891 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Currently we encode the image data downloaded from the net as a data
URL, which still needs to be sent back to a renderer to be converted
into a bitmap. This patch sends over an ImageData object which is
ready to be put into an SkBitmap (with a RGBA->ARGB conversion).
TBR=sky@chromium.org - Changes for ash/ tests with notifications
BUG=238823,232288,168943
Review URL: https://chromiumcodereview.appspot.com/15927043
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@206009 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This function returns an object whose keys are the notification
IDs of all notifications created by that extension.
BUG=240924
TBR=miket@chromium.org
Review URL: https://chromiumcodereview.appspot.com/15715008
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@203001 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Broke Mac ASAN Tests (2):
NotificationsApiTest.TestGetAll:
dyld: warning, unknown environment variable: DYLD_NO_PIE
dyld: warning, unknown environment variable: DYLD_NO_PIE
dyld: warning, unknown environment variable: DYLD_NO_PIE
dyld: warning, unknown environment variable: DYLD_NO_PIE
[5768:3847:0528/182240:INFO:gpu_command_buffer_stub.cc(468)] Created virtual GL context.
../../chrome/browser/extensions/api/notifications/notifications_apitest.cc:331: Failure
Value of: kNotificationsToCreate
Actual: 4
Expected: return_value->size()
Which is: 0
> Reland 201932: Add API function chrome.notifications.getAll
>
> This function returns an object whose keys are the notification
> IDs of all notifications created by that extension.
>
> BUG=240924
>
> TBR=miket@chromium.org
>
> Review URL: https://chromiumcodereview.appspot.com/15715008
TBR=dewittj@chromium.org
Review URL: https://codereview.chromium.org/15820009
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@202764 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This function returns an object whose keys are the notification
IDs of all notifications created by that extension.
BUG=240924
TBR=miket@chromium.org
Review URL: https://chromiumcodereview.appspot.com/15715008
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@202716 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Broke Mac ASAN Tests (1):
http://build.chromium.org/p/chromium.memory/builders/Mac%20ASAN%20Tests%20%281%29/builds/10683
NotificationsApiTest.TestGetAll:
dyld: warning, unknown environment variable: DYLD_NO_PIE
dyld: warning, unknown environment variable: DYLD_NO_PIE
dyld: warning, unknown environment variable: DYLD_NO_PIE
dyld: warning, unknown environment variable: DYLD_NO_PIE
[6552:3847:0523/180035:INFO:gpu_command_buffer_stub.cc(468)] Created virtual GL
context.
../../chrome/browser/extensions/api/notifications/notifications_apitest.cc:331:
Failure
Value of: kNotificationsToCreate
Actual: 4
Expected: return_value->size()
Which is: 0
> Add API function chrome.notifications.getAll
>
> This function returns an object whose keys are the notification
> IDs of all notifications created by that extension.
>
> BUG=240924
>
> Review URL: https://chromiumcodereview.appspot.com/14767029
TBR=dewittj@chromium.org
Review URL: https://codereview.chromium.org/15925003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@201969 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
This function returns an object whose keys are the notification
IDs of all notifications created by that extension.
BUG=240924
Review URL: https://chromiumcodereview.appspot.com/14767029
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@201932 0039d316-1c4b-4281-b951-d872f2087c98
|
|
TBR=sky@chromium.org, yoz@chromium.org
BUG=178511
Review URL: https://codereview.chromium.org/12313115
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@186744 0039d316-1c4b-4281-b951-d872f2087c98
|