| Commit message (Collapse) | Author | Age | Files | Lines |
|---|
| |
|
|
|
|
|
|
|
| |
Ensure notification displayed is latest
Limit number of notifications that can be received by the client. (Client side Garbage collection)
Review URL: http://codereview.chromium.org/8567018
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@110669 0039d316-1c4b-4281-b951-d872f2087c98
|
| |
|
|
|
|
|
|
|
|
|
| |
any semantics on them.
If we load link url only if link text is not empty (and vice versa) when writing notifications JSON file
then we get out of sync with sync database for a given notification. This can fail the model association
when browser starts up next time and halt syncing of notifications in retail builds and crash in debug builds.
Review URL: http://codereview.chromium.org/8474008
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@108730 0039d316-1c4b-4281-b951-d872f2087c98
|
| |
|
|
|
|
|
|
|
|
|
| |
- Implement all methods of SyncableService
- Modify existing methods that change the model (Add and ClearAll) to push changes to sync.
- Add some extra properties to AppNotification: guid and extension id
- Disallow operations on model until storage is loaded.
- Ton of unit tests for sync methods
Review URL: http://codereview.chromium.org/8355030
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@106678 0039d316-1c4b-4281-b951-d872f2087c98
|
| |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
- Implement all methods of SyncableService
- Modify existing methods that change the model (Add and ClearAll) to push changes to sync.
- Add some extra properties to AppNotification: guid and extension id
- Disallow operations on model until storage is loaded.
- Ton of unit tests for sync methods
There is anotehr part for the full notifications sync to work that will be done in a separate CL.
Review URL: http://codereview.chromium.org/8263002
TBR=munjal@chromium.org
Review URL: http://codereview.chromium.org/8345022
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@106136 0039d316-1c4b-4281-b951-d872f2087c98
|
| |
|
|
|
|
|
|
|
|
|
|
|
| |
- Implement all methods of SyncableService
- Modify existing methods that change the model (Add and ClearAll) to push changes to sync.
- Add some extra properties to AppNotification: guid and extension id
- Disallow operations on model until storage is loaded.
- Ton of unit tests for sync methods
There is anotehr part for the full notifications sync to work that will be done in a separate CL.
Review URL: http://codereview.chromium.org/8263002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@106110 0039d316-1c4b-4281-b951-d872f2087c98
|
| |
|
|
|
|
|
|
|
|
|
|
|
|
| |
BUG=98138
TEST=Install a packaged app with the experimental permission, and have it call
chrome.experimental.app.notify({title:"foo", bodyText:"bar"}) from one of its
pages. That should make a notification appear on its icon on the NTP. After
restarting chrome, that same notification should still be there.
Review URL: http://codereview.chromium.org/8038040
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@104066 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
Previously they were defined inside extension_app_api.{h,cc}.
Also:
-Change AppNotification from a struct to a class.
-Remove iconData parameter from notify function (support was never actually implemented)
This CL is preparation for persisting the app notifications to disk.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/8041007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@102796 0039d316-1c4b-4281-b951-d872f2087c98
|
