| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
|
|
|
|
|
|
| |
This patch removes the deprecated ExtensionInstaller and uses
ExtensionInstallChecker in CrxInstaller and UnpackedInstaller.
BUG=386404
TEST=browser_tests
TBR=pam@chromium.org (for include in supervised_user_service_unittest.cc)
Review URL: https://codereview.chromium.org/381553002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@282250 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
- DriveAppProvider to map Drive apps to chrome apps or local url apps;
- DriveAppMapping to track the mapped chrome apps;
- DriveServiceBridge to wrap DriveAPIService and DriveAppRegistry to
provide the user Drive apps info;
- Put feature behind "--enable-drive-apps-in-app-list";
BUG=358791,345066
TEST=DriveAppProviderTest.*:DriveAppMappingTest.*
Review URL: https://codereview.chromium.org/308003005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@278265 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Split from https://codereview.chromium.org/308003005/ for extensions
system changes that allows to install a none syncable Extension.
- Add a do_not_sync pref to ExtensionPrefs;
- Add a kInstallFlagDoNotSync that CrxInstaller uses to initialize the pref;
- Update util::ShouldSyncApp and add ShouldSyncExtension to use the pref to skip sync in ExtensionSyncService;
BUG=358791
Review URL: https://codereview.chromium.org/323843003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@277269 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
take a bitmask instead of 4 boolean values (soon to be 5).
As part of that, change the default-true flag "wait for idle" to a
default-false flag "install immediately".
R=asargent@chromium.org
TBR=estade@chromium.org, atwilson@chromium.org, dimich@chromium.org
Review URL: https://codereview.chromium.org/322893002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@276999 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This CL implements install and uninstall to shared location. New functionality
is disabled by default and can be enabled only by command line switch. The switch
will not be enabled until extensions resources verification is not enabled by
default in force mode for all apps/extensions.
Follow up CL should add support for GC in shared location.
BUG=235263
TEST=browser_tests + manual
R=asargent@chromium.org
TBR=mnissler@chromium.org
Review URL: https://codereview.chromium.org/273193006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@273620 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
If the Broken Window Theory holds true, then ExtensionService will never be
cleaned up (and will, in fact, degrade faster than we can fix it) if it looks
like it's messy. So, let's clean house!
- Group overriden methods together, say what they override.
- Move all comments to the original method declaration (i.e., if it's overriden
from ExtensionServiceInterface, comment there).
- Move accessors together.
- Move for_test methods together.
- Move methods which are not used publicly into private:.
- Move simple getters/setters from the .cc to the .h.
- Remove FRIEND_TESTs that should not be there.
- Remove unneeded forward class declarations.
- Remove unneeded includes.*
*This one led to a BUNCH of fixes in other files, which relied on the
transitive includes of extension_service.h. Sorry for the noise.
BUG=351891
TBR=jochen@chromium.org (for every header file change - they're only fixing transitive includes)
Review URL: https://codereview.chromium.org/296073003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@273424 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This patch moves the IS_EPHEMERAL flag from the Extension class to
extension prefs. This is because an Extension object is immutable and
this flag needs to be changed after creation to quickly promote a
running ephemeral app to being installed. Otherwise the install must
be delayed until the ephemeral app is closed.
BUG=374018
TBR=sky@chromium.org
TEST=All automated tests
Review URL: https://codereview.chromium.org/282103003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@272157 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
To enable this support, the following things are changed:
* ExtensionSyncData, and the ExtensionSpecifics protobuf have a new
remote_install field, to mark a remotely installed extension.
* A new DISABLE_REMOTE_INSTALL reason is added to track this state
locally.
* CrxInstaller::allow_silent_install is changed from a bool to a
three-state enum, where the options are:
- install after showing a permission prompt,
- install and grant all permissions without a prompt and
- install without a prompt and don't grant any permissions
* AddExtensionDisabledError is modified to keep track of the disable
reasons, and change the text that is displayed accordingly.
* ExtensionInstallPrompt has a new prompt type with different text
for remotely installed extensions.
BUG=365737
Review URL: https://codereview.chromium.org/264763002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@270900 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The WebstoreInstaller needs a way to keep track of extensions being
downloaded and installed. The installation is handled by CrxInstaller
but when it used to be created automatically by the
ChromeDownloadManagerDelegate, the WebstoreInstaller had little control
over it and needed the CrxInstaller to keep the original_download_url as
sort of an identifier.
With this change the WebstoreInstaller creates the CrxInstaller itself
and keeps a pointer to it so there is no more need for
CrxInstaller::original_download_url().
This is also more robust because URLs are not unique identifiers (there
could be two installations run simultaneously for one download URL which
would have led to a crash in the old code).
BUG=360487
Review URL: https://codereview.chromium.org/226023003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@265615 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
currently in progress.
This should fix various race conditions where files of extensions could
get deleted while the extension was being installed.
To do this, ExtensionGarbageCollector depends on InstallTracker to be
informed whenever a CRX starts and finishes installing. To be able to
depend on InstallTracker, ExtensionGarbageCollector needed to be a
service of its own (which seems cleaner anyway).
BUG=342271
Review URL: https://codereview.chromium.org/228553005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@264119 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
namespace, and clean up the header."
This is a speculative revert of r242414.
BUG=330681
TEST=as in bug
TBR=ben@chromium.org
Review URL: https://codereview.chromium.org/109673004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@242889 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
clean up the header.
BUG=none
TEST=no change
TBR=ben@chromium.org
Review URL: https://codereview.chromium.org/100543005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@242414 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
Design doc: https://docs.google.com/a/google.com/document/d/1oDS8nT2hj6tOAnhK-sZpK5sIhfc3RPaapzRw1Fb0sng
Review URL: https://codereview.chromium.org/49253005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@241316 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
TBR=sky
Review URL: https://codereview.chromium.org/109233002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@239538 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=298586
R=cdn@chromium.org, miket@chromium.org, sky@chromium.org
TBR=cdn@chromium.org
Review URL: https://codereview.chromium.org/15239002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@235462 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
extension.
This CL improves UI experience of installing an app which depends on other shared modules.
For AppLauncher, the download progress bar will count shared modules.
For NTP, the NTP will not be created until all shared modules are ready.
Uses download shelf for shared modules instead of downloading shared module in background.
BUG=274846
Review URL: https://codereview.chromium.org/25452005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@229129 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Right now right after an extension/app is updated in the webstore, there
can be a period of skew between the webstore and the servers that download
the crx file, which causes installs to fail because we generate a permissions
warning prompt from the newer version of the manifest but get served an
older version of the .crx file.
This changes chrome to allow differences in the manifest as long as those
differences aren't considered to alter the effective severity of the
permissions.
BUG=236099
Review URL: https://chromiumcodereview.appspot.com/23033005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@219322 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=162530
Review URL: https://chromiumcodereview.appspot.com/23257005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@219075 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This helps to clarify that callers are passing ownership of the
ExtensionInstallPrompt that they pass in. Doing this turned up some cases
in crx_installer_browsertest.cc where we were accessing the raw pointer to
the MockInstallPrompt after handing off ownership of it, so this also
introduces a MockPromptProxy class to save the information we need in tests
but avoids holding on to a possibly invalid pointer.
BUG=269049
TBR=phajdan.jr,benjhayden,pkasting,joaodasilva,bauerb (for mechanical changes in various files)
Review URL: https://chromiumcodereview.appspot.com/22272005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@216749 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
policy, etc) into a blacklisted state, rather than not-silently not-installing
them. This new behaviour is correct from a sync perspective, and the old
behaviour is quite annoying.
BUG=257677
R=yoz@chromium.org,isherman@chromium.org
TBR=akalin@chromium.org,dimich@chromium.org,estade@chromium.org
Review URL: https://chromiumcodereview.appspot.com/20217002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@214806 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
extensions install, and the browser already gets the decoded images.
BUG=237249
R=mpcomplete@chromium.org
Review URL: https://codereview.chromium.org/5671933811097600
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@211250 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This upates calls to bound temporary objects to also use get().
While it has the same semantic equivalence to the existing code, this generally
represents a dangerous pattern - indeed, part of the whole motivation for this
change is to make this anti-pattern very visible to authors.
This change simply updates all of the call sites, to allow the "operator T*"
to be removed and preventing new instances. The existing instances will then be
reviewed for "suspicious" changes and updated to use/pass scoped_refptr<T>
rather than T*, as appropriate.
BUG=110610
TBR=darin
Review URL: https://codereview.chromium.org/15984016
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@205560 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
Leaves WebApplicationInfo struct definition in chrome/common
since it is used over IPC and in the browser process.
BUG=239202
R=miket@chromium.org
Review URL: https://codereview.chromium.org/14734007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@199373 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
a policy which might disallow allowing an extension. This CL
changes this and also adds request authorization calls for
managed users. Moreover some common logic of
unpacked_installer and crx_installer is combined.
The managed_user_service_unittest is adjusted to these changes.
BUG=171370
TEST=Manual
Review URL: https://chromiumcodereview.appspot.com/12965012
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@198476 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Allows resource export from one extension that can
be imported into another extension's namespace.
BUG=236044
TEST=browser_tests ExtensionApiTest.SharedModule
TEST=unit_tests SharedModuleManifestTest.*
Review URL: https://chromiumcodereview.appspot.com/13971005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@197201 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
Also move ExtensionResource to extensions namespace.
Also clean up the GenerateId and ShouldLocalizeManfest interfaces.
BUG=159265
Review URL: https://chromiumcodereview.appspot.com/12578008
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@190078 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
When a managed user tries to install or uninstall an extension, he will be
shown a dialog where the passphrase of the custodian has to be entered.
Upon authorization the extension is installed/uninstalled, and when this
has finished, the authorization is reset.
BUG=171370
TEST=Manual
Review URL: https://chromiumcodereview.appspot.com/12476022
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@188205 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
manifest is based on.
BUG=181074,180296
Review URL: https://chromiumcodereview.appspot.com/12391050
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@187220 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The identity API is moving to prompting for scopes at runtime only. This
change removes OAuth prompts from all app install flows. The Identity API
still displays the extension install dialog at runtime for its prompts.
OAuth code will be removed from the extension install dialog in the next
change, which will switch Identity to web-based dialogs.
BUG=124493
Review URL: https://chromiumcodereview.appspot.com/12433009
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@186790 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
While dropping a CRX on the extension page, if there is a previous version installed, then do the following.
- If the extension requires no new permission, then update silently.
- If the extension requires additional permission, install the update silently which causes the extension to get disabled. And show the re-enable prompt.
* if user cancels the prompt, extension will continue to be disabled.
* if user confirms re-enable, extension will be enabled back.
Screenshot of the re-enable prompt is uploaded at http://crbug.com/169521#c11
BUG=169521
Review URL: https://chromiumcodereview.appspot.com/12319131
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@185401 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
TBR=sky
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@184344 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
- check all extensions at once on startup (checking one at a time was
thrashing the message loop),
- check before installing rather than after (prevent blacklisted extensions
from ever being installed), and
- show an infobar ala the policy blacklist warning when an extension is
blacklisted.
Review URL: https://chromiumcodereview.appspot.com/12211029
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@181859 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
version control markers
Merge branch 'master' into file_path_browser
remove version control
Fix typo
Merge branch 'master' into file_path_browser
Conflicts:
chrome/browser/intents/native_services_browsertest.cc
chrome/browser/ui/intents/native_file_picker_service.cc
Merge branch 'master' into file_path_browser
Conflicts:
chrome/browser/chromeos/drive/drive_file_system.cc
chrome/browser/chromeos/drive/drive_file_system.h
chrome/browser/chromeos/drive/drive_file_system_interface.h
chrome/browser/chromeos/drive/drive_file_system_unittest.cc
chrome/browser/chromeos/drive/file_system/drive_operations.cc
chrome/browser/chromeos/login/wallpaper_manager.cc
chrome/browser/chromeos/login/wallpaper_manager.h
chrome/browser/chromeos/login/wallpaper_manager_browsertest.cc
chrome/browser/extensions/api/sync_file_system/extension_sync_event_observer.cc
chrome/browser/google_apis/gdata_wapi_operations.cc
chrome/browser/google_apis/gdata_wapi_operations.h
chrome/browser/google_apis/gdata_wapi_operations_unittest.cc
chrome/browser/profiles/off_the_record_profile_impl.cc
chrome/browser/profiles/off_the_record_profile_impl.h
chrome/browser/profiles/profile_impl.cc
chrome/browser/profiles/profile_impl.h
chrome/browser/profiles/profile_impl_io_data.cc
chrome/browser/profiles/profile_impl_io_data.h
chrome/browser/sync_file_system/drive_file_sync_client_unittest.cc
chrome/browser/ui/webui/options/manage_profile_handler.cc
Long lines
long lines
some long lines.
long lines
long lines
Beginning of lines.
Rename FilePath -> base::FilePath in chrome/browser
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@181638 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
to its own file.
Reverses the dependency between Extension and Manifest.
Part 1 of moving Manifest to top-level extensions.
BUG=162530
TBR=ben@chromium.org
Review URL: https://chromiumcodereview.appspot.com/12093036
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@179828 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
has the same version and location as the pending installation.
This triggers when an ExternalLoader updates its list while an extension is still installing.
BUG=161920
Review URL: https://chromiumcodereview.appspot.com/11440034
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@171752 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
now using their own sequenced task runner instead.
BUG=160183
TEST=SandboxedUnpackerTest.*, ExtensionInstallUIBrowserTest.*
Review URL: https://codereview.chromium.org/11369146
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@167991 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
For Apps and Extensions with a lazy background page, this will delay installing
an update until the background page gets unloaded (or next chrome restart).
Also adds a chrome.runtime.onUpdateAvailable event which is fired when an update is
available but isn't being installed immediately because the app is not idle.
It doesn't change anything yet for Extensions with a persistent background page
(or extensions without a background page at all). Those still get updated as soon
as an update is found.
BUG=37971
BUG=143260
TBR=nick@chromium.org
Review URL: https://chromiumcodereview.appspot.com/11293002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@166358 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Upon signing in to a profile (or login to Chrome OS) sync starts pulling down
extensions and installing them. This creates long tasks on the file thread.
If one of these tasks completes during browser shutdown, it initiates another
installation and more file I/O. This leads to Chrome's shutdown watchdog being
triggered, which on Chrome OS leads to a SIGABRT after 10 seconds.
This is one of our top-crashes on Chrome OS and can be easily triggered by
signing into an account (triggering sync of a bunch of apps) and immediately
signing out.
Fix it by preventing extension installation and updates after the browser has
started shutting down. We make a best-effort attempt to clean up, and on next
run the extension garbage collector cleans things up and sync continues.
BUG=155994
TEST=added to ExtensionServiceTest, existing browser_tests and unit_tests
Review URL: https://chromiumcodereview.appspot.com/11233015
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@163407 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This speeds up extension installation on Chrome OS by about 20%. On Chrome OS
the USER_DATA_DIR is in /home/chronos, which is a different file system than
/home/chronos/user where the Extensions directory lives. Thus an attempt to
rename() an extension into place ends up being a recursive directory copy,
which is both non-atomic and slow.
Also add code to clean up the intermediate directory during extension garbage
collection, which might have lead to leaked files in the old code if Chrome
crashed during extension install.
Removed DIR_USER_DATA_TEMP as the extension install code was the only user.
Just use a temp directory for this during tests so we don't have to worry
about profile creation.
BUG=155994
TEST=Manual testing of extension install speed on Chrome OS, unit_tests ExtensionFromWebApp.* ExtensionFromUserScript.* SandboxedUnpackerTest.*
TBR=sky@chromium.org for removing an unused constant from chrome/common/chrome_paths.h
Review URL: https://chromiumcodereview.appspot.com/11198067
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@162880 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=152010
TBR=rdsmith@chromium.org, jrg@chromium.org
Review URL: https://chromiumcodereview.appspot.com/11087071
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@161479 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
Try 2.
First try: https://chromiumcodereview.appspot.com/10689097
BUG=133027, 130405
TBR=jhawkins@chromium.org, aa@chromium.org
Review URL: https://chromiumcodereview.appspot.com/10908184
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@156119 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Implemented for the "plugins" and "3d" options.
BUG=133027, 130405
Review URL: https://chromiumcodereview.appspot.com/10689097
TBR=eaugusti@chromium.org
Review URL: https://chromiumcodereview.appspot.com/10916220
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@155862 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
Implemented for the "plugins" and "3d" options.
BUG=133027, 130405
Review URL: https://chromiumcodereview.appspot.com/10689097
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@155861 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Rename StringOrdinal to Ordinal, move it to sync/, and templatize it.
Make StringOrdinal be an instantiation of Ordinal that matches its
previous behavior.
Create NodeOrdinal, which is another instantiation of Ordinal for
the ordinal_in_parent field in SyncEntity.
Rework Ordinal to handle arbitrary byte ranges and to simplify the
interpolation code a bit.
Generalize StringOrdinal unit tests for Ordinal.
Update users of StringOrdinal to prepend syncer::.
BUG=145412
TBR=estade@chromium.org,jianli@chromium.org,brettw@chromium.org,
Review URL: https://chromiumcodereview.appspot.com/10920017
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@155368 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=134756, 117261
Review URL: https://chromiumcodereview.appspot.com/10683003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@148244 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=136833, 117261
Review URL: https://chromiumcodereview.appspot.com/10703142
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@146407 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
For context see this thread:
https://groups.google.com/a/chromium.org/forum/?fromgroups#!topic/chromium-dev/RMcVNGjB4II
TBR=thakis,pkasting,jam
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@146163 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
TBR=sky@chromium.org
Review URL: https://chromiumcodereview.appspot.com/10683005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@146157 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
the server is the golden standard for which scopes the user has granted; there's
no point in caching them locally when our cache can go stale at any point.
BUG=130206
TEST=manual
Review URL: https://chromiumcodereview.appspot.com/10694064
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@145750 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
extensions namespace; rename them to SandboxedUnpacker and SandboxedUnpackerClient.
BUG=134011, 117261
Review URL: https://chromiumcodereview.appspot.com/10637004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@145161 0039d316-1c4b-4281-b951-d872f2087c98
|