| Commit message (Collapse) | Author | Age | Files | Lines |
|---|
| |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This CL allows app_shell to use chrome.alarms.
Also it includes the following changes related to unit tests:
- Moved chrome.alarms tests to extensions/
- Moved a helper function CreateEmptyExtensionWithLocation()
from extension_function_test_utils.h to api_test_utils.h.
- Moved CreateBackgroundPage() from extension_api_unittest.h to
api_unittest.h.
- Creates WebContents for the extension that can be used to associate
a RenderViewHost in extension unit tests.
BUG=443622
Review URL: https://codereview.chromium.org/789643004
Cr-Commit-Position: refs/heads/master@{#314040}
|
| |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The Google C++ style guide states:
Explicitly annotate overrides of virtual functions or virtual
destructors with an override or (less frequently) final specifier.
Older (pre-C++11) code will use the virtual keyword as an inferior
alternative annotation. For clarity, use exactly one of override,
final, or virtual when declaring an override.
To better conform to these guidelines, the following constructs have
been rewritten:
- if a base class has a virtual destructor, then:
virtual ~Foo(); -> ~Foo() override;
- virtual void Foo() override; -> void Foo() override;
- virtual void Foo() override final; -> void Foo() final;
This patch was automatically generated. The clang plugin can generate
fixit hints, which are suggested edits when it is 100% sure it knows how
to fix a problem. The hints from the clang plugin were applied to the
source tree using the tool in https://codereview.chromium.org/598073004.
BUG=417463
R=rdevlin.cronin@chromium.org
Review URL: https://codereview.chromium.org/671973003
Cr-Commit-Position: refs/heads/master@{#301704}
|
| |
|
|
|
|
|
|
| |
BUG=417463
Review URL: https://codereview.chromium.org/624153002
Cr-Commit-Position: refs/heads/master@{#298134}
|
| |
|
|
|
|
|
|
|
|
|
|
| |
Chrome dependencies.
Move SocketsTcpUnitTest as the first test to use it.
BUG=397164
Review URL: https://codereview.chromium.org/461273003
Cr-Commit-Position: refs/heads/master@{#292296}
|
|
|
Several different test files are using the same code for running api functions
in a unit test, but they aren't sharing code. Fix this.
Review URL: https://codereview.chromium.org/131973017
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@247315 0039d316-1c4b-4281-b951-d872f2087c98
|
