| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
|
| |
TBR=brettw
Review URL: https://codereview.chromium.org/19074002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@211285 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
TBR=sky
BUG=96594
Review URL: https://codereview.chromium.org/17893012
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@208785 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
This eliminates a whole class of problems with SpawnedTestServer
failing to start.
BUG=96594, 98194
R=asargent@chromium.org, rsleevi@chromium.org, sky@chromium.org
Review URL: https://codereview.chromium.org/16268017
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@208784 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=244912
Review URL: https://chromiumcodereview.appspot.com/15998003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@206139 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This upates calls to bound temporary objects to also use get().
While it has the same semantic equivalence to the existing code, this generally
represents a dangerous pattern - indeed, part of the whole motivation for this
change is to make this anti-pattern very visible to authors.
This change simply updates all of the call sites, to allow the "operator T*"
to be removed and preventing new instances. The existing instances will then be
reviewed for "suspicious" changes and updated to use/pass scoped_refptr<T>
rather than T*, as appropriate.
BUG=110610
TBR=darin
Review URL: https://codereview.chromium.org/15984016
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@205560 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=247723
TEST=none
TBR=ben@chromium.org
Review URL: https://chromiumcodereview.appspot.com/16402006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@205295 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
This is the exact same code change as https://codereview.chromium.org/16058002/, just with more tests manually disabled.
TBR=shess@chromium.org,mpcomplete@chromium.org
BUG=177163
Review URL: https://chromiumcodereview.appspot.com/15995032
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@204135 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
This CL updates chrome/browser/* other than chrome/browser/ui which is in
another CL.
BUG=236029
TBR=brettw
Review URL: https://chromiumcodereview.appspot.com/14113053
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@202664 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
> Better workaround for extension browser test problems on win debug bots
>
> Instead of trying to fake out gtest output and exiting, just return true
> in RunExtensionSubTest.
>
> TBR=shess@chromium.org,mpcomplete@chromium.org
>
> BUG=177163
>
> Review URL: https://chromiumcodereview.appspot.com/16058002
TBR=asargent@chromium.org
Review URL: https://codereview.chromium.org/15934004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@202347 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Instead of trying to fake out gtest output and exiting, just return true
in RunExtensionSubTest.
TBR=shess@chromium.org,mpcomplete@chromium.org
BUG=177163
Review URL: https://chromiumcodereview.appspot.com/16058002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@202339 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
ExitProcess(0). See bug for rationale.
BUG=177163
TEST=none
R=mpcomplete@chromium.org
Review URL: https://codereview.chromium.org/14722017
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@198890 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
This is a part of replacing most usages of the Python test server
with an in-process C++ test server that should be easier to debug.
BUG=96594
R=rch@chromium.org
Review URL: https://codereview.chromium.org/14691006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@198783 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
This is a part of replacing most usages of the Python test server
with an in-process C++ test server that should be easier to debug.
BUG=96594
R=rch@chromium.org
Review URL: https://codereview.chromium.org/14702004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@198151 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This patch was generated by running the empty_string clang tool
across the Chromium Linux compilation database. Implicitly or
explicitly constructing std::string() with a "" argument is
inefficient as the caller needs to emit extra instructions to
pass an argument, and the constructor needlessly copies a byte
into internal storage. Rewriting these instances to simply call
the default constructor appears to save ~14-18 kilobytes on an
optimized release build.
BUG=none
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=193020
Review URL: https://codereview.chromium.org/13145003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@193040 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This reverts commit e59558b78e8c6a1b0bd916a724724b638c3c91b6.
Revert "Fix build after r193020."
This reverts commit 558a35897f6b3ffbcaefde927c1f150b815d140a.
Revert "Really fix build after r193020."
This reverts commit e3748a79b523a8d365d4a33ef986eebb4186fa78.
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@193030 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This patch was generated by running the empty_string clang tool
across the Chromium Linux compilation database. Implicitly or
explicitly constructing std::string() with a "" argument is
inefficient as the caller needs to emit extra instructions to
pass an argument, and the constructor needlessly copies a byte
into internal storage. Rewriting these instances to simply call
the default constructor appears to save ~14-18 kilobytes on an
optimized release build.
BUG=none
Review URL: https://codereview.chromium.org/13145003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@193020 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
version control markers
Merge branch 'master' into file_path_browser
remove version control
Fix typo
Merge branch 'master' into file_path_browser
Conflicts:
chrome/browser/intents/native_services_browsertest.cc
chrome/browser/ui/intents/native_file_picker_service.cc
Merge branch 'master' into file_path_browser
Conflicts:
chrome/browser/chromeos/drive/drive_file_system.cc
chrome/browser/chromeos/drive/drive_file_system.h
chrome/browser/chromeos/drive/drive_file_system_interface.h
chrome/browser/chromeos/drive/drive_file_system_unittest.cc
chrome/browser/chromeos/drive/file_system/drive_operations.cc
chrome/browser/chromeos/login/wallpaper_manager.cc
chrome/browser/chromeos/login/wallpaper_manager.h
chrome/browser/chromeos/login/wallpaper_manager_browsertest.cc
chrome/browser/extensions/api/sync_file_system/extension_sync_event_observer.cc
chrome/browser/google_apis/gdata_wapi_operations.cc
chrome/browser/google_apis/gdata_wapi_operations.h
chrome/browser/google_apis/gdata_wapi_operations_unittest.cc
chrome/browser/profiles/off_the_record_profile_impl.cc
chrome/browser/profiles/off_the_record_profile_impl.h
chrome/browser/profiles/profile_impl.cc
chrome/browser/profiles/profile_impl.h
chrome/browser/profiles/profile_impl_io_data.cc
chrome/browser/profiles/profile_impl_io_data.h
chrome/browser/sync_file_system/drive_file_sync_client_unittest.cc
chrome/browser/ui/webui/options/manage_profile_handler.cc
Long lines
long lines
some long lines.
long lines
long lines
Beginning of lines.
Rename FilePath -> base::FilePath in chrome/browser
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@181638 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
to its own file.
Reverses the dependency between Extension and Manifest.
Part 1 of moving Manifest to top-level extensions.
BUG=162530
TBR=ben@chromium.org
Review URL: https://chromiumcodereview.appspot.com/12093036
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@179828 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=None
Review URL: https://chromiumcodereview.appspot.com/12090063
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@179823 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This change causes shutdown crashes when chrome menu is used to exit.
> Keep browser process alive while there are platform apps with background pages running. This does not happen on Android or ChromeOS builds: Android does not support browser process keep alive, and ChromeOS does not need or like it.
>
> This change prevents platform apps getting killed unceremoniously while they have background pages active.
>
> This also delays the process being shutdown after closing the last platform app window, as background pages are kept alive for 15 seconds after their last activity is completed.
>
> This change re-lands r165772 which caused problems on Google branded ChromeOS. This version does not add keep alives for ChromeOS and was tested on the ChromeOS try bots.
>
> TBR=davemoore@chromium.org for the ash launcher test change.
>
> BUG=155457
> TEST=Make sure platform apps can be used from the launcher without chrome windows open; make sure Chrome shuts down properly in all cases.
>
>
> Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=165772
>
> Review URL: https://chromiumcodereview.appspot.com/11117011
TBR=benwells@chromium.org
Review URL: https://codereview.chromium.org/11299326
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@170891 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
pages running. This does not happen on Android or ChromeOS builds: Android does not support browser process keep alive, and ChromeOS does not need or like it.
This change prevents platform apps getting killed unceremoniously while they have background pages active.
This also delays the process being shutdown after closing the last platform app window, as background pages are kept alive for 15 seconds after their last activity is completed.
This change re-lands r165772 which caused problems on Google branded ChromeOS. This version does not add keep alives for ChromeOS and was tested on the ChromeOS try bots.
TBR=davemoore@chromium.org for the ash launcher test change.
BUG=155457
TEST=Make sure platform apps can be used from the launcher without chrome windows open; make sure Chrome shuts down properly in all cases.
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=165772
Review URL: https://chromiumcodereview.appspot.com/11117011
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@170660 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
ExtensionSystem. Extension services were made into ProfileKeyedServices a while ago; this replaces the deprecated calls that ran directly through the Profile object.
This is about half of the total GetExtensionService calls in the codebase, but this CL is already ridiculously large.
BUG= http://code.google.com/p/chromium/issues/detail?id=104095
Review URL: https://chromiumcodereview.appspot.com/11365181
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@170497 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
with background pages running.
Change r165772 broke logout on official Chrome OS, such that Chrome
crashes every time you log out. This was caught by our bots which
immediately started failing every time, starting with r165772.
I tested this change on Chrome OS bots and confirmed that the
Chrome OS bots were fixed.
TBR=benwells@chromium.org
BUG=chromium:155457, chromium-os:36058
TEST=Run Chrome and Chrome OS trybots on several architectures. Verify
Chrome OS build is reliable now and that all Chrome browser tests still
pass.
Original CL description:
This change prevents platform apps getting killed unceremoniously
while they have background pages active.
This also delays the process being shutdown after closing the last platform
app window, as background pages are kept alive for 15 seconds after their
last activity is completed.
Review URL: https://codereview.chromium.org/11275209
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@166715 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
pages running.
This change prevents platform apps getting killed unceremoniously while they have background pages active.
This also delays the process being shutdown after closing the last platform app window, as background pages are kept alive for 15 seconds after their last activity is completed.
TBR=davemoore@chromium.org for the ash launcher test change.
BUG=155457
TEST=Make sure platform apps can be used from the launcher without chrome windows open; make sure Chrome shuts down properly in all cases.
Review URL: https://chromiumcodereview.appspot.com/11117011
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@165772 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Now that some of our APIs are out of experimental, the ones still in
experimental should append the command line individually in their tests as
needed.
BUG=155430
Review URL: https://chromiumcodereview.appspot.com/11145006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@162004 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
WebSocket test server migration from content::TestWebSocketServer to
net::TestServer.
This is the first change to use net::TestServer as a WebSocket test server.
Other changes will follow to obsoelte content::TestWebSocketServer.
BUG=137639
TEST=browser_tests --gtest_filter='ExtensionApiTest.WebSocket'
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=161304
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=161542
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=161572
Review URL: https://chromiumcodereview.appspot.com/11087027
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@161773 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
ExtensionApiTest.WebSocket (third trial)
WebSocket test server migration from content::TestWebSocketServer to
net::TestServer.
This is the first change to use net::TestServer as a WebSocket test server.
Other changes will follow to obsoelte content::TestWebSocketServer.
BUG=137639
TEST=browser_test --gtest_filter='ExtensionApiTest.WebSocket'
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=161304
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=161542
Review URL: https://chromiumcodereview.appspot.com/11087027
TBR=toyoshim@chromium.org
Review URL: https://codereview.chromium.org/11115011
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@161575 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
WebSocket test server migration from content::TestWebSocketServer to
net::TestServer.
This is the first change to use net::TestServer as a WebSocket test server.
Other changes will follow to obsoelte content::TestWebSocketServer.
BUG=137639
TEST=browser_test --gtest_filter='ExtensionApiTest.WebSocket'
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=161304
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=161542
Review URL: https://chromiumcodereview.appspot.com/11087027
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@161572 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
ExtensionApiTest.WebSocket (retry)
WebSocket test server migration from content::TestWebSocketServer to
net::TestServer.
This is the first change to use net::TestServer as a WebSocket test server.
Other changes will follow to obsoelte content::TestWebSocketServer.
BUG=137639
TEST=browser_test --gtest_filter='ExtensionApiTest.WebSocket'
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=161304
Review URL: https://chromiumcodereview.appspot.com/11087027
TBR=toyoshim@chromium.org
Review URL: https://codereview.chromium.org/11114015
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@161549 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
WebSocket test server migration from content::TestWebSocketServer to
net::TestServer.
This is the first change to use net::TestServer as a WebSocket test server.
Other changes will follow to obsoelte content::TestWebSocketServer.
BUG=137639
TEST=browser_test --gtest_filter='ExtensionApiTest.WebSocket'
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=161304
Review URL: https://chromiumcodereview.appspot.com/11087027
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@161542 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
WebSocket test server migration from content::TestWebSocketServer to
net::TestServer.
This is the first change to use net::TestServer as a WebSocket test server.
Other changes will follow to obsoelte content::TestWebSocketServer.
BUG=137639
TEST=browser_test --gtest_filter='ExtensionApiTest.WebSocket'
Review URL: https://chromiumcodereview.appspot.com/11087027
TBR=toyoshim@chromium.org
Review URL: https://codereview.chromium.org/11091059
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@161308 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
WebSocket test server migration from content::TestWebSocketServer to
net::TestServer.
This is the first change to use net::TestServer as a WebSocket test server.
Other changes will follow to obsoelte content::TestWebSocketServer.
BUG=137639
TEST=browser_test --gtest_filter='ExtensionApiTest.WebSocket'
Review URL: https://chromiumcodereview.appspot.com/11087027
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@161304 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=132718
Review URL: https://chromiumcodereview.appspot.com/10912041
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@154637 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
Test extension should be well-formed. Having warnings is often an early
indicator that something else is wrong (see for example https://chromiumcodereview.appspot.com/10852016/).
Review URL: https://chromiumcodereview.appspot.com/10826157
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@151123 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Mapping from extension.location():
INTERNAL -> 'normal'
LOAD -> 'development'
EXTERNAL_POLICY_DOWNLOAD -> 'admin'
EXTERNAL* -> 'sideload'
(all others) -> 'other'
BUG=135564
TBR=jam@chromium.org
Review URL: https://chromiumcodereview.appspot.com/10750010
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@149767 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
content_browsertests.
BUG=90448
Review URL: https://chromiumcodereview.appspot.com/10822030
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@148514 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
it'll be used by worker_browsertest.cc inside content_browsertests.
BUG=90448
Review URL: https://chromiumcodereview.appspot.com/10796110
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@148139 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
This makes it easier to update the parameters used when changing how apps are launched without updating many call sites with unused parameters.
BUG=None
TEST=Covered by automated tests.
Review URL: https://chromiumcodereview.appspot.com/10700130
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@146554 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
Review URL: https://chromiumcodereview.appspot.com/10631011
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@146412 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=101244
TEST=N/A, only moving code, no change in functionality
Review URL: https://chromiumcodereview.appspot.com/10690113
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@146107 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
TEST=try bots
BUG=131688
Review URL: https://chromiumcodereview.appspot.com/10538074
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@143068 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Any command line arguments which are file names are passed through in
launchData.intent
BUG=None
TEST=New tests added
Review URL: https://chromiumcodereview.appspot.com/10332071
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@139195 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
This doesn't need to be in Browser, and won't always open a Browser
window.
BUG=None
TEST=Existing tests
Review URL: https://chromiumcodereview.appspot.com/10409023
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@138448 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=117262
TBR=aa@chromium.org
Review URL: https://chromiumcodereview.appspot.com/10375021
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@138074 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
onLaunched event.
Platform apps must now have a background page. For the handling of launches,
the background page registers an onLaunched event handler, and creates UI
as appropriate via the chrome.windows.* API.
Updates all tests to use the new window model.
Also makes created shell window respect the bounds that were passed into the
chrome.windows.create() call.
Also fixes bug by resizing windows in PlatformAppBrowserTest.WindowsApi to a
size that matches the Aura grid.
This CL was originally written by mihaip@chromium.org - the original is:
http://codereview.chromium.org/9969087/
TBR=mihaip@chromium.org
BUG=119410
TEST=Platform apps should now require a background page.
Review URL: https://chromiumcodereview.appspot.com/10080017
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@133555 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=122414
TEST=ExtensionWebstorePrivateBundleTest.InstallBundleIncognito
Review URL: http://codereview.chromium.org/10008062
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@131213 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
process.
VerifyPermissions was replaced with something simpler in http://codereview.chromium.org/9867003/, and another simple browser test in chrome/browser/extensions/crx_installer_browsertest.cc.
We weren't copying --enable-platform-apps to the utility process that unzipped CRX files, so it wasn't able to load platform app CRXes.
BUG=120075, also in-person reported during hackathon
TEST=added (and refactored others)
Review URL: https://chromiumcodereview.appspot.com/9839106
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@129556 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Reapplication of http://codereview.chromium.org/9837045/.
BUG=119758
TEST=added
TBR=asargent@chromium.org,jstritar@chromium.org
Review URL: http://codereview.chromium.org/9839105
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@128838 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Reapplication of http://codereview.chromium.org/9834022/ with the
VerifyPermissions test #ifdefed out for Windows.
BUG=119758
TEST=added
Review URL: https://chromiumcodereview.appspot.com/9837045
TBR=miket@chromium.org
Review URL: https://chromiumcodereview.appspot.com/9808096
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@128620 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
Reapplication of http://codereview.chromium.org/9834022/ with the
VerifyPermissions test #ifdefed out for Windows.
BUG=119758
TEST=added
Review URL: https://chromiumcodereview.appspot.com/9837045
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@128610 0039d316-1c4b-4281-b951-d872f2087c98
|