summaryrefslogtreecommitdiffstats
path: root/chrome/browser/extensions/extension_apitest.cc
Commit message (Collapse)AuthorAgeFilesLines
* Fix more cases of unreachable code on Windows, mostly added recently.pkasting@chromium.org2014-05-221-1/+2
| | | | | | | | | BUG=346399 TEST=none Review URL: https://codereview.chromium.org/296053005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@272069 0039d316-1c4b-4281-b951-d872f2087c98
* Add net/base/filename_util.h.sergeyu@chromium.org2014-04-091-1/+1
| | | | | | | | | | | | | | | Moved some filename-related functions from net_util.h to the new filename_util.h . BUG=276739 R=piman@chromium.org, rsleevi@chromium.org TBR=kalman@chromium.org, piman@chromium.org, sky@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=262487 Review URL: https://codereview.chromium.org/220253002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@262609 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 262487 "Add net/base/filename_util.h."sergeyu@chromium.org2014-04-081-1/+1
| | | | | | | | | | | | | | | | | | | > Add net/base/filename_util.h. > > Moved some filename-related functions from net_util.h to the new > filename_util.h . > > BUG=276739 > R=piman@chromium.org, rsleevi@chromium.org > TBR=kalman@chromium.org, piman@chromium.org, sky@chromium.org > > Review URL: https://codereview.chromium.org/220253002 TBR=sergeyu@chromium.org Review URL: https://codereview.chromium.org/228763004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@262498 0039d316-1c4b-4281-b951-d872f2087c98
* Add net/base/filename_util.h.sergeyu@chromium.org2014-04-081-1/+1
| | | | | | | | | | | | | Moved some filename-related functions from net_util.h to the new filename_util.h . BUG=276739 R=piman@chromium.org, rsleevi@chromium.org TBR=kalman@chromium.org, piman@chromium.org, sky@chromium.org Review URL: https://codereview.chromium.org/220253002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@262487 0039d316-1c4b-4281-b951-d872f2087c98
* Move chrome.test API files to src/extensions.yoz@chromium.org2014-04-041-1/+1
| | | | | | | | | BUG=355192 TBR=satorux@chromium.org Review URL: https://codereview.chromium.org/224173004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@261628 0039d316-1c4b-4281-b951-d872f2087c98
* Allow FTP requests by Chromium extensionsrob@robwu.nl2014-03-131-0/+16
| | | | | | | | | | | | | | When an extension specifies a ftp://*/* or <all_urls> permission, then the extension should be allowed to fetch data from a FTP site. Contributed by Rob Wu <rob@robwu.nl> BUG=75248 TEST=ExtensionApiTest.CrossOriginXHRBackgroundPage:ExtensionApiTest.CrossOriginXHRContentScript Review URL: https://codereview.chromium.org/166793003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@256810 0039d316-1c4b-4281-b951-d872f2087c98
* Split ExtensionSystem interface from ExtensionSystemImpl implementation, part 1.yoz@chromium.org2014-01-301-1/+1
| | | | | | | | | | | | | This moves ExtensionSystem to extensions/browser. It also moves setting the channel for Features to ChromeExtensionsBrowserClient. It also removes the duplicate ExtensionSystem::GetForBrowserContext. BUG=337707 TBR=sky@chromium.org Review URL: https://codereview.chromium.org/147923005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@247788 0039d316-1c4b-4281-b951-d872f2087c98
* Update some uses of Value in chrome/browser to use the base:: namespace.avi@chromium.org2013-12-231-1/+1
| | | | | | | | | | BUG=88666 TEST=no change TBR=ben@chromium.org Review URL: https://codereview.chromium.org/120783002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@242389 0039d316-1c4b-4281-b951-d872f2087c98
* Convert Extension* to extension id in AppLaunchParams.koz@chromium.org2013-12-171-1/+1
| | | | | | | | | | | | | | | Having raw Extension pointers is problematic because an extension may be reloaded during the lifetime of AppLaunchParams, which will invalidate the pointer. This also converts CommandLine* to CommandLine and lets the empty command line represent "no command line". BUG=323220 Review URL: https://codereview.chromium.org/114263005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@241143 0039d316-1c4b-4281-b951-d872f2087c98
* Move c/c/e/extension_set to top-level extensions/rdevlin.cronin@chromium.org2013-12-171-1/+3
| | | | | | | | | | | | | | | | | | | | | | | | | | Move extension_set.h/cc and extension_set_unittest to extensions/common/. Remove unused includes. Add includes where transitive includes were used. Update DEPS. No functional changes. BUG=162530 TBR=sky@chromium.org (c/b/autocomplete, c/b/ui, c/test) TBR=jam@chromium.org (c/b/automation) TBR=atwilson@chromium.org (c/b/background, c/b/sync, c/b/policy) TBR=bauerb@chromium.org (c/b/browsing_data, c/b/content_settings, c/b/managed_mode) TBR=satorux@chromium.org (c/b/chromeos) TBR=yurys@chromium.org (c/b/devtools) TBR=thestig@chromium.org (c/b/media_galleries) TBR=stevenjb@chromium.org (c/b/notifications) TBR=battre@chromium.org (c/b/profile_resetter) TBR=dmazzoni@chromium.org (c/b/speech) TBR=kinuko@chromium.org (c/b/sync_file_system) TBR=pkotwicz@chromium.org (c/b/themes) Review URL: https://codereview.chromium.org/102103005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@241131 0039d316-1c4b-4281-b951-d872f2087c98
* Move LaunchContainer enum to extension_constants.h.derat@chromium.org2013-12-061-2/+4
| | | | | | | | | | | | | | | | | | | | | Move the Chrome-specific LaunchContainer enum out of extensions/common/constants.h and into chrome/common/extensions/extension_constants.h (it can't live under chrome/browser/extensions since it's used by AppLaunchInfo). For consistency, also move the LaunchType enum to extension_constants.h. Rename LaunchContainer's values from LAUNCH_* to LAUNCH_CONTAINER_*, and also rename the LAUNCH_TYPE_* values in AppContextMenu to USE_LAUNCH_TYPE_* to avoid confusion with the LaunchType enum. BUG=180083 TBR=sky@chromium.org,jar@chromium.org Review URL: https://codereview.chromium.org/106713002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@239202 0039d316-1c4b-4281-b951-d872f2087c98
* Reinstate alwaysOnTopWindows permissiontmdiep@chromium.org2013-12-061-0/+6
| | | | | | | | | | | | | | | | | | | | | | Reinstate the "alwaysOnTopWindows" permission. This feature is available only in the Dev channel, but is whitelisted for two first-party apps in Stable. Apps that wish to enable the alwaysOnTop property for app windows must now declare the "alwaysOnTopWindows" permission in their manifest. This permission does not generate a warning in install prompts. BUG=326361 TESTS=browser_tests (PlatformAppBrowserTest.WindowsApiAlwaysOnTop*) Manual test: Create an app which does not specify this permission and attempts to create a new window with the option enabled or calls setAlwaysOnTop(true) on an existing window. The window should not be always on top. The option should work for apps which do declare the permission. Review URL: https://codereview.chromium.org/61073004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@239180 0039d316-1c4b-4281-b951-d872f2087c98
* Move Extension and PermissionsData to extensions/common.yoz@chromium.org2013-11-151-2/+2
| | | | | | | | | | BUG=298586 R=cdn@chromium.org, miket@chromium.org, sky@chromium.org TBR=cdn@chromium.org Review URL: https://codereview.chromium.org/15239002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@235462 0039d316-1c4b-4281-b951-d872f2087c98
* Move LaunchContainer enum out of chrome/.derat@chromium.org2013-11-081-2/+1
| | | | | | | | | | | | | | | | | | Move the LaunchContainer enum from chrome/common/extensions/extension_constants.h's extension_misc namespace to extensions/common/constants.h's extensions namespace. Also rename the LAUNCH_* values in the ExtensionPref::LaunchType enum to LAUNCH_TYPE_* to make them less likely to get confused with LaunchContainer's values. BUG=313284 TBR=isherman@chromium.org, sky@chromium.org Review URL: https://codereview.chromium.org/60353011 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@233747 0039d316-1c4b-4281-b951-d872f2087c98
* Fix PrerenderBrowserTestWithExtensions.WebNavigation test.davidben@chromium.org2013-10-291-0/+14
| | | | | | | | | | | | | | | | | It got broken after it was disabled. Fix it and bring its disabled configs in line with other extension browser_test flakes. This is on the theory that this is the only source of the flake. If the test still fails, it can be disabled again. Also remove a chrome.tabs.update call in PrerenderBrowserTestWithExtensions.TabsApi that wasn't doing anything. BUG=177163,249179 TEST=PrerenderBrowserTestWithExtensions.* Review URL: https://codereview.chromium.org/28273007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@231451 0039d316-1c4b-4281-b951-d872f2087c98
* Cleanup: Remove chrome namespace from application_launch.hlimasdf@gmail.com2013-09-271-4/+4
| | | | | | | | | BUG=289619 TEST=compile(windows,linux,chromeos,browser_test,unit_tests) Review URL: https://codereview.chromium.org/24756003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@225693 0039d316-1c4b-4281-b951-d872f2087c98
* Cleanup: Use std::string in ExtensionApiTest.thestig@chromium.org2013-09-241-21/+22
| | | | | | Review URL: https://chromiumcodereview.appspot.com/23531076 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@224891 0039d316-1c4b-4281-b951-d872f2087c98
* Update some includes of chrome_notification_types.hjam@chromium.org2013-07-121-1/+1
| | | | | | | | TBR=brettw Review URL: https://codereview.chromium.org/19074002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@211285 0039d316-1c4b-4281-b951-d872f2087c98
* Fix build.phajdan.jr@chromium.org2013-06-261-5/+5
| | | | | | | | | | TBR=sky BUG=96594 Review URL: https://codereview.chromium.org/17893012 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@208785 0039d316-1c4b-4281-b951-d872f2087c98
* GTTF: convert some tests in chrome to use EmbeddedTestServer patch nr 1phajdan.jr@chromium.org2013-06-261-4/+108
| | | | | | | | | | | | This eliminates a whole class of problems with SpawnedTestServer failing to start. BUG=96594, 98194 R=asargent@chromium.org, rsleevi@chromium.org, sky@chromium.org Review URL: https://codereview.chromium.org/16268017 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@208784 0039d316-1c4b-4281-b951-d872f2087c98
* Begin to merge dup code for embedder in webview tests.lazyboy@chromium.org2013-06-131-6/+20
| | | | | | | | BUG=244912 Review URL: https://chromiumcodereview.appspot.com/15998003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@206139 0039d316-1c4b-4281-b951-d872f2087c98
* Call scoped_refptr<T>::get() rather than relying on implicit "operator T*"rsleevi@chromium.org2013-06-111-1/+1
| | | | | | | | | | | | | | | | | | | This upates calls to bound temporary objects to also use get(). While it has the same semantic equivalence to the existing code, this generally represents a dangerous pattern - indeed, part of the whole motivation for this change is to make this anti-pattern very visible to authors. This change simply updates all of the call sites, to allow the "operator T*" to be removed and preventing new instances. The existing instances will then be reviewed for "suspicious" changes and updated to use/pass scoped_refptr<T> rather than T*, as appropriate. BUG=110610 TBR=darin Review URL: https://codereview.chromium.org/15984016 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@205560 0039d316-1c4b-4281-b951-d872f2087c98
* Use a direct include of strings headers in chrome/browser/extensions/, part 3.avi@chromium.org2013-06-101-2/+2
| | | | | | | | | | BUG=247723 TEST=none TBR=ben@chromium.org Review URL: https://chromiumcodereview.appspot.com/16402006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@205295 0039d316-1c4b-4281-b951-d872f2087c98
* Second try at better workaround for win dbg extensions api browser tests.asargent@chromium.org2013-06-051-5/+2
| | | | | | | | | | | | This is the exact same code change as https://codereview.chromium.org/16058002/, just with more tests manually disabled. TBR=shess@chromium.org,mpcomplete@chromium.org BUG=177163 Review URL: https://chromiumcodereview.appspot.com/15995032 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@204135 0039d316-1c4b-4281-b951-d872f2087c98
* chrome: Use base::MessageLoop. (Part 3)xhwang@chromium.org2013-05-281-2/+2
| | | | | | | | | | | | This CL updates chrome/browser/* other than chrome/browser/ui which is in another CL. BUG=236029 TBR=brettw Review URL: https://chromiumcodereview.appspot.com/14113053 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@202664 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 202339 "Better workaround for extension browser test prob..."xiyuan@chromium.org2013-05-261-2/+5
| | | | | | | | | | | | | | | | | | | > Better workaround for extension browser test problems on win debug bots > > Instead of trying to fake out gtest output and exiting, just return true > in RunExtensionSubTest. > > TBR=shess@chromium.org,mpcomplete@chromium.org > > BUG=177163 > > Review URL: https://chromiumcodereview.appspot.com/16058002 TBR=asargent@chromium.org Review URL: https://codereview.chromium.org/15934004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@202347 0039d316-1c4b-4281-b951-d872f2087c98
* Better workaround for extension browser test problems on win debug botsasargent@chromium.org2013-05-261-5/+2
| | | | | | | | | | | | | Instead of trying to fake out gtest output and exiting, just return true in RunExtensionSubTest. TBR=shess@chromium.org,mpcomplete@chromium.org BUG=177163 Review URL: https://chromiumcodereview.appspot.com/16058002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@202339 0039d316-1c4b-4281-b951-d872f2087c98
* Makes all tests (win-debug) that invoke RunExtensionSubtestsky@chromium.org2013-05-081-0/+8
| | | | | | | | | | | | ExitProcess(0). See bug for rationale. BUG=177163 TEST=none R=mpcomplete@chromium.org Review URL: https://codereview.chromium.org/14722017 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@198890 0039d316-1c4b-4281-b951-d872f2087c98
* Move SpawnedTestServer to its own subdirectory.phajdan.jr@chromium.org2013-05-071-1/+1
| | | | | | | | | | | | This is a part of replacing most usages of the Python test server with an in-process C++ test server that should be easier to debug. BUG=96594 R=rch@chromium.org Review URL: https://codereview.chromium.org/14691006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@198783 0039d316-1c4b-4281-b951-d872f2087c98
* GTTF: rename net::TestServer -> net::SpawnedTestServerphajdan.jr@chromium.org2013-05-031-4/+4
| | | | | | | | | | | | This is a part of replacing most usages of the Python test server with an in-process C++ test server that should be easier to debug. BUG=96594 R=rch@chromium.org Review URL: https://codereview.chromium.org/14702004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@198151 0039d316-1c4b-4281-b951-d872f2087c98
* Rewrite std::string("") to std::string(), Linux edition.dcheng@chromium.org2013-04-091-11/+16
| | | | | | | | | | | | | | | | | | | This patch was generated by running the empty_string clang tool across the Chromium Linux compilation database. Implicitly or explicitly constructing std::string() with a "" argument is inefficient as the caller needs to emit extra instructions to pass an argument, and the constructor needlessly copies a byte into internal storage. Rewriting these instances to simply call the default constructor appears to save ~14-18 kilobytes on an optimized release build. BUG=none Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=193020 Review URL: https://codereview.chromium.org/13145003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@193040 0039d316-1c4b-4281-b951-d872f2087c98
* Revert "Rewrite std::string("") to std::string(), Linux edition."dcheng@chromium.org2013-04-091-16/+11
| | | | | | | | | | | | | | This reverts commit e59558b78e8c6a1b0bd916a724724b638c3c91b6. Revert "Fix build after r193020." This reverts commit 558a35897f6b3ffbcaefde927c1f150b815d140a. Revert "Really fix build after r193020." This reverts commit e3748a79b523a8d365d4a33ef986eebb4186fa78. git-svn-id: svn://svn.chromium.org/chrome/trunk/src@193030 0039d316-1c4b-4281-b951-d872f2087c98
* Rewrite std::string("") to std::string(), Linux edition.dcheng@chromium.org2013-04-091-11/+16
| | | | | | | | | | | | | | | | | This patch was generated by running the empty_string clang tool across the Chromium Linux compilation database. Implicitly or explicitly constructing std::string() with a "" argument is inefficient as the caller needs to emit extra instructions to pass an argument, and the constructor needlessly copies a byte into internal storage. Rewriting these instances to simply call the default constructor appears to save ~14-18 kilobytes on an optimized release build. BUG=none Review URL: https://codereview.chromium.org/13145003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@193020 0039d316-1c4b-4281-b951-d872f2087c98
* Merge branch 'master' into file_path_browserbrettw@chromium.org2013-02-101-2/+3
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | version control markers Merge branch 'master' into file_path_browser remove version control Fix typo Merge branch 'master' into file_path_browser Conflicts: chrome/browser/intents/native_services_browsertest.cc chrome/browser/ui/intents/native_file_picker_service.cc Merge branch 'master' into file_path_browser Conflicts: chrome/browser/chromeos/drive/drive_file_system.cc chrome/browser/chromeos/drive/drive_file_system.h chrome/browser/chromeos/drive/drive_file_system_interface.h chrome/browser/chromeos/drive/drive_file_system_unittest.cc chrome/browser/chromeos/drive/file_system/drive_operations.cc chrome/browser/chromeos/login/wallpaper_manager.cc chrome/browser/chromeos/login/wallpaper_manager.h chrome/browser/chromeos/login/wallpaper_manager_browsertest.cc chrome/browser/extensions/api/sync_file_system/extension_sync_event_observer.cc chrome/browser/google_apis/gdata_wapi_operations.cc chrome/browser/google_apis/gdata_wapi_operations.h chrome/browser/google_apis/gdata_wapi_operations_unittest.cc chrome/browser/profiles/off_the_record_profile_impl.cc chrome/browser/profiles/off_the_record_profile_impl.h chrome/browser/profiles/profile_impl.cc chrome/browser/profiles/profile_impl.h chrome/browser/profiles/profile_impl_io_data.cc chrome/browser/profiles/profile_impl_io_data.h chrome/browser/sync_file_system/drive_file_sync_client_unittest.cc chrome/browser/ui/webui/options/manage_profile_handler.cc Long lines long lines some long lines. long lines long lines Beginning of lines. Rename FilePath -> base::FilePath in chrome/browser git-svn-id: svn://svn.chromium.org/chrome/trunk/src@181638 0039d316-1c4b-4281-b951-d872f2087c98
* Move Extension Location and Type enums to Manifest, and move InstallWarning ↵yoz@chromium.org2013-01-311-1/+1
| | | | | | | | | | | | | | | to its own file. Reverses the dependency between Extension and Manifest. Part 1 of moving Manifest to top-level extensions. BUG=162530 TBR=ben@chromium.org Review URL: https://chromiumcodereview.appspot.com/12093036 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@179828 0039d316-1c4b-4281-b951-d872f2087c98
* Rename application_launch namespace to chromebenwells@chromium.org2013-01-311-4/+4
| | | | | | | | | BUG=None Review URL: https://chromiumcodereview.appspot.com/12090063 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@179823 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 170660benwells@chromium.org2012-12-041-7/+0
| | | | | | | | | | | | | | | | | | | | | | | | | | | This change causes shutdown crashes when chrome menu is used to exit. > Keep browser process alive while there are platform apps with background pages running. This does not happen on Android or ChromeOS builds: Android does not support browser process keep alive, and ChromeOS does not need or like it. > > This change prevents platform apps getting killed unceremoniously while they have background pages active. > > This also delays the process being shutdown after closing the last platform app window, as background pages are kept alive for 15 seconds after their last activity is completed. > > This change re-lands r165772 which caused problems on Google branded ChromeOS. This version does not add keep alives for ChromeOS and was tested on the ChromeOS try bots. > > TBR=davemoore@chromium.org for the ash launcher test change. > > BUG=155457 > TEST=Make sure platform apps can be used from the launcher without chrome windows open; make sure Chrome shuts down properly in all cases. > > > Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=165772 > > Review URL: https://chromiumcodereview.appspot.com/11117011 TBR=benwells@chromium.org Review URL: https://codereview.chromium.org/11299326 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@170891 0039d316-1c4b-4281-b951-d872f2087c98
* Keep browser process alive while there are platform apps with background ↵benwells@chromium.org2012-12-011-0/+7
| | | | | | | | | | | | | | | | | | | | | | pages running. This does not happen on Android or ChromeOS builds: Android does not support browser process keep alive, and ChromeOS does not need or like it. This change prevents platform apps getting killed unceremoniously while they have background pages active. This also delays the process being shutdown after closing the last platform app window, as background pages are kept alive for 15 seconds after their last activity is completed. This change re-lands r165772 which caused problems on Google branded ChromeOS. This version does not add keep alives for ChromeOS and was tested on the ChromeOS try bots. TBR=davemoore@chromium.org for the ash launcher test change. BUG=155457 TEST=Make sure platform apps can be used from the launcher without chrome windows open; make sure Chrome shuts down properly in all cases. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=165772 Review URL: https://chromiumcodereview.appspot.com/11117011 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@170660 0039d316-1c4b-4281-b951-d872f2087c98
* Remove GetExtensionService calls and replace with PKSF calls through the ↵mirandac@chromium.org2012-11-301-2/+4
| | | | | | | | | | | | | ExtensionSystem. Extension services were made into ProfileKeyedServices a while ago; this replaces the deprecated calls that ran directly through the Profile object. This is about half of the total GetExtensionService calls in the codebase, but this CL is already ridiculously large. BUG= http://code.google.com/p/chromium/issues/detail?id=104095 Review URL: https://chromiumcodereview.appspot.com/11365181 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@170497 0039d316-1c4b-4281-b951-d872f2087c98
* Revert r165772: Keep browser process alive while there are platform apps ↵davidjames@google.com2012-11-081-8/+1
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | with background pages running. Change r165772 broke logout on official Chrome OS, such that Chrome crashes every time you log out. This was caught by our bots which immediately started failing every time, starting with r165772. I tested this change on Chrome OS bots and confirmed that the Chrome OS bots were fixed. TBR=benwells@chromium.org BUG=chromium:155457, chromium-os:36058 TEST=Run Chrome and Chrome OS trybots on several architectures. Verify Chrome OS build is reliable now and that all Chrome browser tests still pass. Original CL description: This change prevents platform apps getting killed unceremoniously while they have background pages active. This also delays the process being shutdown after closing the last platform app window, as background pages are kept alive for 15 seconds after their last activity is completed. Review URL: https://codereview.chromium.org/11275209 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@166715 0039d316-1c4b-4281-b951-d872f2087c98
* Keep browser process alive while there are platform apps with background ↵benwells@chromium.org2012-11-021-1/+8
| | | | | | | | | | | | | | | | | | pages running. This change prevents platform apps getting killed unceremoniously while they have background pages active. This also delays the process being shutdown after closing the last platform app window, as background pages are kept alive for 15 seconds after their last activity is completed. TBR=davemoore@chromium.org for the ash launcher test change. BUG=155457 TEST=Make sure platform apps can be used from the launcher without chrome windows open; make sure Chrome shuts down properly in all cases. Review URL: https://chromiumcodereview.appspot.com/11117011 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@165772 0039d316-1c4b-4281-b951-d872f2087c98
* PlatformAppApiTest class should not enable experimental APIs by defaultasargent@chromium.org2012-10-151-15/+0
| | | | | | | | | | | | | Now that some of our APIs are out of experimental, the ones still in experimental should append the command line individually in their tests as needed. BUG=155430 Review URL: https://chromiumcodereview.appspot.com/11145006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@162004 0039d316-1c4b-4281-b951-d872f2087c98
* WebSocket test server migration on ExtensionApiTest.WebSocket (fourth trial)toyoshim@chromium.org2012-10-131-5/+11
| | | | | | | | | | | | | | | | | | | | | | WebSocket test server migration from content::TestWebSocketServer to net::TestServer. This is the first change to use net::TestServer as a WebSocket test server. Other changes will follow to obsoelte content::TestWebSocketServer. BUG=137639 TEST=browser_tests --gtest_filter='ExtensionApiTest.WebSocket' Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=161304 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=161542 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=161572 Review URL: https://chromiumcodereview.appspot.com/11087027 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@161773 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 161572 - WebSocket test server migration on ↵mrossetti@chromium.org2012-10-121-10/+5
| | | | | | | | | | | | | | | | | | | | | | | | | ExtensionApiTest.WebSocket (third trial) WebSocket test server migration from content::TestWebSocketServer to net::TestServer. This is the first change to use net::TestServer as a WebSocket test server. Other changes will follow to obsoelte content::TestWebSocketServer. BUG=137639 TEST=browser_test --gtest_filter='ExtensionApiTest.WebSocket' Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=161304 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=161542 Review URL: https://chromiumcodereview.appspot.com/11087027 TBR=toyoshim@chromium.org Review URL: https://codereview.chromium.org/11115011 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@161575 0039d316-1c4b-4281-b951-d872f2087c98
* WebSocket test server migration on ExtensionApiTest.WebSocket (third trial)toyoshim@chromium.org2012-10-121-5/+10
| | | | | | | | | | | | | | | | | | | | WebSocket test server migration from content::TestWebSocketServer to net::TestServer. This is the first change to use net::TestServer as a WebSocket test server. Other changes will follow to obsoelte content::TestWebSocketServer. BUG=137639 TEST=browser_test --gtest_filter='ExtensionApiTest.WebSocket' Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=161304 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=161542 Review URL: https://chromiumcodereview.appspot.com/11087027 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@161572 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 161542 - WebSocket test server migration on ↵kochi@chromium.org2012-10-121-10/+5
| | | | | | | | | | | | | | | | | | | | | | | ExtensionApiTest.WebSocket (retry) WebSocket test server migration from content::TestWebSocketServer to net::TestServer. This is the first change to use net::TestServer as a WebSocket test server. Other changes will follow to obsoelte content::TestWebSocketServer. BUG=137639 TEST=browser_test --gtest_filter='ExtensionApiTest.WebSocket' Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=161304 Review URL: https://chromiumcodereview.appspot.com/11087027 TBR=toyoshim@chromium.org Review URL: https://codereview.chromium.org/11114015 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@161549 0039d316-1c4b-4281-b951-d872f2087c98
* WebSocket test server migration on ExtensionApiTest.WebSocket (retry)toyoshim@chromium.org2012-10-121-5/+10
| | | | | | | | | | | | | | | | | | WebSocket test server migration from content::TestWebSocketServer to net::TestServer. This is the first change to use net::TestServer as a WebSocket test server. Other changes will follow to obsoelte content::TestWebSocketServer. BUG=137639 TEST=browser_test --gtest_filter='ExtensionApiTest.WebSocket' Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=161304 Review URL: https://chromiumcodereview.appspot.com/11087027 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@161542 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 161304 - WebSocket test server migration on ExtensionApiTest.WebSockettoyoshim@chromium.org2012-10-111-10/+5
| | | | | | | | | | | | | | | | | | | WebSocket test server migration from content::TestWebSocketServer to net::TestServer. This is the first change to use net::TestServer as a WebSocket test server. Other changes will follow to obsoelte content::TestWebSocketServer. BUG=137639 TEST=browser_test --gtest_filter='ExtensionApiTest.WebSocket' Review URL: https://chromiumcodereview.appspot.com/11087027 TBR=toyoshim@chromium.org Review URL: https://codereview.chromium.org/11091059 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@161308 0039d316-1c4b-4281-b951-d872f2087c98
* WebSocket test server migration on ExtensionApiTest.WebSockettoyoshim@chromium.org2012-10-111-5/+10
| | | | | | | | | | | | | | | | WebSocket test server migration from content::TestWebSocketServer to net::TestServer. This is the first change to use net::TestServer as a WebSocket test server. Other changes will follow to obsoelte content::TestWebSocketServer. BUG=137639 TEST=browser_test --gtest_filter='ExtensionApiTest.WebSocket' Review URL: https://chromiumcodereview.appspot.com/11087027 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@161304 0039d316-1c4b-4281-b951-d872f2087c98
* Disallow packing or loading unpacked manifest v1 extensions.aa@chromium.org2012-09-021-1/+13
| | | | | | | | | BUG=132718 Review URL: https://chromiumcodereview.appspot.com/10912041 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@154637 0039d316-1c4b-4281-b951-d872f2087c98
generated by cgit v1.1 at 2025-03-23 16:10:33 +0000