| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
|
|
|
| |
GetWebContents() instead.
BUG=98716
TBR=joi
Review URL: http://codereview.chromium.org/8986009
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@116086 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
switching taskbar to/from auto-hide as well as changes to screen resolution.
- Factored out the part of code that listens to X property changes from
ActiveWindowWatcherX into a separate class.
- Implemented a watcher for work area changes.
- Add hook-up for PanelManager to respond to the changes.
- This change also handles user switching between auto-hide vs non auto-hide mode of taskbar.
TEST=Manual. Create panels. Switch to auto-hide and see them move them move.
BUG=102719
Review URL: http://codereview.chromium.org/8595003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@111171 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=104039
R=ben@chromium.org
Review URL: http://codereview.chromium.org/8566052
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@110787 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Rename FocusChangeListener interface to OnWillChangeFocus and OnDidChangeFocus
Move location bar focus interaction from AccessibilityPaneView to ToolBarView.
BUG=101940
TEST=None
Review URL: http://codereview.chromium.org/8416058
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@109482 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
content/public/browser.
This patch got way bigger than I wanted, but once I moved NotificationDetails, I figured I might as well mvoe the others since they're in the same files. In hindsight, I should have converted a subset of files at a time by leaving a using statement in the header.
BUG=98716
TBR=joi
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@106196 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This adds support for handling multiple tabs, including selecting, removing and moving many tabs at once. (Selecting is now called highlighting for backwards compatibility). The changes are outlined below.
Adds:
- 'highlighted' property to Tab, chrome.tabs.update
- chrome.tabs.query for searching across tabs
- chrome.tabs.highlight for selecting multiple tabs
- chrome.tabs.onHighlightChanged for listening to multi-select events
Modifies:
- renames 'selected' to 'active' on Tab, chrome.tabs.create, chrome.tabs.update
- renames onSelectionChanged to onActiveChanged
- chrome.tabs.move to accept an array of tabs or a single tab
- chrome.tabs.remove to accept an array of tabs or a single tab
- deprecates chrome.tabs.getSelected in favor of chrome.tabs.query
- deprecates chrome.tabs.getAllInWindow in favor of chrome.tabs.query
BUG=81411
TEST=ExtensionApiTest.*Tab*
Review URL: http://codereview.chromium.org/7731004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@103084 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
This moves WidgetFocusManager into its source/header files avoiding the use of nested classes.
R=sky@chromium.org
Review URL: http://codereview.chromium.org/7885001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@101002 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
R=aa@chromium.org
Review URL: http://codereview.chromium.org/7806009
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@99070 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
chrome_notification_types.h.
This file lives in chrome\common. The chrome specific notifications start from NOTIFICATION_CONTENT_END
which defines the end of the enum used by content to define notification types. The notificaton_type.h file
in content\common has been renamed to content_notification_types.h
BUG=76698
Review URL: http://codereview.chromium.org/7327007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@91972 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Multi-profile: treat windows from other profiles as WINDOW_ID_NONE.
Incognito: on switching between default/OTR profile windows, send WINDOW_ID_NONE to the extensions that can't see the new window.
Also make ExtensionBrowserEventRouter listen only to events from browsers and tabs for its profile, except for window focus events.
BUG=46610, 57186, 86001
TEST=Manually tested extensions in spanning and split mode.
Review URL: http://codereview.chromium.org/7187015
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@90143 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
tabs.onCreated callback result has the correct active ("selected" in the API) state.
BUG=59194
TEST=in ExtensionApiTest.TabEvents, reenabled tabsOnCreated
Review URL: http://codereview.chromium.org/7134035
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@88703 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
There is one ExtensionBrowserEventRouter per profile, yet each listens for browser events from all profiles. This patch fixes the event duplication by updating ExtensionBrowserEventRouter to drop events when they originate from other profiles.
BUG=80559
TEST= See bug.
Review URL: http://codereview.chromium.org/7084003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@87180 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Make sure user-declared virtual destructors always have the virtual keyword.
The Clang style-check plugin will check for this soon.
No functionality change: virtual is only added
to destructors that are already implicitly virtual.
Also fix a couple of in-line destructor definitions.
BUG=83408
TEST=none
Review URL: http://codereview.chromium.org/7064033
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@86587 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
ActiveTabChanged
This is done in preparation for multi-tab selection in Linux (http://codereview.chromium.org/6933037/). There was a TODO for that in tab_strip_model_observer.h:75
BUG=NONE
TEST=Tab behavior should be unaffected on all platforms
Review URL: http://codereview.chromium.org/7043020
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@86502 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
1/3.
BUG=None
TEST=None
R=avi@chromium.org
Review URL: http://codereview.chromium.org/6689029
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@80632 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
First part of the remaining files.
BUG=None
TEST=None
Review URL: http://codereview.chromium.org/6649001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@77330 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
TBR=brettw
Review URL: http://codereview.chromium.org/6257006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71970 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Before this change, it's a Singleton that gets passed a pointer to a Profile
during Init(), and holds onto that pointer even after the Profile gets
destroyed. With this change, it's owned by ExtensionService and is destroyed
when the profile is being destructed.
BUG=67927
TEST=On linux, run 'browser_tests --gtest_filter=ExtensionApiTest.BookmarkManager --gtest_repeat=100 --gtest_break_on_failure'. Before this CL, you'll occasionally get a failure because of the race condition described above.
Review URL: http://codereview.chromium.org/6125003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71526 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
otherwise causes subtle problems with extensions and breaks the
invariant that the tab id is unique.
BUG=68508
TEST=none
Review URL: http://codereview.chromium.org/6155003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71063 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=compiles
Review URL: http://codereview.chromium.org/5648004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@68606 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
Code by pinkerton@, with modifications by evanm and myself to get it to build on windows/linux/chromeos.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/4694008
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@66626 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Fire tabs.onUpdated event if a tab's pinned state changes.
BUG=24781
TEST=ExtensionApiTest
Review URL: http://codereview.chromium.org/3816005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@65379 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
(Only 424k off Linux debug .a files).
BUG=none
TEST=compiles
Review URL: http://codereview.chromium.org/3859003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@63059 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
This adds a removeInfo object to the chrome.tabs.onRemoved callback that indicates if the tab's window is also closing.
BUG=56592
TEST=ExtensionApiTest
Review URL: http://codereview.chromium.org/3692004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@62755 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
when an incognito window is closed.
This also avoids crash described in
http://code.google.com/p/chromium/issues/detail?id=56722#c12
We need to remove the half-destroyed Browser from BrowserList
before we start iterating over BrowserList when updating
the application icon.
BUG=48391
TEST=see bug
Review URL: http://codereview.chromium.org/3719004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@62377 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Also get rid of the type enum passed to TabReplacedAt since it can only be one option after phantom tabs are removed.
BUG=none
TEST=compile? good. pass tests? good.
Review URL: http://codereview.chromium.org/3539010
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@61303 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/3425009
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@59733 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/3305025
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@58977 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=50273
TEST=everything still builds, build is 10% faster on windows, same speed on mac/linux
TBR: erg
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@53716 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
focus.
Note that this patch includes support for Views (Windows/chromeos) and GTK (Linux). I was going to do mac as well, but decided my objective-c skillz were too rusty.
BUG=32932
TEST=none
Review URL: http://codereview.chromium.org/2778001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@49884 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
same windowId.
For some reason (on windows, at least) BrowserList::SetLastActive seems to get called for every click in the content area of a window.
This ensures that ExtensionBrowserEventRouter only fires once when the focus changes.
BUG=39882
TEST=none
Review URL: http://codereview.chromium.org/2076013
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@47970 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This CL addresses a few issues related to the behavior of the onUpdated event.
Issue 1: The page re-entering the load state and the completing was causing multiple 'complete' status events to be fired. We now only report the first 'complete' after the didNavigate message is fired (iframe navigation, for example).
Issue 2: We were initializing the URL when the TabEntry was created, and this caused us to fail to send the url with the first navigation because we thought it wasn't changing.
BUG=27208,37149
Review URL: http://codereview.chromium.org/2111010
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@47717 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
places where I left them using the variable with pinned when it should
be app because those places need to be radically whacked. I'll do that
next.
BUG=32845
TEST=none yet
Review URL: http://codereview.chromium.org/555173
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@37880 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
it is closed, and effectively unloads the renderer and replaces it
with a new TabContents that loads when selected. A phantom tab is
currently rendered without a border. Phantom tabs do not prevent a
window from closing.
Long term only pinned app tabs will have the ability to be made
phantom, but this allows us to test the feature until app support is
all wired in.
BUG=32845
TEST=none yet
Review URL: http://codereview.chromium.org/553008
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@36815 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
This makes us fire both the old deprecated style of pageActions click handler and the new pageAction style.
BUG=25833
TEST=none
Review URL: http://codereview.chromium.org/346006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30499 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
This should cut down on the number of occurrences of a crash that happens in JSON serialization.
BUG=25558,26169
Review URL: http://codereview.chromium.org/341029
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30444 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
need to resolve with Glen/Nicholas how to handle the windows side.
BUG=25308
TEST=none
Review URL: http://codereview.chromium.org/314010
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29903 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=23879
TEST=Install sample gmail browser action sample.
Review URL: http://codereview.chromium.org/264046
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29068 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Browser Actions are like Page Actions, except they appear next to the Omnibox and are always visible. For details see http://code.google.com/p/chromium/wiki/BrowserActions.
Added a simple browser action sample that adds a Print button to the chrome toolbar (which brings up the Print dialog for the current page).
Removed |type| from PageActions, which is currently ignored and was already removed from the docs.
Each extension can only have 1 browser_action. Each browser action can specify more than one icon, but only the first is used. And no API has been added yet (besides the event definition).
BUG=22099
TEST=Install the sample browser action, navigate to google.com, press the print button. A print dialog should come up.
Review URL: http://codereview.chromium.org/243001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27319 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
sends full window
BUG=NONE
Review URL: http://codereview.chromium.org/195030
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26771 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
action docs.
Review URL: http://codereview.chromium.org/194082
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26006 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
CID=4459,4563,4564,4566,4567,4569,4570,4571,4803
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/159342
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21540 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
only change is a fix for the UI test that broke and a small change to
event_bindings.cc (reviewed in-person).
ExtensionFunctionDispatcher now notifies ExtensionProcessManager of
renderviews created, which in turn notifies the renderer of page
actions that it knows about.
Remove generic event "page-action-executed" in favor of page action
specific event (sent as extension_id/page_action_id).
In the bindings, we now setup events for each page action we know about
so we can register for specific events, and not receive broadcast events
from all page actions. To setup these events I added a
GetCurrentPageActions() to extension_process_bindings.cc and a helper
function GetCurrentExtensionId().
And, finally, I simplified the page action background page by removing
the check to see if we are already subscribed to the feed (since we now
support multiple feed readers, it doesn't make sense anymore to always
check Google Reader). This check might make a comeback later in a
different form.
TBR=mpcomplete
BUG=13936
TEST=The RSS sample extension should work as before.
Review URL: http://codereview.chromium.org/149683
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20782 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
Rietveld showed all green try bots, but looks like one ui test is failing
Review URL: http://codereview.chromium.org/149668
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20715 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
renderer of page actions that it knows about.
Remove generic event "page-action-executed" in favor of page action specific event (sent as extension_id/page_action_id).
In the bindings, we now setup events for each page action we know about so we can register for specific events, and not receive broadcast events from all page actions. To setup these events I added a GetCurrentPageActions() to extension_process_bindings.cc and a helper function GetCurrentExtensionId().
And, finally, I simplified the page action background page by removing the check to see if we are already subscribed to the feed (since we now support multiple feed readers, it doesn't make sense anymore to always check Google Reader). This check might make a comeback later in a different form.
BUG=13936
TEST=The RSS sample extension should work as before.
Review URL: http://codereview.chromium.org/155514
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20714 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=16634
TEST=none
Review URL: http://codereview.chromium.org/155441
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20581 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
In my scan of headers I got up to browser/gtk/
Review URL: http://codereview.chromium.org/126131
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18500 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
To do this, I needed to add a new TabStripModelObserver call that fired before the tab had been changed, since when the Omnibox asks for the current permanent_text_ it gets it from the selected tab's navigation controller.
BUG=6850
Review URL: http://codereview.chromium.org/113983
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17241 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
BUG=2381
Review URL: http://codereview.chromium.org/113717
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16665 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
navigating to a new url. If a reload is in progress, 'loading' will not be accompanied by 'url'.
Also, refactored some code so that string constants are defined and shared.
BUG=11200
R=erikkay
Review URL: http://codereview.chromium.org/113552
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16467 0039d316-1c4b-4281-b951-d872f2087c98
|