summaryrefslogtreecommitdiffstats
path: root/chrome/browser/extensions/extension_creator.cc
Commit message (Collapse)AuthorAgeFilesLines
* Improve extension packaging by filtering more kinds of files.miket@chromium.org2011-09-071-1/+7
| | | | | | | | | | | | When packaging extensions, ignore files with Windows hidden-file attribute, as well as the special OS X file __MACOSX. These are in addition to the existing dotfile exclusion rule. BUG=27840 TEST=added chrome/browser/extensions/extension_creator_filter_unittest.cc Review URL: http://codereview.chromium.org/7839010 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@100039 0039d316-1c4b-4281-b951-d872f2087c98
* Fix a crash in the Extension Creator when crx is in use.finnur@chromium.org2011-08-161-0/+4
| | | | | | | | BUG=92537 TEST=Create a .crx file from within Chrome, open it up with 7-zip and edit one of the files within (to lock the crx file), then try recreating the crx file -- an error should appear (and no crash). Review URL: http://codereview.chromium.org/7618044 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@96937 0039d316-1c4b-4281-b951-d872f2087c98
* Move scoped_temp_dir and scoped_native_library back from base/memory to base.thakis@chromium.org2011-05-191-4/+4
| | | | | | | | | | | It looks like they got moved accidentally in http://codereview.chromium.org/6714032 BUG=none TEST=none Review URL: http://codereview.chromium.org/7048007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@86010 0039d316-1c4b-4281-b951-d872f2087c98
* Move crypto files out of base, to a top level directory.rvargas@google.com2011-04-141-12/+12
| | | | | | | | | | | | | src/crypto is now an independent project that contains our cryptographic primitives (except md5 and sha1). This removes the base dependency from nss, openssl and sqlite. BUG=76996 TEST=none Review URL: http://codereview.chromium.org/6805019 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@81611 0039d316-1c4b-4281-b951-d872f2087c98
* Replace bools in extension creation with flags.mihaip@chromium.org2011-03-291-2/+1
| | | | | | | | | | | | | | Turn require_key and strict_error_checks bool params of Extension:: InitFromValue, Extension::Create and extension_file_util::LoadExtension into a flags parameter. BUG=None TEST=compiles R=aa@chromium.org Review URL: http://codereview.chromium.org/6766002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@79638 0039d316-1c4b-4281-b951-d872f2087c98
* Move some files from base to base/memory.levin@chromium.org2011-03-281-3/+3
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | raw_scoped_refptr_mismatch_checker.h ref_counted.cc ref_counted.h ref_counted_memory.cc ref_counted_memory.h ref_counted_unittest.cc scoped_callback_factory.h scoped_comptr_win.h scoped_handle.h scoped_native_library.cc scoped_native_library.h scoped_native_library_unittest.cc scoped_nsobject.h scoped_open_process.h scoped_ptr.h scoped_ptr_unittest.cc scoped_temp_dir.cc scoped_temp_dir.h scoped_temp_dir_unittest.cc scoped_vector.h singleton.h singleton_objc.h singleton_unittest.cc linked_ptr.h linked_ptr_unittest.cc weak_ptr.cc weak_ptr.h weak_ptr_unittest.cc BUG=None TEST=Compile Review URL: http://codereview.chromium.org/6714032 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@79524 0039d316-1c4b-4281-b951-d872f2087c98
* Path to extension directory to be packed must be absolute.skerner@chromium.org2011-03-111-1/+8
| | | | | | | | | BUG=73263 TEST=chrome --pack-extension=<rel path> doesn't crash. Review URL: http://codereview.chromium.org/6658043 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@77815 0039d316-1c4b-4281-b951-d872f2087c98
* Give a helpful warning message if a url patern contains a port.skerner@chromium.org2011-03-041-0/+1
| | | | | | | | | BUG=32160 TEST=ExtensionURLPatternTest.Ports,ExtensionManifestTest.* Review URL: http://codereview.chromium.org/2835034 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@76967 0039d316-1c4b-4281-b951-d872f2087c98
* Move l10n_util to ui/baseben@chromium.org2011-01-211-1/+1
| | | | | | | | | BUG=none TEST=none TBR=brettw git-svn-id: svn://svn.chromium.org/chrome/trunk/src@72227 0039d316-1c4b-4281-b951-d872f2087c98
* Unrevert again r63919: "Part 2 of immutable Extension refactor."mpcomplete@chromium.org2010-10-271-1/+1
| | | | | | | | | | | | | | | | | | | | | | | | | | (Last landing broke chromeos and chromium linux builder.) I made Extension a refcounted object, and privitized the existing con/destructor and InitFromValue. The only way to get an Extension is to call a factory method. In the next CL, I plan to make the factory method return a const Extension, to guarantee that no one can modify the Extension object after creation. Note: There was a tricky part of this CL because of the difference in semantics between scoped_ptr and scoped_refptr. I had to be careful not to use ptr.release(), since that would result in leaks (an un-Released AddRef). BUG=56558 TEST=no functional change Original Review URL: http://codereview.chromium.org/3982001 TBR=aa Review URL: http://codereview.chromium.org/4119010 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@64139 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 63962 (broke chromeos and chromium linux builder) - Unrevert r63919: ↵thakis@chromium.org2010-10-261-1/+1
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | "Part 2 of immutable Extension refactor." I made Extension a refcounted object, and privitized the existing con/destructor and InitFromValue. The only way to get an Extension is to call a factory method. In the next CL, I plan to make the factory method return a const Extension, to guarantee that no one can modify the Extension object after creation. Note: There was a tricky part of this CL because of the difference in semantics between scoped_ptr and scoped_refptr. I had to be careful not to use ptr.release(), since that would result in leaks (an un-Released AddRef). BUG=56558 TEST=no functional change Original Review URL: http://codereview.chromium.org/3982001 TBR=aa Review URL: http://codereview.chromium.org/4186002 TBR=mpcomplete@chromium.org Review URL: http://codereview.chromium.org/4130004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@63976 0039d316-1c4b-4281-b951-d872f2087c98
* Unrevert r63919: "Part 2 of immutable Extension refactor."mpcomplete@chromium.org2010-10-261-1/+1
| | | | | | | | | | | | | | | | | | | | | | | | I made Extension a refcounted object, and privitized the existing con/destructor and InitFromValue. The only way to get an Extension is to call a factory method. In the next CL, I plan to make the factory method return a const Extension, to guarantee that no one can modify the Extension object after creation. Note: There was a tricky part of this CL because of the difference in semantics between scoped_ptr and scoped_refptr. I had to be careful not to use ptr.release(), since that would result in leaks (an un-Released AddRef). BUG=56558 TEST=no functional change Original Review URL: http://codereview.chromium.org/3982001 TBR=aa Review URL: http://codereview.chromium.org/4186002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@63962 0039d316-1c4b-4281-b951-d872f2087c98
* Revert r63919 "Part 2 of immutable Extension refactor."mpcomplete@chromium.org2010-10-261-1/+1
| | | | | | | | | | | | Compile failure on Linux x64. BUG=56558 TEST=no functional change TBR=aa Review URL: http://codereview.chromium.org/4156002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@63925 0039d316-1c4b-4281-b951-d872f2087c98
* Part 2 of immutable Extension refactor.mpcomplete@chromium.org2010-10-261-1/+1
| | | | | | | | | | | | | | | | | | | | I made Extension a refcounted object, and privitized the existing con/destructor and InitFromValue. The only way to get an Extension is to call a factory method. In the next CL, I plan to make the factory method return a const Extension, to guarantee that no one can modify the Extension object after creation. Note: There was a tricky part of this CL because of the difference in semantics between scoped_ptr and scoped_refptr. I had to be careful not to use ptr.release(), since that would result in leaks (an un-Released AddRef). BUG=56558 TEST=no functional change Review URL: http://codereview.chromium.org/3982001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@63919 0039d316-1c4b-4281-b951-d872f2087c98
* Move the rest of the Extension data into either StaticData or RuntimeDatampcomplete@chromium.org2010-10-181-0/+1
| | | | | | | | | | | | | | subclasses. The ultimate goal is to move StaticData back up to the top level, so that Extension itself will be a thread-safe immutable object. I plan on making Extension refcounted, and const everywhere that it doesn't need to be initialized. RuntimeData will be the only thing mutable, and then only on the UI thread. BUG=56550 TEST=extensions still work Review URL: http://codereview.chromium.org/3757001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@62957 0039d316-1c4b-4281-b951-d872f2087c98
* Return NULL instead of false when appropriate.evan@chromium.org2010-06-101-3/+3
| | | | | | | | (Found by clang.) Review URL: http://codereview.chromium.org/2725010 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@49466 0039d316-1c4b-4281-b951-d872f2087c98
* extensions: Internationalize error code messages.aa@chromium.org2010-03-121-15/+30
| | | | | | | | | | BUG=23086 TEST=see bug Review URL: http://codereview.chromium.org/682001 Patch from Thiago Farina <thiago.farina@gmail.com>. git-svn-id: svn://svn.chromium.org/chrome/trunk/src@41380 0039d316-1c4b-4281-b951-d872f2087c98
* Further reduce the bad dependency of chrome/common on chrome/browser.phajdan.jr@chromium.org2010-02-241-1/+1
| | | | | | | | TEST=none BUG=none Review URL: http://codereview.chromium.org/656011 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@39877 0039d316-1c4b-4281-b951-d872f2087c98
* Move base64 from 'net/base' into 'base'.hayato@chromium.org2009-11-241-1/+0
| | | | | | | | | BUG=13572 TEST=none Review URL: http://codereview.chromium.org/399068 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32918 0039d316-1c4b-4281-b951-d872f2087c98
* Add validation to extension packaging.aa@chromium.org2009-11-171-0/+10
| | | | | | | | BUG=27685,27690 Review URL: http://codereview.chromium.org/398001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32163 0039d316-1c4b-4281-b951-d872f2087c98
* Delete the temp dir created by CreateZip.thestig@chromium.org2009-11-031-3/+8
| | | | | | | | BUG=none TEST=none Review URL: http://codereview.chromium.org/341074 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30841 0039d316-1c4b-4281-b951-d872f2087c98
* Filter out hidden files, both when loading extensions and whenaa@chromium.org2009-10-281-1/+1
| | | | | | | | | | | | | packaging them. We also special case the common OS X zip dropping "__MACOSX" when loading extensions. BUG=23004 Review URL: http://codereview.chromium.org/340018 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30312 0039d316-1c4b-4281-b951-d872f2087c98
* linux: fix compile errors in extension_creatorevan@chromium.org2009-10-191-9/+18
| | | | | | | | | | | | New code added more fwrite calls where the return code isn't handled, causing compile errors on Fedora and other platforms. While we're at it, use the new PLOG interface. BUG=24347 Review URL: http://codereview.chromium.org/300007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29421 0039d316-1c4b-4281-b951-d872f2087c98
* Use heap memory intead of stack memory to avoid having toaa@chromium.org2009-09-221-6/+8
| | | | | | | | | | | grow the stack. BUG=12968 TEST=none Review URL: http://codereview.chromium.org/215042 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26781 0039d316-1c4b-4281-b951-d872f2087c98
* Adds a button to chrome://extensions/ that allows easy packingaa@chromium.org2009-08-311-2/+2
| | | | | | | | | | | of extensions into crx files. BUG=20578 TEST=Create a sample extension, pack it, then try to install it. Review URL: http://codereview.chromium.org/181020 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@24877 0039d316-1c4b-4281-b951-d872f2087c98
* Pull a SandboxedExtensionUnpacker out of ExtensionsService.aa@chromium.org2009-07-281-6/+6
| | | | | | Review URL: http://codereview.chromium.org/160145 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21770 0039d316-1c4b-4281-b951-d872f2087c98
* Remove svn:executable property from some more files that don't need it.thestig@chromium.org2009-07-101-0/+0
| | | | | | | TBR=evmar Review URL: http://codereview.chromium.org/149471 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20406 0039d316-1c4b-4281-b951-d872f2087c98
* Verify signed .crx extension installationsrafaelw@chromium.org2009-06-121-7/+6
| | | | | | | | | | | | | | | This is second try of: http://codereview.chromium.org/115682 that was comitted in in 18189 and reverted. BUG=12114 R=erikkay,wtc,aa Review URL: http://codereview.chromium.org/126014 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18316 0039d316-1c4b-4281-b951-d872f2087c98
* Revert "BUG=12114"tc@google.com2009-06-111-6/+7
| | | | | | | | | | | This reverts commit r18189. TBR=rafaelw Review URL: http://codereview.chromium.org/125004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18193 0039d316-1c4b-4281-b951-d872f2087c98
* BUG=12114rafaelw@chromium.org2009-06-111-7/+6
| | | | | | | | R=erikkay,wtc Review URL: http://codereview.chromium.org/115682 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18189 0039d316-1c4b-4281-b951-d872f2087c98
* Fix UMR in ExtensionCreator.aa@chromium.org2009-06-101-2/+3
| | | | | | Review URL: http://codereview.chromium.org/119443 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18101 0039d316-1c4b-4281-b951-d872f2087c98
* Remove the prepended manifest from the crx format. Now we just have the ↵aa@chromium.org2009-06-101-97/+47
| | | | | | | | header, the public key, the signature, and the zip. Review URL: http://codereview.chromium.org/118490 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18088 0039d316-1c4b-4281-b951-d872f2087c98
* chrome.exe --package-extension generates .crx from extension directoryrafaelw@chromium.org2009-06-091-0/+275
R=aa BUG=12114 Review URL: http://codereview.chromium.org/118328 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17927 0039d316-1c4b-4281-b951-d872f2087c98