summaryrefslogtreecommitdiffstats
path: root/chrome/browser/extensions/extension_host.h
Commit message (Collapse)AuthorAgeFilesLines
* linux: theme scrollbars from GTK theme estade@chromium.org2009-12-091-1/+1
| | | | | | | | | | | | | | | | Pick the color of the slider's thumbpart and rail from the GTK theme. We cannot match the exact visual appearance of the GTK theme, as rendering engines can make arbitrary changes to the actual visual appearance. But by sampling a representative set of pixels, we ensure that we will at least match the general color scheme. BUG=10949 patch by <markus [at] chromium> original review: http://codereview.chromium.org/400027/show Review URL: http://codereview.chromium.org/466080 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@34183 0039d316-1c4b-4281-b951-d872f2087c98
* Fixes issue where clicking on a <SELECT> dropdown in an extension popup ↵andybons@chromium.org2009-12-091-0/+14
| | | | | | | | | | | | | window would hard crash the browser. I'm hoping that this will open up discussions for refactoring work amongst ExtensionHost and TabContentsView, since so much code is shared between the two and both need sufficient Mac love. BUG=29353 TEST=load a browser action with a popup that contains a SELECT element. click on the element and observe that it acts normally (no crashing). Review URL: http://codereview.chromium.org/465108 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@34136 0039d316-1c4b-4281-b951-d872f2087c98
* Make the default RendererPreferences smarter.estade@chromium.org2009-12-041-0/+1
| | | | | | | | | | | Change the default RenderViewHostDelegate::GetRendererPrefs to a singleton because initialization may not always be cheap (we assume copying is, however). BUG=29043 TEST=if you focus a link in an extension popup, you can actually see the focus ring (the focus ring had been set to 0x000000 color) Review URL: http://codereview.chromium.org/458013 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@33775 0039d316-1c4b-4281-b951-d872f2087c98
* Fix crash when an extension popup shows a JS alert. Showing the alert takes...rafaelw@chromium.org2009-11-241-0/+1
| | | | | | | | | | | | | | | | Landing this on for pam. Original issue: http://codereview.chromium.org/425011/show. Disable showing JS alerts from popups, because doing so makes the popup disappear immediately, which has all sorts of unfortunate side effects for the poor orphaned alert (see bug for details). BUG=27758 TEST=create extension with popup, put link with |onclick="alert('test');"| in it; install extension, open popup, and click link; see no crash (nor popup) Review URL: http://codereview.chromium.org/435010 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32889 0039d316-1c4b-4281-b951-d872f2087c98
* Undo my revert at r32524 due to a startup test regression.mpcomplete@chromium.org2009-11-201-4/+11
| | | | | | | | | | | | ExtensionHosts once again spawn extension processes asynchronously. However, if the process is already started, we now initialize the RenderView synchronously. This is so bug 28049 stays fixed. BUG=28049 Review URL: http://codereview.chromium.org/402101 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32578 0039d316-1c4b-4281-b951-d872f2087c98
* Revert old change that created an ExtensionHost's RenderView asynchronously.mpcomplete@chromium.org2009-11-191-11/+4
| | | | | | | | | | | | | With jam's recent change to spawn renderers from a background thread, ExtensionHost spawns processes asynchronously for free. Reverting this change also fixes a bug due to an extension popup closing before the next one can be created. BUG=28049 Review URL: http://codereview.chromium.org/399098 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32524 0039d316-1c4b-4281-b951-d872f2087c98
* Refactoring of the chrome.experimental.popup API implementation to allow ↵twiz@google.com2009-11-161-38/+5
| | | | | | | | | | | | | | | | display of pop-ups for extensions viewed through a tab-contents view.I added a new class, ExtensionPopupHost. This class implements the necessary environment for managing child popup windows from either an ExtensionHost, or an ExtensionDOMUI. Note that this class is added as a member to ExtensionHost and ExtensionDOMUI. I decided to take this approach to prevent multiple inheritance of the NotificationObserver class: Both ExtensionPopupHost and ExtensionHost must inherit from this class, and I was uncertain of how the system would behave wrt virtual inheritance. Please comment on if I should have used the inheritance approach. I also removed the customHandler tag (in extension_api.json) that I had added in the initial submission. The arguments in the schema are now those that users of the API see. The nodocs tags were also removed. The api experimental.popup.getAnchorWindow() has been renamed to popup.getParentWindow, as per a suggestion from Erik K. BUG=none TEST=extension_popup_apitest.cc Review URL: http://codereview.chromium.org/385061 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32120 0039d316-1c4b-4281-b951-d872f2087c98
* add some histograms to extensionserikkay@chromium.org2009-11-061-0/+4
| | | | | | | | | TEST=none BUG=none Review URL: http://codereview.chromium.org/372005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31241 0039d316-1c4b-4281-b951-d872f2087c98
* Implement window.alert() and its cousins for extensions.pam@chromium.org2009-11-061-1/+13
| | | | | | | | | | | | Second try, now with fixed observer. BUG=12126 TEST=put a window.prompt() in a background page, a browser action, and a page action. Make sure it gets the result back correctly. Also make sure it still works when called from a web page. Review URL: http://codereview.chromium.org/373006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31204 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 31110 - Implement window.alert() and its cousins for extensions.ben@chromium.org2009-11-051-13/+1
| | | | | | | | | | | | | BUG=12126 TEST=put a window.prompt() in a background page, a browser action, and a page action. Make sure it gets the result back correctly. Also make sure it still works when called from a web page. Review URL: http://codereview.chromium.org/341089 TBR=pam@chromium.org Review URL: http://codereview.chromium.org/360063 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31126 0039d316-1c4b-4281-b951-d872f2087c98
* Implement window.alert() and its cousins for extensions.pam@chromium.org2009-11-051-1/+13
| | | | | | | | | | BUG=12126 TEST=put a window.prompt() in a background page, a browser action, and a page action. Make sure it gets the result back correctly. Also make sure it still works when called from a web page. Review URL: http://codereview.chromium.org/341089 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31110 0039d316-1c4b-4281-b951-d872f2087c98
* Submitting change from http://codereview.chromium.org/276029/showmad@chromium.org2009-11-031-3/+42
| | | | | | | | BUG=none TEST=none git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30778 0039d316-1c4b-4281-b951-d872f2087c98
* Fix conflicts between accelerator keys and HTML DOM accesskeys.suzhe@chromium.org2009-10-231-1/+1
| | | | | | | | | | | | | This CL fixes conflicts between accelerator keys and HTML DOM accesskeys by suppressing Char events if corresponding RawKeyDown event was handled by the browser after returning from the renderer unhandled. This CL not only fixes this conflict issue, but also makes the behavior of handling accelerator keys similar than IE, which also suppresses a key press event if the key down event was handled as an accelerator key. BUG=21624 accesskey attributes conflict with browser shortcuts (like tab-switching) TEST=Open http://djmitche.github.com/buildbot/docs/0.7.11/ in one of opened multiple tabs, switch to another tab by pressing an alt-# key binding, then switch back to the original page to see if it's just as you left it before switching tabs. Review URL: http://codereview.chromium.org/235039 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29857 0039d316-1c4b-4281-b951-d872f2087c98
* Popup width and height are now dynamic.erikkay@chromium.org2009-10-161-1/+1
| | | | | | | | | BUG=24471 TEST=none Review URL: http://codereview.chromium.org/273046 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29274 0039d316-1c4b-4281-b951-d872f2087c98
* Add histogram for how tab closing time. Did some cleanup along the way. ↵jam@chromium.org2009-10-141-1/+1
| | | | | | | | Moved the is_showing_before_unload_dialog_ stuff from RenderViewHost to TabContents since we need that bit there as well. Review URL: http://codereview.chromium.org/274057 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29063 0039d316-1c4b-4281-b951-d872f2087c98
* Modify extension request IPC messages to pass a ListValue instead of a string.mpcomplete@chromium.org2009-10-061-1/+1
| | | | | | | | | | | | This allows us to pass binary values through extension requests. I use this in my next CL to pass SkBitmaps. BUG=23269 TEST=no Review URL: http://codereview.chromium.org/251093 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28130 0039d316-1c4b-4281-b951-d872f2087c98
* Resubmit http://codereview.chromium.org/243096 with gcc compile error fixed.erikkay@chromium.org2009-10-061-0/+1
| | | | | | | | | BUG=23832 TBR=mpcomplete Review URL: http://codereview.chromium.org/257056 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28115 0039d316-1c4b-4281-b951-d872f2087c98
* TBR: mpcompleteerikkay@chromium.org2009-10-051-1/+0
| | | | | | revert previous checkin (compile failure due to bad merge resolution) git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28057 0039d316-1c4b-4281-b951-d872f2087c98
* Allow popups to close themselves with window.close().erikkay@chromium.org2009-10-051-0/+1
| | | | | | | | | | | | This also fixes an issue where not all of the parts of WebPreferences were being serialized/deserialized across IPC. BUG=23832 TEST=run set_page_color extension, when it sets the color, the popup should close Review URL: http://codereview.chromium.org/243096 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28053 0039d316-1c4b-4281-b951-d872f2087c98
* Add simple popup support to browser actions. This will create a popup HTML ↵erikkay@chromium.org2009-10-021-0/+1
| | | | | | | | | | | window that extends below a browser action button when the browser is clicked. When it loses focus, it is automatically dismissed. BUG=23596 TEST=none Review URL: http://codereview.chromium.org/258011 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27889 0039d316-1c4b-4281-b951-d872f2087c98
* Don't send tab switching/killing/creating keyboard accelerators to pages. ↵jam@chromium.org2009-10-021-0/+1
| | | | | | | | | | This avoids tabs maliciously preventing closing using ctrl+f4/ctrl+w/alt+f4, and also hung/slow renderers from making tab cycling sluggish. BUG=5496 TEST=added ui test Review URL: http://codereview.chromium.org/224023 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27814 0039d316-1c4b-4281-b951-d872f2087c98
* Retry r27137. Create renderers for ExtensionHosts one at a time to avoid ↵mpcomplete@chromium.org2009-09-281-4/+11
| | | | | | | | | | | | | | | blocking the UI. I added a process.Close() to the fast shutdown path for renderers. The problem was that we were trying to use an old terminated process handle. BUG=14040 TEST=Install a bunch of extensions with toolstrips, then restart Chrome. The UI should be responsive while the toolstrips are loading. Review URL: http://codereview.chromium.org/243007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27434 0039d316-1c4b-4281-b951-d872f2087c98
* Fix deadlock when plugin puts an alert and right afterwards the browser ↵jam@chromium.org2009-09-281-2/+1
| | | | | | | | | | process makes a win32 call that ends up waiting on the plugin. Since the plugin thread is blocked, the Windows message doesn't get dispatched and the browser ui thread deadlocks. The message from the renderer would make the plugin run a nested message loop but it doesn't get run on the browser ui thread since it's blocked. The fix is to set the event that runs nested message loop in the renderer process. BUG=23147 TEST=ui tests already cover nested message loops and plugins. This particular scenario is hard to write a test case for because it's a race condition involving the browser. Review URL: http://codereview.chromium.org/243018 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27421 0039d316-1c4b-4281-b951-d872f2087c98
* Revert r27137: "Create renderers for ExtensionHosts one at a time to avoidmpcomplete@chromium.org2009-09-241-11/+4
| | | | | | | | | blocking the UI" BUG=14040 TBR=erikkay git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27143 0039d316-1c4b-4281-b951-d872f2087c98
* Create renderers for ExtensionHosts one at a time to avoid blocking the UI.mpcomplete@chromium.org2009-09-241-4/+11
| | | | | | | | | BUG=14040 TEST=Install a bunch of extensions with toolstrips, then restart Chrome. The UI should be responsive while the toolstrips are loading. Review URL: http://codereview.chromium.org/220028 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27137 0039d316-1c4b-4281-b951-d872f2087c98
* Change the view mode when switching between moles and toolstrips, anderikkay@chromium.org2009-09-191-3/+5
| | | | | | | | | | | | | | propogate this into the class of the document element so that it's possible to use CSS rules to control the display of your toolstrip/mole. BUG=21939,15494 TEST=run the Mappy extension and verify it can open and close Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=26635 Review URL: http://codereview.chromium.org/208020 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26654 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 26635 - Change the view mode when switching between moles and ↵mbelshe@google.com2009-09-181-5/+3
| | | | | | | | | | | | | | | | | | toolstrips, and propogate this into the class of the document element so that it's possible to use CSS rules to control the display of your toolstrip/mole. BUG=21939,15494 TEST=run the Mappy extension and verify it can open and close Review URL: http://codereview.chromium.org/208020 TBR=erikkay@chromium.org Review URL: http://codereview.chromium.org/210024 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26636 0039d316-1c4b-4281-b951-d872f2087c98
* Change the view mode when switching between moles and toolstrips, anderikkay@chromium.org2009-09-181-3/+5
| | | | | | | | | | | | propogate this into the class of the document element so that it's possible to use CSS rules to control the display of your toolstrip/mole. BUG=21939,15494 TEST=run the Mappy extension and verify it can open and close Review URL: http://codereview.chromium.org/208020 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26635 0039d316-1c4b-4281-b951-d872f2087c98
* Add a bare-bones extension shelf that displays extension items on OS X.thakis@chromium.org2009-09-161-0/+6
| | | | | | | | | | | | | | | | | | | This brings our extension support to about the level it has on linux. One issue is that the toolstrips are webpages with a background image that just happens to look like the shelf they are on. But the background images are not updated on key->nonkey window changes, so the toolstrip backgrounds look slightly off in one of the two cases. If we decide to keep the shelf, we should fix this, but see the bug for erikkay's stance on this. Also, the NTP is only loaded after all toolstrips have been loaded for some reason. That's what happens on the other platforms too, I believe. The extension shelf uses the DownloadShelfView as background view for now. Screenie: http://imgur.com/wSHgU.png BUG=19073 TEST=Extensions that live in the shelf should show up. They should be clickable, resize correctly (e.g. the build status extension), and the shelf should interact in a sane way with the status bubble. Review URL: http://codereview.chromium.org/175025 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26311 0039d316-1c4b-4281-b951-d872f2087c98
* ExtensionShelf now uses the BookmarkExtensionBackground, just like the ↵finnur@chromium.org2009-09-151-0/+3
| | | | | | | | | | | | | | | | | | | | | | | | | | | BookmarkBarView. Changed the WebKit API to add an optional |id| parameter to the insertStyleText, which is needed to be able to replace style sheets that have been previously added. Added an interface that both BookmarkBarView and ExtensionShelf implement. This new interface tells us whether we are located at the top or at the bottom and whether we are detached from the frame or not. Factored out some of the duplicate painting-related code to a namespace of its own. Not happy with the name (welcome suggestions). Moved the check for whether extensions are on top to new class and now cache the value for the lifetime of the process. Toolstrip text color values are no longer hard-coded but use the color specified in the theme. Decreased the timeouts for showing and hiding the toolstrip handle. Replaced the pressed background image and the hover background image for the toolstrip to match what the bookmark bar uses. Known issues: Some themes expose the fact that: - The background for the extension shelf when in detached mode (and located on the bottom) does not seamlessly blend in with background of new tab page. Still works surprisingly well when it breaks, though. - Didn't spend much time theming the shelf handle (just used the solid color from the theme). - When extension shelf is merged with the bookmark bar, there is a painting artifact (horizontal dotted line) that appears (apparently it was known to appear before this change). BUG=18452, 21272, 21273 TEST=Install a theme for Chrome and make sure everything looks correct and is updated on a theme change. Also make sure painting problems in bugs 21272 and 21273 are fixed. Review URL: http://codereview.chromium.org/204022 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26227 0039d316-1c4b-4281-b951-d872f2087c98
* Revert change 26184, 26181 and 26178 to fixnsylvain@chromium.org2009-09-151-3/+0
| | | | | | | | | | the compile error on the toolkit builder. TBR:finnur Review URL: http://codereview.chromium.org/203064 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26186 0039d316-1c4b-4281-b951-d872f2087c98
* ExtensionShelf now uses the BookmarkExtensionBackground, just like the ↵finnur@chromium.org2009-09-141-0/+3
| | | | | | | | | | | | | | | | | | | | | | | | | BookmarkBarView. Changed the WebKit API to add an optional |id| parameter to the insertStyleText, which is needed to be able to replace style sheets that have been previously added. Added an interface that both BookmarkBarView and ExtensionShelf implement. This new interface tells us whether we are located at the top or at the bottom and whether we are detached from the frame or not. Factored out some of the duplicate painting-related code to a namespace of its own. Not happy with the name (welcome suggestions). Moved the check for whether extensions are on top to new class and now cache the value for the lifetime of the process. Toolstrip text color values are no longer hard-coded but use the color specified in the theme. Decreased the timeouts for showing and hiding the toolstrip handle. Replaced the pressed background image and the hover background image for the toolstrip to match what the bookmark bar uses. Known issues: Some themes expose the fact that: - The background for the extension shelf when in detached mode (and located on the bottom) does not seamlessly blend in with background of new tab page. Still works surprisingly well when it breaks, though. - Didn't spend much time theming the shelf handle (just used the solid color from the theme). BUG=18452, 21272, 21273 TEST=Install a theme for Chrome and make sure everything looks correct and is updated on a theme change. Also make sure painting problems in bugs 21272 and 21273 are fixed. Review URL: http://codereview.chromium.org/203034 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26178 0039d316-1c4b-4281-b951-d872f2087c98
* Plumb the DragOperation through all the layers between the platform ↵snej@chromium.org2009-09-081-2/+3
| | | | | | | | | | | | | Drag-n-drop code and WebCore. This allows the HTML5 DataTransfer effectAllowed and dropEffect properties to be set correctly in JS handlers, as per the HTML5 spec. (The drag-dropeffect test isn't in WebKit yet -- it's part of a separate WebKit patch that's been in review for weeks.) R=darin,pink BUG=http://code.google.com/p/chromium/issues/detail?id=14654, http://code.google.com/p/chromium/issues/detail?id=20985 TEST=LayoutTests/fast/events/drag-dropeffect.html, LayoutTests/editing/pasteboard/files-during-page-drags.html Review URL: http://codereview.chromium.org/174364 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25629 0039d316-1c4b-4281-b951-d872f2087c98
* Fix "crashed extension" infobar browser crashes.phajdan.jr@chromium.org2009-08-251-4/+0
| | | | | | | | | | | | | | | | This is a general rework of how "crashed extension" infobar works and how the extension is actually recovered after the crash. This is a subset of original http://codereview.chromium.org/164151/ . I had to remove the part which unloads the entire extension on crash, because it interacts badly with other parts of the browser. I'm fixing that. TEST=See bug. http://crbug.com/15888 Review URL: http://codereview.chromium.org/173314 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@24231 0039d316-1c4b-4281-b951-d872f2087c98
* Revert "Fix "crashed extension" infobar browser crashes."phajdan.jr@chromium.org2009-08-181-0/+4
| | | | | | | | TBR=cevans Review URL: http://codereview.chromium.org/173014 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23644 0039d316-1c4b-4281-b951-d872f2087c98
* Fix "crashed extension" infobar browser crashes.phajdan.jr@chromium.org2009-08-181-4/+0
| | | | | | | | | | | | This is a general rework of how "crashed extension" infobar works and how the extension is actually recovered after the crash. TEST=See bug. http://crbug.com/15888 Review URL: http://codereview.chromium.org/164151 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23628 0039d316-1c4b-4281-b951-d872f2087c98
* Implementation of getBackgroundPage(), getToolstrips(), andaa@chromium.org2009-08-141-1/+7
| | | | | | | | | | | | | | | getTabContentses(). This lands http://codereview.chromium.org/159067. Raf, the only thing you need to look at is the changes to extensions_process_bindings.js and extension_api.json. BUG=13577 TEST=Browser tests added Review URL: http://codereview.chromium.org/164458 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23422 0039d316-1c4b-4281-b951-d872f2087c98
* Revert "Fix "crashed extension" infobar browser crashes."phajdan.jr@chromium.org2009-08-111-0/+4
| | | | | | | | Will it fix browser_tests crashes on Vista? Review URL: http://codereview.chromium.org/165287 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22998 0039d316-1c4b-4281-b951-d872f2087c98
* Fix "crashed extension" infobar browser crashes.phajdan.jr@chromium.org2009-08-111-4/+0
| | | | | | | | | | | | This is a general rework of how "crashed extension" infobar works and how the extension is actually recovered after the crash. TEST=See bug. http://crbug.com/15888 Review URL: http://codereview.chromium.org/164151 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22985 0039d316-1c4b-4281-b951-d872f2087c98
* mole API - take 2erikkay@chromium.org2009-08-041-0/+1
| | | | | | | | | | originally reviewed / committed as http://codereview.chromium.org/160276 TBR=mpcomplete,phadjan.jr Review URL: http://codereview.chromium.org/159854 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22382 0039d316-1c4b-4281-b951-d872f2087c98
* Delay loading of ExtensionHosts until the background page is ready.mpcomplete@chromium.org2009-08-031-1/+25
| | | | | | | | | BUG=13912 TEST=no Review URL: http://codereview.chromium.org/159756 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22302 0039d316-1c4b-4281-b951-d872f2087c98
* Rolling back change 22245.chrome-bot@google.com2009-08-021-1/+0
| | | | | | | | | | | | Too much red :-( BUG=None TEST=None TBR=erikkay Review URL: http://codereview.chromium.org/159763 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22247 0039d316-1c4b-4281-b951-d872f2087c98
* mole expand/collapse API, callable from a toolstrip for manual operationerikkay@chromium.org2009-08-011-0/+1
| | | | | | Review URL: http://codereview.chromium.org/160276 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22245 0039d316-1c4b-4281-b951-d872f2087c98
* Create render view for extensions on Linux.phajdan.jr@chromium.org2009-07-281-1/+7
| | | | | | | | | | | | | Now when an extension is loaded, you will see its entry in the task manager. However, on the shelf there is still only a placeholder label (I have to work on setting proper size for the render widget). TEST=none http://crbug.com/16759 Review URL: http://codereview.chromium.org/159527 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21908 0039d316-1c4b-4281-b951-d872f2087c98
* add mole info to toolstrip definition and enable moleserikkay@chromium.org2009-07-261-0/+5
| | | | | | Review URL: http://codereview.chromium.org/159202 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21621 0039d316-1c4b-4281-b951-d872f2087c98
* Move some more interfaces on RenderViewHostDelegate to separate classes. Thebrettw@chromium.org2009-07-091-1/+1
| | | | | | | | ones in the patch are those that are implemented by other classes, avoiding TabContents pass-throughs. Review URL: http://codereview.chromium.org/149373 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20324 0039d316-1c4b-4281-b951-d872f2087c98
* Do some refactoring of renderer_host.brettw@chromium.org2009-07-061-11/+10
| | | | | | | | | | | | | | | | | | | This removes the last dependency on tab_contents from the renderer_host code and into the RenderViewHostDelegate. Some of the tests depended on tab_contents, so I moved to a new directory with the tab_contents include allowed via DEPS. Now DEPS can enforce that no additional tab_contents includes are added to renderer_host. RenderViewHost delegate is now pure virtual. After spending a while *again* figuring out why my code didn't work, only to find it was because the default implementation of a function was getting called instead of the real one, I decided to make this pure virtual. It is implemented by TabContents, which implements basically everything, and two other places that implement less. Only two lists of duplicate functions seems not too bad, although long-term it would be nice if this delegate was somehow more succinct. Review URL: http://codereview.chromium.org/155071 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19982 0039d316-1c4b-4281-b951-d872f2087c98
* Add an ExtensionBrowserTest base class that allows in-process browser tests ↵aa@chromium.org2009-07-041-0/+7
| | | | | | | | of extensions using ExtensionsService directly, rather than TestExtensionLoaded. Use it to re-enable some old browser tests that had been disabled. Review URL: http://codereview.chromium.org/150213 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19930 0039d316-1c4b-4281-b951-d872f2087c98
* In this episode, we implement the DOMUI interface for extension views that ↵aa@chromium.org2009-07-011-2/+8
| | | | | | | | | | are rendered in the main tab contents area. This gets us loaded and unloaded at the right place and removes many special cases for extensions from the RenderViewHost and RenderViewHostDelegate hierarchy. BUG=13936 Review URL: http://codereview.chromium.org/126137 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19717 0039d316-1c4b-4281-b951-d872f2087c98
* Change ExtensionHost to use notificationserikkay@chromium.org2009-06-261-3/+3
| | | | | | | | | | | rather than direct communication with ExtensionProcessManager. This simplifies ownership and lifetime issues which allows me to also revert the change that made ExtensionProcessManager owned by ExtensionsService. Review URL: http://codereview.chromium.org/147208 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19370 0039d316-1c4b-4281-b951-d872f2087c98
generated by cgit v1.1 at 2025-03-01 13:32:10 +0000