| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Remove content::URLFetcher.
Update all references.
Add explicit dependency on content_common from browser, since template_url_fetcher.cc calls AssociateURLFetcherWithRenderView
(there are probably other direct uses of content_common).
BUG=118220
TEST=
TBR=satorux@chromium.org,mnissler@chromium.org,mal@chromium.org,jhawkins@chromium.org,sky@chromium.org,rlp@chromium.org
Review URL: https://chromiumcodereview.appspot.com/10554008
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@142926 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
plumbing through the Browser window. In two places (file_manager_util.cc and download_crx_util.cc) there is no context so I left those with FindLastActiveWithProfile for now.
BUG=129187
Review URL: https://chromiumcodereview.appspot.com/10548057
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@142489 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
Extensions.
BUG=131026
TEST=no change
Review URL: https://chromiumcodereview.appspot.com/10535077
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@141590 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=117262
TBR=aa@chromium.org
Review URL: https://chromiumcodereview.appspot.com/10375021
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@138074 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
ExtensionManagementTest.AutoUpdateDisabledExtensions under AddressSanitizer
BUG=103371,120640
TBR=yoz
Review URL: http://codereview.chromium.org/10187024
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@134474 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=120640,103371,94964
TBR=asargent
Review URL: https://chromiumcodereview.appspot.com/10209041
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@134463 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
disabled.
Doesn't delete the CRXes yet since ExtensionManagementApiEscalationTest needs them.
BUG=121436
TEST=browser_tests
TBR=aa@chromium.org
Review URL: https://chromiumcodereview.appspot.com/9960087
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@131678 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Broke linux browser_tests ExtensionManagementApiEscalationTest.DisabledReason,ReEnable
Don't show the permissions upgrade alert for extensions disabled by the user.
For existing disabled extensions, guess the disabling reason from whether they exceed their granted permissions.
BUG=121436
TEST=ExtensionDisabledGlobalErrorTest.*
TBR=csilv@chromium.org,jianli@chromium.org,mark@chromium.org
Review URL: https://chromiumcodereview.appspot.com/10014005
TBR=yoz@chromium.org
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@131676 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Don't show the permissions upgrade alert for extensions disabled by the user.
For existing disabled extensions, guess the disabling reason from whether they exceed their granted permissions.
BUG=121436
TEST=ExtensionDisabledGlobalErrorTest.*
TBR=csilv@chromium.org,jianli@chromium.org,mark@chromium.org
Review URL: https://chromiumcodereview.appspot.com/10014005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@131665 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=120640
TEST=disabled
Review URL: https://chromiumcodereview.appspot.com/9877012
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@129446 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
persistent failures on XP.
BUG=http://crbug.com/120640
TEST=None
TBR=kkania
Review URL: https://chromiumcodereview.appspot.com/9873026
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@129406 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=26834
TEST=ExtensionUpdaterTest.TestNonAutoUpdateableLocations
Review URL: http://codereview.chromium.org/9718028
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@129365 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Turns out the AutoUpdate test failures were unrelated to 127887.
BUG=108202
TBR=aa@chromium.org
Review URL: https://chromiumcodereview.appspot.com/9834021
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@128258 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
global error.
Move disabled-extension interface to namespace extensions.
It looks like this:
http://dl.dropbox.com/u/27111995/Mocks/disable-dialog.png
http://dl.dropbox.com/u/27111995/Mocks/disable-menu.png
BUG=108202
TEST=install extension, update to version that requires additional permissions. Accept upgrade. Uninstall manually from chrome://extensions. Don't crash.
Review URL: http://codereview.chromium.org/9718008
TBR=yoz@chromium.org
Review URL: https://chromiumcodereview.appspot.com/9802007
TBR=sky@chromium.org
Review URL: https://chromiumcodereview.appspot.com/9812033
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@128124 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
understand failures on XP bots.
(There is code duplication here, but we should be able to undo it after we understand the failures.)
BUG=108202
TEST=no
Review URL: https://chromiumcodereview.appspot.com/9828002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@128095 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Move disabled-extension interface to namespace extensions.
It looks like this:
http://dl.dropbox.com/u/27111995/Mocks/disable-dialog.png
http://dl.dropbox.com/u/27111995/Mocks/disable-menu.png
BUG=108202
TEST=install extension, update to version that requires additional permissions. Accept upgrade. Uninstall manually from chrome://extensions. Don't crash.
Review URL: http://codereview.chromium.org/9718008
TBR=yoz@chromium.org
Review URL: https://chromiumcodereview.appspot.com/9802007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@127903 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Move disabled-extension interface to namespace extensions.
It looks like this:
http://dl.dropbox.com/u/27111995/Mocks/disable-dialog.png
http://dl.dropbox.com/u/27111995/Mocks/disable-menu.png
BUG=108202
TEST=install extension, update to version that requires additional permissions. Accept upgrade. Uninstall manually from chrome://extensions. Don't crash.
Review URL: http://codereview.chromium.org/9718008
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@127887 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The new ExtensionDownloader takes care of fetching manifests, parsing them,
and downloading crx files. These are then passed to a Delegate.
The ExtensionUpdater is one such Delegate, and does the same as before.
This makes it possible for other components to download extensions given an ID
and update URL; in particular, the retail-mode AppPack for chromeos.
BUG=chromium-os:25463
TEST=Exactly everything about installing/updating extensions works exactly the same. All tests pass.
Review URL: https://chromiumcodereview.appspot.com/9695019
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@127206 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
This also finishes breaking the Chrome dependency on RenderWidgetHostImpl and RenderViewHostImpl.
TBR=jam@chromium.org
BUG=98716
Review URL: https://chromiumcodereview.appspot.com/9599011
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@125166 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Part 1 of N.
See https://groups.google.com/a/chromium.org/group/chromium-dev/browse_thread/thread/fcec09fc659f39a6
BUG=104132,52928,100062,89762,82616,44668,44666,62537,69034,62538,81451,67301,62539,81451,69475,106538,84427,114104,103539,100538,109669,74557,96725,52544,68287,86105,89727,96725,95274,80961,83876
Review URL: http://codereview.chromium.org/9361066
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@121975 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Add tests for tricky logic around multiple sources installing the same extension. Initial chromeos login is an example of a case where we have seen this happen.
BUG=108703
TEST=ExtensionServiceTest.InstallPriority*
Review URL: http://codereview.chromium.org/8991011
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@117579 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
ExtensionManagementApiBrowserTest.LaunchApp fixed by r113141.
Make ExtensionSet iterate like a set instead of a map.
BUG=104091
TEST=existing tests
Review URL: http://codereview.chromium.org/8733004
TBR=yoz@chromium.org
Review URL: http://codereview.chromium.org/8789018
TBR=yoz@chromium.org
Review URL: http://codereview.chromium.org/8822021
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@113233 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
It broke ExtensionManagementApiBrowserTest.LaunchApp.
Make ExtensionSet iterate like a set instead of a map.
BUG=104091
TEST=existing tests
Review URL: http://codereview.chromium.org/8733004
TBR=yoz@chromium.org
Review URL: http://codereview.chromium.org/8789018
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@113071 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Make ExtensionSet iterate like a set instead of a map.
BUG=104091
TEST=existing tests
Review URL: http://codereview.chromium.org/8733004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@113047 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
ExtensionSet.
- When installing CRX, observe CRX_INSTALLER_DONE notification, using that to get the ID of the installed extension.
- Clean up ExtensionManagementTest to use the returned Extension instead of at().
- Use EXPECT in helper InstallExtension functions.
BUG=104091,105728
TEST=browser_tests
Review URL: http://codereview.chromium.org/8725013
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@112042 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
content::URLFetcher interface.
BUG=98716
Review URL: http://codereview.chromium.org/8403017
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@107531 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
and convert users to it. I have added a static create function, but will switch instantiations to use it in another change since this has grown a lot. Basically this change converts function names away from unix_hacker style, which they shouldn't have been using anyways since some are virtual, and made all of the other functions virtual.
BUG=98716
Review URL: http://codereview.chromium.org/8375039
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@107151 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
Also remove the old URLFetcher delegate callback while I'm touching all of them.BUG=98716,83592
Review URL: http://codereview.chromium.org/8373021
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@106949 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=81752
TEST=
Review URL: http://codereview.chromium.org/8230035
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@106573 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
callers to use it. Move the implementation to content/browser. Stop creating it in all child processes since it's only used in the browser.
BUG=98716
Review URL: http://codereview.chromium.org/8342048
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@106403 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
content/public/browser.
This patch got way bigger than I wanted, but once I moved NotificationDetails, I figured I might as well mvoe the others since they're in the same files. In hindsight, I should have converted a subset of files at a time by leaving a using statement in the header.
BUG=98716
TBR=joi
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@106196 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
(attempt 3).
I split up an API test because it times out (it is doing too much).
The other two modifications to the tests were needed because they were trying to open chrome://extensions in incognito.
In one case, the test just needed any page (so I switched to about:blank) and in the other we are testing for a condition that cannot happen anymorebecause chrome://extensions could be loaded in incognito but chrome://settingsdoesn't allow that -- it shunts the request to the non-incognito profile.
The test was testing that we don't crash in incognito, so I removed that test. Also change the URL for the Extension Settings page fromchrome://settings/extensionSettings -> chrome://settings/extensions.
BUG=87377, 96836
TEST=Well... type in chrome://extensions and notice it redirects.
TEST=chrome://settings/extensions (or chrome://extensions) should take you to the extension settings page, and chrome://settings/extensionSettings should not.
Review URL: http://codereview.chromium.org/7918019
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@101804 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
chrome://settings/chromeExtensions (attempt 2).
The two modifications to the tests were needed because they were trying to
open chrome://extensions in incognito.
In one case, the test just needed any page (so I switched to about:blank)
and in the other we are testing for a condition that cannot happen anymore
because chrome://extensions could be loaded in incognito but chrome://settings
doesn't allow that -- it shunts the request to the non-incognito profile.
The test was testing that we don't crash in incognito, so I removed that test.
BUG=87377
TEST=Well... type in chrome://extensions and notice it redirects.
Review URL: http://codereview.chromium.org/7885031
TBR=finnur@chromium.org
Review URL: http://codereview.chromium.org/7892031
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@101089 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
(attempt 2).
The two modifications to the tests were needed because they were trying to
open chrome://extensions in incognito.
In one case, the test just needed any page (so I switched to about:blank)
and in the other we are testing for a condition that cannot happen anymore
because chrome://extensions could be loaded in incognito but chrome://settings
doesn't allow that -- it shunts the request to the non-incognito profile.
The test was testing that we don't crash in incognito, so I removed that test.
BUG=87377
TEST=Well... type in chrome://extensions and notice it redirects.
Review URL: http://codereview.chromium.org/7885031
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@101081 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
chrome://settings/chromeExtensions.
The two modifications to the tests were needed because they were trying to
open chrome://extensions in incognito.
In one case, the test just needed any page (so I switched to about:blank)
and in the other we are testing for a condition that cannot happen anymore
because chrome://extensions could be loaded in incognito but chrome://settings
doesn't allow that -- it shunts the request to the non-incognito profile.
The test was testing that we don't crash in incognito, so I removed that test.
BUG=87377
TEST=Well... type in chrome://extensions and notice it redirects.
Review URL: http://codereview.chromium.org/7888010
TBR=finnur@chromium.org
Review URL: http://codereview.chromium.org/7890029
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@101064 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The two modifications to the tests were needed because they were trying to
open chrome://extensions in incognito.
In one case, the test just needed any page (so I switched to about:blank)
and in the other we are testing for a condition that cannot happen anymore
because chrome://extensions could be loaded in incognito but chrome://settings
doesn't allow that -- it shunts the request to the non-incognito profile.
The test was testing that we don't crash in incognito, so I removed that test.
BUG=87377
TEST=Well... type in chrome://extensions and notice it redirects.
Review URL: http://codereview.chromium.org/7888010
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@101046 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Revert revert of r99187.
This reverts r99198.
BUG=94741
TEST=no visible change
Review URL: http://codereview.chromium.org/7810002
TBR=avi@chromium.org
Review URL: http://codereview.chromium.org/7827017
Review URL: http://codereview.chromium.org/7826014
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@99222 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
ProfileSyncServiceSessionTest.FailModelAssociation on 10.5)
- Move infobar handling to a tab helper, part 1.
BUG=94741
TEST=no visible change
Review URL: http://codereview.chromium.org/7810002
TBR=avi@chromium.org
Review URL: http://codereview.chromium.org/7827017
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@99198 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=94741
TEST=no visible change
Review URL: http://codereview.chromium.org/7810002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@99187 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=86519
TEST=Extensions tests, should all work as before. The test described in the bug should now work as expected.
Review URL: http://codereview.chromium.org/7605001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@96420 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
BUG=90905
Review URL: http://codereview.chromium.org/7532034
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@94720 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
removed unused/irrelevant functions
removed irrelevant comments
Moved stl_util-inl.h => stl_util.h
BUG=None
TEST=None
Review URL: http://codereview.chromium.org/7342047
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@93110 0039d316-1c4b-4281-b951-d872f2087c98
|
|\
| |
| |
| |
| |
| |
| |
| |
| | |
BUG=89733
TBR=robertshield@chromium.org
TEST=browser_tests
Review URL: http://codereview.chromium.org/7447001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@93027 0039d316-1c4b-4281-b951-d872f2087c98
|
| |
| |
| |
| |
| |
| |
| |
| |
| | |
BUG=
TEST=try
Review URL: http://codereview.chromium.org/7375016
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@93026 0039d316-1c4b-4281-b951-d872f2087c98
|
|/
|
|
|
|
|
|
|
| |
BUG=89727
TEST=NONE
TBR=grt
Review URL: http://codereview.chromium.org/7432007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@93022 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
chrome_notification_types.h.
This file lives in chrome\common. The chrome specific notifications start from NOTIFICATION_CONTENT_END
which defines the end of the enum used by content to define notification types. The notificaton_type.h file
in content\common has been renamed to content_notification_types.h
BUG=76698
Review URL: http://codereview.chromium.org/7327007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@91972 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
In case the testing machine already has some policies, don't time out but fail with an error message.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/7278020
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@91410 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=84507
TEST=*Extension*
Review URL: http://codereview.chromium.org/7003098
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@90244 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
When an extension is disabled because a newer version requires higher
permissions, if you then uninstall the extension while the infobar warning
is still up, you'll get a crash if you switch to the tab that had the infobar.
This patch makes the infobar notice the extension uninstall and remove itself.
BUG=84826
TEST=As detailed in description above (and outlined in bug report too).
Review URL: http://codereview.chromium.org/7003068
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@88458 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
(component) extensions.
BUG=79093
TEST=
R=aa@chromium.org
Review URL: http://codereview.chromium.org/6850018
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@81627 0039d316-1c4b-4281-b951-d872f2087c98
|