summaryrefslogtreecommitdiffstats
path: root/chrome/browser/extensions/extension_menu_manager_unittest.cc
Commit message (Collapse)AuthorAgeFilesLines
* Moved ExtensionMenuManager and ExtensionMenuItem into extensions namespace; ↵rdevlin.cronin@chromium.org2012-07-051-629/+0
| | | | | | | | | | | rename them to MenuManager and MenuItem. BUG=134711, 117261 Review URL: https://chromiumcodereview.appspot.com/10664037 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@145550 0039d316-1c4b-4281-b951-d872f2087c98
* Move test_browser_thread.h from content\test to content\public\test. This ↵jam@chromium.org2012-06-041-1/+1
| | | | | | | | | | way we can enforce that internal content headers don't leak to embedders. BUG=98716 TBR=phajdan.jr Review URL: https://chromiumcodereview.appspot.com/10500016 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@140254 0039d316-1c4b-4281-b951-d872f2087c98
* Dispatch a new event chrome.contextMenus.onClicked.yoz@chromium.org2012-06-011-5/+17
| | | | | | | | | | | | | Disallow onclick create parameter for event pages. Fix onClickData, which had incorrect types and missing fields. BUG=123366 TEST=Register a chrome.contextMenus.onClicked handler in an event page (adding the menu items upon chrome.runtime.onInstalled). Check that it fires. Review URL: https://chromiumcodereview.appspot.com/10454106 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@140112 0039d316-1c4b-4281-b951-d872f2087c98
* Change profile distinguisher in ExtensionMenuItem::Id to a bool.yoz@chromium.org2012-05-231-3/+3
| | | | | | | | | | | | | | In ages past, this option was considered in http://codereview.chromium.org/4090011/. Now it would simplify serialization to/from prefs. Also, add a few checks that parent and child nodes match profiles. BUG=123366 TEST=no Review URL: https://chromiumcodereview.appspot.com/10399117 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@138583 0039d316-1c4b-4281-b951-d872f2087c98
* Move Extension into extensions namespaceaa@chromium.org2012-05-211-3/+5
| | | | | | | | | BUG=117262 TBR=aa@chromium.org Review URL: https://chromiumcodereview.appspot.com/10375021 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@138074 0039d316-1c4b-4281-b951-d872f2087c98
* Add option of string item IDs (given at create() time) to contextMenus API.yoz@chromium.org2012-05-161-7/+31
| | | | | | | | | | | This will be (but is not yet) required for event pages. BUG=123366 TEST=automated tests Review URL: https://chromiumcodereview.appspot.com/10391125 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@137323 0039d316-1c4b-4281-b951-d872f2087c98
* Modify the base::JSONReader interface to take a set of options rather than a ↵rsesek@chromium.org2012-04-111-1/+2
| | | | | | | | | | | | | | boolean flag. This is just prep work for a large CL that rewrites the JSON parser. Splitting out this interface change will make it easier to review the other CL. BUG=121469 TEST=No functional change. Review URL: https://chromiumcodereview.appspot.com/9960077 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@131680 0039d316-1c4b-4281-b951-d872f2087c98
* Allow extension context menus to enable/disable itemscduvall@chromium.org2012-04-031-1/+1
| | | | | | | | | | | | | Added an "enabled" parameter to contextMenus.create and contextMenus.update so an item can be enabled and disabled. BUG=76554 TEST=ExtensionContextMenuBrowserTest.Enabled Review URL: http://codereview.chromium.org/9791014 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@130334 0039d316-1c4b-4281-b951-d872f2087c98
* Clean up password manager code.isherman@chromium.org2012-03-021-1/+1
| | | | | | | | | | BUG=none TEST=password saving should continue to work Review URL: http://codereview.chromium.org/9564001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@124735 0039d316-1c4b-4281-b951-d872f2087c98
* Update extension events, routing, and delivery to use user gesture.gbillock@chromium.org2012-03-021-11/+14
| | | | | | | | | | | R=aa@chromium.org BUG=109425 TEST=*Extension* Review URL: http://codereview.chromium.org/9316102 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@124596 0039d316-1c4b-4281-b951-d872f2087c98
* Move ContextMenuParams struct from webkit/glue to content/public/common. The ↵jam@chromium.org2012-02-121-2/+2
| | | | | | | | | | | | | reasons are: -this struct wasn't used at all in webkit layer, so no need to have it there -we can avoid exposing content layer's serialization of SSLInfo to embedders -avoid mentioning routing_ids in the webkit layer BUG=98716 Review URL: https://chromiumcodereview.appspot.com/9382037 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@121673 0039d316-1c4b-4281-b951-d872f2087c98
* Ensure one radio button is always checked in extension context menus.Eriq.Augustine@gmail.com2012-01-111-1/+93
| | | | | | | | | | | | | | | This patch changes the behavior on all systems to match the behavior on Linux ie. there is always exactly one item selected in a run of radio items. This patch includes a unit test (ExtensionMenuManagerTest.SanitizeRadioButtons). BUG=49808 TEST=On any OS but Linux, load an extension that has a context menu without items selected by defuat. One item shuold be selected, but none are. Review URL: http://codereview.chromium.org/8935016 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@117301 0039d316-1c4b-4281-b951-d872f2087c98
* Switch to IWYU for files that previously were getting a bunch ofjoi@chromium.org2011-12-011-0/+1
| | | | | | | | | | | header files via io_thread.h or browser_thread.h TBR=owners (previously approved on codereview 8477004) BUG=98716 Review URL: http://codereview.chromium.org/8746023 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@112455 0039d316-1c4b-4281-b951-d872f2087c98
* Move BrowserThread to content namespace.joi@chromium.org2011-11-021-0/+1
| | | | | | | | | TBR=owners BUG=98716 Review URL: http://codereview.chromium.org/8437002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@108270 0039d316-1c4b-4281-b951-d872f2087c98
* Split BrowserThread into public API and private implementation, step 1.joi@chromium.org2011-10-281-3/+3
| | | | | | | | | | | | | | | | | | | | | Only content/ now has the ability to create BrowserThread objects, with the exception that tests can create the content::TestBrowserThread subclass, and (temporarily) code in chrome/ can create the DeprecatedBrowserThread subclass. A follow-up change will make content/ take care of its own thread creation, remove DeprecatedBrowserThread, and move all state and non-trivial constructors from BrowserThread down to BrowserThreadImpl. Also moved BrowserProcessSubThread into content/ namespace. As part of follow-up cleanup, chrome/ will stop using this class. BUG=98716 TEST=existing Review URL: http://codereview.chromium.org/8392042 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@107718 0039d316-1c4b-4281-b951-d872f2087c98
* Make NotificationService an interface in the content namespace, and switch ↵jam@chromium.org2011-10-191-2/+3
| | | | | | | | | callers to use it. Move the implementation to content/browser. Stop creating it in all child processes since it's only used in the browser. BUG=98716 Review URL: http://codereview.chromium.org/8342048 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@106403 0039d316-1c4b-4281-b951-d872f2087c98
* Move NotificationObserver, NotificationSource, and NotificationDetails to ↵jam@chromium.org2011-10-191-2/+2
| | | | | | | | | | | content/public/browser. This patch got way bigger than I wanted, but once I moved NotificationDetails, I figured I might as well mvoe the others since they're in the same files. In hindsight, I should have converted a subset of files at a time by leaving a using statement in the header. BUG=98716 TBR=joi git-svn-id: svn://svn.chromium.org/chrome/trunk/src@106196 0039d316-1c4b-4281-b951-d872f2087c98
* Fix some AllSources observers of EXTENSION_UNLOADED.yoz@chromium.org2011-10-131-1/+3
| | | | | | | | | | | | Most such observers use it to remove state they are tracking about particular extensions. extension_menu_manager should be okay even without this. desktop_notification_service might have had subtle wrongness. BUG=99391 TEST=existing tests Review URL: http://codereview.chromium.org/8253005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@105390 0039d316-1c4b-4281-b951-d872f2087c98
* Lazy creation of background pages with --enable-lazy-background-pagestessamac@chromium.org2011-08-311-12/+11
| | | | | | | | | | BUG=81752 TEST=None Review URL: http://codereview.chromium.org/7672009 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@98981 0039d316-1c4b-4281-b951-d872f2087c98
* Switch ChromeTestSuite to the same convention as ContentTestSuite:phajdan.jr@chromium.org2011-08-271-2/+1
| | | | | | | | | | | | | | | | | the test suite implicitly provides global resources for each test, but they're re-initialized between each test. The performance overhead is negligible. We need that to continue moving tests from unit_tests to content_unittests. Because of shared test fixtures the test suites need to be compatible. BUG=90443 Review URL: http://codereview.chromium.org/7744039 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@98526 0039d316-1c4b-4281-b951-d872f2087c98
* Remove extension.h #include from profile.h.mihaip@chromium.org2011-08-131-1/+2
| | | | | | | | | | | | | Touching extension.h now results in 202 files being compiled instead of 495 (when building the chrome target). Required that the UnloadedExtensionReason enum be moved to extension_constants.h. R=asargent@chromium.org Review URL: http://codereview.chromium.org/7633029 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@96686 0039d316-1c4b-4281-b951-d872f2087c98
* Reorganize chrome/test, part #9phajdan.jr@chromium.org2011-08-111-1/+1
| | | | | | | | | TBR=jcivelli BUG=90905 Review URL: http://codereview.chromium.org/7616019 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@96453 0039d316-1c4b-4281-b951-d872f2087c98
* GTTF: Use a fresh TestingBrowserProcess for each test, part #4phajdan.jr@chromium.org2011-08-031-1/+2
| | | | | | | | | | | For a detailed description see part #1, http://codereview.chromium.org/6478005/ BUG=61062 TEST=unit_tests, possibly more Review URL: http://codereview.chromium.org/7465041 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@95350 0039d316-1c4b-4281-b951-d872f2087c98
* Move more files from chrome/test to chrome/test/base, part #4phajdan.jr@chromium.org2011-08-011-1/+1
| | | | | | | BUG=90905 Review URL: http://codereview.chromium.org/7544021 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@94963 0039d316-1c4b-4281-b951-d872f2087c98
* Moving notification types which are chrome specific to a new header file ↵ananta@chromium.org2011-07-101-1/+2
| | | | | | | | | | | | | chrome_notification_types.h. This file lives in chrome\common. The chrome specific notifications start from NOTIFICATION_CONTENT_END which defines the end of the enum used by content to define notification types. The notificaton_type.h file in content\common has been renamed to content_notification_types.h BUG=76698 Review URL: http://codereview.chromium.org/7327007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@91972 0039d316-1c4b-4281-b951-d872f2087c98
* More correct window focus changes for multi-profile and incognito.yoz@chromium.org2011-06-231-2/+4
| | | | | | | | | | | | | | | | Multi-profile: treat windows from other profiles as WINDOW_ID_NONE. Incognito: on switching between default/OTR profile windows, send WINDOW_ID_NONE to the extensions that can't see the new window. Also make ExtensionBrowserEventRouter listen only to events from browsers and tabs for its profile, except for window focus events. BUG=46610, 57186, 86001 TEST=Manually tested extensions in spanning and split mode. Review URL: http://codereview.chromium.org/7187015 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@90143 0039d316-1c4b-4281-b951-d872f2087c98
* Move scoped_temp_dir and scoped_native_library back from base/memory to base.thakis@chromium.org2011-05-191-1/+1
| | | | | | | | | | | It looks like they got moved accidentally in http://codereview.chromium.org/6714032 BUG=none TEST=none Review URL: http://codereview.chromium.org/7048007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@86010 0039d316-1c4b-4281-b951-d872f2087c98
* Move some files from base to base/memory.levin@chromium.org2011-03-281-2/+2
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | raw_scoped_refptr_mismatch_checker.h ref_counted.cc ref_counted.h ref_counted_memory.cc ref_counted_memory.h ref_counted_unittest.cc scoped_callback_factory.h scoped_comptr_win.h scoped_handle.h scoped_native_library.cc scoped_native_library.h scoped_native_library_unittest.cc scoped_nsobject.h scoped_open_process.h scoped_ptr.h scoped_ptr_unittest.cc scoped_temp_dir.cc scoped_temp_dir.h scoped_temp_dir_unittest.cc scoped_vector.h singleton.h singleton_objc.h singleton_unittest.cc linked_ptr.h linked_ptr_unittest.cc weak_ptr.cc weak_ptr.h weak_ptr_unittest.cc BUG=None TEST=Compile Review URL: http://codereview.chromium.org/6714032 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@79524 0039d316-1c4b-4281-b951-d872f2087c98
* ImportantFileWriter: check return value of PostTaskphajdan.jr@chromium.org2011-03-101-5/+9
| | | | | | | | | | | | | when writing to the disk, so we can be sure it doesn't lose data. Also fix tests that misused things. TEST=none BUG=none Review URL: http://codereview.chromium.org/6627060 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@77695 0039d316-1c4b-4281-b951-d872f2087c98
* Update a bunch of files to the new location of notification files.tfarina@chromium.org2011-03-081-3/+3
| | | | | | | | | | | First part of the remaining files. BUG=None TEST=None Review URL: http://codereview.chromium.org/6649001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@77330 0039d316-1c4b-4281-b951-d872f2087c98
* Update a bunch of files to the new location of browser_thread.h jam@chromium.org2011-03-011-1/+1
| | | | | | | | TBR=avi Review URL: http://codereview.chromium.org/6594084 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@76411 0039d316-1c4b-4281-b951-d872f2087c98
* Change extension unload notification to indicate updates.asargent@chromium.org2010-12-231-1/+2
| | | | | | | | | | | | | | | | | | | When an extension in being unloaded, some listeners want to know if it's because the extension is being updated to a newer version, or disabled. This changes the details sent to include a reason. Also this removes the EXTENSION_UNLOADED_DISABLED notification, since only a small number of places actually cared about the disctinction between EXTENSION_UNLOADED and EXTENSION_UNLOADED_DISABLED, and puts that information into the details as well. BUG=65510 TEST=Should be covered by existing unit & browser tests. Review URL: http://codereview.chromium.org/5968009 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@70104 0039d316-1c4b-4281-b951-d872f2087c98
* webkit: use string16 in ContextMenuParamsevan@chromium.org2010-12-141-3/+5
| | | | | | | | | BUG=23581 TEST=compiles Review URL: http://codereview.chromium.org/5712003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@69074 0039d316-1c4b-4281-b951-d872f2087c98
* Fix bug with context menus in incognito mode.mpcomplete@chromium.org2010-11-021-3/+3
| | | | | | | | | | | | | | | | | If an extension uses "spanning" mode, the context menu items are shared between profiles. If an extension uses "split" mode, the items are separate per profile. In either case, they only appear in incognito if the extension is enabled in incognito. Also fixed a minor bug, so that tabs.create now can open extension URLs in incognito if the extension uses split mode. BUG=61147 TEST=see bug for repro steps; context menu items should work in incognito mode Review URL: http://codereview.chromium.org/4090011 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@64812 0039d316-1c4b-4281-b951-d872f2087c98
* Part 3 of immutable Extension refactor.mpcomplete@chromium.org2010-10-291-1/+1
| | | | | | | | | | | | | Make ExtensionsService hold const Extension pointers only. This ensures that extensions can't be modified after they're created, and lets us share them between threads. BUG=56558 TEST=no functional change Review URL: http://codereview.chromium.org/4138006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@64517 0039d316-1c4b-4281-b951-d872f2087c98
* Fix broken icons in new context menu items after removing previous itemsasargent@chromium.org2010-10-281-1/+18
| | | | | | | | | | | | | | BUG=59603 TEST=Have an extension add several context menu items. Verify that the context menu properly shows the extension's icon. Now call chrome.contextMenus.remove repeatedly to remove all the items. Then add one or more new ones. The icon should still show up properly, and not revert to the default puzzle piece icon. Review URL: http://codereview.chromium.org/4170008 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@64337 0039d316-1c4b-4281-b951-d872f2087c98
* Unrevert again r63919: "Part 2 of immutable Extension refactor."mpcomplete@chromium.org2010-10-271-2/+2
| | | | | | | | | | | | | | | | | | | | | | | | | | (Last landing broke chromeos and chromium linux builder.) I made Extension a refcounted object, and privitized the existing con/destructor and InitFromValue. The only way to get an Extension is to call a factory method. In the next CL, I plan to make the factory method return a const Extension, to guarantee that no one can modify the Extension object after creation. Note: There was a tricky part of this CL because of the difference in semantics between scoped_ptr and scoped_refptr. I had to be careful not to use ptr.release(), since that would result in leaks (an un-Released AddRef). BUG=56558 TEST=no functional change Original Review URL: http://codereview.chromium.org/3982001 TBR=aa Review URL: http://codereview.chromium.org/4119010 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@64139 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 63962 (broke chromeos and chromium linux builder) - Unrevert r63919: ↵thakis@chromium.org2010-10-261-2/+2
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | "Part 2 of immutable Extension refactor." I made Extension a refcounted object, and privitized the existing con/destructor and InitFromValue. The only way to get an Extension is to call a factory method. In the next CL, I plan to make the factory method return a const Extension, to guarantee that no one can modify the Extension object after creation. Note: There was a tricky part of this CL because of the difference in semantics between scoped_ptr and scoped_refptr. I had to be careful not to use ptr.release(), since that would result in leaks (an un-Released AddRef). BUG=56558 TEST=no functional change Original Review URL: http://codereview.chromium.org/3982001 TBR=aa Review URL: http://codereview.chromium.org/4186002 TBR=mpcomplete@chromium.org Review URL: http://codereview.chromium.org/4130004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@63976 0039d316-1c4b-4281-b951-d872f2087c98
* Unrevert r63919: "Part 2 of immutable Extension refactor."mpcomplete@chromium.org2010-10-261-2/+2
| | | | | | | | | | | | | | | | | | | | | | | | I made Extension a refcounted object, and privitized the existing con/destructor and InitFromValue. The only way to get an Extension is to call a factory method. In the next CL, I plan to make the factory method return a const Extension, to guarantee that no one can modify the Extension object after creation. Note: There was a tricky part of this CL because of the difference in semantics between scoped_ptr and scoped_refptr. I had to be careful not to use ptr.release(), since that would result in leaks (an un-Released AddRef). BUG=56558 TEST=no functional change Original Review URL: http://codereview.chromium.org/3982001 TBR=aa Review URL: http://codereview.chromium.org/4186002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@63962 0039d316-1c4b-4281-b951-d872f2087c98
* Revert r63919 "Part 2 of immutable Extension refactor."mpcomplete@chromium.org2010-10-261-2/+2
| | | | | | | | | | | | Compile failure on Linux x64. BUG=56558 TEST=no functional change TBR=aa Review URL: http://codereview.chromium.org/4156002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@63925 0039d316-1c4b-4281-b951-d872f2087c98
* Part 2 of immutable Extension refactor.mpcomplete@chromium.org2010-10-261-2/+2
| | | | | | | | | | | | | | | | | | | | I made Extension a refcounted object, and privitized the existing con/destructor and InitFromValue. The only way to get an Extension is to call a factory method. In the next CL, I plan to make the factory method return a const Extension, to guarantee that no one can modify the Extension object after creation. Note: There was a tricky part of this CL because of the difference in semantics between scoped_ptr and scoped_refptr. I had to be careful not to use ptr.release(), since that would result in leaks (an un-Released AddRef). BUG=56558 TEST=no functional change Review URL: http://codereview.chromium.org/3982001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@63919 0039d316-1c4b-4281-b951-d872f2087c98
* Part 2 of extension event refactor.mpcomplete@chromium.org2010-10-211-10/+13
| | | | | | | | | | | | | Extension events are no longer broadcast to an entire process. They are filtered by extension. This allows me to move the cross-incognito check into the browser, and remove a bunch of cruft associated with that. BUG=58214 TEST=no functional change Review URL: http://codereview.chromium.org/3775015 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@63448 0039d316-1c4b-4281-b951-d872f2087c98
* Pull events-related code out of ExtensionMessageService into its own class.mpcomplete@chromium.org2010-10-151-11/+11
| | | | | | | | | | | | | | The events code is independent of the messaging code and didn't belong in the same class. This is part 1 of an extension event refactor. See bug for more details. BUG=58214 TEST=covered by tests Review URL: http://codereview.chromium.org/3758005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@62764 0039d316-1c4b-4281-b951-d872f2087c98
* Rename ChromeThread to BrowserThread Part19:tfarina@chromium.org2010-10-121-1/+1
| | | | | | | | | | | - Include browser_thread.h instead of chrome_thread.h in more 65 files. BUG=56926 TEST=trybots Review URL: http://codereview.chromium.org/3717003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@62226 0039d316-1c4b-4281-b951-d872f2087c98
* Rename ChromeThread to BrowserThread Part10:tfarina@chromium.org2010-10-091-1/+1
| | | | | | | | | | | - Rename entries under download and extensions. BUG=56926 TEST=trybots Review URL: http://codereview.chromium.org/3685001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@62081 0039d316-1c4b-4281-b951-d872f2087c98
* Add support for a "split" incognito behavior for extensions.mpcomplete@chromium.org2010-08-311-6/+2
| | | | | | | | | | | | | | | | - On by default for apps, off by default for extensions. - Split mode means "run incognito extensions in a separate process if the user says OK, and the two processes can only see their own profile." - Spanning mode is what we have now, and means "run a single extension process, but allow it to access both profiles if the user says OK." BUG=49232 BUG=49114 TEST=extensions still work in incognito when you check "Allow in Incognito". Review URL: http://codereview.chromium.org/3210007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@58033 0039d316-1c4b-4281-b951-d872f2087c98
* Clean up ExtensionMessageService.mpcomplete@chromium.org2010-08-191-0/+1
| | | | | | | | | | | | | - Remove debugging cruft from an old bug that has been closed. - Make it UI-thread only. This complicates ResourceMessageFilter a little, but makes the EMS lifetime a lot easier to reason about. BUG=no TEST=covered by unit tests Review URL: http://codereview.chromium.org/3117024 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@56761 0039d316-1c4b-4281-b951-d872f2087c98
* Convert more wide strings in browser/extensions.viettrungluu@chromium.org2010-08-141-8/+7
| | | | | | | | | | | | I think this kills off the remaining uses of the now-deprecated wstring DictionaryValue methods. BUG=23581 TEST=builds and passes tests Review URL: http://codereview.chromium.org/3125010 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@56141 0039d316-1c4b-4281-b951-d872f2087c98
* Update the names of some parameters passed to contextMenu onclick handlers.asargent@chromium.org2010-08-041-2/+2
| | | | | | | | | | | | | | This changes the mediaType parameter values to be lowercase (eg "audio" instead of "AUDIO"), and changes mainFrameUrl to be pageUrl as the design doc had intended. BUG=49725 TEST=In onclick handlers, values for mediaType should be lowercase and there should be a pageUrl property matching the url of the page. Review URL: http://codereview.chromium.org/3017056 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@54999 0039d316-1c4b-4281-b951-d872f2087c98
* Make sure we fully remove child context menu items when deleting a parent.asargent@chromium.org2010-08-021-0/+65
| | | | | | | | | BUG=49742 TEST=Follow steps in the bug report Review URL: http://codereview.chromium.org/3081009 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@54628 0039d316-1c4b-4281-b951-d872f2087c98
generated by cgit v1.1 at 2025-02-12 08:48:10 +0000