summaryrefslogtreecommitdiffstats
path: root/chrome/browser/extensions/extension_message_service.cc
Commit message (Collapse)AuthorAgeFilesLines
* Define the public interface for content browser SiteInstance. This interface ↵ananta@chromium.org2012-01-251-1/+2
| | | | | | | | | | | | | | | is implemented by the SiteInstanceImpl class which lives in content\browser\site_instance.cc/.h. Changes as part of creating a content API. BUG=98716 TEST=No change in functionality. Hopefully it all compiles and works. Review URL: http://codereview.chromium.org/8515027 Review URL: https://chromiumcodereview.appspot.com/9146028 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@119102 0039d316-1c4b-4281-b951-d872f2087c98
* Get rid of a bunch of tab_contents.h includes from chrome. These are all ↵jam@chromium.org2012-01-041-11/+14
| | | | | | | | | trivial changes to use WebContents instead of TabContents. BUG=98716 Review URL: http://codereview.chromium.org/9030032 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@116392 0039d316-1c4b-4281-b951-d872f2087c98
* Convert unix_hacker functions on NavigationController that are used by ↵jam@chromium.org2011-12-291-2/+2
| | | | | | | | | | Chrome to CamelCase. This is in preparation for adding an interface around NavigationController. BUG=98716 TBR=joi Review URL: http://codereview.chromium.org/8989070 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@115937 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 115346. The change didn't break anything, the test was faulty. Will ↵jam@chromium.org2011-12-211-2/+2
| | | | | | | | | | | | | | | | | | | | disable in a followup. - Revert r115276, it broke PanelDownloadTest.Download in interactive_ui_tests on win,linux,mac. Original change: Rename TabContents::controller() to GetController and put it into the WebContents namespace. BUG=98716 TBR=dpranke Review URL: http://codereview.chromium.org/8956050 TBR=jam Review URL: http://codereview.chromium.org/9018016 TBR=thakis@chromium.org git-svn-id: svn://svn.chromium.org/chrome/trunk/src@115428 0039d316-1c4b-4281-b951-d872f2087c98
* Revert r115276, it broke PanelDownloadTest.Download in interactive_ui_teststhakis@chromium.org2011-12-211-2/+2
| | | | | | | | | | | | | | | | on win,linux,mac. Original change: Rename TabContents::controller() to GetController and put it into the WebContents namespace. BUG=98716 TBR=dpranke Review URL: http://codereview.chromium.org/8956050 TBR=jam Review URL: http://codereview.chromium.org/9018016 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@115346 0039d316-1c4b-4281-b951-d872f2087c98
* Rename TabContents::controller() to GetController and put it into the ↵jam@chromium.org2011-12-211-2/+2
| | | | | | | | | | WebContents namespace. BUG=98716 TBR=dpranke Review URL: http://codereview.chromium.org/8956050 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@115276 0039d316-1c4b-4281-b951-d872f2087c98
* Rename TabContents::render_view_host() to GetRenderViewHost and put it into ↵jam@chromium.org2011-12-201-4/+4
| | | | | | | | | the WebContents interface. BUG=98716 Review URL: http://codereview.chromium.org/9007026 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@115200 0039d316-1c4b-4281-b951-d872f2087c98
* Clean up TCW, make it solely a hub for 1:1 observer/helper objects.avi@chromium.org2011-12-121-3/+4
| | | | | | | | | BUG=105872 TEST=no functional change Review URL: http://codereview.chromium.org/8892011 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@114017 0039d316-1c4b-4281-b951-d872f2087c98
* Define the public interface for content browser RenderProcessHost. This ↵ananta@chromium.org2011-11-181-8/+10
| | | | | | | | | | | | | | | interface is implemented by the RenderProcessHostImpl class which lives in content\browser\renderer_host\render_process_host_impl.cc/.h. The RenderProcessHostImpl class is a consolidation of the RenderProcessHost and BrowserRenderProcessHost classes. The RenderProcessHost public interface was created from the now deleted RenderProcessHost class defined in content\browser\renderer_host\render_process_host.h. Additional methods have been added to the interface to ensure that it works correctly with the MockRenderProcessHost class used by unit tests. I had to implement a number of overrides in the MockRenderProcessHost class to ensure that tests work correctly. This was because of assumptions in the tests that the MockRPH class was a real RPH which it was till now. Added a TODO for the methods which could potentially be removed from this interface. Will revisit that in a subsequent CL. BUG=98716 TEST=No change in functionality. Hopefully it all compiles and works. Review URL: http://codereview.chromium.org/8515027 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@110615 0039d316-1c4b-4281-b951-d872f2087c98
* Extract a ProcessMap class from ExtensionProcessManager. This is a dumb data ↵aa@chromium.org2011-11-091-3/+15
| | | | | | | | | | | class that can be used on both the IO and UI threads to test extension/process associations. BUG=95111,102617 TEST=Already covered by tests Review URL: http://codereview.chromium.org/8387061 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@109194 0039d316-1c4b-4281-b951-d872f2087c98
* Make NotificationService an interface in the content namespace, and switch ↵jam@chromium.org2011-10-191-4/+4
| | | | | | | | | callers to use it. Move the implementation to content/browser. Stop creating it in all child processes since it's only used in the browser. BUG=98716 Review URL: http://codereview.chromium.org/8342048 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@106403 0039d316-1c4b-4281-b951-d872f2087c98
* Move NotificationObserver, NotificationSource, and NotificationDetails to ↵jam@chromium.org2011-10-191-5/+7
| | | | | | | | | | | content/public/browser. This patch got way bigger than I wanted, but once I moved NotificationDetails, I figured I might as well mvoe the others since they're in the same files. In hindsight, I should have converted a subset of files at a time by leaving a using statement in the header. BUG=98716 TBR=joi git-svn-id: svn://svn.chromium.org/chrome/trunk/src@106196 0039d316-1c4b-4281-b951-d872f2087c98
* Move content_notification_types.h from content\common to ↵jam@chromium.org2011-10-181-0/+1
| | | | | | | | | content\public\browser. I dropped the "content" from the name to match other files whose chrome version adds a "chrome_" prefix. I also moved it to the browser directory since notifications are only used in the browser process. I will move the other notification files in future changes. BUG=98716 Review URL: http://codereview.chromium.org/8331001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@106028 0039d316-1c4b-4281-b951-d872f2087c98
* Mark ExtensionMessageService AllSources usage as ok.yoz@chromium.org2011-10-151-3/+3
| | | | | | | | | BUG=99391 TEST=none Review URL: http://codereview.chromium.org/8295010 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@105616 0039d316-1c4b-4281-b951-d872f2087c98
* Refactor ExtensionTabUtil-namespaced functions into their own file.miket@chromium.org2011-09-271-1/+1
| | | | | | | | | TEST=none; no functionality has changed. Review URL: http://codereview.chromium.org/8037005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@102958 0039d316-1c4b-4281-b951-d872f2087c98
* Reland 101111 - Only deliver extension messages to contexts that care.aa@chromium.org2011-09-151-8/+4
| | | | | | | | BUG=96544,76571 Review URL: http://codereview.chromium.org/7888064 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@101221 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 101111 - Only deliver extension messages to contexts that care. Thisericu@google.com2011-09-141-4/+8
| | | | | | | | | | | | | | save 60 (of 70) mb of string data on www.mashable.com with AdBlock installed. BUG=96544,76571 Review URL: http://codereview.chromium.org/7890024 TBR=aa@chromium.org Review URL: http://codereview.chromium.org/7888050 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@101130 0039d316-1c4b-4281-b951-d872f2087c98
* Only deliver extension messages to contexts that care. Thisaa@chromium.org2011-09-141-8/+4
| | | | | | | | | | | save 60 (of 70) mb of string data on www.mashable.com with AdBlock installed. BUG=96544,76571 Review URL: http://codereview.chromium.org/7890024 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@101111 0039d316-1c4b-4281-b951-d872f2087c98
* Populate ContextInfo::extension_id for all extension-relatedaa@chromium.org2011-08-191-2/+5
| | | | | | | | | | | | contexts. This is going to be used in a subsequent change to unify the way that renderer_extension_bindings and extension_process_bindings are initialized. Also remove ContextInfo::parent_frame since it was only used in one place and easily derived. Review URL: http://codereview.chromium.org/7655031 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@97425 0039d316-1c4b-4281-b951-d872f2087c98
* Removal of Profile from content part 2.avi@chromium.org2011-07-271-2/+4
| | | | | | | | | | | BUG=76788 TEST=no change visible Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=94332 Review URL: http://codereview.chromium.org/7480028 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@94347 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 94332 - Removal of Profile from content part 2.sergeyu@chromium.org2011-07-271-4/+2
| | | | | | | | | | | | BUG=76788 TEST=no change visible Review URL: http://codereview.chromium.org/7480028 TBR=avi@chromium.org Review URL: http://codereview.chromium.org/7492051 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@94335 0039d316-1c4b-4281-b951-d872f2087c98
* Removal of Profile from content part 2.avi@chromium.org2011-07-271-2/+4
| | | | | | | | | BUG=76788 TEST=no change visible Review URL: http://codereview.chromium.org/7480028 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@94332 0039d316-1c4b-4281-b951-d872f2087c98
* Remove explicit keyword from multi-argument (w/o default values) constructorsdilmah@chromium.org2011-07-261-1/+1
| | | | | | | | | BUG=None TEST=None Review URL: http://codereview.chromium.org/7477008 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@94115 0039d316-1c4b-4281-b951-d872f2087c98
* some cleanup for base/stl_utildilmah@chromium.org2011-07-191-1/+1
| | | | | | | | | | | | | removed unused/irrelevant functions removed irrelevant comments Moved stl_util-inl.h => stl_util.h BUG=None TEST=None Review URL: http://codereview.chromium.org/7342047 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@93110 0039d316-1c4b-4281-b951-d872f2087c98
* Moving notification types which are chrome specific to a new header file ↵ananta@chromium.org2011-07-101-8/+8
| | | | | | | | | | | | | chrome_notification_types.h. This file lives in chrome\common. The chrome specific notifications start from NOTIFICATION_CONTENT_END which defines the end of the enum used by content to define notification types. The notificaton_type.h file in content\common has been renamed to content_notification_types.h BUG=76698 Review URL: http://codereview.chromium.org/7327007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@91972 0039d316-1c4b-4281-b951-d872f2087c98
* Send the RENDER_VIEW_HOST_DELETED notification for all RenderViewHost, ↵jam@chromium.org2011-03-311-1/+1
| | | | | | | | | instead of just ones for TabContents. BUG=78030 Review URL: http://codereview.chromium.org/6758039 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@80075 0039d316-1c4b-4281-b951-d872f2087c98
* Move extension messages to their own file and add a RenderViewObserver to ↵jam@chromium.org2011-03-281-4/+4
| | | | | | | | | start moving the extension code out of RenderView. TBR=aa Review URL: http://codereview.chromium.org/6735004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@79561 0039d316-1c4b-4281-b951-d872f2087c98
* Update a bunch of files to the new location of notification files.tfarina@chromium.org2011-03-081-2/+2
| | | | | | | | | | | First part of the remaining files. BUG=None TEST=None Review URL: http://codereview.chromium.org/6649001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@77330 0039d316-1c4b-4281-b951-d872f2087c98
* Delete the temporary headers left behind in chrome\browser. I've left ↵jam@chromium.org2011-03-011-4/+4
| | | | | | | | | browser_thread.h for another change, since 450 files include it. TBR=avi Review URL: http://codereview.chromium.org/6596060 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@76326 0039d316-1c4b-4281-b951-d872f2087c98
* Move:ben@chromium.org2010-12-021-1/+1
| | | | | | | | | | | | | | | file_path_watcher into subdir profile* into profiles/ subdir login* into ui/login visitedlink* into subdir BUG=none TEST=none TBR=brettw Review URL: http://codereview.chromium.org/5606002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@68069 0039d316-1c4b-4281-b951-d872f2087c98
* Move:ben@chromium.org2010-12-021-1/+1
| | | | | | | | | | | | | | | | | | | | tab_menu_model->ui/tabs tab_contents_wrapper->ui/tab_contents view_ids.h->ui status_bubble.h->ui options*->ui/options show_options_url*->ui/options location_bar*->ui/omnibox input_window*->ui browser_uitests->ui/tests BUG=none TEST=none TBR=brettw Review URL: http://codereview.chromium.org/5582002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@68047 0039d316-1c4b-4281-b951-d872f2087c98
* Make pink's TabContentsWrapper change compile on Windows.ben@chromium.org2010-11-181-1/+2
| | | | | | | | | | Code by pinkerton@, with modifications by evanm and myself to get it to build on windows/linux/chromeos. BUG=none TEST=none Review URL: http://codereview.chromium.org/4694008 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@66626 0039d316-1c4b-4281-b951-d872f2087c98
* 1. Fires port.onDisconnect if tabs.connect fails.jstritar@chromium.org2010-10-281-5/+6
| | | | | | | | | | | | 2. Throws an error in port.postMessage if the port has already been disconnected. 3. Sets lastError when tabs.sendRequest can't connect to the tab. BUG=27565, 32899 TEST=ExtensionApiTest Review URL: http://codereview.chromium.org/3676008 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@64277 0039d316-1c4b-4281-b951-d872f2087c98
* Part 2 of extension event refactor.mpcomplete@chromium.org2010-10-211-3/+3
| | | | | | | | | | | | | Extension events are no longer broadcast to an entire process. They are filtered by extension. This allows me to move the cross-incognito check into the browser, and remove a bunch of cruft associated with that. BUG=58214 TEST=no functional change Review URL: http://codereview.chromium.org/3775015 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@63448 0039d316-1c4b-4281-b951-d872f2087c98
* Pull events-related code out of ExtensionMessageService into its own class.mpcomplete@chromium.org2010-10-151-111/+4
| | | | | | | | | | | | | | The events code is independent of the messaging code and didn't belong in the same class. This is part 1 of an extension event refactor. See bug for more details. BUG=58214 TEST=covered by tests Review URL: http://codereview.chromium.org/3758005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@62764 0039d316-1c4b-4281-b951-d872f2087c98
* Remove traces for the WhitelistExtension test. The flakiness seems to be gone.finnur@chromium.org2010-10-141-21/+3
| | | | | | | | | | TBR=aa BUG=59060 TEST=None Review URL: http://codereview.chromium.org/3808005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@62536 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 62458 - Expands the chrome.experimental.processes extension API.creis@google.com2010-10-131-14/+0
| | | | | | | | | | | | | | | Adds an onUpdated event that reports process metrics from the TaskManager, and modifies the TaskManager to support multiple independent observers. BUG=32302 TEST=ExtensionApiTest.Processes browsertest TEST=process_monitor sample extension Review URL: http://codereview.chromium.org/3597016 TBR=jrg@google.com git-svn-id: svn://svn.chromium.org/chrome/trunk/src@62464 0039d316-1c4b-4281-b951-d872f2087c98
* Expands the chrome.experimental.processes extension API.creis@google.com2010-10-131-0/+14
| | | | | | | | | | | | | Adds an onUpdated event that reports process metrics from the TaskManager, and modifies the TaskManager to support multiple independent observers. BUG=32302 TEST=ExtensionApiTest.Processes browsertest TEST=process_monitor sample extension Review URL: http://codereview.chromium.org/3597016 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@62458 0039d316-1c4b-4281-b951-d872f2087c98
* Fix flaky IncognitoSplitMode. For real this time.mpcomplete@chromium.org2010-10-131-11/+0
| | | | | | | | | | | | | | | | I accidentally checked in the wrong change last time. This reverts r62432 and commits the code that was actually reviewed in http://codereview.chromium.org/3656005/show . Stop processing incoming messages in BrowserRenderProcessHost when it is about to be deleted. See comment 20 on the bug for details. BUG=53991 TEST=handled by existing test Review URL: http://codereview.chromium.org/3772003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@62445 0039d316-1c4b-4281-b951-d872f2087c98
* Add more traces. I think what is happening is that the background page ↵finnur@chromium.org2010-10-131-3/+21
| | | | | | | | | | | | hasn't loaded when the tabUpdated event is sent to the extension, so there is no listener. This should verify that. TBR=aa BUG=57694 TEST=None (this is an attempt to fix a test) Review URL: http://codereview.chromium.org/3783001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@62392 0039d316-1c4b-4281-b951-d872f2087c98
* Ensure global extension events (like bookmarks) are sent to the incognitompcomplete@chromium.org2010-10-081-9/+9
| | | | | | | | | | | | | extension process for split-mode extensions. Also cleaned up some naming. BUG=58189 TEST=no Review URL: http://codereview.chromium.org/3578017 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@62018 0039d316-1c4b-4281-b951-d872f2087c98
* Rip out phantom tabs and corresponding unit tests.andybons@chromium.org2010-10-021-3/+3
| | | | | | | | | | | Also get rid of the type enum passed to TabReplacedAt since it can only be one option after phantom tabs are removed. BUG=none TEST=compile? good. pass tests? good. Review URL: http://codereview.chromium.org/3539010 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@61303 0039d316-1c4b-4281-b951-d872f2087c98
* Add support for a "split" incognito behavior for extensions.mpcomplete@chromium.org2010-08-311-11/+19
| | | | | | | | | | | | | | | | - On by default for apps, off by default for extensions. - Split mode means "run incognito extensions in a separate process if the user says OK, and the two processes can only see their own profile." - Spanning mode is what we have now, and means "run a single extension process, but allow it to access both profiles if the user says OK." BUG=49232 BUG=49114 TEST=extensions still work in incognito when you check "Allow in Incognito". Review URL: http://codereview.chromium.org/3210007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@58033 0039d316-1c4b-4281-b951-d872f2087c98
* When extension is blacklisted by admin policy, it should be removed if ↵finnur@chromium.org2010-08-211-1/+1
| | | | | | | | | | | | | | already running. (Attempt 2 at landing this, this time with changes to fix Enabledness unit test) BUG=51689 TEST=ExtensionsServiceTest.BlacklistedByPolicyRemovedIfRunning Review URL: http://codereview.chromium.org/3166023 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@56987 0039d316-1c4b-4281-b951-d872f2087c98
* Clean up ExtensionMessageService.mpcomplete@chromium.org2010-08-191-150/+45
| | | | | | | | | | | | | - Remove debugging cruft from an old bug that has been closed. - Make it UI-thread only. This complicates ResourceMessageFilter a little, but makes the EMS lifetime a lot easier to reason about. BUG=no TEST=covered by unit tests Review URL: http://codereview.chromium.org/3117024 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@56761 0039d316-1c4b-4281-b951-d872f2087c98
* Try to fix a valgrind leak.thakis@chromium.org2010-07-201-1/+4
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This shows up as Suppression: { <insert_a_suppression_name_here> Memcheck:Leak fun:_Znw* fun:_ZNSt8_Rb_treeISsSt4pairIKSsSt3setIiSt4lessIiESaIiEEESt10_Select1stIS7_ES3_ISsESaIS7_EE11_M_get_nodeEv fun:_ZNSt8_Rb_treeISsSt4pairIKSsSt3setIiSt4lessIiESaIiEEESt10_Select1stIS7_ES3_ISsESaIS7_EE14_M_create_nodeERKS7_ fun:_ZNSt8_Rb_treeISsSt4pairIKSsSt3setIiSt4lessIiESaIiEEESt10_Select1stIS7_ES3_ISsESaIS7_EE9_M_insertEPSt18_Rb_tree_node_baseSE_RKS7_ fun:_ZNSt8_Rb_treeISsSt4pairIKSsSt3setIiSt4lessIiESaIiEEESt10_Select1stIS7_ES3_ISsESaIS7_EE13insert_uniqueESt17_Rb_tree_iteratorIS7_ERKS7_ fun:_ZNSt3mapISsSt3setIiSt4lessIiESaIiEES1_ISsESaISt4pairIKSsS4_EEE6insertESt17_Rb_tree_iteratorIS8_ERKS8_ fun:_ZNSt3mapISsSt3setIiSt4lessIiESaIiEES1_ISsESaISt4pairIKSsS4_EEEixERS7_ fun:_ZN23ExtensionMessageService24DispatchEventToRenderersERKSsS1_bRK4GURL fun:_ZL13DispatchEventP7ProfilePKcSs fun:_ZL26DispatchSimpleBrowserEventP7ProfileiPKc fun:_ZN27ExtensionBrowserEventRouter17OnBrowserRemovingEPK7Browser fun:_ZN11BrowserList13RemoveBrowserEP7Browser fun:_ZN7BrowserD0Ev fun:object_cxxDestructFromClass fun:_ZN12_GLOBAL__N_113ZombieDeallocEP11objc_objectP13objc_selector fun:-[NSResponder dealloc] fun:-[NSWindowController dealloc] fun:-[BrowserWindowController dealloc] fun:-[NSWindowController release] fun:__delayedPerformCleanup fun:CFRunLoopTimerInvalidate fun:CFRunLoopRunSpecific } , with c++filt __ZNSt3mapISsSt3setIiSt4lessIiESaIiEES1_ISsESaISt4pairIKSsS4_EEEixERS7_ being map::operator[] and the symbol above it being map::insert(). (e.g. http://build.chromium.org/buildbot/memory/builders/Chromium%20Mac%20UI%20(valgrind)(3)/builds/3538/steps/memory%20test:%20ui/logs/stdio ). Seems to happen only on mac. This shouldn't leak, but maybe we're hitting an STL leak (I tried to build a reduced test case for a few minutes and failed). Maybe it goes away with this. BUG=none TEST=One fewer "Suppression:" line on mac ui_tests valgrind bots (2 instead of 3 atm). TBR=mpcomplete Review URL: http://codereview.chromium.org/2870060 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@52995 0039d316-1c4b-4281-b951-d872f2087c98
* Add support for omnibox.onInputStarted and onInputCancelled.mpcomplete@chromium.org2010-07-021-0/+16
| | | | | | | | | | | | Also fix a bug where we'd keep an extension's old keyword even if it changed on upgrade/reload. BUG=46475 BUG=48091 Review URL: http://codereview.chromium.org/2807033 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@51540 0039d316-1c4b-4281-b951-d872f2087c98
* First pass at experimental omnibox API. There are plenty of rough edges and ↵mpcomplete@chromium.org2010-05-281-0/+6
| | | | | | | | | | | | | | | features to work on, but it's in a usable state. When an extension is installed that specifies an omnibox keyword in its manifest, we add that keyword to the user's list of Search Engines. The user can then edit this keyword later. I'm leveraging most of the original search engine keyword code. An extension keyword has a special URL that identifies it as an extension keyword. There is some special case code to treat these keywords slightly differently throughout the omnibox code. BUG=38884 Review URL: http://codereview.chromium.org/2078021 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@48503 0039d316-1c4b-4281-b951-d872f2087c98
* Replace CHECK(false) by LOG(FATAL) where appropriate.evan@chromium.org2010-05-051-2/+2
| | | | | | | | | The difference is that the error message doesn't contain "Assertion failed: false". Review URL: http://codereview.chromium.org/1970001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@46422 0039d316-1c4b-4281-b951-d872f2087c98
* Reland 44348 Add support for restricting broadcasting events to extensions ↵jochen@chromium.org2010-04-141-8/+11
| | | | | | | | | | | | based on host permissions BUG=38398 TEST=none TBR=jochen@chromium.org Review URL: http://codereview.chromium.org/1528038 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@44470 0039d316-1c4b-4281-b951-d872f2087c98