summaryrefslogtreecommitdiffstats
path: root/chrome/browser/extensions/extension_page_actions_module.h
Commit message (Collapse)AuthorAgeFilesLines
* Refactor browserAction API and pageAction APIcduvall@chromium.org2012-03-171-97/+0
| | | | | | | | | | | | | | Created a new class ExtensionActionFunction that allows BrowserActionFunction and PageActionFunction to share much of their code. PageActionFunction still has a lot of pageAction specific code for enabling/disabling. BUG=118060 TEST=*BrowserAction*, *PageAction* Review URL: http://codereview.chromium.org/9704004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@127371 0039d316-1c4b-4281-b951-d872f2087c98
* Add OVERRIDE to chrome/browser/extensions/.avi@chromium.org2011-11-211-11/+11
| | | | | | | | | BUG=104314 TEST=no change Review URL: http://codereview.chromium.org/8473003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@110919 0039d316-1c4b-4281-b951-d872f2087c98
* Virtual destructors should have virtual keyword.hans@chromium.org2011-05-251-10/+10
| | | | | | | | | | | | | | | | | Make sure user-declared virtual destructors always have the virtual keyword. The Clang style-check plugin will check for this soon. No functionality change: virtual is only added to destructors that are already implicitly virtual. Also fix a couple of in-line destructor definitions. BUG=83408 TEST=none Review URL: http://codereview.chromium.org/7064033 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@86587 0039d316-1c4b-4281-b951-d872f2087c98
* Get rid of extensions dependency from content\browser.jam@chromium.org2011-04-041-2/+2
| | | | | | | BUG=76789 Review URL: http://codereview.chromium.org/6693054 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@80315 0039d316-1c4b-4281-b951-d872f2087c98
* `#pragma once` for app, base, chrome, gfx, ipc, net, skia, viewsthakis@chromium.org2010-07-261-0/+1
| | | | | | | | | BUG=50273 TEST=everything still builds, build is 10% faster on windows, same speed on mac/linux TBR: erg git-svn-id: svn://svn.chromium.org/chrome/trunk/src@53716 0039d316-1c4b-4281-b951-d872f2087c98
* Allow extensions to add, remove, or change their page action popup.skerner@chromium.org2010-01-281-0/+17
| | | | | | | | | | | A similar change will be made for browser action popups. BUG=27526 TEST=Added unit tests. Manual testing on linux. Review URL: http://codereview.chromium.org/545068 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@37353 0039d316-1c4b-4281-b951-d872f2087c98
* Revert "Revert r31175 r31176 r31187"hclam@chromium.org2009-11-061-0/+10
| | | | | | | | | | | | The bustage seems to be a WebKit change upstream. It is not reverted in WebKit and merger. So bring the innocent change back in. TBR=jam TEST=green tree Review URL: http://codereview.chromium.org/375009 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31214 0039d316-1c4b-4281-b951-d872f2087c98
* Rever r31175 r31176 r31187hclam@chromium.org2009-11-061-10/+0
| | | | | | | | | | | XP tests are failing, the guess is r31175 and r31176. TBR=beng TEST=XP tests go green Review URL: http://codereview.chromium.org/376008 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31201 0039d316-1c4b-4281-b951-d872f2087c98
* Sixth patch in making destructors of refcounted objects private.jam@chromium.org2009-11-061-0/+10
| | | | | | | | BUG=26749 Review URL: http://codereview.chromium.org/370001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31176 0039d316-1c4b-4281-b951-d872f2087c98
* Replace ExtensionAction with ExtensionAction2.aa@chromium.org2009-10-271-2/+2
| | | | | | | | BUG=24472 Review URL: http://codereview.chromium.org/337035 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30172 0039d316-1c4b-4281-b951-d872f2087c98
* Move page actions over to ExtensionAction2 and get rid ofaa@chromium.org2009-10-271-5/+3
| | | | | | | | | | | | | extension_action.*. Final bit of refactor will be to rename ExtensionAction2 to ExtensionAction will be the next CL. BUG=24472,25844 Review URL: http://codereview.chromium.org/332021 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30133 0039d316-1c4b-4281-b951-d872f2087c98
* Implement new page action API.mpcomplete@chromium.org2009-10-161-0/+46
| | | | | | | | | | | Still no actual drawing code for badges, though. BUG=24635 TEST=Load the sample test_page_action extension and click the page action to cycle through various states. Review URL: http://codereview.chromium.org/269079 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29335 0039d316-1c4b-4281-b951-d872f2087c98
* Small cleanup to extension function registration to avoid scattered definitions.mpcomplete@chromium.org2009-10-141-0/+2
| | | | | | | | BUG=no Review URL: http://codereview.chromium.org/274059 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29059 0039d316-1c4b-4281-b951-d872f2087c98
* Adding the ability to remove page actions.BUG=NoneTEST=unit test.finnur@chromium.org2009-06-221-1/+10
| | | | | | Review URL: http://codereview.chromium.org/131003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18910 0039d316-1c4b-4281-b951-d872f2087c98
* This is the first part of the PageAction implementation. More work is ↵finnur@chromium.org2009-05-011-0/+14
required, but this is a good checkpoint. Design doc: http://dev.chromium.org/developers/design-documents/extensions/page-actions-api This checkin only covers Tab scoped page actions (not type "permanent"). It works end to end (if you have an extension that supplies the page action info -- I created an RSS page action that links to Google Reader). Please note that TabIndex is hard coded to 0 until the extension system can provide the tab id to the extensions (which I understand is in progress). This means that page action(s) only show up for the first tab in the tabstrip. :) BUG=None TEST=There is a unit test for the API, but apart from that it is not possible to test this manually without writing an extension that adds a PageAction. My RSS page action is not ready to be checked in but I can provide it if there is interest in a sneak preview during review/QA. Review URL: http://codereview.chromium.org/99253 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15105 0039d316-1c4b-4281-b951-d872f2087c98
generated by cgit v1.1 at 2025-02-13 02:24:43 +0000