| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
|
|
|
|
| |
This should be much safer than the old idiom.
BUG=none
Review URL: https://chromiumcodereview.appspot.com/11567017
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@173518 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
This makes lots of code easier. The conversion from policy to prefs is
now done in the right place, reporting errors in about:policy.
BUG=chromium:166067
TEST=unit tests.
Review URL: https://codereview.chromium.org/11566024
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@173151 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
ordinal we have might be invalid.
BUG=166037
Review URL: https://chromiumcodereview.appspot.com/11570013
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@173090 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=165337
Review URL: https://chromiumcodereview.appspot.com/11530015
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@172736 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=chromium:165202
TEST=Unit tests, manual: configure the policy and try to add extension of non-allowed type.
Review URL: https://chromiumcodereview.appspot.com/11512004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@172397 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
extension uninstall.
BUG=85127
Review URL: https://chromiumcodereview.appspot.com/11419307
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@172278 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
OnExtensionInstalled().
BUG=none
Review URL: https://chromiumcodereview.appspot.com/11465016
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@171956 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
> Revert 171079 - investigating perf regression.
>
> > Make Blacklist::IsBlacklist asynchronous (it will need to be for safe
> > browsing), and unravel the knots that result from it:
> > - Decouple it from the admin policy.
> > - Take the other half of blacklist logic out of ExtensionPrefs and into
> > Blacklist.
> > - Fix bug where blacklisted extensions couldn't be re-installed (let alone
> > re-enabled) if they get taken off the blacklist.
> >
> >
> > TBR=sky@chromium.org
> > BUG=154149,156750
> >
> >
> > Review URL: https://chromiumcodereview.appspot.com/11415216
>
> TBR=kalman@chromium.org
>
> Review URL: https://codereview.chromium.org/11478003
TBR=kalman@chromium.org
Review URL: https://codereview.chromium.org/11465014
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@171642 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
> Make Blacklist::IsBlacklist asynchronous (it will need to be for safe
> browsing), and unravel the knots that result from it:
> - Decouple it from the admin policy.
> - Take the other half of blacklist logic out of ExtensionPrefs and into
> Blacklist.
> - Fix bug where blacklisted extensions couldn't be re-installed (let alone
> re-enabled) if they get taken off the blacklist.
>
>
> TBR=sky@chromium.org
> BUG=154149,156750
>
>
> Review URL: https://chromiumcodereview.appspot.com/11415216
TBR=kalman@chromium.org
Review URL: https://codereview.chromium.org/11478003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@171554 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Many things were calling IsMetroProcess() when the intent was really to turn things ON/OFF for Metro Chrome, this does not apply to Metro Ash however.
Details of how this has been decoupled can be found at https://docs.google.com/spreadsheet/ccc?key=0AtwXJ4IPPZBAdEdaWUpLYk9IM3I1bTJleFJobXN3Z2c (more decoupling will be needed later and has been listed in separate columns on this spreadsheet; however for now this CL only applies the first column).
Also introduces win8_util where some other win8-specific things currently in base should eventually also be refactored into.
BUG=151718
TEST=This makes a bunch of things just work now in Metro Ash :).
Review URL: https://chromiumcodereview.appspot.com/11411286
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@171366 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
browsing), and unravel the knots that result from it:
- Decouple it from the admin policy.
- Take the other half of blacklist logic out of ExtensionPrefs and into
Blacklist.
- Fix bug where blacklisted extensions couldn't be re-installed (let alone
re-enabled) if they get taken off the blacklist.
TBR=sky@chromium.org
BUG=154149,156750
Review URL: https://chromiumcodereview.appspot.com/11415216
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@171079 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
downgrades.
There is a possible case where users may have their profile populated with manifest
information to track the version of a component extension and then start up an old
version of Chrome reading that profile. Older versions of chome (since r49016 in
mid-2010) have had a check to treat a blank 'state' as a component extension. We can
rely on that to let old Chrome versions continue to open profiles with richer
manifest information for component extensions.
BUG=157717
TEST=Open a chrome from before r170137 on a profile created from a chrome after this CL.
Browser should not DCHECK/NOTREACHED in GetInstalledExtensionInfo
Review URL: https://chromiumcodereview.appspot.com/11428082
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@170370 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This ensures, e.g., that background pages for component extensions are run and
that their event listeners are registered appropriately. The change also saves
manifest information into profile preferences for component applications so that
the version can be tracked, which was not previously done.
BUG=157717
TEST=browser_test PlatformAppBrowserTest.ComponentAppBackgroundPages
Review URL: https://chromiumcodereview.appspot.com/11275069
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@170137 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=148465
TBR=xiyuan
Review URL: https://chromiumcodereview.appspot.com/11361209
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@168750 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
new classes: Blacklist for the blacklist logic, and
StandardManagementPolicyProvider for the management policy component.
This is a preliminary step to making the extension blacklist backed by safe
browsing. Dumb blacklisting code will still live in ExtensionPrefs until the
migration is complete.
BUG=154149
TBR=ben@chromium.org
Review URL: https://chromiumcodereview.appspot.com/11410048
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@168020 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This doesn't create an extensions gyp target, or a module with a public API.
It does set of DEPS rules and seems like it will make it easier for people to
write correctly layered code today, while we are in transition.
BUG=159265
TBR=ben@chromium.org
Review URL: https://codereview.chromium.org/11410015
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@167454 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
ShouldDisplayIn{AppLauncher,NewTabPage}.
Adds manifest property show_in_new_tab_page (default value=show_in_launcher)
to give component apps a way to indicate that they should only appear in the
app launcher, and not the browser new tab page.
BUG=158880
TEST=unit_tests --gtest_filter=ExtensionTest.DisplayInXManifestProperties, and (on Windows)
settings app icon does appear on app launcher: ./chrome --user-data-dir=empty --enable-settings-app --show-app-list
settings app icon does not appear on NTP: ./chrome --user-data-dir=empty --enable-settings-app
Review URL: https://chromiumcodereview.appspot.com/11362081
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@166849 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
For Apps and Extensions with a lazy background page, this will delay installing
an update until the background page gets unloaded (or next chrome restart).
Also adds a chrome.runtime.onUpdateAvailable event which is fired when an update is
available but isn't being installed immediately because the app is not idle.
It doesn't change anything yet for Extensions with a persistent background page
(or extensions without a background page at all). Those still get updated as soon
as an update is found.
BUG=37971
BUG=143260
TBR=nick@chromium.org
Review URL: https://chromiumcodereview.appspot.com/11293002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@166358 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
OVERRIDE when they are overridden.
BUG=none
Review URL: https://chromiumcodereview.appspot.com/11338006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@165659 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
Obey the 'exclude from wipeout' pref.
Make sure we have room to show just wipeout banner on its own (with or without the managed-mode banner).
TBR=mihaip
BUG=154624
TEST=Setup an extension to install through Windows registry. Then run Chrome with --prompt-for-external-extensions=1 and acknowledge the new extension as external. Run with --sideload-wipeout=1 and make sure the extension is not wiped out. Also make sure that when an extension is wiped out that the banner on the chrome://extensions page doesn't overlap the action buttons below it.
Review URL: https://codereview.chromium.org/11338035
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@165346 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
a new external extension (post-sideload UI). This is intended to be used by the
sideload wipeout UI.
BUG=154624
Review URL: https://chromiumcodereview.appspot.com/11236075
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@163690 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
to break dependencies back to Chrome.
This leaves the following in chrome/ for now, which will move later:
- PrefService, to move once sync dependencies and dependencies on
Chrome-specific pref stores are externalized.
- PrefNotifierImpl and PrefObserverMock, to move once
NotificationSource dependency is broken.
- PrefValueStore, to move once PrefModelAssociatior dependency is
externalized.
- ScopedUserPrefUpdate, to move once PrefService moves.
TBR=ben@chromium.org
BUG=155525
Review URL: https://chromiumcodereview.appspot.com/11243002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@163354 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=154624
TEST=None
Review URL: https://codereview.chromium.org/11189094
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@163350 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
mediaGalleries specific classes.
This changes the permission parsing code in Extension to support parsing
permissions like [{'fileSystem': ['write']}] as equivalent to
['fileSystem', 'fileSystem.write'].
BUG=147531
BUG=156125
Review URL: https://chromiumcodereview.appspot.com/11005002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@162882 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
- External extensions are installed initially disabled.
- Global error appears in menu, which will show an install dialog when clicked.
TBR=sky@chromium.org
BUG=137469,131510
Review URL: https://chromiumcodereview.appspot.com/11150002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@162380 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This adds the event chrome.app.runtime.onRestarted, which apps can use to
restore their state after a restart.
BUG=138676
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=156659
Review URL: https://chromiumcodereview.appspot.com/10875027
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@161827 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=135503
TBR=jhawkins@chromium.org
Review URL: https://codereview.chromium.org/11030042
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@161725 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
We added a new creation_flag for default apps was_installed_by_default,
but every time we add a new creation_flag, we need to update the installedLoader
as it does not directly pick the creation_flags but re-creates them
through other preferences.
To fix this, I added a new preference to save creation_flags in preference,
and read that directly.
BUG=152582
TBR=nick@chromium.org
Review URL: https://chromiumcodereview.appspot.com/10977048
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@160259 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
lifetime of the box itself, as opposed to ActionBoxMenuModel which is scoped to
the lifetime of the menu. Move business logic out of ActionBoxMenuModel and
into ActionBoxController.
The reason we need this is because some extension logic needs to be scoped to
the action box -- for example, we will need the commands API to affect the
action box when there isn't a menu open. We may also want to do something like
open up the action box and point at the extension when one is installed.
This logic could be implemented in UI code but that would be icky.
BUG=125307
Review URL: https://chromiumcodereview.appspot.com/10979014
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@159201 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
- Support more default app ordering than just web store app;
- Add default app ordering for ChromeOS;
- Add tests for default ordering;
BUG=149750
TEST=Verify it does not break NTP page on non-chromeos. And for chromeos, wait until app list CL that respects NTP ordering is landed.
R=csharp@chromium.org,asargent@chromium.org
Review URL: https://chromiumcodereview.appspot.com/10969044
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@158472 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Errors in preference files are not programming errors and can be caused in a few ways, for example when an experimental or in-development APIs permissions are renamed. Crashing developer builds in these cases is not helpful.
BUG=None
Review URL: https://chromiumcodereview.appspot.com/10958010
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@157726 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Chrome is updated.
BUG=148898
Review URL: https://chromiumcodereview.appspot.com/10941003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@157685 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This adds the event chrome.app.runtime.onRestarted, which apps can use to
restore their state after a restart.
BUG=138676,149727
Review URL: https://chromiumcodereview.appspot.com/10875027
TBR=sky@chromium.org
Review URL: https://chromiumcodereview.appspot.com/10905306
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@157076 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This adds the event chrome.app.runtime.onRestarted, which apps can use to
restore their state after a restart.
BUG=138676
Review URL: https://chromiumcodereview.appspot.com/10875027
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@156659 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Rename StringOrdinal to Ordinal, move it to sync/, and templatize it.
Make StringOrdinal be an instantiation of Ordinal that matches its
previous behavior.
Create NodeOrdinal, which is another instantiation of Ordinal for
the ordinal_in_parent field in SyncEntity.
Rework Ordinal to handle arbitrary byte ranges and to simplify the
interpolation code a bit.
Generalize StringOrdinal unit tests for Ordinal.
Update users of StringOrdinal to prepend syncer::.
BUG=145412
TBR=estade@chromium.org,jianli@chromium.org,brettw@chromium.org,
Review URL: https://chromiumcodereview.appspot.com/10920017
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@155368 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
way to remove/disable
the new window menu option which is done via JS in a subsequent CL.
Fixes bug http://code.google.com/p/chromium/issues/detail?id=146368
BUG=146368
R=aa
Review URL: https://chromiumcodereview.appspot.com/10905088
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@155062 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
makes it obsolete
BUG=125307
Review URL: https://chromiumcodereview.appspot.com/10894022
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@154328 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=138614
Review URL: https://chromiumcodereview.appspot.com/10855190
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@153554 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=143961
TEST=unit_tests
Review URL: https://chromiumcodereview.appspot.com/10834436
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@152658 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
APIPermission
BUG=130222
TEST=unit_tests
Review URL: https://chromiumcodereview.appspot.com/10837309
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@152549 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
auto-updated Google blacklist.
BUG=93246
TEST=unit_tests
Review URL: https://chromiumcodereview.appspot.com/10854009
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@152548 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=
Review URL: https://chromiumcodereview.appspot.com/10824344
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@152173 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=130222
TEST=unittest & browser_test
Review URL: https://chromiumcodereview.appspot.com/10692160
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@151956 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Use a bitmask to represent all the reasons an extension is disabled.
Switch to a new key in ExtensionPrefs for the bitmask.
When we init ExtensionPrefs, check for the old key, migrate the reason over
to the new key, and delete the old key.
BUG=142762
Review URL: https://chromiumcodereview.appspot.com/10828316
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@151785 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=125307
Review URL: https://chromiumcodereview.appspot.com/10827268
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@151670 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
just CL is getting too big
and need to share existing code with other developers.
BUG=125307
Review URL: https://chromiumcodereview.appspot.com/10533086
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@150869 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=NONE
Review URL: https://chromiumcodereview.appspot.com/10821077
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@150474 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Since platform apps always use isolated storage, they can't (silently) access
user data on other domains, so there's no need to prompt.
BUG=130680
R=aa@chromium.org
TBR=phajdan.jr@chromium.org,atwilson@chromium.org
Review URL: https://chromiumcodereview.appspot.com/10837060
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@149688 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=NONE
Review URL: https://chromiumcodereview.appspot.com/10824116
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@149658 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
For problem description and other info please see the BUG page.
This is for DictionaryValue.
BUG=138946
TEST=N/A (no fix & no new feature)
TBR=jar scottbyer achuith agl mnissler davemoore garykac akalin hans bulach phajdan.jr jamesr
Review URL: https://chromiumcodereview.appspot.com/10834004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@148833 0039d316-1c4b-4281-b951-d872f2087c98
|