summaryrefslogtreecommitdiffstats
path: root/chrome/browser/extensions/extension_tabs_module.cc
Commit message (Collapse)AuthorAgeFilesLines
* Make pink's TabContentsWrapper change compile on Windows.ben@chromium.org2010-11-181-32/+36
| | | | | | | | | | Code by pinkerton@, with modifications by evanm and myself to get it to build on windows/linux/chromeos. BUG=none TEST=none Review URL: http://codereview.chromium.org/4694008 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@66626 0039d316-1c4b-4281-b951-d872f2087c98
* Cleanup: Include browser.h -> ui/browser.h [Part 3].jhawkins@chromium.org2010-11-161-1/+1
| | | | | | | | | BUG=none TEST=none Review URL: http://codereview.chromium.org/5089001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@66338 0039d316-1c4b-4281-b951-d872f2087c98
* Cleanup: Remove chrome/browser/browser_navigator.* and references.jhawkins@chromium.org2010-11-121-1/+1
| | | | | | | | | BUG=none TEST=none Review URL: http://codereview.chromium.org/4840001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@65881 0039d316-1c4b-4281-b951-d872f2087c98
* Add pinned property to tabs.update and create.jstritar@chromium.org2010-11-081-14/+45
| | | | | | | | | | | Fire tabs.onUpdated event if a tab's pinned state changes. BUG=24781 TEST=ExtensionApiTest Review URL: http://codereview.chromium.org/3816005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@65379 0039d316-1c4b-4281-b951-d872f2087c98
* Fix bug with context menus in incognito mode.mpcomplete@chromium.org2010-11-021-2/+3
| | | | | | | | | | | | | | | | | If an extension uses "spanning" mode, the context menu items are shared between profiles. If an extension uses "split" mode, the items are separate per profile. In either case, they only appear in incognito if the extension is enabled in incognito. Also fixed a minor bug, so that tabs.create now can open extension URLs in incognito if the extension uses split mode. BUG=61147 TEST=see bug for repro steps; context menu items should work in incognito mode Review URL: http://codereview.chromium.org/4090011 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@64812 0039d316-1c4b-4281-b951-d872f2087c98
* Make all browser code use browser::Navigate to open tabs.ben@chromium.org2010-11-021-15/+16
| | | | | | | | | BUG=none TEST=existing unittests. Also, test all places where new tabs and windows are opened from UI, e.g. links in options, new tab button, Ctrl+T, popup windows, etc. Review URL: http://codereview.chromium.org/3834002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@64745 0039d316-1c4b-4281-b951-d872f2087c98
* Part 3 of immutable Extension refactor.mpcomplete@chromium.org2010-10-291-3/+3
| | | | | | | | | | | | | Make ExtensionsService hold const Extension pointers only. This ensures that extensions can't be modified after they're created, and lets us share them between threads. BUG=56558 TEST=no functional change Review URL: http://codereview.chromium.org/4138006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@64517 0039d316-1c4b-4281-b951-d872f2087c98
* Convert LOG(INFO) to VLOG(1) - chrome/browser/extensions/.pkasting@chromium.org2010-10-221-2/+2
| | | | | | | | BUG=none TEST=none Review URL: http://codereview.chromium.org/4003001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@63534 0039d316-1c4b-4281-b951-d872f2087c98
* Change to use the new FORMAT_SkBitmap when encoding SkBitmap to jpeg.klobag@chromium.org2010-10-201-1/+1
| | | | | | Review URL: http://codereview.chromium.org/3757008 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@63270 0039d316-1c4b-4281-b951-d872f2087c98
* Tab array support for chrome.windows.createjstritar@chromium.org2010-10-141-11/+38
| | | | | | | | | | | With this change, a user can pass in an individual url or a list of urls to be opened with the new window. BUG=53517 TEST=ExtensionApiTest Review URL: http://codereview.chromium.org/3772004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@62633 0039d316-1c4b-4281-b951-d872f2087c98
* Fix issue where opening a new tab using the ext API would not focus the omnibox.andybons@chromium.org2010-10-081-14/+9
| | | | | | | | | | | The current behavior was correct for all other pages (focusing the contents, not the omnibox) but was not for the new tab page. BUG=40977 TEST=see bug for some example reduced test cases. Review URL: http://codereview.chromium.org/3579013 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@61984 0039d316-1c4b-4281-b951-d872f2087c98
* ExtensionApiTest.Tabs: fix window type, re-enable testevan@chromium.org2010-10-061-4/+4
| | | | | | | | | | | | | | | | | | | When you created a window with type='popup', the resulting window.type was incorrectly 'app'. After discussion, we concluded that a popup app window should be called a popup. This was a real regression that was masked by the test being marked flaky for unrelated reasons. :( (While I'm at it, fixed the ordering of some assertEq's to make the error messages more understandable.) BUG=48920 TEST=ExtensionApiTest.Tabs Review URL: http://codereview.chromium.org/3594014 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@61722 0039d316-1c4b-4281-b951-d872f2087c98
* Add chrome.windows.update({focused:true});aa@chromium.org2010-10-051-1/+11
| | | | | | | | | BUG=31434 TEST=browser_tests --gtest_filter=ExtensionApiTest.*Tabs Review URL: http://codereview.chromium.org/3584010 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@61555 0039d316-1c4b-4281-b951-d872f2087c98
* Replace Browser::AddTabWithURL(...) with:ben@chromium.org2010-10-051-7/+6
| | | | | | | | | | | | | | - Browser::AddSelectedTabWithURL(const GURL& url, PageTransition::Type transition) -> A good many callsites just wanted a way to open a tab somewhere and select it. - Browser::AddTabWithURL(AddTabWithURLParams* params) -> For the callsites with specialized needs, this new signature allows the parameter set to change as features are added without having to update a bunch of callers every time. BUG=none TEST=existing unit tests Review URL: http://codereview.chromium.org/3599006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@61517 0039d316-1c4b-4281-b951-d872f2087c98
* chromium-os:5166 Panel/popup cleanup for ChromeOSstevenjb@google.com2010-10-041-11/+24
| | | | | | | | | | | | | | | | | | | | * Move size based disposition override for ChromeOS from tab_container to browser. * TYPE_APP_PANEL |= TYPE_POPUP so that special popup behavior applies to panels. * Removed confusing BrowserFrameChromeos::IsPanel(), replaced with BrowserView::IsBrowserTypePopup() calls. * Replaced now redundant checks against panel or popup types with 'browser->type() & Browser::TYPE_POPUP'. * Added size limiting code to PanelBrowserView. * Modified CreateWindowFunction::RunImpl() to create TYPE_APP_POPUP windows instead of TYPE_POPUP. BUG=http://code.google.com/p/chromium-os/issues/detail?id=5166 TEST=Test spawning popups/panels/tabs from web pages (e.g. gmail), extensions (e.g. chat manager), and apps More info: https://docs.google.com/document/edit?id=14nBjW6gHJW0kk44o8Z8vfDSnDi0ZT1sUU74Zc5wmwIQ&hl=en&authkey=CKT6-O8I !!! This commit didn't go through !!! Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=29fe99e Review URL: http://codereview.chromium.org/3449007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@61427 0039d316-1c4b-4281-b951-d872f2087c98
* Attempt2: Component extensions (and whitelisted extensions) specifying ↵finnur@chromium.org2010-10-041-2/+10
| | | | | | | | | | | | | | | <all_urls> in their Extension match pattern should be allowed to run content scripts everywhere (including chrome://, chrome-extension://, about: and gallery pages. The intent was to also allow these extensions to specify more granular permissions, such as about:version instead of <all_urls>, but that didn't make the cut this time. This CL also enables <all_urls> for host permissions for regular extensions, which was disabled before. Note: That still doesn't give them permission to script the gallery and chrome:// pages, etc. BUG=36275 TEST=Working on it right now. Review URL: http://codereview.chromium.org/3585009 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@61359 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 61323 - Component extensions (and whitelisted extensions) specifying ↵finnur@chromium.org2010-10-031-10/+2
| | | | | | | | | | | | | | | | | | <all_urls> in their Extension match pattern should be allowed to run content scripts everywhere (including chrome://, chrome-extension://, about: and gallery pages. The intent was to also allow these extensions to specify more granular permissions, such as about:version instead of <all_urls>, but that didn't make the cut this time. This CL also enables <all_urls> for host permissions for regular extensions, which was disabled before. Note: That still doesn't give them permission to script the gallery and chrome:// pages, etc. BUG=36275 TEST=New: ExtensionBrowserTest.AllUrlsWhitelistedExtension, ExtensionBrowserTest.AllUrlsRegularExtensions Review URL: http://codereview.chromium.org/3440027 TBR=finnur@chromium.org Review URL: http://codereview.chromium.org/3557006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@61327 0039d316-1c4b-4281-b951-d872f2087c98
* Component extensions (and whitelisted extensions) specifying <all_urls> in ↵finnur@chromium.org2010-10-031-2/+10
| | | | | | | | | | | | | | | their Extension match pattern should be allowed to run content scripts everywhere (including chrome://, chrome-extension://, about: and gallery pages. The intent was to also allow these extensions to specify more granular permissions, such as about:version instead of <all_urls>, but that didn't make the cut this time. This CL also enables <all_urls> for host permissions for regular extensions, which was disabled before. Note: That still doesn't give them permission to script the gallery and chrome:// pages, etc. BUG=36275 TEST=New: ExtensionBrowserTest.AllUrlsWhitelistedExtension, ExtensionBrowserTest.AllUrlsRegularExtensions Review URL: http://codereview.chromium.org/3440027 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@61323 0039d316-1c4b-4281-b951-d872f2087c98
* Rip out phantom tabs and corresponding unit tests.andybons@chromium.org2010-10-021-9/+1
| | | | | | | | | | | Also get rid of the type enum passed to TabReplacedAt since it can only be one option after phantom tabs are removed. BUG=none TEST=compile? good. pass tests? good. Review URL: http://codereview.chromium.org/3539010 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@61303 0039d316-1c4b-4281-b951-d872f2087c98
* Do not create an incogntio profile as side effect when listing all tabs/windows.jochen@chromium.org2010-09-211-3/+6
| | | | | | | | | BUG=55479 TEST=DontCreateIncognitoProfile Review URL: http://codereview.chromium.org/3412005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@60039 0039d316-1c4b-4281-b951-d872f2087c98
* extensions: Append base:: in the StringPrintf calls.tfarina@chromium.org2010-09-211-1/+3
| | | | | | | | | | | (Note this is a TODO in string_util.h) BUG=None TEST=trybots Review URL: http://codereview.chromium.org/3415015 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@60012 0039d316-1c4b-4281-b951-d872f2087c98
* Revert r56902aa@chromium.org2010-08-201-1/+1
| | | | | | TBR=rafaelw@chromium.org git-svn-id: svn://svn.chromium.org/chrome/trunk/src@56907 0039d316-1c4b-4281-b951-d872f2087c98
* Remove TYPE_EXTENSION_APP. Experiment failed. It looks like the layout ↵aa@chromium.org2010-08-201-1/+1
| | | | | | | | changes have already been removed. Review URL: http://codereview.chromium.org/3149029 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@56902 0039d316-1c4b-4281-b951-d872f2087c98
* Convert wide strings in extension_tabs_module_constants.viettrungluu@chromium.org2010-08-131-1/+1
| | | | | | | | | BUG=23581 TEST=builds and passes tests Review URL: http://codereview.chromium.org/3181010 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@55995 0039d316-1c4b-4281-b951-d872f2087c98
* Clone of issue 2941001. See initial review below.twiz@google.com2010-08-121-4/+7
| | | | | | | | | | | | | | http://codereview.chromium.org/2941001 Initial submit broke the chromeos build. This patch includes the original change, and fixes to compile ChromeOs properly. BUG=None TEST=None Review URL: http://codereview.chromium.org/2819086 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@55951 0039d316-1c4b-4281-b951-d872f2087c98
* Make prefs use std::string for keys rather than wstrings.viettrungluu@chromium.org2010-08-111-1/+1
| | | | | | | | | | | Much remains to be converted. BUG=23581 TEST=builds and passes tests Review URL: http://codereview.chromium.org/3076037 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@55660 0039d316-1c4b-4281-b951-d872f2087c98
* FBTF: Clean up some headers in tab_contents_delegate.h.erg@google.com2010-08-101-0/+1
| | | | | | | | | BUG=none TEST=none Review URL: http://codereview.chromium.org/3145001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@55635 0039d316-1c4b-4281-b951-d872f2087c98
* Move the number conversions from string_util to a new file.brettw@chromium.org2010-07-301-5/+6
| | | | | | | | | | | | | Use the base namespace in the new file. Update callers. I removed all wstring variants and also the string->number ones that ignore the return value. That encourages people to write code and forget about error handling. TEST=included unit tests BUG=none Review URL: http://codereview.chromium.org/3056029 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@54355 0039d316-1c4b-4281-b951-d872f2087c98
* Deal with alpha values when building PNG in chrome.tabs.captureVisibleTab().skerner@chromium.org2010-07-191-7/+8
| | | | | | | | | BUG=44758 TEST=ExtensionApiTest.CaptureVisibleTab, try taking a snapshot of google.com on mac, linux, win. Review URL: http://codereview.chromium.org/2819050 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@52931 0039d316-1c4b-4281-b951-d872f2087c98
* Fix a regression with chrome.tabs.create() with a chrome-extension URL whenmpcomplete@chromium.org2010-06-301-3/+7
| | | | | | | | | | only an incognito window was visible. BUG=41087 Review URL: http://codereview.chromium.org/2881004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@51283 0039d316-1c4b-4281-b951-d872f2087c98
* Reland - Fix NULL dereference in ExtensionTabsModule.rafaelw@chromium.org2010-06-301-16/+18
| | | | | | | | | | | | | | | | original review: http://codereview.chromium.org/2885006 ---------- This is almost certainly caused by a start-up or shut-down race, but CreateWindowValue doesn't have much meaning without a window attached to the browser, so just return an error in those cases BUG=47808 TEST=none. TBR=asargent Review URL: http://codereview.chromium.org/2858036 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@51213 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 51161 - Fix NULL dereference in ExtensionTabsModule.rafaelw@google.com2010-06-291-17/+15
| | | | | | | | | | | | | | This is almost certainly caused by a start-up or shut-down race, but CreateWindowValue doesn't have much meaning without a window attached to the browser, so just return an error in those cases BUG=47808 TEST=none Review URL: http://codereview.chromium.org/2885006 TBR=rafaelw@chromium.org Review URL: http://codereview.chromium.org/2868039 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@51165 0039d316-1c4b-4281-b951-d872f2087c98
* Fix NULL dereference in ExtensionTabsModule.rafaelw@chromium.org2010-06-291-15/+17
| | | | | | | | | | | This is almost certainly caused by a start-up or shut-down race, but CreateWindowValue doesn't have much meaning without a window attached to the browser, so just return an error in those cases BUG=47808 TEST=none Review URL: http://codereview.chromium.org/2885006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@51161 0039d316-1c4b-4281-b951-d872f2087c98
* Attempt 2 at Moving Browser::AddTypes to TabStripModel. The firstsky@chromium.org2010-06-281-4/+5
| | | | | | | | | | | | | | | | | | | | | | | | | attempt caused some flakiness on the new tab warm startup test. The only difference between this and the last is that I'm leaving some suspcious code in TabStripModel::InsertTabContents and Browser::AddTabWithURL. I'll try to isolate why those changes caused flakiness after I land the rest. Here's the description: Moves Browser::AddTypes to TabStripModel. This patch is primarily cleanup before I fix 29933, but has a couple of interesting bits beyond the enum change: . AddTabContents now supports adding pinned. . Converted InsertTabContents call in extensionstabmodule to pass in nothing (Rafael said old code was wrong). BUG=29933 TEST=none TBR=ben@chromium.org Review URL: http://codereview.chromium.org/2866024 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@50981 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 50752 - Moves Browser::AddTypes to TabStripModel. This patch is primarilysky@chromium.org2010-06-241-5/+4
| | | | | | | | | | | | | | | | | | | | | | | | cleanup before I fix 29933, but has a couple of interesting bits beyond the enum change: . AddTabContents now supports adding pinned. . Nuked duplicate code in Browser::addTabWithURL that invoked wasHidden on the TabContents. This code is already in TabStripModel. . Moved code for setting visibility of tabcontents from TabStripModel::AddTabContents to InsertTabContentsAt. Since everything ends up in InsertTabContentsAt it should be there. . Converted InsertTabContents call in extensionstabmodule to pass in nothing (Rafael said old code was wrong). BUG=29933 TEST=none Review URL: http://codereview.chromium.org/2863021 TBR=sky@chromium.org Review URL: http://codereview.chromium.org/2849025 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@50776 0039d316-1c4b-4281-b951-d872f2087c98
* Moves Browser::AddTypes to TabStripModel. This patch is primarilysky@chromium.org2010-06-241-4/+5
| | | | | | | | | | | | | | | | | | | | | cleanup before I fix 29933, but has a couple of interesting bits beyond the enum change: . AddTabContents now supports adding pinned. . Nuked duplicate code in Browser::addTabWithURL that invoked wasHidden on the TabContents. This code is already in TabStripModel. . Moved code for setting visibility of tabcontents from TabStripModel::AddTabContents to InsertTabContentsAt. Since everything ends up in InsertTabContentsAt it should be there. . Converted InsertTabContents call in extensionstabmodule to pass in nothing (Rafael said old code was wrong). BUG=29933 TEST=none Review URL: http://codereview.chromium.org/2863021 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@50752 0039d316-1c4b-4281-b951-d872f2087c98
* Require user opt-in before allowing content script injection on file URLs.mpcomplete@chromium.org2010-06-241-1/+2
| | | | | | | | BUG=47180 Review URL: http://codereview.chromium.org/2809034 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@50737 0039d316-1c4b-4281-b951-d872f2087c98
* Fix a regression where tabs.create() would focus the tab's window even ifmpcomplete@chromium.org2010-06-031-1/+0
| | | | | | | | | | selected is false. BUG=42531 Review URL: http://codereview.chromium.org/2483003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@48872 0039d316-1c4b-4281-b951-d872f2087c98
* Clean up calls like "gfx::Rect(0, 0, size().width(), size().height()".erg@chromium.org2010-05-261-2/+1
| | | | | | | | | | | | The caller can use the much shorter "gfx::Rect(size())", since gfx::Rect has a constructor that just takes a Size. BUG=none TEST=none Review URL: http://codereview.chromium.org/2204001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@48283 0039d316-1c4b-4281-b951-d872f2087c98
* Prevent tabs.move from moving tabs to or from anything but normal (tabbed) ↵rafaelw@chromium.org2010-05-251-0/+10
| | | | | | | | | | | windows BUG=22651 TEST=NONE Review URL: http://codereview.chromium.org/2173003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@48211 0039d316-1c4b-4281-b951-d872f2087c98
* Change the code based on Raf's feedback.arv@chromium.org2010-05-221-7/+5
| | | | | | | | BUG=None TEST=Unit tests Review URL: http://codereview.chromium.org/2074022 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@47980 0039d316-1c4b-4281-b951-d872f2087c98
* Update extension functions to always pass a list of arguments, even when one ↵arv@chromium.org2010-05-211-37/+31
| | | | | | | | | | | argument was passed. BUG=36301 TEST=Updated tests and ran all the existing tests. Review URL: http://codereview.chromium.org/2137012 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@47972 0039d316-1c4b-4281-b951-d872f2087c98
* Remove histogram collection evaluating impact of changing extension url ↵rafaelw@chromium.org2010-05-211-41/+9
| | | | | | | | | | | | | resolution. This reverts the histogram collection part of http://codereview.chromium.org/1605005. BUG=21909 TEST=none Review URL: http://codereview.chromium.org/2082016 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@47969 0039d316-1c4b-4281-b951-d872f2087c98
* fix chrome.tabs.onUpdated bugs, add browsertest.rafaelw@chromium.org2010-05-191-21/+4
| | | | | | | | | | | | | | This CL addresses a few issues related to the behavior of the onUpdated event. Issue 1: The page re-entering the load state and the completing was causing multiple 'complete' status events to be fired. We now only report the first 'complete' after the didNavigate message is fired (iframe navigation, for example). Issue 2: We were initializing the URL when the TabEntry was created, and this caused us to fail to send the url with the first navigation because we thought it wasn't changing. BUG=27208,37149 Review URL: http://codereview.chromium.org/2111010 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@47717 0039d316-1c4b-4281-b951-d872f2087c98
* Have extension call windows.getLastFocused include incognito windows if thempcomplete@chromium.org2010-04-301-1/+2
| | | | | | | | | | extension is enabled for incognito. BUG=39113 Review URL: http://codereview.chromium.org/1789010 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@46076 0039d316-1c4b-4281-b951-d872f2087c98
* Nukes one of the AddTabWithURL variants.sky@chromium.org2010-04-291-3/+5
| | | | | | | | | BUG=none TEST=none Review URL: http://codereview.chromium.org/1736022 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@45902 0039d316-1c4b-4281-b951-d872f2087c98
* Reland r45520. This adds a new browser type: EXTENSION_APP thataa@chromium.org2010-04-261-1/+1
| | | | | | | | | has a larger titlebar and a big icon, along with a tabstrip, but no titlebar. Review URL: http://codereview.chromium.org/1774003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@45566 0039d316-1c4b-4281-b951-d872f2087c98
* Sigh. Revert r45520. Breaks ChromeOS.aa@chromium.org2010-04-241-1/+1
| | | | | | TBR=jamesr@chromium.org git-svn-id: svn://svn.chromium.org/chrome/trunk/src@45523 0039d316-1c4b-4281-b951-d872f2087c98
* This adds a new kind of browser window: EXTENSION_APP. EXTENSION_APP windows ↵aa@chromium.org2010-04-241-1/+1
| | | | | | | | have a bigger titlebar with a giant icon and title, and supports tabs. Review URL: http://codereview.chromium.org/1730010 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@45520 0039d316-1c4b-4281-b951-d872f2087c98
* Fix a bug where opening an extension options tab from a sole incognito windowmpcomplete@chromium.org2010-04-161-0/+1
| | | | | | | | | | would fail to show the new window. BUG=41526 Review URL: http://codereview.chromium.org/1545041 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@44781 0039d316-1c4b-4281-b951-d872f2087c98