| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
|
|
|
| |
Code by pinkerton@, with modifications by evanm and myself to get it to build on windows/linux/chromeos.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/4694008
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@66626 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/5089001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@66338 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/4840001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@65881 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Fire tabs.onUpdated event if a tab's pinned state changes.
BUG=24781
TEST=ExtensionApiTest
Review URL: http://codereview.chromium.org/3816005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@65379 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
If an extension uses "spanning" mode, the context menu items are shared
between profiles. If an extension uses "split" mode, the items are separate
per profile. In either case, they only appear in incognito if the extension is
enabled in incognito.
Also fixed a minor bug, so that tabs.create now can open extension URLs in
incognito if the extension uses split mode.
BUG=61147
TEST=see bug for repro steps; context menu items should work in incognito mode
Review URL: http://codereview.chromium.org/4090011
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@64812 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=existing unittests. Also, test all places where new tabs and windows are opened from UI, e.g. links in options, new tab button, Ctrl+T, popup windows, etc.
Review URL: http://codereview.chromium.org/3834002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@64745 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Make ExtensionsService hold const Extension pointers only. This ensures that
extensions can't be modified after they're created, and lets us share them
between threads.
BUG=56558
TEST=no functional change
Review URL: http://codereview.chromium.org/4138006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@64517 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/4003001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@63534 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/3757008
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@63270 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
With this change, a user can pass in an individual url or a list of urls to be opened with the new window.
BUG=53517
TEST=ExtensionApiTest
Review URL: http://codereview.chromium.org/3772004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@62633 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
The current behavior was correct for all other pages (focusing the contents, not the omnibox) but was not for the new tab page.
BUG=40977
TEST=see bug for some example reduced test cases.
Review URL: http://codereview.chromium.org/3579013
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@61984 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
When you created a window with type='popup', the resulting window.type
was incorrectly 'app'. After discussion, we concluded that a popup
app window should be called a popup.
This was a real regression that was masked by the test being marked flaky
for unrelated reasons. :(
(While I'm at it, fixed the ordering of some assertEq's to make the error
messages more understandable.)
BUG=48920
TEST=ExtensionApiTest.Tabs
Review URL: http://codereview.chromium.org/3594014
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@61722 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=31434
TEST=browser_tests --gtest_filter=ExtensionApiTest.*Tabs
Review URL: http://codereview.chromium.org/3584010
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@61555 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
- Browser::AddSelectedTabWithURL(const GURL& url, PageTransition::Type transition)
-> A good many callsites just wanted a way to open a tab somewhere and select it.
- Browser::AddTabWithURL(AddTabWithURLParams* params)
-> For the callsites with specialized needs, this new signature allows the parameter set to change as features are added without having to update a bunch of callers every time.
BUG=none
TEST=existing unit tests
Review URL: http://codereview.chromium.org/3599006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@61517 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
* Move size based disposition override for ChromeOS from tab_container to browser.
* TYPE_APP_PANEL |= TYPE_POPUP so that special popup behavior applies to panels.
* Removed confusing BrowserFrameChromeos::IsPanel(), replaced with BrowserView::IsBrowserTypePopup() calls.
* Replaced now redundant checks against panel or popup types with 'browser->type() & Browser::TYPE_POPUP'.
* Added size limiting code to PanelBrowserView.
* Modified CreateWindowFunction::RunImpl() to create TYPE_APP_POPUP windows instead of TYPE_POPUP.
BUG=http://code.google.com/p/chromium-os/issues/detail?id=5166
TEST=Test spawning popups/panels/tabs from web pages (e.g. gmail), extensions (e.g. chat manager), and apps
More info: https://docs.google.com/document/edit?id=14nBjW6gHJW0kk44o8Z8vfDSnDi0ZT1sUU74Zc5wmwIQ&hl=en&authkey=CKT6-O8I
!!! This commit didn't go through !!! Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=29fe99e
Review URL: http://codereview.chromium.org/3449007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@61427 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
<all_urls> in their Extension match pattern should be allowed to run content scripts everywhere (including chrome://, chrome-extension://, about: and gallery pages.
The intent was to also allow these extensions to specify more granular permissions, such as about:version instead of <all_urls>, but that didn't make the cut this time.
This CL also enables <all_urls> for host permissions for regular extensions, which was disabled before. Note: That still doesn't give them permission to script the gallery and chrome:// pages, etc.
BUG=36275
TEST=Working on it right now.
Review URL: http://codereview.chromium.org/3585009
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@61359 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
<all_urls> in their Extension match pattern should be allowed to run content scripts everywhere (including chrome://, chrome-extension://, about: and gallery pages.
The intent was to also allow these extensions to specify more granular permissions, such as about:version instead of <all_urls>, but that didn't make the cut this time.
This CL also enables <all_urls> for host permissions for regular extensions, which was disabled before. Note: That still doesn't give them permission to script the gallery and chrome:// pages, etc.
BUG=36275
TEST=New: ExtensionBrowserTest.AllUrlsWhitelistedExtension, ExtensionBrowserTest.AllUrlsRegularExtensions
Review URL: http://codereview.chromium.org/3440027
TBR=finnur@chromium.org
Review URL: http://codereview.chromium.org/3557006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@61327 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
their Extension match pattern should be allowed to run content scripts everywhere (including chrome://, chrome-extension://, about: and gallery pages.
The intent was to also allow these extensions to specify more granular permissions, such as about:version instead of <all_urls>, but that didn't make the cut this time.
This CL also enables <all_urls> for host permissions for regular extensions, which was disabled before. Note: That still doesn't give them permission to script the gallery and chrome:// pages, etc.
BUG=36275
TEST=New: ExtensionBrowserTest.AllUrlsWhitelistedExtension, ExtensionBrowserTest.AllUrlsRegularExtensions
Review URL: http://codereview.chromium.org/3440027
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@61323 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Also get rid of the type enum passed to TabReplacedAt since it can only be one option after phantom tabs are removed.
BUG=none
TEST=compile? good. pass tests? good.
Review URL: http://codereview.chromium.org/3539010
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@61303 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=55479
TEST=DontCreateIncognitoProfile
Review URL: http://codereview.chromium.org/3412005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@60039 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
(Note this is a TODO in string_util.h)
BUG=None
TEST=trybots
Review URL: http://codereview.chromium.org/3415015
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@60012 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
TBR=rafaelw@chromium.org
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@56907 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
changes have already been removed.
Review URL: http://codereview.chromium.org/3149029
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@56902 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=23581
TEST=builds and passes tests
Review URL: http://codereview.chromium.org/3181010
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@55995 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
http://codereview.chromium.org/2941001
Initial submit broke the chromeos build. This patch includes the original change, and fixes to compile ChromeOs properly.
BUG=None
TEST=None
Review URL: http://codereview.chromium.org/2819086
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@55951 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Much remains to be converted.
BUG=23581
TEST=builds and passes tests
Review URL: http://codereview.chromium.org/3076037
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@55660 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/3145001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@55635 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Use the base namespace in the new file. Update callers.
I removed all wstring variants and also the string->number ones that ignore the return value. That encourages people to write code and forget about error handling.
TEST=included unit tests
BUG=none
Review URL: http://codereview.chromium.org/3056029
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@54355 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=44758
TEST=ExtensionApiTest.CaptureVisibleTab, try taking a snapshot of google.com on mac, linux, win.
Review URL: http://codereview.chromium.org/2819050
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@52931 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
only an incognito window was visible.
BUG=41087
Review URL: http://codereview.chromium.org/2881004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@51283 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
original review: http://codereview.chromium.org/2885006
----------
This is almost certainly caused by a start-up or shut-down race, but CreateWindowValue doesn't have much meaning without a window attached to the browser, so just return an error in those cases
BUG=47808
TEST=none.
TBR=asargent
Review URL: http://codereview.chromium.org/2858036
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@51213 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This is almost certainly caused by a start-up or shut-down race, but CreateWindowValue doesn't have much meaning without a window attached to the browser, so just return an error in those cases
BUG=47808
TEST=none
Review URL: http://codereview.chromium.org/2885006
TBR=rafaelw@chromium.org
Review URL: http://codereview.chromium.org/2868039
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@51165 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
This is almost certainly caused by a start-up or shut-down race, but CreateWindowValue doesn't have much meaning without a window attached to the browser, so just return an error in those cases
BUG=47808
TEST=none
Review URL: http://codereview.chromium.org/2885006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@51161 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
attempt caused some flakiness on the new tab warm startup test. The
only difference between this and the last is that I'm leaving some
suspcious code in TabStripModel::InsertTabContents and
Browser::AddTabWithURL. I'll try to isolate why those changes caused
flakiness after I land the rest.
Here's the description:
Moves Browser::AddTypes to TabStripModel. This patch is primarily
cleanup before I fix 29933, but has a couple of interesting bits
beyond the enum change:
. AddTabContents now supports adding pinned.
. Converted InsertTabContents call in extensionstabmodule to pass in
nothing (Rafael said old code was wrong).
BUG=29933
TEST=none
TBR=ben@chromium.org
Review URL: http://codereview.chromium.org/2866024
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@50981 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
cleanup before I fix 29933, but has a couple of interesting bits
beyond the enum change:
. AddTabContents now supports adding pinned.
. Nuked duplicate code in Browser::addTabWithURL that invoked
wasHidden on the TabContents. This code is already in TabStripModel.
. Moved code for setting visibility of tabcontents from
TabStripModel::AddTabContents to InsertTabContentsAt. Since everything
ends up in InsertTabContentsAt it should be there.
. Converted InsertTabContents call in extensionstabmodule to pass in
nothing (Rafael said old code was wrong).
BUG=29933
TEST=none
Review URL: http://codereview.chromium.org/2863021
TBR=sky@chromium.org
Review URL: http://codereview.chromium.org/2849025
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@50776 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
cleanup before I fix 29933, but has a couple of interesting bits
beyond the enum change:
. AddTabContents now supports adding pinned.
. Nuked duplicate code in Browser::addTabWithURL that invoked
wasHidden on the TabContents. This code is already in TabStripModel.
. Moved code for setting visibility of tabcontents from
TabStripModel::AddTabContents to InsertTabContentsAt. Since everything
ends up in InsertTabContentsAt it should be there.
. Converted InsertTabContents call in extensionstabmodule to pass in
nothing (Rafael said old code was wrong).
BUG=29933
TEST=none
Review URL: http://codereview.chromium.org/2863021
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@50752 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=47180
Review URL: http://codereview.chromium.org/2809034
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@50737 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
selected is false.
BUG=42531
Review URL: http://codereview.chromium.org/2483003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@48872 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
The caller can use the much shorter "gfx::Rect(size())", since gfx::Rect
has a constructor that just takes a Size.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/2204001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@48283 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
windows
BUG=22651
TEST=NONE
Review URL: http://codereview.chromium.org/2173003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@48211 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=None
TEST=Unit tests
Review URL: http://codereview.chromium.org/2074022
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@47980 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
argument was passed.
BUG=36301
TEST=Updated tests and ran all the existing tests.
Review URL: http://codereview.chromium.org/2137012
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@47972 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
resolution.
This reverts the histogram collection part of http://codereview.chromium.org/1605005.
BUG=21909
TEST=none
Review URL: http://codereview.chromium.org/2082016
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@47969 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This CL addresses a few issues related to the behavior of the onUpdated event.
Issue 1: The page re-entering the load state and the completing was causing multiple 'complete' status events to be fired. We now only report the first 'complete' after the didNavigate message is fired (iframe navigation, for example).
Issue 2: We were initializing the URL when the TabEntry was created, and this caused us to fail to send the url with the first navigation because we thought it wasn't changing.
BUG=27208,37149
Review URL: http://codereview.chromium.org/2111010
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@47717 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
extension is enabled for incognito.
BUG=39113
Review URL: http://codereview.chromium.org/1789010
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@46076 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/1736022
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@45902 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
has a larger titlebar and a big icon, along with a tabstrip,
but no titlebar.
Review URL: http://codereview.chromium.org/1774003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@45566 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
TBR=jamesr@chromium.org
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@45523 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
have a bigger titlebar with a giant icon and title, and supports tabs.
Review URL: http://codereview.chromium.org/1730010
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@45520 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
would fail to show the new window.
BUG=41526
Review URL: http://codereview.chromium.org/1545041
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@44781 0039d316-1c4b-4281-b951-d872f2087c98
|