| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
|
|
|
| |
chrome url request data sources. This will allow me to merge
IncognitoTabHTMLSource and NewTabHTMLSource and allow me clean
up DOMUIThemeSource, but those will be follow up changes.
Review URL: http://codereview.chromium.org/397019
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32126 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/394002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31893 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
from the design team, but I wanted to at least get the words
in before the string freeze.
Review URL: http://codereview.chromium.org/385075
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31842 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
BUG=27399
TEST=Extensions without an icon now have a light-blue
puzzle-piece icon when installing/uninstalling them
and when listing them on chrome://extensions.
Review URL: http://codereview.chromium.org/384055
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31713 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The code to display the dialog looks up an
Extension by id but doesn't return disabled ones.
So I added that option to the function.
I also added a check so that we don't show the
Options button enabled when the extension is
disabled, since you need the extension to be
enabled for the Options page to work.
BUG=26910
TEST=Disable an extension that has an Option page,
make sure Options is not enabled after disabling,
then uninstall it. It should uninstall.
Review URL: http://codereview.chromium.org/385014
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31612 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Reuses the Install dialog (and makes it slightly more generic).
BUG=27162
TEST=None
Review URL: http://codereview.chromium.org/376030
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31540 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
don't have a process.
BUG=NONE
TEST=Open two chrome windows, navigate one to extensions management UI. Install an extension that has no background process in the other. Management UI should show the installed extension automatically, without reload.
Review URL: http://codereview.chromium.org/371043
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31324 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
development' andshould not DCHECK when uninstalling a disabledextension.I also reordered the links on the page, now thatwe show the Reload link conditionally, sinceit is weird to enable extensions after this change.The order starts out as...Disable - Reload - Uninstall... then when you press Disable it becomes: Enable - Uninstallpress Enable, it becomes:Disable - Reload - UninstallNotice how the Reload link pops up where Enable linkwas and where you'd expect Disable to be?TEST=Open chrome://extensions and make sure extensionsloaded with --load-extension have the Reload optionand when you disable an extension it does not DCHECKin debug version of Chrome.BUG=http://crbug.com/26901, http://crbug.com/26910
Review URL: http://codereview.chromium.org/374014
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31285 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
opened within one window when teh "Options" button is pressed on the extensions settings page.
BUG=none
TEST=Install an extension that specifies an options_page in it's manifest file. Open the extensions page (wrench menu) and click the "Options" button for that extension. The options page will open and come to the forefront. Go back to the extensions tab and click "Options" again. The same tab as before should be brought to the forefront.
Review URL: http://codereview.chromium.org/366026
Patch from Akira <akira@yayakoshi.net>.
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31170 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
extension (disable/enable...).
BUG=26163
TEST=Click on Disable/Reload links and check if the whole page got reloaded.
Review URL: http://codereview.chromium.org/341076
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31157 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
UI for disabled extensions.
Also, desaturate the icons of disabled extensions to make them
look more disabledy.
BUG=25963
TEST=On the extensions page, disable an extension, then press
reload. You should see a greyscale version of the icon.
Review URL: http://codereview.chromium.org/360039
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31139 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
CID=7228-7241
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/360037
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31056 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
ones more prominently.
Also added an unused string for 'getting more extensions',
so we can translate.
Converted 'Developer Tools' references to 'Developer Mode',
to avoid confusion with Chrome's developer tools.
TEST=Load extension b_foo through --load-extension.
Open chrome://extensions/ and notice extension b_foo is
on top, even though another extension a_foo normally would
appear at the top due to alphabetical sorting. Then disable
an extension and notice it should turn all gray. Enable,
and it should no longer be gray.
BUG=http://crbug.com/26699, http://crbug.com/25850
Review URL: http://codereview.chromium.org/365008
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31021 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
is just cleanup.
Take 2 with a fix in sync code.
TBR=evanm
Review URL: http://codereview.chromium.org/350007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30622 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
This reverts commit r30594.
Review URL: http://codereview.chromium.org/342062
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30600 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
Singleton. This is just cleanup.
Review URL: http://codereview.chromium.org/339078
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30594 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
BUG=25354
Review URL: http://codereview.chromium.org/345023
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30550 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=25947
TEST=Not easily testable until we have the strings localized.
Review URL: http://codereview.chromium.org/329039
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30324 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
This changes the details text from gray to black. It also persists in the preferences the state of devMode (whether the developer tools are showing). Lastly, it adds a fade/slide effect on page elements which are shown in devMode.
BUG=25471
Review URL: http://codereview.chromium.org/329018
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30219 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
different thread lifetimes.The rest of the code doesn't get MessageLoop pointers since they're not thread-safe and instead just call PostTask on ChromeThread. If the target thread is not alive, then the task is simply deleted.In a followup change, I'll remove any remaining MessageLoop* caching. With this change, there's little to be gained by caching since no locks are involved if the target MessageLoop is guaranteed to outlive the current thread (inferred automatically by the order of the chrome_threads_ array).BUG=25354
Review URL: http://codereview.chromium.org/306032
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30163 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
TBR=arv
BUG=25509
TEST=Open the extensions page and it should have a plugin as it's favicon.
Review URL: http://codereview.chromium.org/329012
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29935 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=25509
TEST=Open the extensions page and its tab should have an icon.
Review URL: http://codereview.chromium.org/332009
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29922 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
and shows it on the page.
BUG=12119
TEST=Open chrome://extensions and all extensions that
have an icon associated with them, should show the
icon and those that don't have the generic plugin
icon.
Review URL: http://codereview.chromium.org/292048
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29714 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
And made some minor lint fixes and code refactoring on the way, based on CR comments of previous attempt.
BUG=none
TEST=Make sure that the extension resources can still be properly localized and that they also load correctly when they are not localized.
Review URL: http://codereview.chromium.org/267051
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29512 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
BUG=23801
TEST=Create an extension with an "options_page" entry in its manifest with a value the name of a html file in the extension dir.
Load that extension and go to chrome://extensions, there should be an "Options" button that takes you to the page specified in the manifest.
Review URL: http://codereview.chromium.org/271114
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29297 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
- reduce header dependencies
- remove things that shouldn't be #included in a header, like string_util.h and theme_resources.h!
TEST=none
BUG=none
Review URL: http://codereview.chromium.org/245011
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28705 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
original issue: http://codereview.chromium.org/207062
The issue had to do with a symbol collison with the nss libraries (which are currently out-of-date) on the build bots.
HTML Pack Extension Dialog. This removes the views implementation of the ExtensionPackDialog, and implements the dialog in html in the extensions_ui DOMUI.
Additionally, support is added for packaging extensions via ---pack-extension on linux and mac
BUG=20668, 20669
TBR=aa,wtc
Review URL: http://codereview.chromium.org/265032
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28365 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
falls back to extension subtree.
We look for ext_root/foo/bar.js under ext_root/_locales/fr/foo/bar.js if current locale is fr. If there is no fr specific resource we load ext_root/foo/bar.js instead.
Lots of small refactoring to replace FilePath with ExtensionResource.
BUG=12131
TEST=See unittest for sample tree.
Review URL: http://codereview.chromium.org/256022
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28333 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
original issue: http://codereview.chromium.org/207062/
TBR=sky
Review URL: http://codereview.chromium.org/270001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28234 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
ExtensionPackDialog, and implements the dialog in html in the extensions_ui DOMUI.
Additionally, support is added for packaging extensions via ---pack-extension on linux and mac
Review URL: http://codereview.chromium.org/207062
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28229 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
with the StringPiece class in icu4.2, which is a problem
when trying to use the system version of icu.
Review URL: http://codereview.chromium.org/193072
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25920 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
TEST=Try installing and/or loading some extensions, and toggling between enable and disable in the management UI (chrome://extensions).
BUG=12122
Review URL: http://codereview.chromium.org/199018
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25659 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
BUG=http://crbug.com/17853
TEST=Install an old version of an extension with an available update, then go
to chrome://extensions and hit the auto-update now button. The extension
should update.
Review URL: http://codereview.chromium.org/184005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25293 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
an unpacked extension from chrome://extensions.
BUG=20860
TEST=go to chrome://extensions on Mac, click "Load unpacked extensions...", don't crash
Review URL: http://codereview.chromium.org/171121
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25253 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
process ID with an internally-generated id() function. This allows us the
guarantee that the IDs are unique over the entire run of the application.
This also cleans up some code associated with managing the PID.
The main potentially interesting change is now the PID is set uniquely for
every creation of RenderProcessHost. It used to be set cleared if the process
went away, and re-set if the process was re-created. The ID generation is in
ChildProcesInfo so it is also unique between workers and plugins. I had to
change some significant things in resource_dispatcher_host_unittest to take
into account this new generation of IDs.
BUG=17828
TEST=none
Review URL: http://codereview.chromium.org/160203
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@24899 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
* CHECK when reloading installed extension. Caused because we
were somtimes trying to register for the same notifications
twice.
* Not able to "Reload" extensions that were loaded with
"Load Unpacked Extension".
TBR=erikkay@chromium.org
Review URL: http://codereview.chromium.org/178033
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@24882 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
of extensions into crx files.
BUG=20578
TEST=Create a sample extension, pack it, then try to install it.
Review URL: http://codereview.chromium.org/181020
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@24877 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=20577
TBR=rafaelw@chromium.org
Review URL: http://codereview.chromium.org/177032
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@24871 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
permissions then before, and prompt the user to re-enable.
Incidentally, this required adding support for disabling extensions.
BUG=12140
TEST=covered by unit tests
Review URL: http://codereview.chromium.org/165414
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23480 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This first pass is fairly simple. If a permission is not specified in the
manifest, the corresponding module will not be exposed to script. For example,
without specifying the "tabs" permission, chrome.tabs and chrome.windows will
not be available.
BUG=12140
TEST=no
Review URL: http://codereview.chromium.org/164039
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22745 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
where the extension config UI doesn't work right with themes.
This isn't ideal because users go to chrome://extensions/
expecting themes to be listed. If they aren't there, users
might be confused. But I don't have an alternate solution.
Also, this change removes the error listing from the top of chrome://extensions/. These errors are just getting noisy, I don't think they provide much value.
BUG=13649,18456
Review URL: http://codereview.chromium.org/160631
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22578 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
http://crbug.com/16459
Review URL: http://codereview.chromium.org/159323
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21719 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
optimized for the way we do internationalization with JST before
and is about 4 times faster (average 4.8ms vs 22.8ms) for the history
page.
The syntax for this is very similar to JsTemplates. It uses the
attributes i18n-values and i18n-content which worls like jsvalues and
jscontent except that it does not allow arbitrary expressions.
BUG=None
TEST=All UI pages should work as before
Review URL: http://codereview.chromium.org/149420
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20590 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
are rendered in the main tab contents area. This gets us loaded and unloaded at the right place and removes many special cases for extensions from the RenderViewHost and RenderViewHostDelegate hierarchy.
BUG=13936
Review URL: http://codereview.chromium.org/126137
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19717 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
This time without browser_tests timeout that caused the revert. The problem was BrowsingHistoryHandler trying to use a dom_ui_ before being attached.
Review URL: http://codereview.chromium.org/149117
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19556 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
TBR=nsylvain
Review URL: http://codereview.chromium.org/147206
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19363 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
construct these objects by deferring the DOMUI dependency to the init / "Attach" step.
Add GetMessageHandlers to HtmlDialogUIDelegate to allow
sending/receiving messages to the page hosted in the dialog as opposed to only on open/close.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/131094
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19359 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
the prefs file, but instead reads a preferences file
(a json file called external_extensions.json).
This file specifies what external extensions we
installed (shipped with Chrome) and the extension
system takes care of installing them.
Having this in a separate file makes the upgrade
scenario easier, since we can during upgrade simply
blow away this file and replace it (and not have
to worry about merging/loosing user specified data).
The extension system will read the file, and figure
out whether any extension needs to be upgraded based
on the information provided.
Now, all external providers fetch data on the file
thread instead of reading and copying preferences on
the UI thread and posting them to the file thread.
BUG=http://crbug.com/14201
TEST=Covered by unit test.
Review URL: http://codereview.chromium.org/144018
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19264 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
render_view_host API.
Review URL: http://codereview.chromium.org/146080
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19112 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
In my scan of headers I got up to browser/gtk/
Review URL: http://codereview.chromium.org/126131
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18500 0039d316-1c4b-4281-b951-d872f2087c98
|