| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
|
|
|
|
|
| |
This makes lots of code easier. The conversion from policy to prefs is
now done in the right place, reporting errors in about:policy.
BUG=chromium:166067
TEST=unit tests.
Review URL: https://codereview.chromium.org/11566024
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@173151 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
TBR=estade@chromium.org,aa@chromium.org
BUG=155525
Review URL: https://chromiumcodereview.appspot.com/11377131
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@167704 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Instead of using content::NotificationObserver, introduce specific
type-safe observer classes and update users to use them. In a very
large number of cases this was the users' only reason for being a
content::NotificationObserver and they would have a lot of
boiler-plate code such as a DCHECK on the notification type and
unpacking of the generic NotificationDetails types, so this change
removes a bunch of boilerplate and introduces more type safety.
This is part of enabling more of the Prefs code to live in
base/prefs/.
TBR=ben@chromium.org,brettw@chromium.org
BUG=155525
Review URL: https://chromiumcodereview.appspot.com/11345008
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@165414 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
to break dependencies back to Chrome.
This leaves the following in chrome/ for now, which will move later:
- PrefService, to move once sync dependencies and dependencies on
Chrome-specific pref stores are externalized.
- PrefNotifierImpl and PrefObserverMock, to move once
NotificationSource dependency is broken.
- PrefValueStore, to move once PrefModelAssociatior dependency is
externalized.
- ScopedUserPrefUpdate, to move once PrefService moves.
TBR=ben@chromium.org
BUG=155525
Review URL: https://chromiumcodereview.appspot.com/11243002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@163354 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This is the first step in breaking Autofill's concrete dependency on
prefs. These two classes are essentially utilities with very small
dependencies back to PrefService (which I will break in the next
change, by introducing a virtual PrefServiceBase) so they are suitable
for api.
TBRing other owners for mechanical changes.
TBR=ben@chromium.org
BUG=140037
Review URL: https://chromiumcodereview.appspot.com/10857031
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@152544 0039d316-1c4b-4281-b951-d872f2087c98
|
|
Moved ExternalExtensionLoader, ExternalExtensionProviderImpl,
ExternalExtensionProviderInterface, ExternalRegistryExtensionLoader,
ExternalPrefsExtensionLoader, and ExternalPolicyExtensionLoader into extensions
namespace. Renamed appropriately.
BUG=136873, 117261
Review URL: https://chromiumcodereview.appspot.com/10692168
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@146847 0039d316-1c4b-4281-b951-d872f2087c98
|