summaryrefslogtreecommitdiffstats
path: root/chrome/browser/extensions/image_loading_tracker.h
Commit message (Collapse)AuthorAgeFilesLines
* Remove ImageLoadingTracker class, as it is not used anymore.rpaquay@chromium.org2013-02-121-192/+0
| | | | | | | | | | | | | * Remove related methods in Extension: Set/GetCachedImage * Remove related unit tests * Update all comments mentioning ImageLoadingTracker to mention ImageLoader instead BUG=163929 TBR=sky@chromium.org (for mechanical changes in chrome/.) Review URL: https://chromiumcodereview.appspot.com/12213093 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@182039 0039d316-1c4b-4281-b951-d872f2087c98
* Use ImageLoader instead of ImageLoadingTracker (Part 11)rpaquay@chromium.org2013-02-081-1/+0
| | | | | | | | | | | | | | | * Update extensions::IconImage class to use new ImageLoader class. * Delete code related to dealing with sync/async behavior of |ImageLoadingTracker|. * Update unit tests. * Update callers of |IconImage| to pass a |Profile| instance. BUG=163929 Review URL: https://chromiumcodereview.appspot.com/11946003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@181505 0039d316-1c4b-4281-b951-d872f2087c98
* Use ImageLoader instead of ImageLoadingTracker (Part 6)rpaquay@chromium.org2013-01-311-1/+0
| | | | | | | | | BUG=163929 Review URL: https://chromiumcodereview.appspot.com/11889012 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@179802 0039d316-1c4b-4281-b951-d872f2087c98
* Use ImageLoader instead of ImageLoadingTracker (Part 12)rpaquay@chromium.org2013-01-261-1/+0
| | | | | | | | | | | Update extensions::TabHelper class to use new ImageLoader class. BUG=163929 Review URL: https://chromiumcodereview.appspot.com/11886073 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@178981 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 178405 - reinstating 178361 which was proven innocent of all charges byfischman@chromium.org2013-01-241-1/+0
| | | | | | | | | | | | | | | | | | | | | | | http://build.chromium.org/p/chromium.win/builders/Win%20Aura%20Tests%20%283%29/builds/793 > Revert 178361 - suspected of introducing flake: > http://build.chromium.org/p/chromium.win/buildstatus?builder=Win%20Aura%20Tests%20%283%29&number=790 > http://build.chromium.org/p/chromium.win/buildstatus?builder=Win%20Aura%20Tests%20%283%29&number=791 > > > Use ImageLoader instead of ImageLoadingTracker (Part 9) > > > > BUG=163929 > > > > > > Review URL: https://chromiumcodereview.appspot.com/11886029 > > TBR=rpaquay@chromium.org > Review URL: https://codereview.chromium.org/12049055 TBR=fischman@chromium.org Review URL: https://codereview.chromium.org/12042091 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@178655 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 178361 - suspected of introducing flake:fischman@chromium.org2013-01-231-0/+1
| | | | | | | | | | | | | | | | | http://build.chromium.org/p/chromium.win/buildstatus?builder=Win%20Aura%20Tests%20%283%29&number=790 http://build.chromium.org/p/chromium.win/buildstatus?builder=Win%20Aura%20Tests%20%283%29&number=791 > Use ImageLoader instead of ImageLoadingTracker (Part 9) > > BUG=163929 > > > Review URL: https://chromiumcodereview.appspot.com/11886029 TBR=rpaquay@chromium.org Review URL: https://codereview.chromium.org/12049055 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@178405 0039d316-1c4b-4281-b951-d872f2087c98
* Use ImageLoader instead of ImageLoadingTracker (Part 9)rpaquay@chromium.org2013-01-231-1/+0
| | | | | | | | | BUG=163929 Review URL: https://chromiumcodereview.appspot.com/11886029 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@178361 0039d316-1c4b-4281-b951-d872f2087c98
* Use ImageLoader instead of ImageLoadingTracker (Part 10)rpaquay@chromium.org2013-01-231-1/+0
| | | | | | | | | BUG=163929 Review URL: https://chromiumcodereview.appspot.com/11889022 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@178165 0039d316-1c4b-4281-b951-d872f2087c98
* Use ImageLoader instead of ImageLoadingTracker (Part 4)rpaquay@chromium.org2013-01-221-1/+0
| | | | | | | | | | | Add WeakPtrFactory to ensure correct lifetime wrt callback BUG=163929 Review URL: https://chromiumcodereview.appspot.com/11877004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@178118 0039d316-1c4b-4281-b951-d872f2087c98
* Use ImageLoader instead of ImageLoadingTracker (Part 7)rpaquay@chromium.org2013-01-171-1/+0
| | | | | | | | | BUG=163929 Review URL: https://chromiumcodereview.appspot.com/11878025 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@177282 0039d316-1c4b-4281-b951-d872f2087c98
* Use ImageLoader instead of ImageLoadingTracker (Part 8)rpaquay@chromium.org2013-01-161-1/+0
| | | | | | | | | BUG=163929 Review URL: https://chromiumcodereview.appspot.com/11882031 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@177039 0039d316-1c4b-4281-b951-d872f2087c98
* Use ImageLoader instead of ImageLoadingTracker (Part 5)rpaquay@chromium.org2013-01-151-1/+0
| | | | | | | | | | | | | * Remove usage of tracker from ExtensionIconManager * Ensure Profile instance is passed everywhere needed * Update unit tests BUG=163929 Review URL: https://chromiumcodereview.appspot.com/11877009 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@177003 0039d316-1c4b-4281-b951-d872f2087c98
* Use ImageLoader instead of ImageLoadingTracker (Part 3)rpaquay@chromium.org2013-01-151-1/+0
| | | | | | | | | BUG=163929 Review URL: https://chromiumcodereview.appspot.com/11857018 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@176823 0039d316-1c4b-4281-b951-d872f2087c98
* Use ImageLoader instead of ImageLoadingTracker (part 2)rpaquay@chromium.org2013-01-141-1/+0
| | | | | | | | | BUG=163929 Review URL: https://chromiumcodereview.appspot.com/11823062 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@176710 0039d316-1c4b-4281-b951-d872f2087c98
* Use ImageLoader instead of ImageLoadingTracker (Part 1)rpaquay@chromium.org2013-01-111-1/+0
| | | | | | | | | BUG=163929 Review URL: https://chromiumcodereview.appspot.com/11826061 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@176428 0039d316-1c4b-4281-b951-d872f2087c98
* Deprecate ImageLoadingTracker after r168155 added a replacement.mek@chromium.org2012-11-201-1/+27
| | | | | | | | | | | | This makes the constructor private to prevent new code from using this class and adds all current users as friends. BUG=141673 Review URL: https://chromiumcodereview.appspot.com/11348141 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@168810 0039d316-1c4b-4281-b951-d872f2087c98
* Add a class to replace ImageLoadingTracker with a nicer API.mek@chromium.org2012-11-161-8/+0
| | | | | | | | | | | | This adds a new extensions::ImageLoader class, which mostly serves the same purpose as ImageLoadingTracker, but with some differences. It currently doesn't do any caching, and it uses callbacks instead of a delegate to pass the loaded image back to the caller. This should make this new class much nicer to use. Also ported some ILT usage to the new ImageLoader class. BUG=141673 Review URL: https://chromiumcodereview.appspot.com/11027044 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@168155 0039d316-1c4b-4281-b951-d872f2087c98
* Give Chrome Web Store app an icon in its manifest file.mek@chromium.org2012-10-041-15/+8
| | | | | | | | | | | | | | | | | This fixes no icon being shown in the "The app is currently unreachable" page for the chrome web store. Also added is another exception to ResourceRequestPolicy::CanRequestResource to make sure the error page is always allowed to display the app's icon, even in a manifest v2 app that doesn't list its icons in web_accessible_resources. This time without the nondeterministic compile failures http://codereview.chromium.org/10985028/ caused by depending on browser/ grit files from common/ code. BUG=135549 Review URL: https://chromiumcodereview.appspot.com/11045030 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@160143 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 159950 - Give Chrome Web Store app an icon in its manifest file.rlarocque@chromium.org2012-10-031-1/+6
| | | | | | | | | | | | | | | | | This fixes no icon being shown in the "The app is currently unreachable" page for the chrome web store. Also added is another exception to ResourceRequestPolicy::CanRequestResource to make sure the error page is always allowed to display the app's icon, even in a manifest v2 app that doesn't list its icons in web_accessible_resources. BUG=135549 Review URL: https://chromiumcodereview.appspot.com/10985028 TBR=mek@chromium.org Review URL: https://codereview.chromium.org/11056005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@159963 0039d316-1c4b-4281-b951-d872f2087c98
* Give Chrome Web Store app an icon in its manifest file.mek@chromium.org2012-10-031-6/+1
| | | | | | | | | | | | | | This fixes no icon being shown in the "The app is currently unreachable" page for the chrome web store. Also added is another exception to ResourceRequestPolicy::CanRequestResource to make sure the error page is always allowed to display the app's icon, even in a manifest v2 app that doesn't list its icons in web_accessible_resources. BUG=135549 Review URL: https://chromiumcodereview.appspot.com/10985028 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@159950 0039d316-1c4b-4281-b951-d872f2087c98
* chromeos: Fix pixelated icons in app list and launcher (part 3)xiyuan@chromium.org2012-09-111-0/+5
| | | | | | | | | | | | | | | | | - Use extensions::IconImage for HiDPI icons; - Fix IconImage use default icon for bundled component extension icon; - Fix ImageLoadingTracker does not properly resize bundled component extension icon; - Get rid of icon cache and work thread for shadow generation. We are using the exact icon size (smaller) and only generate shadow for visible ones. Thus, it is no longer needed. BUG=131738, 131739 TEST=Verify launcher and app list have crispy icons on HiDPI. Review URL: https://chromiumcodereview.appspot.com/10868003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@155939 0039d316-1c4b-4281-b951-d872f2087c98
* taking over xiyuan's patch: http://codereview.chromium.org/10701087/tbarzic@chromium.org2012-08-201-20/+46
| | | | | | | | | | | | | | | | | | | | *************************************************************** chromeos: Fix pixelated icons in app list and launcher (part 2) Add an ExtensionIconImage, which loads image that supports DIP by having a special ImageSkiaSource that makes ImageLoadingTracker to load image for additional DIP scale. BUG=131738, 131739 TEST=None. Wait for the last CL to update laucher/app list code to use LoadImageInDIP to verify. *************************************************************** For gypi files (I reckon this part is trivial enough) TBR=ben@chromium.org Review URL: https://chromiumcodereview.appspot.com/10825012 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@152407 0039d316-1c4b-4281-b951-d872f2087c98
* Remove the rest of #pragma once in one big CL.ajwong@chromium.org2012-07-111-1/+0
| | | | | | | | | For context see this thread: https://groups.google.com/a/chromium.org/forum/?fromgroups#!topic/chromium-dev/RMcVNGjB4II TBR=thakis,pkasting,jam git-svn-id: svn://svn.chromium.org/chrome/trunk/src@146163 0039d316-1c4b-4281-b951-d872f2087c98
* Move Extension into extensions namespaceaa@chromium.org2012-05-211-5/+8
| | | | | | | | | BUG=117262 TBR=aa@chromium.org Review URL: https://chromiumcodereview.appspot.com/10375021 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@138074 0039d316-1c4b-4281-b951-d872f2087c98
* Attempt to load component extension favicon from the resources first.dgozman@chromium.org2012-04-241-0/+11
| | | | | | | | | | | Special handling of CWS icon. Also correctly handle URL rewrites in favicon requests. BUG=chromium-os:28314,chromium:120471 TEST=Observe the right favicon for CWS and FileManager component extension. Bookmark them and see the right favicon. Review URL: https://chromiumcodereview.appspot.com/9979001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@133657 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 133427 - Attempt to load component extension favicon from the ↵dgozman@chromium.org2012-04-231-11/+0
| | | | | | | | | | | | | | | | | | resources first. This broke BackgroundApplicationListModelTest.ExplicitTest. Special handling of CWS icon. Also correctly handle URL rewrites in favicon requests. BUG=chromium-os:28314,chromium:120471 TEST=Observe the right favicon for CWS and FileManager component extension. Bookmark them and see the right favicon. Review URL: https://chromiumcodereview.appspot.com/9979001 TBR=dgozman@chromium.org Review URL: https://chromiumcodereview.appspot.com/10186001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@133428 0039d316-1c4b-4281-b951-d872f2087c98
* Attempt to load component extension favicon from the resources first.dgozman@chromium.org2012-04-231-0/+11
| | | | | | | | | | | Special handling of CWS icon. Also correctly handle URL rewrites in favicon requests. BUG=chromium-os:28314,chromium:120471 TEST=Observe the right favicon for CWS and FileManager component extension. Bookmark them and see the right favicon. Review URL: https://chromiumcodereview.appspot.com/9979001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@133427 0039d316-1c4b-4281-b951-d872f2087c98
* This broke the app icon for the Chrome Web Store on the NTP.dbeam@chromium.org2012-04-201-11/+0
| | | | | | | | | | | | | | | | Revert 132563 - Attempt to load component extension favicon from the resources first. Special handling of CWS icon. Also correctly handle URL rewrites in favicon requests. BUG=chromium-os:28314,chromium:120471 TEST=Observe the right favicon for CWS and FileManager component extension. Bookmark them and see the right favicon. Review URL: https://chromiumcodereview.appspot.com/9979001 TBR=dgozman@chromium.org Review URL: https://chromiumcodereview.appspot.com/10155009 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@133154 0039d316-1c4b-4281-b951-d872f2087c98
* Attempt to load component extension favicon from the resources first.dgozman@chromium.org2012-04-171-0/+11
| | | | | | | | | | | Special handling of CWS icon. Also correctly handle URL rewrites in favicon requests. BUG=chromium-os:28314,chromium:120471 TEST=Observe the right favicon for CWS and FileManager component extension. Bookmark them and see the right favicon. Review URL: https://chromiumcodereview.appspot.com/9979001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@132563 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 132196 - Attempt to load component extension favicon from the ↵tim@chromium.org2012-04-131-11/+0
| | | | | | | | | | | | | | | | resources first. Special handling of CWS icon. Also correctly handle URL rewrites in favicon requests. BUG=chromium-os:28314,chromium:120471 TEST=Observe the right favicon for CWS and FileManager component extension. Bookmark them and see the right favicon. Review URL: https://chromiumcodereview.appspot.com/9979001 TBR=dgozman@chromium.org Review URL: https://chromiumcodereview.appspot.com/10083006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@132199 0039d316-1c4b-4281-b951-d872f2087c98
* Attempt to load component extension favicon from the resources first.dgozman@chromium.org2012-04-131-0/+11
| | | | | | | | | | | Special handling of CWS icon. Also correctly handle URL rewrites in favicon requests. BUG=chromium-os:28314,chromium:120471 TEST=Observe the right favicon for CWS and FileManager component extension. Bookmark them and see the right favicon. Review URL: https://chromiumcodereview.appspot.com/9979001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@132196 0039d316-1c4b-4281-b951-d872f2087c98
* Pass large parameters by referencetbreisacher@chromium.org2012-03-071-1/+1
| | | | | | | | | | | CID=101433,101434,102147,103399,101393,103446 BUG=none TEST=compile Review URL: https://chromiumcodereview.appspot.com/9592017 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@125269 0039d316-1c4b-4281-b951-d872f2087c98
* Add support for multiple icon sizes for Mac platform appssail@chromium.org2012-03-031-15/+45
| | | | | | | | | | | | | | This is the combined version of the following CLs: http://codereview.chromium.org/9428025/ http://codereview.chromium.org/9500007/ http://codereview.chromium.org/9535002/ BUG=112651 TEST= Review URL: https://chromiumcodereview.appspot.com/9586018 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@124875 0039d316-1c4b-4281-b951-d872f2087c98
* Adds access to the index passed to ImageLoadingTracker::Observer. I needsky@chromium.org2012-01-231-4/+10
| | | | | | | | | | | | | | this for an observer implementation so that I can identify the request I made when OnImageLoaded is invoked. BUG=110827 TEST=none R=finnur@chromium.org Review URL: http://codereview.chromium.org/9159027 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@118688 0039d316-1c4b-4281-b951-d872f2087c98
* Move NotificationObserver, NotificationSource, and NotificationDetails to ↵jam@chromium.org2011-10-191-8/+8
| | | | | | | | | | | content/public/browser. This patch got way bigger than I wanted, but once I moved NotificationDetails, I figured I might as well mvoe the others since they're in the same files. In hindsight, I should have converted a subset of files at a time by leaving a using statement in the header. BUG=98716 TBR=joi git-svn-id: svn://svn.chromium.org/chrome/trunk/src@106196 0039d316-1c4b-4281-b951-d872f2087c98
* Remove obsolete TODO and add a bunch of OVERRIDEs.mihaip@chromium.org2011-08-311-1/+2
| | | | | | | | | R=aa@chromium.org Review URL: http://codereview.chromium.org/7806009 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@99070 0039d316-1c4b-4281-b951-d872f2087c98
* Moving notification types which are chrome specific to a new header file ↵ananta@chromium.org2011-07-101-1/+1
| | | | | | | | | | | | | chrome_notification_types.h. This file lives in chrome\common. The chrome specific notifications start from NOTIFICATION_CONTENT_END which defines the end of the enum used by content to define notification types. The notificaton_type.h file in content\common has been renamed to content_notification_types.h BUG=76698 Review URL: http://codereview.chromium.org/7327007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@91972 0039d316-1c4b-4281-b951-d872f2087c98
* Virtual destructors should have virtual keyword.hans@chromium.org2011-05-251-1/+1
| | | | | | | | | | | | | | | | | Make sure user-declared virtual destructors always have the virtual keyword. The Clang style-check plugin will check for this soon. No functionality change: virtual is only added to destructors that are already implicitly virtual. Also fix a couple of in-line destructor definitions. BUG=83408 TEST=none Review URL: http://codereview.chromium.org/7064033 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@86587 0039d316-1c4b-4281-b951-d872f2087c98
* Move some files from base to base/memory.levin@chromium.org2011-03-281-1/+1
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | raw_scoped_refptr_mismatch_checker.h ref_counted.cc ref_counted.h ref_counted_memory.cc ref_counted_memory.h ref_counted_unittest.cc scoped_callback_factory.h scoped_comptr_win.h scoped_handle.h scoped_native_library.cc scoped_native_library.h scoped_native_library_unittest.cc scoped_nsobject.h scoped_open_process.h scoped_ptr.h scoped_ptr_unittest.cc scoped_temp_dir.cc scoped_temp_dir.h scoped_temp_dir_unittest.cc scoped_vector.h singleton.h singleton_objc.h singleton_unittest.cc linked_ptr.h linked_ptr_unittest.cc weak_ptr.cc weak_ptr.h weak_ptr_unittest.cc BUG=None TEST=Compile Review URL: http://codereview.chromium.org/6714032 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@79524 0039d316-1c4b-4281-b951-d872f2087c98
* Fix some coverity defects (mostly pass by value).estade@chromium.org2011-03-111-1/+2
| | | | | | | | | | CID=15414,15415,15413,15412,15402,14582,13684,12723,15407,14785,14511,13975,13647,11655,10891,9103,8402,8394,10924,8497,others BUG=none TEST=trybots Review URL: http://codereview.chromium.org/6665012 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@77740 0039d316-1c4b-4281-b951-d872f2087c98
* Update a bunch of files to the new location of notification files.tfarina@chromium.org2011-03-091-3/+3
| | | | | | | | | | | Second part of the remaining files. BUG=None TEST=None Review URL: http://codereview.chromium.org/6639008 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@77396 0039d316-1c4b-4281-b951-d872f2087c98
* Part 3 of immutable Extension refactor.mpcomplete@chromium.org2010-10-291-2/+2
| | | | | | | | | | | | | Make ExtensionsService hold const Extension pointers only. This ensures that extensions can't be modified after they're created, and lets us share them between threads. BUG=56558 TEST=no functional change Review URL: http://codereview.chromium.org/4138006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@64517 0039d316-1c4b-4281-b951-d872f2087c98
* Fix problem with extension context menu items losing top-level icon.asargent@chromium.org2010-09-161-1/+3
| | | | | | | | | | | | | | | If an extension adds some context menu items, then removes them all, and adds some more, instead of their actual icon the new items will get the default extension icon in context menus. This is because we use the caching feature of ImageLoadingTracker and get an immediate callback from LoadImage before we've put the request in pending_icons_. BUG=53543 TEST=Steps are outlined in bug report. Review URL: http://codereview.chromium.org/3425007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@59726 0039d316-1c4b-4281-b951-d872f2087c98
* `#pragma once` for app, base, chrome, gfx, ipc, net, skia, viewsthakis@chromium.org2010-07-261-0/+1
| | | | | | | | | BUG=50273 TEST=everything still builds, build is 10% faster on windows, same speed on mac/linux TBR: erg git-svn-id: svn://svn.chromium.org/chrome/trunk/src@53716 0039d316-1c4b-4281-b951-d872f2087c98
* Revert "Revert "Show extension icons next to their top-level context menu ↵hclam@chromium.org2010-06-251-2/+5
| | | | | | | | | | | items."" This reverts r50828 as the error is already suppressed r50793. TBR=asargent Review URL: http://codereview.chromium.org/2844028 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@50831 0039d316-1c4b-4281-b951-d872f2087c98
* Revert r50779 as it breaks memory testshclam@chromium.org2010-06-251-5/+2
| | | | | | | | | TBR=asargent@chromium.org TEST=Tree goes green Review URL: http://codereview.chromium.org/2812025 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@50828 0039d316-1c4b-4281-b951-d872f2087c98
* Show extension icons next to their top-level context menu items.asargent@chromium.org2010-06-241-2/+5
| | | | | | | | | | | | | | | Also fix a bug in extension icon caching where we weren't keeping track of potential resizing done by ImageLoadingTracker before setting the cached SkBitmap. BUG=39494 TEST=Install an extension that includes an icon and uses the experimental context menu API. You should see the extension's icon in the context menu next to its top-level item. Review URL: http://codereview.chromium.org/2867008 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@50779 0039d316-1c4b-4281-b951-d872f2087c98
* Reduce header dependencies in chrome/phajdan.jr@chromium.org2010-05-111-1/+1
| | | | | | | | | TEST=if it compiles, it is perfect BUG=none Review URL: http://codereview.chromium.org/2001007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@46894 0039d316-1c4b-4281-b951-d872f2087c98
* Attempt 2 at landing this. Patch is exactly same as last time around.sky@chromium.org2010-03-301-8/+38
| | | | | | | | | | | | Adds ability for ImageLoadingTracker to cache images. BUG=none TEST=none TBR=aa@chromium.org Review URL: http://codereview.chromium.org/1534006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@43130 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 43005 - Adds ability for ImageLoadingTracker to cache images.sky@chromium.org2010-03-291-38/+8
| | | | | | | | | | | | BUG=none TEST=none Review URL: http://codereview.chromium.org/1251011 TBR=sky@chromium.org Review URL: http://codereview.chromium.org/1526003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@43008 0039d316-1c4b-4281-b951-d872f2087c98
generated by cgit v1.1 at 2025-05-12 18:01:12 +0000