| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
|
|
| |
BUG=227219
R=joi@chromium.org
Review URL: https://codereview.chromium.org/15517005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@201634 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Renames of the classes and methods will follow in separate patch(es).
BUG=227219
R=erg@chromium.org, joi@chromium.org
Review URL: https://codereview.chromium.org/14743010
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@201167 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=155525
R=joi@chromium.org
TBR=darin@chromium.org
Review URL: https://codereview.chromium.org/12789006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@189513 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: https://chromiumcodereview.appspot.com/12828006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@188380 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
BUG=179300
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=187850
Review URL: https://chromiumcodereview.appspot.com/12508011
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@188138 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Broke PreferencesBrowserTest.* on xp dbg bots, win7 dbg bots, aura bots.
Somewhat speculative, but the failing tests all have something like this:
2924:4484:0313/073213:2077246:FATAL:extension_app_item.cc(124)] Check failed: extension_misc::EXTENSION_ICON_SMALL == icon_.width() (32 vs. 0)
Backtrace:
base::win::OSInfo::processors [0x10082461+467580]
base::win::OSInfo::processors [0x100DAE9E+830649]
RelaunchChromeBrowserWithNewCommandLineIfNeeded [0x0378D9FF+13984735]
RelaunchChromeBrowserWithNewCommandLineIfNeeded [0x0378D4D8+13983416]
RelaunchChromeBrowserWithNewCommandLineIfNeeded [0x0368EA9D+12940413]
content::Stream::url [0x0CCC03E3+5571221]
(No symbol) [0x0124E69E]
(No symbol) [0x01253153]
(No symbol) [0x0125486F]
(No symbol) [0x01253DA2]
(No symbol) [0x01254307]
(No symbol) [0x0146B6B5]
(No symbol) [0x0146AECC]
(No symbol) [0x0146BFA3]
(No symbol) [0x0146EB0B]
(No symbol) [0x0146EABA]
(No symbol) [0x0146EA3A]
PrefService::RemovePrefObserver [0x0A3DFC3F+312458]
PrefService::RemovePrefObserver [0x0A3DF27B+309958]
PrefService::RemovePrefObserver [0x0A3E5542+335245]
PrefService::RemovePrefObserver [0x0A3E54F5+335168]
PrefService::RemovePrefObserver [0x0A3E5462+335021]
PrefService::RemovePrefObserver [0x0A3DBA0C+295511]
PrefService::RemovePrefObserver [0x0A3DF24B+309910]
PrefService::RemovePrefObserver [0x0A3B2126+125297]
PrefService::RemovePrefObserver [0x0A3B1B52+123805]
PrefService::RemovePrefObserver [0x0A3DABA2+291821]
PrefService::RemovePrefObserver [0x0A3DB6E3+294702]
PrefService::RemovePrefObserver [0x0A3DA384+289743]
RelaunchChromeBrowserWithNewCommandLineIfNeeded [0x02AF208F+764527]
RelaunchChromeBrowserWithNewCommandLineIfNeeded [0x02AF1BBD+763293]
(No symbol) [0x0205AB30]
(No symbol) [0x02067F73]
(No symbol) [0x02067C87]
(No symbol) [0x02067A58]
base::win::OSInfo::processors [0x1005E94F+321386]
base::win::OSInfo::processors [0x100E6CC3+879326]
base::win::OSInfo::processors [0x100E71B4+880591]
base::win::OSInfo::processors [0x100E8076+884369]
base::win::OSInfo::processors [0x100FBB44+964959]
base::win::OSInfo::processors [0x100FAC92+961197]
base::win::OSInfo::processors [0x1002811C+98103]
base::win::OSInfo::processors [0x100E6809+878116]
base::win::OSInfo::processors [0x100E655E+877433]
base::win::OSInfo::processors [0x10162DA9+1387460]
(No symbol) [0x018AC3B3]
(No symbol) [0x018ACE9E]
(No symbol) [0x018AEE90]
(No symbol) [0x018AE6E5]
(No symbol) [0x018B056C]
(No symbol) [0x018B08A5]
(No symbol) [0x00DF8892]
(No symbol) [0x00DFC6ED]
(No symbol) [0x01197A02]
(No symbol) [0x0192311E]
(No symbol) [0x019236DB]
(No symbol) [0x019236AA]
(No symbol) [0x01923665]
(No symbol) [0x004E9DBF]
RelaunchChromeBrowserWithNewCommandLineIfNeeded [0x02A3B03F+14879]
RelaunchChromeBrowserWithNewCommandLineIfNeeded [0x02A38C77+5719]
(No symbol) [0x02434F36]
> Put a tab overlay over installing v1 apps in the app launcher.
>
>
> BUG=179300
>
>
> Review URL: https://chromiumcodereview.appspot.com/12508011
TBR=koz@chromium.org
Review URL: https://codereview.chromium.org/12643009
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@187870 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=179300
Review URL: https://chromiumcodereview.appspot.com/12508011
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@187850 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Currently the destructor for AppsModelBuilder tries to reacquire InstallTracker
via its factory, but at that point the service has been Shutdown().
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=185086
Review URL: https://codereview.chromium.org/12377002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@185098 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Causes build break on Linux ASAN.
http://build.chromium.org/p/chromium.memory/builders/Linux%20ASAN%20Builder/builds/19933
> Don't re-get InstallTracker in AppsModelBuilder.
>
> Currently the destructor for AppsModelBuilder tries to reacquire InstallTracker
> via its factory, but at that point the service has been Shutdown().
>
> Review URL: https://codereview.chromium.org/12377002
TBR=koz@chromium.org
Review URL: https://codereview.chromium.org/12390003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@185087 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
Currently the destructor for AppsModelBuilder tries to reacquire InstallTracker
via its factory, but at that point the service has been Shutdown().
Review URL: https://codereview.chromium.org/12377002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@185086 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
> Revert 184604
> > Change NotifyAppList*() functions into observers on a ProfileKeyedService.
> >
> > This causes the events to also be delivered to the app list on ChromeOS, which would otherwise require separate plumbing.
> >
> >
> > BUG=152854
> >
> >
> > Review URL: https://chromiumcodereview.appspot.com/12298015
>
> TBR=koz@chromium.org
> Review URL: https://codereview.chromium.org/12340071
TBR=henrika@chromium.org
Review URL: https://codereview.chromium.org/12326123
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@184636 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
> Change NotifyAppList*() functions into observers on a ProfileKeyedService.
>
> This causes the events to also be delivered to the app list on ChromeOS, which would otherwise require separate plumbing.
>
>
> BUG=152854
>
>
> Review URL: https://chromiumcodereview.appspot.com/12298015
TBR=koz@chromium.org
Review URL: https://codereview.chromium.org/12340071
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@184627 0039d316-1c4b-4281-b951-d872f2087c98
|
|
This causes the events to also be delivered to the app list on ChromeOS, which would otherwise require separate plumbing.
BUG=152854
Review URL: https://chromiumcodereview.appspot.com/12298015
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@184604 0039d316-1c4b-4281-b951-d872f2087c98
|