summaryrefslogtreecommitdiffstats
path: root/chrome/browser/extensions/theme_installed_infobar_delegate.h
Commit message (Collapse)AuthorAgeFilesLines
* Cleanup: de-inline a bunch of classes, rename and move "PluginInstaller" to ↵pkasting@chromium.org2011-01-211-13/+18
| | | | | | | | | | "PluginInstallerInfoBarDelegate" for clarity, lots of other misc. stuff BUG=none TEST=none Review URL: http://codereview.chromium.org/6249010 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@72166 0039d316-1c4b-4281-b951-d872f2087c98
* Part 3 of immutable Extension refactor.mpcomplete@chromium.org2010-10-291-1/+1
| | | | | | | | | | | | | Make ExtensionsService hold const Extension pointers only. This ensures that extensions can't be modified after they're created, and lets us share them between threads. BUG=56558 TEST=no functional change Review URL: http://codereview.chromium.org/4138006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@64517 0039d316-1c4b-4281-b951-d872f2087c98
* Convert infobar APIs to UTF-16.evan@chromium.org2010-08-131-2/+2
| | | | | | | | | | | | | | | | | The critical change is the base class in infobar_delegate.h. The remainder is just adapting all users to that change. I grepped for all instances of the three base functions whose types I changed to be more sure that I found all classes that tried to overload these functions. I sure wish C++ had an @Override annotation. :~( TEST=compiles BUG=23581 Review URL: http://codereview.chromium.org/3127009 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@56066 0039d316-1c4b-4281-b951-d872f2087c98
* `#pragma once` for app, base, chrome, gfx, ipc, net, skia, viewsthakis@chromium.org2010-07-261-0/+1
| | | | | | | | | BUG=50273 TEST=everything still builds, build is 10% faster on windows, same speed on mac/linux TBR: erg git-svn-id: svn://svn.chromium.org/chrome/trunk/src@53716 0039d316-1c4b-4281-b951-d872f2087c98
* Before creating a theme info bar, check if one is already visible for the ↵bulach@chromium.org2010-04-221-1/+5
| | | | | | | | | | | | | same theme. (landing for satish@chromium.org, original http://codereview.chromium.org/1745003/show) This allows user to easily undo a theme install if they accidentally installed the same theme multiple times. BUG=40856 TEST=visit the themes gallery, install the same theme twice and hit 'Undo' in the theme info bar to verify that it rolls back to the correct previous theme. Review URL: http://codereview.chromium.org/1771001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@45331 0039d316-1c4b-4281-b951-d872f2087c98
* Close previous theme info bars when resetting to default themebulach@chromium.org2010-04-201-1/+18
| | | | | | | | | | | | Select and close previous theme info bars when resetting to default theme via the options dialog. As a nice side effect if one tab is showing a theme info bar and the user switches to a different theme in another tab, this change closes the previous theme info bars as well. (landing for satish@chromium.org / http://codereview.chromium.org/1622017/show) BUG=35607 TEST=Install a theme, and with the theme info bar visible open Preferences dialog and click 'reset to default theme' and check the info bar. (full steps given in the above bug entry) Review URL: http://codereview.chromium.org/1650016 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@45034 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 44885 - Select and close previous theme info bars when resetting to ↵jorlow@chromium.org2010-04-181-18/+1
| | | | | | | | | | | | | | | | | default theme via the options dialog. As a nice side effect if one tab is showing a theme info bar and the user switches to a different theme in another tab, this change closes the previous theme info bars as well. BUG=35607 TEST=Install a theme, and with the theme info bar visible open Preferences dialog and click 'reset to default theme' and check the info bar. (full steps given in the above bug entry) Landing http://codereview.chromium.org/1622017/show for Satish. Review URL: http://codereview.chromium.org/1600030 TBR=jorlow@chromium.org Review URL: http://codereview.chromium.org/1599038 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@44886 0039d316-1c4b-4281-b951-d872f2087c98
* Select and close previous theme info bars when resetting to default theme ↵jorlow@chromium.org2010-04-181-1/+18
| | | | | | | | | | | | | | via the options dialog. As a nice side effect if one tab is showing a theme info bar and the user switches to a different theme in another tab, this change closes the previous theme info bars as well. BUG=35607 TEST=Install a theme, and with the theme info bar visible open Preferences dialog and click 'reset to default theme' and check the info bar. (full steps given in the above bug entry) Landing http://codereview.chromium.org/1622017/show for Satish. Review URL: http://codereview.chromium.org/1600030 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@44885 0039d316-1c4b-4281-b951-d872f2087c98
* [More BTP includes.]erg@google.com2009-12-181-5/+1
| | | | | | | | | | | | | | | | | | | | | | Uninstall themes when all theme infobars are gone; not on each infobar's destruction. There are multiple problems with the current implementation: - It handles multiple tabs with theme install infobars badly. - It has a subtle race condition where installing a second theme, and then installing the original theme (note: not clicking undo) uninstalled both themes. Instead, only uninstall unused themes when all infobars are closed down. BUG=none TEST=Install theme A. Install theme B. Install theme A. Restart chrome. Theme A should show. TEST=Install theme A in window 1. Install theme B in window 2. Install theme C in window 3. Clicking undo in any of those windows in any order should work. Previous Review URL: http://codereview.chromium.org/504052 Review URL: http://codereview.chromium.org/501096 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@34900 0039d316-1c4b-4281-b951-d872f2087c98
* TBR: Revert to fix Chromos.erg@google.com2009-12-171-1/+5
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@34891 0039d316-1c4b-4281-b951-d872f2087c98
* Uninstall themes when all theme infobars are gone; not on each infobar's ↵erg@google.com2009-12-171-5/+1
| | | | | | | | | | | | | | | | | | | | destruction. There are multiple problems with the current implementation: - It handles multiple tabs with theme install infobars badly. - It has a subtle race condition where installing a second theme, and then installing the original theme (note: not clicking undo) uninstalled both themes. Instead, only uninstall unused themes when all infobars are closed down. BUG=none TEST=Install theme A. Install theme B. Install theme A. Restart chrome. Theme A should show. TEST=Install theme A in window 1. Install theme B in window 2. Install theme C in window 3. Clicking undo in any of those windows in any order should work. Review URL: http://codereview.chromium.org/504052 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@34890 0039d316-1c4b-4281-b951-d872f2087c98
* Fixes almost all of the rest of lint errors in the chrome/ directory (minus ↵erg@google.com2009-11-131-3/+3
| | | | | | | | the really hard ones which will need actual review instead of rubber-stamping.) Review URL: http://codereview.chromium.org/386026 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31932 0039d316-1c4b-4281-b951-d872f2087c98
* Uninstall themes after the undo infobar goes away.tony@chromium.org2009-10-291-4/+12
| | | | | | | | | | | | We don't hold a pointer to the Extension in ThemeInstalledInfobarDelegate because it can become invalid. Instead we use the id to uninstall if the extension exists at infobar close time. Also keep the code for deleting themes on shutdown to clean up old users and because a crash could leave themes hanging around. BUG=25832 Review URL: http://codereview.chromium.org/343027 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30466 0039d316-1c4b-4281-b951-d872f2087c98
* Reland: Rename ThemePreviewInfobarDelegate toaa@chromium.org2009-10-091-0/+38
| | | | | | | | | | ThemeInstalledInfoBarDelegate Contributed by Thiago Farina <tfarina@gmail.com> TBR=rafaelw@chromium.org git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28595 0039d316-1c4b-4281-b951-d872f2087c98
* Revert r28519-28523. Accidentally used wrong command,aa@chromium.org2009-10-091-38/+0
| | | | | | | | | committing a bunch of local changes individually with bad commit messages. TBR=rafaelw@chromium.org git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28525 0039d316-1c4b-4281-b951-d872f2087c98
* patch from issue 261007aa@chromium.org2009-10-091-11/+8
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28520 0039d316-1c4b-4281-b951-d872f2087c98
* copy files to new location to help git cl patchaa@chromium.org2009-10-091-0/+41
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28519 0039d316-1c4b-4281-b951-d872f2087c98
generated by cgit v1.1 at 2025-04-01 13:30:53 +0000