summaryrefslogtreecommitdiffstats
path: root/chrome/browser/extensions
Commit message (Collapse)AuthorAgeFilesLines
* handle index from bookmarks API properlyerikkay@chromium.org2009-08-211-2/+1
| | | | | | | | | BUG=19866 TEST=ExtensionApiTest.Bookmarks Review URL: http://codereview.chromium.org/173220 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@24020 0039d316-1c4b-4281-b951-d872f2087c98
* Load extensions that have their manifest in the Prefs on the UI thread.mpcomplete@chromium.org2009-08-218-226/+173
| | | | | | | | | | | | | | | | There is some migration code for loading old extensions which we do on the UI thread as well, for simplicity. This will only happen the first time the user starts Chrome, so I think it's OK. Also cleaned up the EXTENSIONS_LOADED notification to send out a single extension, instead of a 1-element list of extensions. BUG=18293 TEST=loading extensions should still work Review URL: http://codereview.chromium.org/174208 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23997 0039d316-1c4b-4281-b951-d872f2087c98
* Reapply r23840 - Also return bookmark index through bookmarks API.kuchhal@chromium.org2009-08-201-1/+4
| | | | | | Review URL: http://codereview.chromium.org/173155 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23903 0039d316-1c4b-4281-b951-d872f2087c98
* Remove include of IPC headers from headers they crept into. This slows down ↵jam@chromium.org2009-08-201-0/+1
| | | | | | | | the build. Review URL: http://codereview.chromium.org/174148 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23884 0039d316-1c4b-4281-b951-d872f2087c98
* Disable the Bookmarks ExtensionAPITest becuase it is flaky.brettw@chromium.org2009-08-201-1/+2
| | | | | | Review URL: http://codereview.chromium.org/173149 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23877 0039d316-1c4b-4281-b951-d872f2087c98
* Get rid of the extension's "Current Version" file.mpcomplete@chromium.org2009-08-2010-281/+240
| | | | | | | | | | | | The entire manifest.json value is now stored in the prefs file. This will allow for quick extension checks on startup. BUG=18293 TEST=Make sure installing/upgrading/uninstalling extensions works as expected. Review URL: http://codereview.chromium.org/174036 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23848 0039d316-1c4b-4281-b951-d872f2087c98
* Revert "Also return bookmark index through bookmarks API."kuchhal@chromium.org2009-08-201-4/+1
| | | | | | | | Revert r23840 Review URL: http://codereview.chromium.org/173133 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23847 0039d316-1c4b-4281-b951-d872f2087c98
* Also return bookmark index through bookmarks API.kuchhal@chromium.org2009-08-201-1/+4
| | | | | | Review URL: http://codereview.chromium.org/173074 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23840 0039d316-1c4b-4281-b951-d872f2087c98
* Fix theme install on 64 bit chromium builds.tony@chromium.org2009-08-201-4/+4
| | | | | | | | | | Extension signature sizes are always 4 bytes, not variable depending on platform. Review URL: http://codereview.chromium.org/173104 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23837 0039d316-1c4b-4281-b951-d872f2087c98
* Do extensions update manifest XML parsing in a sandboxed process.asargent@chromium.org2009-08-205-423/+197
| | | | | | | | | | | | | | | | This involves moving the xml parsing code from static functions in extension_updater.cc to a UpdateManifest class, and switching from logging any errors directly to collecting them up and passing them across the IPC channel. BUG=http://crbug.com/12677 TEST=extensions auto-update should still work correctly Review URL: http://codereview.chromium.org/164541 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23822 0039d316-1c4b-4281-b951-d872f2087c98
* This change enables Chrome to load locale information for the extension. It ↵cira@chromium.org2009-08-196-0/+447
| | | | | | | | | | | | | | | | | | | | | | detects default locale, and filters out all locales not supported by Chrome or with invalid names/missing messages. It also checks for folders that start with _ and are not in the reserved list. We don't validate messages file with this CL. Added support for loading supplied locale information to the extension_file_util, and detecting default locale. Added new constants to extension class (_locales directory name, messages filename). Added new error messages to _constants. Added new unittests. BUG=12131 TEST=There should be no visible changes, except in case of error when loading extension (e.g. create empty _locales folder and try loading). Review URL: http://codereview.chromium.org/170015 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23739 0039d316-1c4b-4281-b951-d872f2087c98
* Re-implement BackingStore on the Mac as a CGLayer instead of a Skia canvas,amanda@chromium.org2009-08-191-2/+17
| | | | | | | | | | | | | | to get better performance. As a side effect, remove the ugly stopgap scrolling code. Do not close 14823 with this fix, but it should help (primary motivation was improving the plugin drawing path). Paul: review rafael: please check the change to extension_tabs_module.cc John, Rohit: FYI, comments welcome BUG=14823, TEST=scrolling and plugin performance should improve Review URL: http://codereview.chromium.org/171054 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23722 0039d316-1c4b-4281-b951-d872f2087c98
* Lands <http://codereview.chromium.org/165297> for thiago.farina@gmail.com.hbono@chromium.org2009-08-192-2/+2
| | | | | | | | | | | | | | R=me From Thiago: Replaces some TrimWhitespace with TrimWhitespaceASCII or TrimWhitespaceUTF8. BUG=9851 TEST=run base_unittests.exe, unit_tests.exe and ui_tests.exe Review URL: http://codereview.chromium.org/172039 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23703 0039d316-1c4b-4281-b951-d872f2087c98
* Async extension callbacks now always fire and set chrome.extension.lastError ↵rafaelw@chromium.org2009-08-181-0/+17
| | | | | | | | | | | | on error. Includes doc changes for extension.lastError and a browsertest. BUG=17381 Review URL: http://codereview.chromium.org/172078 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23676 0039d316-1c4b-4281-b951-d872f2087c98
* Show the extension install UI when the user clicks Reenable for a ↵mpcomplete@chromium.org2009-08-187-103/+169
| | | | | | | | | | | | | | | disabled-on-upgrade extension. Also fix a couple misc bugs with disabled extensions: - Fix a crash when trying to reenable an uninstalled disabled extension. - Fix a bug where upgrading a disabled extension would reenable it. BUG=12140 TEST=no Review URL: http://codereview.chromium.org/172006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23675 0039d316-1c4b-4281-b951-d872f2087c98
* Revert "Fix "crashed extension" infobar browser crashes."phajdan.jr@chromium.org2009-08-188-155/+84
| | | | | | | | TBR=cevans Review URL: http://codereview.chromium.org/173014 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23644 0039d316-1c4b-4281-b951-d872f2087c98
* Implement chrome.tabs.captureVisibleTab for linuxerg@google.com2009-08-181-0/+4
| | | | | | | | http://crbug.com/19532 Review URL: http://codereview.chromium.org/172072 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23638 0039d316-1c4b-4281-b951-d872f2087c98
* Renames the function CreateTemporaryFilename to CreateTemporaryFile and ↵erikkay@chromium.org2009-08-181-1/+1
| | | | | | | | | | | | | | track down all callers, also removes the deprecated function that uses std::wstring. BUG=3078 (http://crbug.com/3078) TEST=run base_unittests, installer_util_unittests, net_unittests, setup_unittests, and unit_tests. Review URL: http://codereview.chromium.org/164537 Patch from Thiago Farina. git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23631 0039d316-1c4b-4281-b951-d872f2087c98
* Fix "crashed extension" infobar browser crashes.phajdan.jr@chromium.org2009-08-188-84/+155
| | | | | | | | | | | | This is a general rework of how "crashed extension" infobar works and how the extension is actually recovered after the crash. TEST=See bug. http://crbug.com/15888 Review URL: http://codereview.chromium.org/164151 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23628 0039d316-1c4b-4281-b951-d872f2087c98
* Call the new FilePath API to make sure the untrusted sandboxed process is notcevans@chromium.org2009-08-181-2/+12
| | | | | | | | | | | sending us paths with .. in them. BUG=NONE TEST=NONE Review URL: http://codereview.chromium.org/171025 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23597 0039d316-1c4b-4281-b951-d872f2087c98
* An initial pass at structure to do end-to-end extension API tests. I'll ↵erikkay@chromium.org2009-08-177-6/+201
| | | | | | | | work on actually fleshing out some tests in the next CL. Review URL: http://codereview.chromium.org/171032 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23577 0039d316-1c4b-4281-b951-d872f2087c98
* DevTools: remove TODO on completed item.pfeldman@chromium.org2009-08-171-1/+0
| | | | | | | | | BUG=19335 TBR=aa Review URL: http://codereview.chromium.org/171036 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23543 0039d316-1c4b-4281-b951-d872f2087c98
* Undo disabled toolstrip test, now that upstream bug is fixed.aa@chromium.org2009-08-151-1/+1
| | | | | | | TBR=mpcomplete@chromium.org BUG=19335 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23515 0039d316-1c4b-4281-b951-d872f2087c98
* Adds a copyright header to extension_browsertest.cc and fixes lint error.mpcomplete@chromium.org2009-08-142-3/+9
| | | | | | Review URL: http://codereview.chromium.org/171005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23499 0039d316-1c4b-4281-b951-d872f2087c98
* Disable UpdatePermissions until I can figure out why it's failing.mpcomplete@chromium.org2009-08-141-0/+3
| | | | | | | | | | BUG=no TEST=no TBR=aa Review URL: http://codereview.chromium.org/171002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23492 0039d316-1c4b-4281-b951-d872f2087c98
* Disable an extension when it is upgraded to a version that requires morempcomplete@chromium.org2009-08-1412-69/+389
| | | | | | | | | | | | | permissions then before, and prompt the user to re-enable. Incidentally, this required adding support for disabling extensions. BUG=12140 TEST=covered by unit tests Review URL: http://codereview.chromium.org/165414 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23480 0039d316-1c4b-4281-b951-d872f2087c98
* Implement chrome.tabs.getVisibleTabCapture() on Macrafaelw@chromium.org2009-08-141-1/+4
| | | | | | Review URL: http://codereview.chromium.org/165429 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23479 0039d316-1c4b-4281-b951-d872f2087c98
* remove some unneeded DCHECKs (from an earlier review comment you made)erikkay@chromium.org2009-08-141-5/+1
| | | | | | | | | BUG=none TEST=none Review URL: http://codereview.chromium.org/165545 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23456 0039d316-1c4b-4281-b951-d872f2087c98
* Temporarily disable ExtensionBrowserTest.Toolstrip while the levin@chromium.org2009-08-141-1/+2
| | | | | | | | | | | | crash is being investigated. BUG=http://crbug.com/19335 TEST=None Review URL: http://codereview.chromium.org/164549 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23426 0039d316-1c4b-4281-b951-d872f2087c98
* The change has the followings:lzheng@chromium.org2009-08-149-101/+670
| | | | | | | | | | | | | | | 1. Auto-updating of extension blacklist. 2. Handle extensions in the blacklist. If an extension is in the blacklist, a. browser will not load the extension at start time; b. browser will unload the extension at running time; c. browser will not install the extension; BUG=12118 TEST=Verify behavior described above works (they should be covered in the unittests in this change). Review URL: http://codereview.chromium.org/165164 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23423 0039d316-1c4b-4281-b951-d872f2087c98
* Implementation of getBackgroundPage(), getToolstrips(), andaa@chromium.org2009-08-144-8/+77
| | | | | | | | | | | | | | | getTabContentses(). This lands http://codereview.chromium.org/159067. Raf, the only thing you need to look at is the changes to extensions_process_bindings.js and extension_api.json. BUG=13577 TEST=Browser tests added Review URL: http://codereview.chromium.org/164458 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23422 0039d316-1c4b-4281-b951-d872f2087c98
* Make confirm info bar buttons support mnemonics.tony@chromium.org2009-08-131-2/+6
| | | | | | | | | | | | I think this is temporary because we're past string freeze and the undo text is borrowed from elsewhere. I should have caught this in the last change. :( Review URL: http://codereview.chromium.org/164490 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23360 0039d316-1c4b-4281-b951-d872f2087c98
* Add some paranoid CHECKs to the ExtensionMessageService to track down a crash.mpcomplete@chromium.org2009-08-131-0/+11
| | | | | | | | | BUG=19067 TEST=no Review URL: http://codereview.chromium.org/165431 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23345 0039d316-1c4b-4281-b951-d872f2087c98
* Add privacy_blacklists key to extension manifest and validate it.phajdan.jr@chromium.org2009-08-131-0/+12
| | | | | | | | | | | This is the first step towards shipping privacy blacklists in extensions. TEST=Covered by unit_tests. BUG=none Review URL: http://codereview.chromium.org/164349 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23316 0039d316-1c4b-4281-b951-d872f2087c98
* I have taken over this patch, original authored by Adam Hunter (adamhunter).rafaelw@chromium.org2009-08-135-0/+95
| | | | | | | | | | | | | | | | | | | | | | | The original issue is: http://codereview.chromium.org/144019 -------------- Functionality has been requested in the Extension API for Javascript to take screenshots of the currently visible tab. This changelist builds this function, chrome.tabs.getVisibleScreenCapture. This function takes a single callback function and returns to that function a data URL of a JPEG image of the current screen. A simple sample extension is provided as a use case. BUG=14760 TEST=There is an extension in chrome\test\data\extensions\samples\screenshot, load this extension. It creates a toolstrip button. Click this button, you should get a page with a screenshot of the active tab. The API function is found at chrome.tabs.getVisibleScreenCapture. Review URL: http://codereview.chromium.org/160228 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23259 0039d316-1c4b-4281-b951-d872f2087c98
* Add a default icon for theme install infobar.glen@chromium.org2009-08-121-1/+4
| | | | | | | | | BUG=18227 TEST=Install a theme, verify that an infobar with a pretty icon appears. Review URL: http://codereview.chromium.org/165205 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23126 0039d316-1c4b-4281-b951-d872f2087c98
* Make the theme install infobar have an 'undo' button insteadaa@chromium.org2009-08-114-17/+34
| | | | | | | | | | | of a 'back to default' button. BUG=18986 TEST=none Review URL: http://codereview.chromium.org/164312 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23055 0039d316-1c4b-4281-b951-d872f2087c98
* Revert "Fix "crashed extension" infobar browser crashes."phajdan.jr@chromium.org2009-08-118-155/+84
| | | | | | | | Will it fix browser_tests crashes on Vista? Review URL: http://codereview.chromium.org/165287 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22998 0039d316-1c4b-4281-b951-d872f2087c98
* Fix "crashed extension" infobar browser crashes.phajdan.jr@chromium.org2009-08-118-84/+155
| | | | | | | | | | | | This is a general rework of how "crashed extension" infobar works and how the extension is actually recovered after the crash. TEST=See bug. http://crbug.com/15888 Review URL: http://codereview.chromium.org/164151 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22985 0039d316-1c4b-4281-b951-d872f2087c98
* vector.end() is out of range, need to erase (end() - 1)jnd@chromium.org2009-08-091-24/+15
| | | | | | | | | BUG=none TEST=none Review URL: http://codereview.chromium.org/165045 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22886 0039d316-1c4b-4281-b951-d872f2087c98
* Committing for Siggi based on review:mad@google.com2009-08-082-9/+15
| | | | | | | | http://codereview.chromium.org/165134 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22858 0039d316-1c4b-4281-b951-d872f2087c98
* Add module-level permissions to extensions.mpcomplete@chromium.org2009-08-074-3/+19
| | | | | | | | | | | | | | This first pass is fairly simple. If a permission is not specified in the manifest, the corresponding module will not be exposed to script. For example, without specifying the "tabs" permission, chrome.tabs and chrome.windows will not be available. BUG=12140 TEST=no Review URL: http://codereview.chromium.org/164039 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22745 0039d316-1c4b-4281-b951-d872f2087c98
* Fix a few bugs with the theme infobar:aa@chromium.org2009-08-071-5/+11
| | | | | | | | | | | | | | * Don't animate the infobar closing and opening when switching between themes. * Don't show multiple infobars when intalling themes in rapid succession. BUG=18213 Review URL: http://codereview.chromium.org/165029 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22711 0039d316-1c4b-4281-b951-d872f2087c98
* Add a temporary extension error message box on linux.tc@google.com2009-08-061-2/+4
| | | | | | | | | The NOTREACHED() crashed my debug build. Review URL: http://codereview.chromium.org/164088 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22695 0039d316-1c4b-4281-b951-d872f2087c98
* Correctly handle extensions width in the GTK extension shelf.phajdan.jr@chromium.org2009-08-061-2/+2
| | | | | | | | | | | Also make the method name used on Windows shorter and more obvious. TEST=none http://crbug.com/16759 Review URL: http://codereview.chromium.org/164092 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22672 0039d316-1c4b-4281-b951-d872f2087c98
* Switch extension update manifest parse errors to LOG(WARN).asargent@chromium.org2009-08-061-1/+1
| | | | | | | | | | | | | | | | Before this patch they are using ExtensionErrorReporter, but I don't think it's actually useful for users to see them on the chrome://extensions page. BUG=http://crbug.com/18565 TEST=You should no longer see messages like "Extension update manifest parse error: Invalid codebase url"on the chrome://extensions page. Review URL: http://codereview.chromium.org/164008 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22662 0039d316-1c4b-4281-b951-d872f2087c98
* Don't show themes in extension config UI. This fixes various bugsaa@chromium.org2009-08-061-11/+5
| | | | | | | | | | | | | | | | where the extension config UI doesn't work right with themes. This isn't ideal because users go to chrome://extensions/ expecting themes to be listed. If they aren't there, users might be confused. But I don't have an alternate solution. Also, this change removes the error listing from the top of chrome://extensions/. These errors are just getting noisy, I don't think they provide much value. BUG=13649,18456 Review URL: http://codereview.chromium.org/160631 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22578 0039d316-1c4b-4281-b951-d872f2087c98
* extensions: clean up some code I saw while tracking down a bugevan@chromium.org2009-08-051-4/+3
| | | | | | | | The bug was already fixed, but this change shouldn't hurt too. Review URL: http://codereview.chromium.org/162020 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22524 0039d316-1c4b-4281-b951-d872f2087c98
* Undo my bonehead mistake of checking in a modification to theaa@chromium.org2009-08-051-6/+0
| | | | | | | | hardcoded theme gallery URL. Review URL: http://codereview.chromium.org/159888 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22448 0039d316-1c4b-4281-b951-d872f2087c98
* Unpack extensions in-process in --single-process mode.mpcomplete@chromium.org2009-08-041-1/+3
| | | | | | | | | TEST=no BUG=no Review URL: http://codereview.chromium.org/159833 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22447 0039d316-1c4b-4281-b951-d872f2087c98
generated by cgit v1.1 at 2025-06-14 20:36:52 +0000