| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
|
|
|
|
|
| |
Also notify other browser windows of changes to the order.
BUG=http://code.google.com/p/chromium/issues/detail?id=12123
TEST=browser_tests.exe --gtest_filter=ExtensionShelfModelTest.*
Review URL: http://codereview.chromium.org/131114
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18845 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
See: http://codereview.chromium.org/126098
Patch from Jerry Tang <tangjie@google.com>.
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18837 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
It only passes on the build bots because they still have old directories, I
think? AbsolutePath() on POSIX will fail if the path doesn't exist. We let
the program march on in that case and the normal error handling (that would
handle the non-existent path) make the tests continue to pass.
Review URL: http://codereview.chromium.org/132054
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18834 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
Also correctly handle crashes in task manager. The infobar allows user to restart the extension process.
TEST=Install buildbot extension, see its content in the shelf. Open task manager, kill extension process. Click "restart" in the infobar that should appear. The extension content in the shelf should re-appear after the crash.
http://crbug.com/14111
Review URL: http://codereview.chromium.org/126289
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18809 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
TBR=mpcomplete
Review URL: http://codereview.chromium.org/131093
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18784 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Also add onLoad and onUnload chrome Event to our bindings, so we can add
listeners to these events without needing a DOM. These don't hook into the
window "unload" event, so we no longer prevent Chrome's sudden termination of
tabs on shutdown.
BUG=12686
TEST=no
Review URL: http://codereview.chromium.org/125280
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18765 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
Relands http://codereview.chromium.org/126281 which had been reverted due to a leak.
The only difference is in extension_prefs.h where extension_data_ is now a scoped_ptr.
Review URL: http://codereview.chromium.org/131040
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18717 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
Broke purify and mac valgrind. "Pull Extension-related prefs into its own class. Also add a notification for when the extensions service has finished its initial load of extensions, separate from EXTENSIONS_LOADED.TEST=noneBUG=none"
Review URL: http://codereview.chromium.org/132008
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18682 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
for when the extensions service has finished its initial load of extensions, separate from EXTENSIONS_LOADED.TEST=noneBUG=none
Review URL: http://codereview.chromium.org/126281
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18661 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
goes away.
Combine the various ExtensionMessageService IPC message into a single "Invoke"
message.
BUG=12686
TEST=no
Review URL: http://codereview.chromium.org/126234
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18645 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
Original issue: http://codereview.chromium.org/119325
r=rafaelw,Jói,stoyan,aa
Review URL: http://codereview.chromium.org/125206
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18555 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
through prefs.
First we try the path as absolute path. If the file is not found, we try a relative path: [installation path]\extensions
This will make installing extensions easier from pre-installed prefs, since we can drop them into an extensions directory under the program directory.
BUG=14202
TEST=Specify relative path when installing extensions through prefs. Best to test this with an installer that supports deploying extensions (blocked on 14201)
Review URL: http://codereview.chromium.org/125219
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18554 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
This is erikkay's patch. I'm landing it while he's away.
TBR=erikkay
BUG=none
TEST=install an extension with a toolstrip and close chrome. It shouldn't
crash.
Review URL: http://codereview.chromium.org/126219
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18516 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
In my scan of headers I got up to browser/gtk/
Review URL: http://codereview.chromium.org/126131
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18500 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
instead of the crx file.
Review URL: http://codereview.chromium.org/125172
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18480 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
so I am changing to something I know will work.
Review URL: http://codereview.chromium.org/125167
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18476 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
properly when a browser window was closed.
BUG=13975
TEST=see bug for repro steps
Review URL: http://codereview.chromium.org/125164
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18470 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=ExtensionViewTest.Incognito
Review URL: http://codereview.chromium.org/126175
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18466 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
entries needed to permanently fix.
Review URL: http://codereview.chromium.org/125162
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18462 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
all threads.
BUG=13914
TEST=install an extension an make sure the install dialog window shows up in front of
the Chrome window.
Review URL: http://codereview.chromium.org/125077
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18430 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=browser_tests.exe --gtest_filter=ExtensionViewTest.Incognito
Review URL: http://codereview.chromium.org/126151
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18427 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=None
TEST=Covered by automated tests.
Review URL: http://codereview.chromium.org/125137
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18400 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
* load extensions from prefs rather than by scanning filesystem
* fix multiple loading bug
* in-place upgrade
* split out Init() behavior into individual pieces that can be called by tests
Also:
* add look up of extension by URL
* rename GetExtensionByID -> GetExtensionById
BUG=12399
BUG=14053
TEST=ExtensionServiceTest.*
Review URL: http://codereview.chromium.org/125102
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18397 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
- remove unneeded header includes
- move implementation bits out of headers
- more explicit header deps
In my scan of headers I got up to (including) dom_ui.
Review URL: http://codereview.chromium.org/126071
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18353 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
- register for notifications when extension hosts are created/destroyed
- collapse extension tabs into just one table row, also for tabs opened while the task manager stays open
TEST=Start chrome.exe with --enable-extensions. Install the buildbot monitor extension. Open the task manager. You should see an extension process.
http://crbug.com/12127
Review URL: http://codereview.chromium.org/125047
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18352 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
length to 32 chars (exactly 128 bits).
Review URL: http://codereview.chromium.org/126074
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18351 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This is second try of:
http://codereview.chromium.org/115682
that was comitted in in 18189 and reverted.
BUG=12114
R=erikkay,wtc,aa
Review URL: http://codereview.chromium.org/126014
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18316 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
top-windows).Components that have HWND now need to specifically let the FocusManager know when they get the native focus.This is the reason for the new GotFocus() notification on the RenderWidgetHostViewWin class.BUG=NoneTEST=Run the interactive tests, the unit-tests. Test that the focus is remembered correctly when switching windows, switching tabs. Test that focus traversal in the browser and in the option dialog works as expected.
Review URL: http://codereview.chromium.org/122002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18301 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
ExtensionView. This was leading to crashes at shutdown as well as shutdown code not cleaning up properly.
BUG=13974
TEST=none
Review URL: http://codereview.chromium.org/126064
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18296 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This should fix leaks at:
extensions_service.cc:495 and 498
... and since the providers are getting cleaned up, it should take care of:
extensions_service.cc:211
... as well.
TBR=erikkay
TEST=Covered by automated tests.
BUG=None
Review URL: http://codereview.chromium.org/126037
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18251 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
Registry and Preferences into separate classes. While I was at it, I removed the EXTERNAL_INSTALL file, since we now keep track of this in the Preferences.
This also takes care of the virtualization problem in the unit tests for vista (see bug).
BUG=13063
TEST=None, covered by automated tests.
Review URL: http://codereview.chromium.org/122004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18247 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
This reverts commit r18189.
TBR=rafaelw
Review URL: http://codereview.chromium.org/125004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18193 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
R=erikkay,wtc
Review URL: http://codereview.chromium.org/115682
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18189 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
extensions.
Review URL: http://codereview.chromium.org/122021
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18186 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/119448
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18181 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
This reverts commit 4775c631c09be565706f8a6ce3c4659bc89097e4.
Review URL: http://codereview.chromium.org/122024
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18149 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
events to extensions. Implements an initial test that send all
known window, tab, page action, and bookmark events and makes
sure the extension received them.
Original review: http://codereview.chromium.org/119325
Review URL: http://codereview.chromium.org/123010
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18148 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
This reverts commit 9b7fbb1e720ab2071b30531fd0266918c4e68d12.
Review URL: http://codereview.chromium.org/122022
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18147 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
events to extensions. Implements an initial test that send all
known window, tab, page action, and bookmark events and makes
sure the extension received them.
Original review: http://codereview.chromium.org/119325
Review URL: http://codereview.chromium.org/123009
Patch from Roger Tawa <rogerta@gmail.com>.
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18146 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
when extensions are disabled.
BUG=12076
TEST=Added a unit test. Also, install an extension, then create a new version of it and overinstall. You should not see two of them.
Review URL: http://codereview.chromium.org/123004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18140 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Add a browsertest to make sure we don't crash with an incognito window open.
Had to finagle utility_process_host to make it work in a browsertest.
BUG=12326
TEST=none
Review URL: http://codereview.chromium.org/118476
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18116 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/119443
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18101 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
BUG=13103
Review URL: http://codereview.chromium.org/119389
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18095 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
header, the public key, the signature, and the zip.
Review URL: http://codereview.chromium.org/118490
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18088 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
TEST=none
BUG=none
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18067 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
TEST=none
BUG=none
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18065 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=11823
TEST=--load-extension test/data/extensions/samples/bookmarks
TEST=unit_tests.exe --gtest_filter=ExtensionAPIClientTest.*
Review URL: http://codereview.chromium.org/118209
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18056 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
* split up extension_shelf into a model and a view (easier to port)
* ExtensionHost now owns ExtensionView rather than vice versa
* dragging reorders extensions on the shelf
* moved ExtensionView* into browser_tests (currently not working)
BUG=12123
TEST=browser_tests.exe --gtest_filter=ExtensionShelfModel* (browser_tests.exe is currently broken)
Review URL: http://codereview.chromium.org/119290
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18002 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
R=aa
BUG=12114
Review URL: http://codereview.chromium.org/118328
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17927 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=13290,13128
TEST=Add --enable-user-scripts to command line without --enable-extensions or --load-extension. Start Chrome, user scripts should work. Also run ui tests with --enable-extensions.
Review URL: http://codereview.chromium.org/119256
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17898 0039d316-1c4b-4281-b951-d872f2087c98
|