| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Pick the color of the slider's thumbpart and rail from the GTK theme.
We cannot match the exact visual appearance of the GTK theme, as
rendering engines can make arbitrary changes to the actual visual
appearance. But by sampling a representative set of pixels, we ensure
that we will at least match the general color scheme.
BUG=10949
patch by <markus [at] chromium>
original review: http://codereview.chromium.org/400027/show
Review URL: http://codereview.chromium.org/466080
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@34183 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
window would hard crash the browser.
I'm hoping that this will open up discussions for refactoring work amongst ExtensionHost and TabContentsView, since
so much code is shared between the two and both need sufficient Mac love.
BUG=29353
TEST=load a browser action with a popup that contains a SELECT element. click on the element and observe that it acts normally (no crashing).
Review URL: http://codereview.chromium.org/465108
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@34136 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
using the /proc/self/exe trick we use for plugins. Since we don't
need any resources from .pak files, this should be safe.
BUG=22703
TEST=Install a theme, verify that it worked properly.
Review URL: http://codereview.chromium.org/464073
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@34117 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
- Bring up extension_apitest on mac
- stub browser_action_apitest but get it compiling
- stubs_apitest passes
- compile cross_origin_xhr_apitest, but we don't pass it.
- content_script_all_frames_apitest passes
- execute_script_apitest passes
BUG=none
TEST=waterfall stays green
Review URL: http://codereview.chromium.org/465121
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@34065 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
allows the caller to specify the behaviour of the window focus when the pop-up is displayed.
I added a test for the new parameter in the ExtensionApiTest.FLAKY_Popup test. I also corrected a truncated string in the unit-test.
Because the pop-up actually uses two windows, I had to change the WidgetWin::Show() routine to also reposition the window at the top. If a window is shown and activated, it is automatically brought to the front. Because we don't activate the pop-up when we want to keep the focus in the current extension view, I had to bring it to the front so that it wouldn't be hidden behind the 'chrome-bubble' window.
BUG=none
TEST=ExtensionApiTest.FLAKY_Popup
Review URL: http://codereview.chromium.org/454019
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@34037 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Part 1."
Original CL: http://codereview.chromium.org/400018/show
Looks like we're no longer hoping to get this approach into mstone4 release, so I'm unwinding this.
BUG=27431
TBR=aa
Review URL: http://codereview.chromium.org/467042
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@34025 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
call FindPreference directly.
BUG=None
TEST=compiles and passes existing tests
Original patch by Thiago Farina <thiago.farina@gmail.com> at
http://codereview.chromium.org/460117/show
Review URL: http://codereview.chromium.org/463044
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@34010 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
and use it on Linux.
TODO: persist the order of buttons
TODO: use the model on windows, mac
TODO: let the view change the order of buttons
My plan for persisting the order is just to write/read a simple text file to/from disk, one extension id per line. Similar to the bookmark model, except that is structured data (because they try to hold more information).
BUG=26990
Review URL: http://codereview.chromium.org/462026
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@34005 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
In this episode we:
-Create a new ChildProcess privilege (SILENT_INSTALL_EXTENSION) which is granted to the extension gallery pages.
-Ensure that extension gallery pages are isolated into their own process which is never shared with other urls.
Important: The SILENT_INSTALL_EXTENSION privilege is never granted any additional abilities in this patch, so this patch only has the effect of grouping gallery URLs into a separate process.
In subsequent patch(es) we plan to (a) observe this new privilege and allow gallery urls to install extensions bypassing the normal prompts, (b) polish this UI flow [in particular, do not show the black "loading" dilaog, (c) check the id of the extension to be installed (from the crx) matches the expected id (from gallery url).
BUG=27431
Review URL: http://codereview.chromium.org/400018
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@33952 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
to make sure it doesn't happen again.
Also, re-enable a test nearby. The history has been lost of
why this was failing, so it may fail again, but at least
we'll have data.
Finally, fix a Greasemonkey compat issue.
BUG=29298
Review URL: http://codereview.chromium.org/466053
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@33945 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
tests over to ExternalTabUITest.
BUG=27326
TEST=ui_tests.exe
Review URL: http://codereview.chromium.org/468013
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@33902 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG= 28624
TEST= links from the chrome://extensions page should include locale information.
Review URL: http://codereview.chromium.org/467019
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@33857 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
do-nothing make.
TEST=manual browser test, trybots
BUG=none
Review URL: http://codereview.chromium.org/464031
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@33851 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
crash.
BUG=19866
TEST=ExtensionApiTest.Bookmarks
Review URL: http://codereview.chromium.org/465034
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@33822 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
TBR=nick
Review URL: http://codereview.chromium.org/468018
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@33791 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Change the default RenderViewHostDelegate::GetRendererPrefs to a singleton because initialization may not always be cheap (we assume copying is, however).
BUG=29043
TEST=if you focus a link in an extension popup, you can actually see the focus ring (the focus ring had been set to 0x000000 color)
Review URL: http://codereview.chromium.org/458013
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@33775 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
to mutating extension functions, as discussed on chromium-dev and
in Extensions quotaserver design doc.
Add a hook in the dispatcher to have the quota service assess the request.
Wire up bookmarks.{create, move, remove, update} to the service.
BUG=19899
TEST=ExtensionsQuotaServiceTest, QuotaLimitHeuristicTest (both new)
Review URL: http://codereview.chromium.org/441006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@33770 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
1) Make it explicit that it only supports ASCII (since it iterates
character by character).
2) Limit the recursion to 16 levels. We could allow more, but in the
case of a ?, it has exponential complexity, so I figured 16 was a good
stopping point. It seems rare that someone would have more than 16
'?' and '*'s.
BUG=28645
Review URL: http://codereview.chromium.org/460047
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@33748 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
This is the OSX complement to http://src.chromium.org/viewvc/chrome?view=rev&revision=32853
BUG=b/2168147
TEST=extension autoupdate should still work on MacOS
Review URL: http://codereview.chromium.org/431033
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@33731 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=24168
TEST=covered by unit tests
Review URL: http://codereview.chromium.org/466012
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@33720 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
utility process on OS X.
Other changes:
* An error initializing the sandbox on OS X is now treated as fatal.
* Improved error reporting for sandbox-related failures.
BUG=26492,23837
TEST=Installing extensions and themes should still work on OS X.
Review URL: http://codereview.chromium.org/434077
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@33682 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
BUG=28824
TEST=tools/valgrind/chrome_tests.sh -t unit --gtest_filter=ProfileManagerTest.CreateProfile
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=33611
Review URL: http://codereview.chromium.org/455031
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@33626 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
BUG=28824
TEST=tools/valgrind/chrome_tests.sh t unit gtest_filter=ProfileManagerTest.CreateProfile
Review URL: http://codereview.chromium.org/455031
TBR=mattm@chromium.org
Review URL: http://codereview.chromium.org/458012
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@33613 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=28824
TEST=tools/valgrind/chrome_tests.sh -t unit --gtest_filter=ProfileManagerTest.CreateProfile
Review URL: http://codereview.chromium.org/455031
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@33611 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Also enable the task_manager_browsertest.cc (where I added the new test) on Linux.
TEST=Covered by browser_tests.
BUG=21635
Review URL: http://codereview.chromium.org/465007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@33599 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
containing a privacy blacklist.
TEST=Covered by unit_tests.
BUG=21541
Review URL: http://codereview.chromium.org/453016
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@33573 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
Instead of storing pointers into a vector, store offsets. That
way, if the vector resizes, we should still be OK.
Also, add a DCHECK that we only enter this method once, which
is my current assumption.
Review URL: http://codereview.chromium.org/457028
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@33541 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
changes for a child window of the popup, as it is the case
with select popups.
BUG=28110
TEST=Make sure extension popups are still working as expected.
Open an extension popup with a select popup (combo box)
in it. Click on the select to bring up its popup, the
extension popup should stay opened.
Review URL: http://codereview.chromium.org/459005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@33533 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
collection.
BUG=28884
Review URL: http://codereview.chromium.org/455026
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@33530 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
TEST=none
BUG=none
Review URL: http://codereview.chromium.org/454004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@33324 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
TBR=pawel
Review URL: http://codereview.chromium.org/453007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@33309 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
TEST=none
BUG=none
Review URL: http://codereview.chromium.org/454004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@33301 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Now each Profile has a BlacklistManager that maintains a compiled Blacklist for that Profile.
The system does not yet pause user-initiated web requests until the blacklist system is ready. However, the code is not supposed to be ready, and is hidden behind a --enable-privacy-blacklists command-line flag.
TEST=Covered by browser_test.
BUG=21541
Review URL: http://codereview.chromium.org/371063
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@33290 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
implements Windows right now. Mac and linux will be separate CLs.
"Active" is overloaded to mean different things depending on
the process type:
browser: all enabled extensions
renderer: unique set of extensions from all user scripts
extension: extensions running in the process
BUG=27169
Review URL: http://codereview.chromium.org/437078
--
There are thousands of new crashes with reivison 33256 and 33255, so i'm
reverting. the crashes are in chrome_2610000!child_process_logging::SetActiveURL
TBR=aa@chromium.org
Review URL: http://codereview.chromium.org/448006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@33269 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
right now. Mac and linux will be separate CLs.
"Active" is overloaded to mean different things depending on
the process type:
- browser: all enabled extensions
- renderer: unique set of extensions from all user scripts
- extension: extensions running in the process
BUG=27169
Review URL: http://codereview.chromium.org/437078
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@33255 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
* Add support for keys with "." in them via new XXXWithoutPathExpansion() APIs.
* Use these APIs with all key iterator usage.
* SetXXX() calls cannot fail, so change them from bool to void.
* Change GetSize() to size() since it's cheap, and add empty().
Other:
* Use standard for loop format in more places (e.g. instead of while loops when they're really doing a for loop).
* Shorten a few bits of code.
BUG=567
TEST=none
Review URL: http://codereview.chromium.org/441008
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@33109 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
doing so, make it use the font-family and font-size (84% by default) set in locale_settings for the current UI language. The body font size used to be 87%. To make up for the difference between two, the font sizes given in percentage are adjusted (increased) accordingly in the rest of the file.
BUG=28202
TEST=1. Run Chrome with '--lang=he' or '--lang=ar' on Windows (or 'LANGUAGE=he chrome' / 'LANGUAGE=ar chrome' on Linux) and go to 'chrome://extensions'. Strings are not yet translated, but the overall UI should be RTL.
2. Run Chrome in en-US (or your favorite LTR language) and go to 'chrome://extensions'. It should look the same as before.
Review URL: http://codereview.chromium.org/434024
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@33108 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
UI thread.
BUG=27834
TEST=none
Review URL: http://codereview.chromium.org/440012
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@33057 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=27333
TEST=UserScriptTest and check the issue does not happen against userscipt encoded in UTF-8 with BOM..
Review URL: http://codereview.chromium.org/420001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@33048 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
default it to false. This should improve performance in
sites that use frames and elimiate confusion, since in most
cases developers *don't* expect content scripts to match
frames.
Review URL: http://codereview.chromium.org/412008
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@33035 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=None
TEST=UserScriptMasterTest
Review URL: http://codereview.chromium.org/434034
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@33033 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
This doesn't remove the underlying support from
UserScriptMaster; that is a riskier change.
BUG=27520
Review URL: http://codereview.chromium.org/418043
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32987 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
--enable-extension-toolstrips
BUG=24475
TEST=Extension*Toolstrip*
Review URL: http://codereview.chromium.org/434026
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32928 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=13572
TEST=none
Review URL: http://codereview.chromium.org/399068
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32918 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
described in http://crbug.com/27944.
BUG=28530
TEST=Open chrome://extensions, select 'Pack Extension', select an extension folder, press OK. Should pack the extension instead of crash.
Review URL: http://codereview.chromium.org/436008
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32898 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Landing this on for pam. Original issue: http://codereview.chromium.org/425011/show.
Disable showing JS alerts from popups, because doing so makes the popup
disappear immediately, which has all sorts of unfortunate side effects for the
poor orphaned alert (see bug for details).
BUG=27758
TEST=create extension with popup, put link with |onclick="alert('test');"| in
it; install extension, open popup, and click link; see no crash (nor popup)
Review URL: http://codereview.chromium.org/435010
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32889 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
be identical to LoadDataResourceBytes. Migrate callers to
LoadDataResourceBytes.
Review URL: http://codereview.chromium.org/437019
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32885 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
apparent reason
on the vista dbg builder.
Issue http://code.google.com/p/chromium/issues/detail?id=28630 has been logged to track this.
TBR=aa
Bug=28630
Review URL: http://codereview.chromium.org/432010
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32866 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=b/2168147
TEST=Extensions auto-updates should still work.
Review URL: http://codereview.chromium.org/403026
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32853 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
extensions-related places.
Also add a virtual destructor in some unrelated infobar.
BUG=27691
Review URL: http://codereview.chromium.org/427002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32840 0039d316-1c4b-4281-b951-d872f2087c98
|