| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
|
|
| |
BUG=24672
TEST=out/Debug/unit_tests
Review URL: http://codereview.chromium.org/1741012
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@47370 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
test hangs in cases when the server fails to start.
The tests will still fail in that case, obviously,
but will no longer hang (or crash), which is an
improvement.
TEST=browser_tests
BUG=none
Review URL: http://codereview.chromium.org/2095004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@47362 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
TBR=rafaelw@chromium.org
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@47104 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
enough for anyone's shortcut flags!"
Review URL: http://codereview.chromium.org/1991009
TBR=aa@chromium.org
Review URL: http://codereview.chromium.org/2010013
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@47081 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
anyone's shortcut flags!"
Review URL: http://codereview.chromium.org/1991009
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@47079 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=39505
TEST=Should be able to add a bunch of context menu items and then change or
remove them using update and removeAll respectively.
Review URL: http://codereview.chromium.org/1736028
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@47060 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
This is a duplicate of http://codereview.chromium.org/2027006 which was accidentally created in a read-only client.
BUG=None
TEST=ExtensionApiTest.Popup
Review URL: http://codereview.chromium.org/2003016
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@47052 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=32906
TEST=none
Review URL: http://codereview.chromium.org/2015018
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@47044 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
a related crash.
BUG=31737,32906
TEST=none
Review URL: http://codereview.chromium.org/2018006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@47036 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
actual gallery downloads.
BUG=None
TEST=Pass in a gallery url through the command line and make sure the dangerous download warning does not show when downloading from that gallery.
Review URL: http://codereview.chromium.org/1997019
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@47033 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=41275
Review URL: http://codereview.chromium.org/2013015
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@46979 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
TEST=if it compiles, it is perfect
BUG=none
Review URL: http://codereview.chromium.org/2001007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@46894 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=43172
Review URL: http://codereview.chromium.org/2044002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@46763 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=None
TEST=Build and Unittests
Review URL: http://codereview.chromium.org/1995008
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@46739 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
experimental.extension.popup(...) windows.
Patch 1 contains twiz@'s code reviewed implementation from http://codereview.chromium.org/1512007.
This CL is to address the failure of release tests.
BUG=None
TEST=ExtensionApiTest.Popup
Review URL: http://codereview.chromium.org/1921003
TBR=ericdingle@google.com
Review URL: http://codereview.chromium.org/2036002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@46638 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
http://codereview.chromium.org/1921003
Bug=none
Test=none
Review URL: http://codereview.chromium.org/2030004
TBR=ericdingle@google.com
Review URL: http://codereview.chromium.org/1981005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@46636 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
Bug=none
Test=none
Review URL: http://codereview.chromium.org/2030004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@46611 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
Patch 1 contains twiz@'s code reviewed implementation from http://codereview.chromium.org/1512007.
This CL is to address the failure of release tests.
BUG=None
TEST=ExtensionApiTest.Popup
Review URL: http://codereview.chromium.org/1921003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@46592 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
TBR=bulach
TEST=none
BUG=43441
Review URL: http://codereview.chromium.org/1998005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@46587 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
TBR=skerner
TEST=none
BUG=43440
Review URL: http://codereview.chromium.org/1988004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@46586 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
net tests with chrome frame.
See revision 42240 for more details: http://codereview.chromium.org/1107013
TEST=n/a
BUG=none
Review URL: http://codereview.chromium.org/1987001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@46577 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This patch adds a new RVH container: BackgroundContents. The idea is that apps can open a live web-page as a "background" page using window.open('<url>', '<name>', 'background');
If 'background' is specified and the opener is within the app's extent, a BackgroundContents will be used. Otherwise, the 'background' feature is ignored and it is treated as a regular popup call.
Note that as of this patch the following are explicitly not-yet addressed:
1) Session storage for BackgroundContents
2) SSL (or other failures) requiring UI
3) Javascript messages (alert, etc...)
4) Session restore
TEST=All tests should pass
BUG=41275
Review URL: http://codereview.chromium.org/1734014
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@46544 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
It remains at least as wide as the browser location bar (that way it can always point at the + button).
InfoBubble was modified so it can be resized.
BUG=42260
TEST=Open the app launcher multiple-times. The app launcher
should fit its contents nicely.
Review URL: http://codereview.chromium.org/1739020
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@46482 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
used for a nice animation.
Review URL: http://codereview.chromium.org/1906004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@46472 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
The difference is that the error message doesn't contain
"Assertion failed: false".
Review URL: http://codereview.chromium.org/1970001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@46422 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=39372
Review URL: http://codereview.chromium.org/1940002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@46390 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
flaky/crash problems.
BUG=39158
TEST=none
Review URL: http://codereview.chromium.org/1872002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@46389 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=43147
Review URL: http://codereview.chromium.org/1933001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@46330 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
recent webkit fix disabled clipboard completely, unfortunately.
Review URL: http://codereview.chromium.org/1925001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@46322 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
This changes the implementation such that the extensions_ui now iterates over all the RVHs in the process, rather than maintain an explicit list of ExtensionFunctionDispatchers (live app pages don't have EFDs).
TEST=none
BUG=42605
Review URL: http://codereview.chromium.org/1827002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@46295 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
popup API. "
This reverts http://codereview.chromium.org/1512007
TBR=twiz
Review URL: http://codereview.chromium.org/1735026
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@46184 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=42497,42943
TEST=none
Review URL: http://codereview.chromium.org/1705025
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@46151 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
- It was previously possible to programmatically launch two popups from the same extension. (Simply call popup.show twice in a row, or in a callback chain.)
I removed this incorrect funcationality by registering ExtensionPopupHost to listen for EXTENSION_HOST_CREATED notifications. If a popup is shown, and a new ExtensionHost is constructed of type EXTENSION_POPUP, then the presently displayed popup is dismissed.
- The callback function for popup.show(...) was previously called in response to EXTENSION_POPUP_VIEW_READY, as processed in response to a ViewHostMsg_DocumentAvailableInMainFrame message. This message wassent after PARSING of the conent of the popup view. Because of this behaviour, the API was difficult to use because one could not meaningfully interact with the popup page
during the callback: The callback would race with completion of the onload handler within the popup, so some sort of polling for onload-complete was required.
I fixed the problem by adding new notifications and messages so that EXTENSION_POPUP_VIEW_READY is now sent only after all onload handlers have been invoked.Corresponding unit-tests have also been added.
BUG=None
TEST=ExtensionApiTest.Popup
Review URL: http://codereview.chromium.org/1512007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@46136 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=42497
Review URL: http://codereview.chromium.org/1691023
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@46096 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=42943
TEST=none
TBR=rafaelw
Review URL: http://codereview.chromium.org/1810012
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@46083 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Other users of the temp directory will be altered in a subsequent CL.
BUG=13044
TEST=SandboxedExtensionUnpackerTest.*, ScopedTempDir.UniqueTempDirUnderPath, FileUtilTest.CreateNewTempDirInDirTest, manual testing on win, linux, mac.
Review URL: http://codereview.chromium.org/1582022
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@46078 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
extension is enabled for incognito.
BUG=39113
Review URL: http://codereview.chromium.org/1789010
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@46076 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
running.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/1810008
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@46074 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
- URLRequestTestContext (from now on use TestURLRequestContext)
- TestServerPageW (use TestServerPage).
TEST=none
BUG=none
Review URL: http://codereview.chromium.org/1814002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@46044 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
and extension_error_reporter to browser, so that the UIs surrounding them can be in the browser.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/1705009
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@45986 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
TBR=mpcomplete
TEST=flaky
BUG=42844
Review URL: http://codereview.chromium.org/1705014
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@45948 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
TBR=rogerta
TEST=flaky
BUG=37554
Review URL: http://codereview.chromium.org/1695024
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@45947 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/1736022
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@45902 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
experimental window.open feature strings to be captured and passed to the client.
It should wait for: https://bugs.webkit.org/show_bug.cgi?id=38013 to land. This is required because this patch needs to use the WebWindowFeature binding struct in WebKit.
Once this is landed, a webkit patch to change the call signature for WebViewClient::createView to include the WebWindowFeatures will be submitted (and after that another chromium patch to remove the old call signature).
This patch implements old and new WebViewClient::createView signatures, and additionally passes the vector all the way to RenderViewHostDelegateHelper who will eventually use it to observe the 'background' feature.
BUG=41275
TEST=all tests should pass
Review URL: http://codereview.chromium.org/1758004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@45877 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
gallery page, if the extension is from the gallery.
BUG=29739
TEST=Install a gallery extension and a third-party extension and make sure the
gallery extension name is a link (whereas the third party extension name is
static text).
Review URL: http://codereview.chromium.org/1780009
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@45807 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Link the name of the extension on the management page to the
gallery page, if the extension is from the gallery.
BUG=29739
TEST=Install a gallery extension and a thirdparty extension and make sure the gallery extension name is a link (whereas the third party extension name is static text).
Review URL: http://codereview.chromium.org/1792006
TBR=finnur@chromium.org
Review URL: http://codereview.chromium.org/1807001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@45751 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
gallery page, if the extension is from the gallery.
BUG=29739
TEST=Install a gallery extension and a third-party extension and make sure the gallery extension name is a link (whereas the third party extension name is static text).
Review URL: http://codereview.chromium.org/1792006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@45749 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This includes adding a few methods to ExtensionPrefs that I'm going to need to
use inside ExtensionUpdater for implementing the "do updates at idle" feature.
Instead of adding more call-through stubs to the interface that
ExtensionsService providers to the ExtensionUpdater, I instead decided it was
time to do some refactoring to expose a ExtensionPrefs getter in the interface.
TEST=(Should be covered by unit/browser tests)
BUG=37971
Review URL: http://codereview.chromium.org/1695018
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@45738 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/1723014
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@45659 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=42497
Review URL: http://codereview.chromium.org/1745016
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@45630 0039d316-1c4b-4281-b951-d872f2087c98
|