summaryrefslogtreecommitdiffstats
path: root/chrome/browser/extensions
Commit message (Collapse)AuthorAgeFilesLines
* Begin work on extension shelf for Linux.phajdan.jr@chromium.org2009-07-171-0/+2
| | | | | | | | | | | For now it displays only a placeholder text, but knows when to display (it's connected to the ExtensionShelfModel). TEST=none http://crbug.com/16759 Review URL: http://codereview.chromium.org/159019 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21014 0039d316-1c4b-4281-b951-d872f2087c98
* A small start: add icons to the extension manifest.aa@chromium.org2009-07-171-0/+11
| | | | | | Review URL: http://codereview.chromium.org/155662 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20941 0039d316-1c4b-4281-b951-d872f2087c98
* First step in abstracting extension api to common/shared "IDL" files ↵rafaelw@chromium.org2009-07-168-61/+65
| | | | | | | | | | | | | | (jsonschema). In this step, All "normal" api calls and events (those that arrive or originate from the browser process) are routed through a single v8::Extension API Call ("StartRequest"). Additionally, internal string names for methods and events now match the js namespace (i.e. "RemoveTab" -> "tabs.remove"), in anticipation of having names be implicit from their api module & name in the api "IDL". TBR=aa,mpcomplete Review URL: http://codereview.chromium.org/149730 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20910 0039d316-1c4b-4281-b951-d872f2087c98
* Change getLanguage to detectLanguage, and incorporate corresponding changes, ↵sidchat@google.com2009-07-165-10/+10
| | | | | | | | | | in tab extensions. Also, use ISO language (e.g. "fr" instead of "French") as return language. BUG=none TEST=Enable extensions, add the given toolstrip as extension. For a page, the language of the page should be returned as ISO language (e.g., "french" as "fr") Review URL: http://codereview.chromium.org/149627 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20895 0039d316-1c4b-4281-b951-d872f2087c98
* Fix for bug where we would not create ExtensionFunctionDispatcheraa@chromium.org2009-07-163-0/+19
| | | | | | | | | | instances for ExtensionDOMUI if RenderView was reused. BUG=16853 TEST=Added browser test Review URL: http://codereview.chromium.org/155592 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20880 0039d316-1c4b-4281-b951-d872f2087c98
* Add more browser tests for Task Manager.phajdan.jr@chromium.org2009-07-151-6/+7
| | | | | | | | | TEST=Covered by browser_tests. http://crbug.com/12127 Review URL: http://codereview.chromium.org/155433 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20786 0039d316-1c4b-4281-b951-d872f2087c98
* Retrying this patch. This was already reviewed by mpcomplete and thefinnur@chromium.org2009-07-158-7/+78
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | only change is a fix for the UI test that broke and a small change to event_bindings.cc (reviewed in-person). ExtensionFunctionDispatcher now notifies ExtensionProcessManager of renderviews created, which in turn notifies the renderer of page actions that it knows about. Remove generic event "page-action-executed" in favor of page action specific event (sent as extension_id/page_action_id). In the bindings, we now setup events for each page action we know about so we can register for specific events, and not receive broadcast events from all page actions. To setup these events I added a GetCurrentPageActions() to extension_process_bindings.cc and a helper function GetCurrentExtensionId(). And, finally, I simplified the page action background page by removing the check to see if we are already subscribed to the feed (since we now support multiple feed readers, it doesn't make sense anymore to always check Google Reader). This check might make a comeback later in a different form. TBR=mpcomplete BUG=13936 TEST=The RSS sample extension should work as before. Review URL: http://codereview.chromium.org/149683 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20782 0039d316-1c4b-4281-b951-d872f2087c98
* Disable MessagingContentScript. It's failing on the buildbot.mpcomplete@chromium.org2009-07-151-0/+3
| | | | | | | | | | BUG=no TEST=no TBR=aa Review URL: http://codereview.chromium.org/155580 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20761 0039d316-1c4b-4281-b951-d872f2087c98
* Reenable content script messaging test.mpcomplete@chromium.org2009-07-151-4/+0
| | | | | | | | | | | Remove temporary change now that webkit DEPS roll landed. TEST=no BUG=16228 Review URL: http://codereview.chromium.org/149655 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20755 0039d316-1c4b-4281-b951-d872f2087c98
* Lands http://codereview.chromium.org/155428 for Thiago, which changessky@chromium.org2009-07-152-11/+0
| | | | | | | | | | | | | | from me to get the thing to work. Merging two versions of BookmarkNodeRemoved into one. BUG=None TEST=Remove some bookmarks from BookmarkBar or Bookmarks Manager and make sure everything works ok. Review URL: http://codereview.chromium.org/155572 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20739 0039d316-1c4b-4281-b951-d872f2087c98
* Various minor fixes:aa@chromium.org2009-07-153-64/+90
| | | | | | | | | | | | | | | | * --load-extension no longer requires --enable-extensions * No longer support chrome:// URLs for user scripts * Remove old unused Greasemonkey test * Enable Greasemonkey API emulation in linux/mac BUG=16720,16007,4476 TEST=Added several unit tests Original review: http://codereview.chromium.org/149619 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20719 0039d316-1c4b-4281-b951-d872f2087c98
* Reverting 20714.finnur@chromium.org2009-07-157-69/+3
| | | | | | | Rietveld showed all green try bots, but looks like one ui test is failing Review URL: http://codereview.chromium.org/149668 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20715 0039d316-1c4b-4281-b951-d872f2087c98
* EFD now notifies EPM of renderviews created, which in turn notifies the ↵finnur@chromium.org2009-07-157-3/+69
| | | | | | | | | | | | | | | | renderer of page actions that it knows about. Remove generic event "page-action-executed" in favor of page action specific event (sent as extension_id/page_action_id). In the bindings, we now setup events for each page action we know about so we can register for specific events, and not receive broadcast events from all page actions. To setup these events I added a GetCurrentPageActions() to extension_process_bindings.cc and a helper function GetCurrentExtensionId(). And, finally, I simplified the page action background page by removing the check to see if we are already subscribed to the feed (since we now support multiple feed readers, it doesn't make sense anymore to always check Google Reader). This check might make a comeback later in a different form. BUG=13936 TEST=The RSS sample extension should work as before. Review URL: http://codereview.chromium.org/155514 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20714 0039d316-1c4b-4281-b951-d872f2087c98
* Remove the defunct SetAccelerator message and replace it with anamit@chromium.org2009-07-141-2/+10
| | | | | | | | | | | automation message to set initial settings. BUG=none TEST=none Review URL: http://codereview.chromium.org/155376 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20676 0039d316-1c4b-4281-b951-d872f2087c98
* This provides a simpler js template engine than JsTemplate. It has beenarv@google.com2009-07-141-3/+6
| | | | | | | | | | | | | | | | | | optimized for the way we do internationalization with JST before and is about 4 times faster (average 4.8ms vs 22.8ms) for the history page. The syntax for this is very similar to JsTemplates. It uses the attributes i18n-values and i18n-content which worls like jsvalues and jscontent except that it does not allow arbitrary expressions. BUG=None TEST=All UI pages should work as before Review URL: http://codereview.chromium.org/149420 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20590 0039d316-1c4b-4281-b951-d872f2087c98
* Nukes the 3 arg TabMoved variant in favor of the 4 arg variant.sky@chromium.org2009-07-132-4/+6
| | | | | | | | | BUG=16634 TEST=none Review URL: http://codereview.chromium.org/155441 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20581 0039d316-1c4b-4281-b951-d872f2087c98
* Try the original CL "Always persist bookmark IDs" again with the fix tomunjal@chromium.org2009-07-134-28/+68
| | | | | | | | | | | | | | Valgrind issue. The fix is in bookmark_storage.h - initialized the newly added member ids_reassigned_ of LoadDetails class. See http://codereview.chromium.org/149310 for the original CL. TEST=NONE BUG=16068 Review URL: http://codereview.chromium.org/155456 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20565 0039d316-1c4b-4281-b951-d872f2087c98
* Revert "Always persist bookmark IDs."tc@google.com2009-07-134-68/+28
| | | | | | | | | | | | | This reverts commit r20532 because valgrind was complaining about uninitialized memory: http://build.chromium.org/buildbot/waterfall/builders/Chromium%20Linux%20(valgrind)/builds/697/steps/valgrind%20test:%20unit/logs/stdio TBR=munjal Review URL: http://codereview.chromium.org/155448 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20550 0039d316-1c4b-4281-b951-d872f2087c98
* Refactoring handle and dragging a bit in preparation for moles. The primary ↵erikkay@chromium.org2009-07-132-23/+42
| | | | | | | | change for this is to get rid of the concept of a "current" toolstrip and the idea that there's only one handle around. Instead, each toolstrip has its own handle and each can be displaying it independently. There's some initial work for moles in there, but it's disabled since this will require some other plumbing to hook up properly. Review URL: http://codereview.chromium.org/155192 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20544 0039d316-1c4b-4281-b951-d872f2087c98
* Always persist bookmark IDs.munjal@chromium.org2009-07-134-28/+68
| | | | | | | | | | | | | | | | Remove the preference to persist IDs. NOTE that we need to save the file the first time with IDs since existing bookmark files won't have IDs and the file won't be saved until something changes in the bookmark model. So we need to explicitly save once when we assign ids for the first time. TEST=NONE BUG=16068 Review URL: http://codereview.chromium.org/149310 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20532 0039d316-1c4b-4281-b951-d872f2087c98
* Add an optional channel name to the extension message connect event.mpcomplete@chromium.org2009-07-133-43/+77
| | | | | | | | | | | Also changed the way port IDs work internally to reduce confusion. Each end of the port has its own ID, not the ID of its opposite end. BUG=13706 TEST=no Review URL: http://codereview.chromium.org/155381 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20519 0039d316-1c4b-4281-b951-d872f2087c98
* Refactor extension constants to improve readability, debugging, and to make ↵erikkay@chromium.org2009-07-133-8/+14
| | | | | | | | it easier to add new constants. Review URL: http://codereview.chromium.org/155407 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20483 0039d316-1c4b-4281-b951-d872f2087c98
* Fix leaks in ExtensionUpdater unit testsasargent@chromium.org2009-07-102-6/+8
| | | | | | | | | BUG=http://crbug.com/16444 TEST=none Review URL: http://codereview.chromium.org/149479 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20430 0039d316-1c4b-4281-b951-d872f2087c98
* Remove svn:executable property from some more files that don't need it.thestig@chromium.org2009-07-1010-0/+0
| | | | | | | TBR=evmar Review URL: http://codereview.chromium.org/149471 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20406 0039d316-1c4b-4281-b951-d872f2087c98
* Temporarily disable unit tests with leaks until I can check in a fix for them.asargent@chromium.org2009-07-101-5/+5
| | | | | | | | | | | BUG=http://crbug.com/16444 TEST=none TBR=eroman Review URL: http://codereview.chromium.org/155362 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20393 0039d316-1c4b-4281-b951-d872f2087c98
* ExtensionBrowserEventRouter now observes TAB_CONTENTS_DESTROYED. This became ↵rafaelw@chromium.org2009-07-101-14/+18
| | | | | | | | | | necessary with the addition of dockable devtools TabContents. It is now possible for Tab contents to close after having been detached without being re-attached to a browser (as in the case of docking). TBR=pfeldman Review URL: http://codereview.chromium.org/149429 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20387 0039d316-1c4b-4281-b951-d872f2087c98
* Implementation of Extension Updater.asargent@chromium.org2009-07-106-37/+1264
| | | | | | | | | | | | This also contains changes to the ExtensionsService to hook up the ExtensionUpdater. BUG=http://crbug.com/12117 TEST=Extensions still work Review URL: http://codereview.chromium.org/149213 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20379 0039d316-1c4b-4281-b951-d872f2087c98
* Add getLanguage function to tab extension.sidchat@google.com2009-07-107-7/+91
| | | | | | | | BUG=none TEST=enable extensions using the toolstip.html code (added with this CL) and load pages in different languages. The corresponding language should appear in the bottom left after the page is loadedm or when the button is clicked, or when you navigate back to that tab after visiting some other tab. Review URL: http://codereview.chromium.org/150062 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20378 0039d316-1c4b-4281-b951-d872f2087c98
* Properly restart extensions with no visible UI.phajdan.jr@chromium.org2009-07-101-1/+7
| | | | | | | | http://crbug.com/16070 Review URL: http://codereview.chromium.org/149416 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20376 0039d316-1c4b-4281-b951-d872f2087c98
* Move some more interfaces on RenderViewHostDelegate to separate classes. Thebrettw@chromium.org2009-07-092-3/+3
| | | | | | | | ones in the patch are those that are implemented by other classes, avoiding TabContents pass-throughs. Review URL: http://codereview.chromium.org/149373 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20324 0039d316-1c4b-4281-b951-d872f2087c98
* Add a rudamentary feed preview to the RSS extension. Itfinnur@chromium.org2009-07-093-1/+163
| | | | | | | | | | | | | | | | | | | | | doesn't handle inline HTML in the item description (it just dumps it as text) and the feed needs to be valid XML for it to show any preview, but it is better than nothing. We can easily change it to display the HTML but we want to (at some point) try to use a separate origin so that we can render the HTML code from untrusted sources safely. Also fix a bug in the image tracker. It should not try to communicate with the view if the view has gone away (which was the whole point of the image tracker...) BUG=None TEST=Install the extension, browse to a page with a feed and click onthe rss icon in the Omnibox. An interstitial page should appear with a preview of the feed. Review URL: http://codereview.chromium.org/155180 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20316 0039d316-1c4b-4281-b951-d872f2087c98
* Make the API to open a message channel symmetric, so it works the same ↵mpcomplete@chromium.org2009-07-096-162/+222
| | | | | | | | | | | | | | | whether opening from a tab or extension. Also, move the callback handling back to extension_process_bindings, since I didn't need it in event_bindings to implement this, and it didn't make sense there anyway. BUG=12461 TEST=no Review URL: http://codereview.chromium.org/149237 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20296 0039d316-1c4b-4281-b951-d872f2087c98
* ExtensionsServiceBackend::GarbageCollectionExtensions() makes a local copy ↵rafaelw@chromium.org2009-07-092-9/+4
| | | | | | | | | | | | of install_directory_. It was forcing the persistent copy to an absolute path which was causing the ExternsionsService and ExtensionsPrefs install_directory_ values to diverge. Re-enable ExternalInstallPref on mac. TBR=mpcomplete Review URL: http://codereview.chromium.org/155187 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20214 0039d316-1c4b-4281-b951-d872f2087c98
* DevTools: remove extensions-related workaround from the docked devtools ↵pfeldman@chromium.org2009-07-081-1/+13
| | | | | | | | window destruction. Review URL: http://codereview.chromium.org/155206 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20139 0039d316-1c4b-4281-b951-d872f2087c98
* Aha, I think this was racing because INSTALLED is actually firedaa@chromium.org2009-07-081-7/+2
| | | | | | | | | | | | | before LOADED. Frequently, this didn't matter because we post a task to the message loop to quit and usually this would get queued after the LOADED message. But it is also possible for us to queue the quit task first, I think. TBR=mpcomplete git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20133 0039d316-1c4b-4281-b951-d872f2087c98
* Add some more logging. Still trying to figure out flakey test.aa@chromium.org2009-07-081-3/+20
| | | | | | TBR=mpcomplete git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20126 0039d316-1c4b-4281-b951-d872f2087c98
* Add some logging to a flakey browsertest to debug.aa@chromium.org2009-07-082-4/+11
| | | | | | Review URL: http://codereview.chromium.org/149291 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20103 0039d316-1c4b-4281-b951-d872f2087c98
* Disable ExtensionBrowserTest.Incognito because it fails too often.nsylvain@chromium.org2009-07-071-0/+3
| | | | | | | | BUG:16106 Review URL: http://codereview.chromium.org/155147 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20029 0039d316-1c4b-4281-b951-d872f2087c98
* Fixing a crash in RenderViewGone.finnur@chromium.org2009-07-061-4/+7
| | | | | | | | | | | | | | | | | | | | | | If I start Chrome and shut it down quickly RenderViewHost receives an IPC ViewHostMsg_RenderViewGone. We respond in ExtensionHost::RenderViewGone by putting up an info bar on the selected tab contents saying that an extension crashed. Only problem is that ExtensionHost::GetBrowser() can return NULL during startup and shutdown, as documented in the function and so we should not try to put up the Infobar if the browser is going away. BUG=None TEST=Open Chrome with extensions enabled and an extension loaded and shut Chrome down as soon as it launches. It should not crash. Might take a few trys to repro. Review URL: http://codereview.chromium.org/149205 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19986 0039d316-1c4b-4281-b951-d872f2087c98
* Do some refactoring of renderer_host.brettw@chromium.org2009-07-062-38/+36
| | | | | | | | | | | | | | | | | | | This removes the last dependency on tab_contents from the renderer_host code and into the RenderViewHostDelegate. Some of the tests depended on tab_contents, so I moved to a new directory with the tab_contents include allowed via DEPS. Now DEPS can enforce that no additional tab_contents includes are added to renderer_host. RenderViewHost delegate is now pure virtual. After spending a while *again* figuring out why my code didn't work, only to find it was because the default implementation of a function was getting called instead of the real one, I decided to make this pure virtual. It is implemented by TabContents, which implements basically everything, and two other places that implement less. Only two lists of duplicate functions seems not too bad, although long-term it would be nice if this delegate was somehow more succinct. Review URL: http://codereview.chromium.org/155071 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19982 0039d316-1c4b-4281-b951-d872f2087c98
* Add an ExtensionBrowserTest base class that allows in-process browser tests ↵aa@chromium.org2009-07-0410-328/+284
| | | | | | | | of extensions using ExtensionsService directly, rather than TestExtensionLoaded. Use it to re-enable some old browser tests that had been disabled. Review URL: http://codereview.chromium.org/150213 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19930 0039d316-1c4b-4281-b951-d872f2087c98
* Create a project for maintaining default extensions.finnur@chromium.org2009-07-031-0/+0
| | | | | | | | | | | | | | | | | | | | | This project is responsible for listing and copying the extensions we want to ship with Chrome by default. It copies the .crx files listed in the project plus a .json file from: src\chrome\browser\extensions\default_extensions to debug\extensions ... where the mini_installer will pick them up. At the moment only the json file is getting copied, but we can add .crx files when they are ready. BUG=None TEST=I will give a build to QA for testing this. Review URL: http://codereview.chromium.org/155016 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19889 0039d316-1c4b-4281-b951-d872f2087c98
* Fix some issues with extension messaging:mpcomplete@chromium.org2009-07-024-18/+25
| | | | | | | | | | | | | | - Disconnect ports properly (javascript mistake). - Use the right port ID when dispatching the disconnect event. - Fix a bug with 2 extensions loaded in the same process. BUG=12686 BUG=15798 TEST=Load an extension that uses messaging, and make sure it disconnects when you navigate or close the connecting. Review URL: http://codereview.chromium.org/152003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19844 0039d316-1c4b-4281-b951-d872f2087c98
* PageActions can now specify multiple icons and switch between themfinnur@chromium.org2009-07-015-9/+32
| | | | | | | | | | | using optional parameters to enableForTab. BUG=http://crbug.com/11906 TEST=None Review URL: http://codereview.chromium.org/149046 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19772 0039d316-1c4b-4281-b951-d872f2087c98
* Create an interface just for update-related functions in ExtensionsService.asargent@chromium.org2009-07-013-15/+31
| | | | | | | | | | | This abstracts out the pieces that ExtensionUpdater will depend on, to allow easy mocking. BUG=http://crbug.com/12117 TEST=none Review URL: http://codereview.chromium.org/151127 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19747 0039d316-1c4b-4281-b951-d872f2087c98
* In this episode, we implement the DOMUI interface for extension views that ↵aa@chromium.org2009-07-018-38/+132
| | | | | | | | | | are rendered in the main tab contents area. This gets us loaded and unloaded at the right place and removes many special cases for extensions from the RenderViewHost and RenderViewHostDelegate hierarchy. BUG=13936 Review URL: http://codereview.chromium.org/126137 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19717 0039d316-1c4b-4281-b951-d872f2087c98
* Adds a browser_test for extension startup, content scriptaa@chromium.org2009-07-012-3/+255
| | | | | | | | | | | | injection, and user script injection. Also adds unit tests that EXTENSIONS_READY always gets fired. Also removes some old test data that we weren't using. Review URL: http://codereview.chromium.org/149120 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19709 0039d316-1c4b-4281-b951-d872f2087c98
* Send port disconnect events when a frame is unloaded.mpcomplete@chromium.org2009-07-012-28/+42
| | | | | | | | | | | | This is the other half of CL http://codereview.chromium.org/125280, which I split into http://codereview.chromium.org/147033 and this CL. BUG=12686 TEST=no Review URL: http://codereview.chromium.org/150125 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19686 0039d316-1c4b-4281-b951-d872f2087c98
* Refactor extension bindings to share code, avoid exposing hidden variablesmpcomplete@chromium.org2009-06-301-4/+4
| | | | | | | | | | | | | | | | | globally, and avoid using the DOM load/unload events. - moved callback handling into event_bindings.js (ports will use it). - added chromeHidden, a V8 hidden value, to keep all internal variables that need to be accessible to native code. - changed context registration to occur always at extension load, instead of DOM load. - added an internal unload event that doesn't disable SuddenTermination. This is a rework of my earlier CL http://codereview.chromium.org/125280 which was reverted because of a perf regression. I believe the perf problem was caused by the call into javascript I did on page load to handle context registration - this CL avoids that. Review URL: http://codereview.chromium.org/147033 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19634 0039d316-1c4b-4281-b951-d872f2087c98
* Fix memleak in GetNodeDictionary.finnur@chromium.org2009-06-301-19/+18
| | | | | | | | | BUG=None TEST=None Review URL: http://codereview.chromium.org/151041 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19609 0039d316-1c4b-4281-b951-d872f2087c98