summaryrefslogtreecommitdiffstats
path: root/chrome/browser/extensions
Commit message (Collapse)AuthorAgeFilesLines
* Allow themes to be localized. This doesn't show up anywhereaa@chromium.org2010-06-171-0/+47
| | | | | | | | | | in Chrome (yet), but it is used by the gallery. BUG=46379 Review URL: http://codereview.chromium.org/2845010 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@50062 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 50050 - Revert r48693: This broke existing extensions that wanted to ↵aa@chromium.org2010-06-161-47/+0
| | | | | | | | | | | | | run script on XML pages. For more info, see: http://code.google.com/p/chromium/issues/detail?id=39845#c7 TBR=rafaelw@chromium.org TBR=aa@chromium.org Review URL: http://codereview.chromium.org/2812006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@50051 0039d316-1c4b-4281-b951-d872f2087c98
* Revert r48693: This broke existing extensions that wanted to run script on XMLaa@chromium.org2010-06-161-0/+47
| | | | | | | | pages. For more info, see: http://code.google.com/p/chromium/issues/detail?id=39845#c7 TBR=rafaelw@chromium.org git-svn-id: svn://svn.chromium.org/chrome/trunk/src@50050 0039d316-1c4b-4281-b951-d872f2087c98
* [Linux] Enable ExtensionManagementTest.UpdatePermissions since bug 36890 has ↵kkania@chromium.org2010-06-161-8/+1
| | | | | | | | | | | been fixed. BUG=32906 TEST=none Review URL: http://codereview.chromium.org/2567004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@49957 0039d316-1c4b-4281-b951-d872f2087c98
* Mark ExtensionInstallUIBrowserTest.TestThemeInstallUndoResetsToDefault as flaky.satish@chromium.org2010-06-161-2/+1
| | | | | | | | | TEST=none BUG=43441, 44548 Review URL: http://codereview.chromium.org/2833007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@49909 0039d316-1c4b-4281-b951-d872f2087c98
* Add DISABLE_RUNNABLE_METHOD_REFCOUNT to make disabling refcounts in ↵ajwong@chromium.org2010-06-161-4/+1
| | | | | | | | | | | RunnableMethods easier. BUG=none TEST=none Review URL: http://codereview.chromium.org/2830006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@49887 0039d316-1c4b-4281-b951-d872f2087c98
* Send WINDOW_ID_NONE in chrome.windows.onFocusChanged when all windows loose ↵rafaelw@chromium.org2010-06-163-6/+55
| | | | | | | | | | | | | focus. Note that this patch includes support for Views (Windows/chromeos) and GTK (Linux). I was going to do mac as well, but decided my objective-c skillz were too rusty. BUG=32932 TEST=none Review URL: http://codereview.chromium.org/2778001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@49884 0039d316-1c4b-4281-b951-d872f2087c98
* ExtensionApiTest.Popup is flaky on windows.michaeln@chromium.org2010-06-151-1/+8
| | | | | | | | | | TEST=none BUG=46601 TBR=mpcomplete Review URL: http://codereview.chromium.org/2868003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@49844 0039d316-1c4b-4281-b951-d872f2087c98
* Reenable InstallApps attempt #2. This time with a fix tompcomplete@chromium.org2010-06-151-3/+1
| | | | | | | | | | | | | ManifestTest.AppsDisabledByDefault. Don't cache the value of the CommandLine, since unit_tests can modify it while the process is running. BUG=41280 Review URL: http://codereview.chromium.org/2824005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@49809 0039d316-1c4b-4281-b951-d872f2087c98
* TBR: phajdan.jrsatish@chromium.org2010-06-151-1/+1
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@49796 0039d316-1c4b-4281-b951-d872f2087c98
* Remove a ResourceBundle::GetDataResource and convert people totony@chromium.org2010-06-151-2/+2
| | | | | | | | | | the StringPiece version. In most cases, I didn't bother trying to make the calling code more efficient since nothing seems to be in time sensitive code. Review URL: http://codereview.chromium.org/2827001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@49766 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 49739 - Reenable InstallApps.mpcomplete@chromium.org2010-06-151-1/+3
| | | | | | | | | | | | | | Don't cache the value of the CommandLine, since unit_tests can modify it while the process is running. BUG=41280 Review URL: http://codereview.chromium.org/2632001 TBR=mpcomplete@chromium.org Review URL: http://codereview.chromium.org/2861001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@49745 0039d316-1c4b-4281-b951-d872f2087c98
* Reenable InstallApps.mpcomplete@chromium.org2010-06-141-3/+1
| | | | | | | | | | | Don't cache the value of the CommandLine, since unit_tests can modify it while the process is running. BUG=41280 Review URL: http://codereview.chromium.org/2632001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@49739 0039d316-1c4b-4281-b951-d872f2087c98
* Add code to instantiate the ConfigurationPolicyPrefStore for the Windows ↵danno@chromium.org2010-06-141-1/+1
| | | | | | | | | | | | platform. BUG=46134 TEST=none Review URL: http://codereview.chromium.org/2321003 Patch from Markus Heintz <markusheintz@google.com>. git-svn-id: svn://svn.chromium.org/chrome/trunk/src@49684 0039d316-1c4b-4281-b951-d872f2087c98
* Added plumbing to transport the frame name between RenderViewHost and the ↵atwilson@chromium.org2010-06-122-4/+8
| | | | | | | | | | | | | Webkit layer. Extended ViewMsg_New and ViewHostMsg_CreateWindow to have a new frame_name parameter. This allows the RVH to know the initial name of the frame associated with its RenderView, and also to set the name of the frame when creating a new RenderView. Review URL: http://codereview.chromium.org/2775003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@49622 0039d316-1c4b-4281-b951-d872f2087c98
* Re-enable two unit unit tests that were disabled for Mac in Oct 2009.csilv@chromium.org2010-06-111-11/+2
| | | | | | | | | | | These seem to be working fine on trybots now, so checking to see how these behave now. Will revert if necessary. BUG=26035 TEST=none Review URL: http://codereview.chromium.org/2738009 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@49580 0039d316-1c4b-4281-b951-d872f2087c98
* Remove MAYBE_ prefix from ExtensionStartupTesst.Test (fixing my mistake)jshin@chromium.org2010-06-111-1/+1
| | | | | | | | | | TEST=NONE BUG=NONE Review URL: http://codereview.chromium.org/2725011 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@49473 0039d316-1c4b-4281-b951-d872f2087c98
* Mark ExtensionsLoadTest.Test as flaky on Win/Macjshin@chromium.org2010-06-101-2/+8
| | | | | | | | | BUG=46301 TEST=greener tree TBR=jcivelli Review URL: http://codereview.chromium.org/2727007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@49472 0039d316-1c4b-4281-b951-d872f2087c98
* Return NULL instead of false when appropriate.evan@chromium.org2010-06-101-3/+3
| | | | | | | | (Found by clang.) Review URL: http://codereview.chromium.org/2725010 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@49466 0039d316-1c4b-4281-b951-d872f2087c98
* Reduce console spam from unneeded LOG().evan@chromium.org2010-06-101-1/+0
| | | | | | Review URL: http://codereview.chromium.org/2779014 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@49450 0039d316-1c4b-4281-b951-d872f2087c98
* Send event on changes to the cookie monster.jochen@chromium.org2010-06-106-2/+120
| | | | | | | | | BUG=38398 TEST=*.CookiesEvents Review URL: http://codereview.chromium.org/2703004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@49390 0039d316-1c4b-4281-b951-d872f2087c98
* Make the reload button respond to middle-clicks like back/forward/home ↵pkasting@chromium.org2010-06-101-2/+2
| | | | | | | | | | | | already do. This also makes GTK and Mac reset the location bar in the correct cases with various types of clicks on back/forward. BUG=none TEST=Middle-click reload. It should reload the page in a new background tab. Review URL: http://codereview.chromium.org/2779011 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@49350 0039d316-1c4b-4281-b951-d872f2087c98
* Give the extension unpacker process a junction/symlink free path to the ↵skerner@chromium.org2010-06-091-4/+20
| | | | | | | | | | | unpack directory. BUG=35198,13044 TEST=FileUtilTest.NormalizeFilePathBasic,FileUtilTest. NormalizeFilePathReparsePoints,FileUtilTest.NormalizeFilePathSymlinks Review URL: http://codereview.chromium.org/2088006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@49337 0039d316-1c4b-4281-b951-d872f2087c98
* Infobars on GTK (first part).finnur@chromium.org2010-06-091-2/+2
| | | | | | | | | | | | | | | | | I got it to a point where we show HTML content from the extension within an infobar, but there are a few things missing. Missing pieces: - Infobar does not size based on the height of its content (between 36px and 72px). - Infobar content always has a fixed width, but needs to fill out into the available infobar area. - I've put in code to asynchronously fetch the image for the Infobar, but it needs to be shown and hooked up to the ExtensionAction context menu (same context menu we use for the browser action container icons). - The background for HTML content should have a gradient, but is just solid blue at the moment. BUG=39916 TEST=Infobars should show up on GTK. Review URL: http://codereview.chromium.org/2753005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@49319 0039d316-1c4b-4281-b951-d872f2087c98
* Show theme loading info bubble and info bars in last normal browser.xiyuan@chromium.org2010-06-091-1/+4
| | | | | | | | | BUG=chromium-os:1797 TEST=Verify fix for chromium-os:1791. Review URL: http://codereview.chromium.org/2659004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@49254 0039d316-1c4b-4281-b951-d872f2087c98
* Marking the test as flaky since it fails 14% of the time.thomasvl@chromium.org2010-06-081-1/+7
| | | | | | | | BUG=46097 TEST=none Review URL: http://codereview.chromium.org/2724006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@49190 0039d316-1c4b-4281-b951-d872f2087c98
* Revert r49169 and r49170; they didn't fix the problem.evan@chromium.org2010-06-081-11/+0
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@49175 0039d316-1c4b-4281-b951-d872f2087c98
* Fix the build by disabling out unused functions.rsesek@chromium.org2010-06-081-0/+6
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@49170 0039d316-1c4b-4281-b951-d872f2087c98
* Disable the extension messages tests.evan@chromium.org2010-06-081-0/+5
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@49169 0039d316-1c4b-4281-b951-d872f2087c98
* It seems all RenderView tests have issues. I'll try reverting last ↵cira@chromium.org2010-06-071-2/+2
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | significant RenderView change and see if that helps. Revert 49046 - Disable RenderViewTest.ExtensionMessages* since they consistently crash localy and on the bots. Code in question didn't change recently (9months) so it is possible it's a WebKit problem. You need to run all tests to get the crash. Running with --gtest_filter=RenderViewTest.* passes. There is a possible namespace clash with other RenderViewTest class. Stack trace: \src\third_party\WebKit\WebCore\platform\TreeShared.h:38 WebCore::TreeShared<class WebCore::Node>::TreeShared) Backtrace: WebCore::TreeShared<WebCore::Node>::TreeShared<WebCore::Node> [0x03AE8EBA+90] (d:\chromium2\src\third_party\webkit\webcore\platform\treeshared.h:38) WebCore::Node::Node [0x03AD4011+49] (d:\chromium2\src\third_party\webkit\webcore\dom\document.h:1280) WebCore::ContainerNode::ContainerNode [0x03AD3D7E+30] (d:\chromium2\src\third_party\webkit\webcore\dom\containernode.h:107) WebCore::Document::Document [0x03AD331A+42] (d:\chromium2\src\third_party\webkit\webcore\dom\document.cpp:403) WebCore::HTMLDocument::HTMLDocument [0x03DDF76E+30] (d:\chromium2\src\third_party\webkit\webcore\html\htmldocument.cpp:86) WebCore::HTMLDocument::create [0x03E522B6+54] (d:\chromium2\src\third_party\webkit\webcore\html\htmldocument.h:40) WebCore::DOMImplementation::createDocument [0x03E52360+112] (d:\chromium2\src\third_party\webkit\webcore\dom\domimplementation.cpp:312) WebCore::DocumentWriter::createDocument [0x03B9B008+280] (d:\chromium2\src\third_party\webkit\webcore\loader\documentwriter.cpp:88) WebCore::DocumentWriter::begin [0x03B9B214+52] (d:\chromium2\src\third_party\webkit\webcore\loader\documentwriter.cpp:99) WebCore::FrameLoader::init [0x03B77539+441] (d:\chromium2\src\third_party\webkit\webcore\loader\frameloader.cpp:251) WebCore::Frame::init [0x026D4FB9+25] (d:\chromium2\src\third_party\webkit\webcore\page\frame.h:370) WebKit::WebFrameImpl::initializeAsMainFrame [0x026D4EE6+118] (d:\chromium2\src\third_party\webkit\webkit\chromium\src\webframeimpl.cpp:1712) WebKit::WebViewImpl::initializeMainFrame [0x0270D1D1+81] (d:\chromium2\src\third_party\webkit\webkit\chromium\src\webviewimpl.cpp:209) RenderView::Init [0x02BB1C04+660] (d:\chromium2\src\chrome\renderer\render_view.cc:533) RenderView::Create [0x02BB14CB+267] (d:\chromium2\src\chrome\renderer\render_view.cc:479) RenderViewTest::SetUp [0x01329E49+841] (d:\chromium2\src\chrome\test\render_view_test.cc:111) testing::Test::Run [0x02A47DC3+163] (d:\chromium2\src\testing\gtest\src\gtest.cc:2060) testing::internal::TestInfoImpl::Run [0x02A48B03+339] (d:\chromium2\src\testing\gtest\src\gtest.cc:2318 TBR=cira@chromium.org Review URL: http://codereview.chromium.org/2698005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@49051 0039d316-1c4b-4281-b951-d872f2087c98
* Support multiple PrefStoresmnissler@chromium.org2010-06-072-8/+19
| | | | | | | | | | | | Add interface for multi_pref_store_manager. BUG=40259 TEST=Unittests in pref_service_unittest.cc, pref_value_store_unittest.cc Review URL: http://codereview.chromium.org/1957005 Patch from Markus Heintz <markusheintz@google.com>. git-svn-id: svn://svn.chromium.org/chrome/trunk/src@49048 0039d316-1c4b-4281-b951-d872f2087c98
* Disable RenderViewTest.ExtensionMessages* since they consistently crash ↵cira@chromium.org2010-06-071-2/+2
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | localy and on the bots. Code in question didn't change recently (9months) so it is possible it's a WebKit problem. You need to run all tests to get the crash. Running with --gtest_filter=RenderViewTest.* passes. There is a possible namespace clash with other RenderViewTest class. Stack trace: \src\third_party\WebKit\WebCore\platform\TreeShared.h:38 WebCore::TreeShared<class WebCore::Node>::TreeShared) Backtrace: WebCore::TreeShared<WebCore::Node>::TreeShared<WebCore::Node> [0x03AE8EBA+90] (d:\chromium2\src\third_party\webkit\webcore\platform\treeshared.h:38) WebCore::Node::Node [0x03AD4011+49] (d:\chromium2\src\third_party\webkit\webcore\dom\document.h:1280) WebCore::ContainerNode::ContainerNode [0x03AD3D7E+30] (d:\chromium2\src\third_party\webkit\webcore\dom\containernode.h:107) WebCore::Document::Document [0x03AD331A+42] (d:\chromium2\src\third_party\webkit\webcore\dom\document.cpp:403) WebCore::HTMLDocument::HTMLDocument [0x03DDF76E+30] (d:\chromium2\src\third_party\webkit\webcore\html\htmldocument.cpp:86) WebCore::HTMLDocument::create [0x03E522B6+54] (d:\chromium2\src\third_party\webkit\webcore\html\htmldocument.h:40) WebCore::DOMImplementation::createDocument [0x03E52360+112] (d:\chromium2\src\third_party\webkit\webcore\dom\domimplementation.cpp:312) WebCore::DocumentWriter::createDocument [0x03B9B008+280] (d:\chromium2\src\third_party\webkit\webcore\loader\documentwriter.cpp:88) WebCore::DocumentWriter::begin [0x03B9B214+52] (d:\chromium2\src\third_party\webkit\webcore\loader\documentwriter.cpp:99) WebCore::FrameLoader::init [0x03B77539+441] (d:\chromium2\src\third_party\webkit\webcore\loader\frameloader.cpp:251) WebCore::Frame::init [0x026D4FB9+25] (d:\chromium2\src\third_party\webkit\webcore\page\frame.h:370) WebKit::WebFrameImpl::initializeAsMainFrame [0x026D4EE6+118] (d:\chromium2\src\third_party\webkit\webkit\chromium\src\webframeimpl.cpp:1712) WebKit::WebViewImpl::initializeMainFrame [0x0270D1D1+81] (d:\chromium2\src\third_party\webkit\webkit\chromium\src\webviewimpl.cpp:209) RenderView::Init [0x02BB1C04+660] (d:\chromium2\src\chrome\renderer\render_view.cc:533) RenderView::Create [0x02BB14CB+267] (d:\chromium2\src\chrome\renderer\render_view.cc:479) RenderViewTest::SetUp [0x01329E49+841] (d:\chromium2\src\chrome\test\render_view_test.cc:111) testing::Test::Run [0x02A47DC3+163] (d:\chromium2\src\testing\gtest\src\gtest.cc:2060) testing::internal::TestInfoImpl::Run [0x02A48B03+339] (d:\chromium2\src\testing\gtest\src\gtest.cc:2318 TBR=aa,mpcomplete,senorblanco git-svn-id: svn://svn.chromium.org/chrome/trunk/src@49046 0039d316-1c4b-4281-b951-d872f2087c98
* Add a context menu item to toggle app tab toolbars.aa@chromium.org2010-06-063-6/+72
| | | | | | Review URL: http://codereview.chromium.org/2690001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@49016 0039d316-1c4b-4281-b951-d872f2087c98
* Fix submenu support for extensions context menu API.asargent@chromium.org2010-06-033-118/+75
| | | | | | | | | | | | | | | | This fixes submenus which broke on all platforms during a recent refactor of the RenderViewContextMenu class, and adds support for more than one level of child menus. BUG=39504 TEST=Create a test extension using the chrome.experimental.contextMenu API and add multiple levels of child menu items. Review URL: http://codereview.chromium.org/2443002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@48892 0039d316-1c4b-4281-b951-d872f2087c98
* Disabled InstallApps while I fix the text on Linux.mpcomplete@chromium.org2010-06-031-1/+3
| | | | | | | | BUG=41280 Review URL: http://codereview.chromium.org/2618002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@48889 0039d316-1c4b-4281-b951-d872f2087c98
* Prevent installation of an app if its web extent overlaps another installed app.mpcomplete@chromium.org2010-06-034-11/+67
| | | | | | | | BUG=41280 Review URL: http://codereview.chromium.org/2469004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@48886 0039d316-1c4b-4281-b951-d872f2087c98
* Remove BOM from js and css files in content script.cira@chromium.org2010-06-032-21/+51
| | | | | | | | | BUG=38152 TEST=Inject css file with BOM using an extension. It should be injected without BOM. Review URL: http://codereview.chromium.org/2453005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@48885 0039d316-1c4b-4281-b951-d872f2087c98
* Force web_origin to be present only on extension gallery installs. Formpcomplete@chromium.org2010-06-034-16/+36
| | | | | | | | | | non-gallery installs, use the download URL as origin. BUG=40848 Review URL: http://codereview.chromium.org/2517001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@48878 0039d316-1c4b-4281-b951-d872f2087c98
* Remove some test file complitation exceptions from chrome_tests.gypistuartmorgan@chromium.org2010-06-031-1/+1
| | | | | | | | | | | Adds bug annotation to the tests that still needs porting work. BUG=45766,45753,45770,45771 TEST=Compling ui_tests still works Review URL: http://codereview.chromium.org/2605001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@48875 0039d316-1c4b-4281-b951-d872f2087c98
* Fix a regression where tabs.create() would focus the tab's window even ifmpcomplete@chromium.org2010-06-031-1/+0
| | | | | | | | | | selected is false. BUG=42531 Review URL: http://codereview.chromium.org/2483003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@48872 0039d316-1c4b-4281-b951-d872f2087c98
* A very basic fix that prevents experimental popups from living longer than ↵twiz@google.com2010-06-031-9/+46
| | | | | | | | | | | | | the ExtensionFunctionDispatcher/RenderViewHost that launched the popup. This is a problem, for example, when Chrome is closed while a popup is still displayed. I also removed the code that delayed sending the onClosed popup notification. I modified the ExtensionPopup::Obeserver interface to add methods for about-to-close, and fully-closed notifications. BUG=None TEST=ExtensionApiTest.Popup Review URL: http://codereview.chromium.org/2092020 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@48841 0039d316-1c4b-4281-b951-d872f2087c98
* [Mac] Re-enable some incognito extensions tests either because they are no ↵andybons@chromium.org2010-06-022-21/+4
| | | | | | | | | | longer failing or to gather more data on the crashes since I cannot get them to fail on my local machine. BUG=40002,40133 TEST=ExtensionBrowserTest, BrowserActionApiTest Review URL: http://codereview.chromium.org/2495002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@48756 0039d316-1c4b-4281-b951-d872f2087c98
* C++ readability change for cindylau.cindylau@google.com2010-06-025-83/+155
| | | | | | | | BUG=none TEST=none Review URL: http://codereview.chromium.org/2090008 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@48733 0039d316-1c4b-4281-b951-d872f2087c98
* Attempt to fix flaky OmniboxApiTest.Basic.mpcomplete@chromium.org2010-06-021-9/+12
| | | | | | | | | | | I'm making an educated guess that the TemplateURLModel wasn't loaded by the time we needed a keyword, so let's just wait for it to load. BUG=45588 Review URL: http://codereview.chromium.org/2485004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@48729 0039d316-1c4b-4281-b951-d872f2087c98
* Disable ExtensionBrowserTest.PageActionRefreshCrash on Mac. It crashes onlyjshin@chromium.org2010-06-021-1/+1
| | | | | | | | | | | | | | | occassionally, but when it does, FLAKY prefix does not help because it turns the tree red. By disabling this test, we lose the coverage for this test on Mac. Until we have a better way to handle flaky crashes, it's better to disable it. BUG=45079 TEST=Mac bots don't turn red due to this test crashing. TBR=jrg Review URL: http://codereview.chromium.org/2485003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@48684 0039d316-1c4b-4281-b951-d872f2087c98
* Disable FindInPageControllerTest.ActivateLinkNavigatesPage and jshin@chromium.org2010-06-021-1/+8
| | | | | | | | | | | ExtensionApiTest.Bookmarks on Windows BUG=45594,45595 TEST=Windows bot don't turn red with browser_test failure TBR=jrg Review URL: http://codereview.chromium.org/2433003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@48683 0039d316-1c4b-4281-b951-d872f2087c98
* Implement most of the ridealong fixes/cleanups I suggested during review for ↵pkasting@chromium.org2010-06-011-11/+10
| | | | | | | | | | enabling warn-on-signed-versus-unsigned-equality-comparisions on Windows. BUG=none TEST=none Review URL: http://codereview.chromium.org/2395001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@48666 0039d316-1c4b-4281-b951-d872f2087c98
* [GTTF] Add FRIEND_TEST_ALL_PREFIXES, a FRIEND_TEST replacementphajdan.jr@chromium.org2010-06-012-9/+10
| | | | | | | | | | | that works with all test prefixes (DISABLED, FLAKY, FAILS). TEST=none BUG=44549 Review URL: http://codereview.chromium.org/2439001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@48634 0039d316-1c4b-4281-b951-d872f2087c98
* Fix ability to add sub-menu items with extension context menu API.asargent@chromium.org2010-05-281-1/+1
| | | | | | | | | | | BUG=45157 TEST=Try adding a context menu item with the chrome.experimental.contextMenu API, and then adding another one whose parentId is set to the id of the first one. This should now succeed. Review URL: http://codereview.chromium.org/2296002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@48514 0039d316-1c4b-4281-b951-d872f2087c98
* First pass at experimental omnibox API. There are plenty of rough edges and ↵mpcomplete@chromium.org2010-05-288-5/+269
| | | | | | | | | | | | | | | features to work on, but it's in a usable state. When an extension is installed that specifies an omnibox keyword in its manifest, we add that keyword to the user's list of Search Engines. The user can then edit this keyword later. I'm leveraging most of the original search engine keyword code. An extension keyword has a special URL that identifies it as an extension keyword. There is some special case code to treat these keywords slightly differently throughout the omnibox code. BUG=38884 Review URL: http://codereview.chromium.org/2078021 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@48503 0039d316-1c4b-4281-b951-d872f2087c98