summaryrefslogtreecommitdiffstats
path: root/chrome/browser/extensions
Commit message (Collapse)AuthorAgeFilesLines
* Don't prompt before installing a Theme, move existing prompt so that users ↵glen@chromium.org2009-06-053-11/+25
| | | | | | | | | | | | aren't prompted twice in the case when they have extensions disabled. Theme installation confirmation will be done through an infobar (allowing you to preview a lot of themes quickly without dealing with dialogs) - see CL 119235. BUG=none TEST=Install a theme, verify that you don't get prompted. Install an extension and verify that you do get prompted. Review URL: http://codereview.chromium.org/119232 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17755 0039d316-1c4b-4281-b951-d872f2087c98
* Make AsyncExtensionFunction possible.mpcomplete@google.com2009-06-057-25/+78
| | | | | | | | | | | Change the bookmarks API to be async functions, so that they can delay their response until the bookmark system is loaded. BUG=12353 TEST=none Review URL: http://codereview.chromium.org/114079 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17751 0039d316-1c4b-4281-b951-d872f2087c98
* Validate that extension resources exist.glen@chromium.org2009-06-052-3/+28
| | | | | | | | | BUG=11678 TEST=Make a theme with bad references to images and try to install it. Or just verify that the InstallTheme unit_test passes. Review URL: http://codereview.chromium.org/119137 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17708 0039d316-1c4b-4281-b951-d872f2087c98
* make extension apis tolerate browser absence during start-up & shutdownrafaelw@chromium.org2009-06-045-30/+63
| | | | | | | | | | | Note: I was never able to directly reproduce the 13082 bug, the error mode is clear (there was no selected tab during a call to tabs.getSelected()). This fix will address that issue and we should stop seeing this crash reports. R=erikkay BUG=13082 Review URL: http://codereview.chromium.org/119117 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17631 0039d316-1c4b-4281-b951-d872f2087c98
* Part 1 of dragging extensions on the shelf. This part was just about ↵erikkay@google.com2009-06-033-20/+151
| | | | | | | | getting the mechanics of the shelf handle and the dragging correct. Part 2 will actually allow the order to be changed.TEST=hover over an extension toolstrip, grab the handle and drag. release. Review URL: http://codereview.chromium.org/119103 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17559 0039d316-1c4b-4281-b951-d872f2087c98
* Change plugin handling in extension from "plugin_dir" to a "plugin" list ofmpcomplete@google.com2009-06-032-3/+18
| | | | | | | | | | | | dictionaries, which allows us to specify properties per plugin. This is the first part of allowing extensions to have plugins only accessible by the extension process. BUG=12960 Review URL: http://codereview.chromium.org/114072 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17510 0039d316-1c4b-4281-b951-d872f2087c98
* Headers cleanup in chrome/browser/phajdan.jr@chromium.org2009-06-032-0/+3
| | | | | | | | | | | - reduce header dependencies - miscellanous cleanups (add missing includes for OS_ defines etc) Further changesets may follow. I was only looking at header files up to character_encoding.h. Review URL: http://codereview.chromium.org/118072 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17470 0039d316-1c4b-4281-b951-d872f2087c98
* Support for searching bookmarks for IDN.brettw@chromium.org2009-06-021-1/+4
| | | | | | | | | | | | | | The main part of this change is DoesBookmarkContainWords() in bookmark_utils.cc. It tries to match a query words to IDN and %-decoded strings as well as ASCII URL. BUG=3991 TEST=add a unit test, check for IDN in the search box of Bookmark Manager. Checked in for tkent@google.com. Original review: http://codereview.chromium.org/113815 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17435 0039d316-1c4b-4281-b951-d872f2087c98
* Add some browser-level checks to prohibit access to extension bindings bympcomplete@google.com2009-06-021-0/+7
| | | | | | | | | | | | non-extension renderers. Also add a check so that bindings are only exposed if the top-level frame is the chrome-extension scheme. BUG=11545 BUG=11993 TEST=none Review URL: http://codereview.chromium.org/119014 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17408 0039d316-1c4b-4281-b951-d872f2087c98
* The extensions service wasn't getting inited despite being used by themes ↵glen@chromium.org2009-06-022-16/+46
| | | | | | | | | | | (this manifested itself as theme reinstall failing, because CheckCurrentVersion found the directory, but ExtensionService::extensions_ was empty). BUG=none TEST=none Review URL: http://codereview.chromium.org/115974 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17373 0039d316-1c4b-4281-b951-d872f2087c98
* Implements a Zip() utility function. Refactor existingaa@chromium.org2009-06-011-1/+1
| | | | | | | | Unzip-relatedness into shared locations. Review URL: http://codereview.chromium.org/118028 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17305 0039d316-1c4b-4281-b951-d872f2087c98
* Coverity underground warfare: Uninitalized membercpu@google.com2009-05-301-1/+3
| | | | | | | | | | | | - Fix ctor to init members - CID 4187 BUG = none TEST = none Review URL: http://codereview.chromium.org/118035 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17275 0039d316-1c4b-4281-b951-d872f2087c98
* Fixes a slew of random link/compile errors for views on gtk.sky@chromium.org2009-05-293-6/+6
| | | | | | | | | BUG=none TEST=none TBR=ben Review URL: http://codereview.chromium.org/115948 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17246 0039d316-1c4b-4281-b951-d872f2087c98
* Revert the Omnibox when changing tabs while its contents have been deleted.pkasting@chromium.org2009-05-292-11/+12
| | | | | | | | | To do this, I needed to add a new TabStripModelObserver call that fired before the tab had been changed, since when the Omnibox asks for the current permanent_text_ it gets it from the selected tab's navigation controller. BUG=6850 Review URL: http://codereview.chromium.org/113983 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17241 0039d316-1c4b-4281-b951-d872f2087c98
* Allow themes to be installed without any commandline flag, still require ↵glen@chromium.org2009-05-293-13/+95
| | | | | | | | | | | flag for Extensions. Expand themes unittests. BUG=12205,12231 TEST=Without any flags, try installing an extension and a theme. The extension should fail and the theme should succeed. Attempts to install a theme with extension components in the manifest should similarly result in failure. Review URL: http://codereview.chromium.org/115798 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17240 0039d316-1c4b-4281-b951-d872f2087c98
* Fix a browser crash that occurs if the extension unpacker process crashesmpcomplete@google.com2009-05-291-2/+15
| | | | | | | | | | after it sends a response to the browser. BUG=none TEST=none Review URL: http://codereview.chromium.org/113867 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17222 0039d316-1c4b-4281-b951-d872f2087c98
* Fixing more bustage by ifdefing out Windows-only code.ben@chromium.org2009-05-292-1/+19
| | | | | | | | | TBR=brettw BUG=none TEST=none Review URL: http://codereview.chromium.org/115914 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17173 0039d316-1c4b-4281-b951-d872f2087c98
* Fix unit test bustage by making sure ExtensionView::ViewHierarchyChanged ↵ben@chromium.org2009-05-293-0/+9
| | | | | | | | | | | | | calls the base class impl first. Fix compile bustage by not compiling windows-specific code on other platforms. TBR=brettw BUG=none TEST=none Review URL: http://codereview.chromium.org/115912 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17172 0039d316-1c4b-4281-b951-d872f2087c98
* Refactors HWNDView, NativeViewHostGtk and NativeViewHost so that they match ↵ben@chromium.org2009-05-292-13/+6
| | | | | | | | | | the NativeControl pattern established for NativeButtons. NativeViewHost is a platform-neutral class that clients instantiate. Behind the scenes the platform instantiates the appropriate NativeViewHostWrapper implementation, either NativeViewHostGtk (as before) or NativeViewHostWin (replaces HWNDView). BUG=none TEST=none Review URL: http://codereview.chromium.org/114059 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17169 0039d316-1c4b-4281-b951-d872f2087c98
* Make automation proxy objects to ref_counted. That allows to process async ↵stoyan@chromium.org2009-05-281-1/+1
| | | | | | | | | | | notifications directly in channel background thread. Add support for listener-less ChannelProxy. BUG=none TEST=none Review URL: http://codereview.chromium.org/113722 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17093 0039d316-1c4b-4281-b951-d872f2087c98
* Add a single monitor implementation of WindowSizer for Linux. (try 2)thestig@chromium.org2009-05-261-6/+1
| | | | | | | BUG=10005 Review URL: http://codereview.chromium.org/115723 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16940 0039d316-1c4b-4281-b951-d872f2087c98
* Fix a race condition in the unpacking of the extension system.finnur@chromium.org2009-05-261-0/+4
| | | | | | | | | | | | | | | After asking for an extension to be unpacked, sometimes the temp directory gets cleaned up before the unpacker can do its work (in LoadExtensionsFromInstallDirectory, because the dir contains no current version). BUG=None TEST=Add a reg key to HKLM to install an external extension and make sure the extension gets installed. Review URL: http://codereview.chromium.org/113795 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16884 0039d316-1c4b-4281-b951-d872f2087c98
* Remove unused code from ExtensionsService.mpcomplete@google.com2009-05-2624-1502/+21
| | | | | | | | Move extension.* from browser to common, so it can be included by the utility process. Review URL: http://codereview.chromium.org/115716 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16880 0039d316-1c4b-4281-b951-d872f2087c98
* Separate out the string constants used for extension API functionaa@chromium.org2009-05-2615-284/+524
| | | | | | | | | | | | names, function parameter keys, error messages and event names so that they can be reused when writing extension UI tests. Original review: http://codereview.chromium.org/113771 Review URL: http://codereview.chromium.org/113831 Patch from Joi Sigurdsson <joi.sigurdsson@gmail.com>. git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16867 0039d316-1c4b-4281-b951-d872f2087c98
* Update renderers when there are zero user scripts.aa@chromium.org2009-05-262-11/+5
| | | | | | | | | | | | | Commit: http://codereview.chromium.org/113733 BUG=12170 TEST=Enable user scripts and create one. See that it runs. Now delete it. See that it does not run! Review URL: http://codereview.chromium.org/113741 Patch from Ted Crossman <tedoc2000@gmail.com>. git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16864 0039d316-1c4b-4281-b951-d872f2087c98
* Committing issue 113734 for Joi.tommi@chromium.org2009-05-231-1/+1
| | | | | | | | | | | | | | | | | | | | | | | | | | Description: Make sure extension_uitest.cc is actually built (my bad - got confused about the whole .gyp vs. .sln thing). Also, to get things building now that extension_uitest.cc is built, shuffle the extension automation constants around so they end up in the browser library (I didn't realize the UI tests are already linking with that, and the linker was bringing in the automation_extension_function.obj file ended up causing lots of unresolved linker problems). Note that this did build the other day when I submitted the file originally, but it must have been essentially a fluke that the linker chose the other .obj file to get the constants. BUG=none TEST=none Original issue: http://codereview.chromium.org/113734 Review URL: http://codereview.chromium.org/113788 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16835 0039d316-1c4b-4281-b951-d872f2087c98
* Reverting 16796.thestig@chromium.org2009-05-221-0/+6
| | | | | | Review URL: http://codereview.chromium.org/113791 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16800 0039d316-1c4b-4281-b951-d872f2087c98
* Add a single monitor implementation of WindowSizer for Linux.thestig@chromium.org2009-05-221-6/+0
| | | | | | | BUG=10005 Review URL: http://codereview.chromium.org/114041 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16796 0039d316-1c4b-4281-b951-d872f2087c98
* Have the browser process rewrite manifest.json and theme/page action imagesmpcomplete@google.com2009-05-223-36/+105
| | | | | | | | | that the extension unpacker process parsed. BUG=11680 Review URL: http://codereview.chromium.org/115595 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16768 0039d316-1c4b-4281-b951-d872f2087c98
* Hook up more of extension uninstall.aa@chromium.org2009-05-2113-498/+660
| | | | | | | | | | | Also removed all external dependencies from ExtensionsService. It now only sends out notifications, which other services consume. This should allow us to unit test the ExtensionsService frontend, but I haven't added that yet. Review URL: http://codereview.chromium.org/113493 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16676 0039d316-1c4b-4281-b951-d872f2087c98
* Use a NotificationRegistrar to listen for notifications.pkasting@chromium.org2009-05-219-45/+34
| | | | | | | BUG=2381 Review URL: http://codereview.chromium.org/113717 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16665 0039d316-1c4b-4281-b951-d872f2087c98
* Move the validation of icons for page actions to load time.finnur@chromium.org2009-05-213-16/+22
| | | | | | | | | | | | This is in line with how we validate content scripts and enables installing page actions as .crx filed. BUG=None TEST=Install a Page Action as a .crx file. It should install. Review URL: http://codereview.chromium.org/115644 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16640 0039d316-1c4b-4281-b951-d872f2087c98
* Revert "Hook up more of extension uninstall."aa@chromium.org2009-05-2113-663/+503
| | | | | | | | This reverts commit ebb5f616663f9d5ee78584187da16bba4ce96811. Review URL: http://codereview.chromium.org/113680 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16557 0039d316-1c4b-4281-b951-d872f2087c98
* Hook up more of extension uninstall.aa@chromium.org2009-05-2013-503/+663
| | | | | | | | | | | Also removed all external dependencies from ExtensionsService. It now only sends out notifications, which other services consume. This should allow us to unit test the ExtensionsService frontend, but I haven't added that yet. Review URL: http://codereview.chromium.org/113493 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16547 0039d316-1c4b-4281-b951-d872f2087c98
* TBR: Revert "Hook up more of extension uninstall."aa@chromium.org2009-05-2013-663/+503
| | | | | | | | This reverts commit 5b2fc12fbca26b20ed4176ac740c58fe49360c4a. Review URL: http://codereview.chromium.org/113664 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16538 0039d316-1c4b-4281-b951-d872f2087c98
* Hook up more of extension uninstall.aa@chromium.org2009-05-2013-503/+663
| | | | | | | | | | | Also removed all external dependencies from ExtensionsService. It now only sends out notifications, which other services consume. This should allow us to unit test the ExtensionsService frontend, but I haven't added that yet. Review URL: http://codereview.chromium.org/113493 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16529 0039d316-1c4b-4281-b951-d872f2087c98
* tabs.onUpdated now sends 'url' when 'state' has changed to 'loading' when ↵rafaelw@chromium.org2009-05-204-110/+254
| | | | | | | | | | | | | navigating to a new url. If a reload is in progress, 'loading' will not be accompanied by 'url'. Also, refactored some code so that string constants are defined and shared. BUG=11200 R=erikkay Review URL: http://codereview.chromium.org/113552 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16467 0039d316-1c4b-4281-b951-d872f2087c98
* Allow connecting and messaging with extension ports by funneling externalmpcomplete@google.com2009-05-192-15/+99
| | | | | | | | | | ports through the automation postMessage interface. See original review at: http://codereview.chromium.org/113461 Patch by Siggi Asgeirsson <sigurdur.asgeirsson@gmail.com> Review URL: http://codereview.chromium.org/113538 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16396 0039d316-1c4b-4281-b951-d872f2087c98
* Fix inspection of extensions.aa@chromium.org2009-05-193-4/+5
| | | | | | | | | | | | As a bonus, debugging of extensions now works. Go OOP inspector team! Inspection code was calling RVHD::GetProfile(), which was not implemented by ExtensionHost. Looking into this, it seems better to just remove the method from the interface since Profile is already accessible by way of RVH. The only caller to RVHD::GetProfile() besides the inspector was HWNDHtmlView which is itself dead code, so I removed it too. Review URL: http://codereview.chromium.org/115501 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16392 0039d316-1c4b-4281-b951-d872f2087c98
* Fix Skia includes to use the whole path name.brettw@chromium.org2009-05-191-1/+1
| | | | | | Review URL: http://codereview.chromium.org/115412 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16374 0039d316-1c4b-4281-b951-d872f2087c98
* Fix a crash in the extension system when sending response back to extension ↵finnur@chromium.org2009-05-182-4/+7
| | | | | | | | | | with no results. Also found an UMR causing DCHECKs to hit repeatedly (in AsyncExtensionFunction::SetArgs). BUG=None TEST=Basically, use any extension that calls an API function that returns no results (such as PageAction) and Chrome should not crash. Review URL: http://codereview.chromium.org/114033 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16325 0039d316-1c4b-4281-b951-d872f2087c98
* Add a handle to the ExtensionShelf. This is how users will drag extension ↵erikkay@google.com2009-05-186-5/+305
| | | | | | | | | | | | | | | | toolstrips around, and perhaps where we'll add other UI for manipulating an extension. BUG=none TEST=none depends on the following other changes: http://codereview.chromium.org/113481 http://codereview.chromium.org/113486 http://codereview.chromium.org/113466 Review URL: http://codereview.chromium.org/113483 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16284 0039d316-1c4b-4281-b951-d872f2087c98
* First step to enable end-to-end testing of extensions through theaa@chromium.org2009-05-155-77/+442
| | | | | | | | | | | | | | automation interface. This adds a method to turn on automation of extension API functions, plumbing that redirects API requests through the automation interface when appropriate, and a couple of UITests that exercise the functionality. See http://codereview.chromium.org/113277 for the original review. Review URL: http://codereview.chromium.org/115427 Patch from Joi Sigurdsson <joi.sigurdsson@gmail.com>. git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16207 0039d316-1c4b-4281-b951-d872f2087c98
* Introducing the Utility process, which handles the unpacking and verificationmpcomplete@google.com2009-05-153-97/+187
| | | | | | | | | | | | of extension packages. This is a first pass. In the second pass, I will add support for transcoding the manifest and any images in the browser process. BUG=11680 Review URL: http://codereview.chromium.org/114027 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16198 0039d316-1c4b-4281-b951-d872f2087c98
* ChromeCanvas->gfx::Canvasben@chromium.org2009-05-152-5/+5
| | | | | | | | | | | Rename files too. TBR=brettw http://crbug.com/11387 Review URL: http://codereview.chromium.org/113443 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16148 0039d316-1c4b-4281-b951-d872f2087c98
* Add ExtensionsService::Uninstall() plus unit tests.aa@chromium.org2009-05-156-58/+185
| | | | | | | | Haven't hooked this up to anything yet though. Still trying to figure out the best way to shut everything down, so I figured I'd send this easy part out alone. Review URL: http://codereview.chromium.org/113376 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16147 0039d316-1c4b-4281-b951-d872f2087c98
* Uploaded & applied on behalf of Roger Tawa (rogerta@google.com).rafaelw@chromium.org2009-05-154-20/+136
| | | | | | | | | | | BUG=11200 R=aa,rafaelw http://codereview.chromium.org/115250 Review URL: http://codereview.chromium.org/113442 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16146 0039d316-1c4b-4281-b951-d872f2087c98
* Add error handling to PageAction extension API.finnur@chromium.org2009-05-142-13/+29
| | | | | | | | | BUG=None TEST=None Review URL: http://codereview.chromium.org/113415 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16101 0039d316-1c4b-4281-b951-d872f2087c98
* Extend the chrome.tabs API to allow relative paths.finnur@chromium.org2009-05-141-5/+26
| | | | | | | | BUG=None TEST=In an extension, use chrome.tabs.create(...) to create a tab using a relative path ("foo/bar.html"). It should resolve that path by prepending the extension path ("chrome-extension://0000000000000000000000000000000000000042/foo/bar.html). Review URL: http://codereview.chromium.org/113374 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16098 0039d316-1c4b-4281-b951-d872f2087c98
* Add support for almost-recursive watches in Linux DirectoryWatcherphajdan.jr@chromium.org2009-05-141-1/+5
| | | | | | | | | | | | | | | | | After this patch DirectoryWatcher when asked for recursive watch will scan the subtree and add inotify watches for each subfolder, but further changes to the tree structure won't trigger adding/removing watches. Support for really recursive watches is planned. This is just to divide the work, because the task is not easy. Based on patch by Janwar Dinata <j.dinata@gmail.com> reviewed at http://codereview.chromium.org/92151 http://crbug.com/8968 Review URL: http://codereview.chromium.org/115229 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16070 0039d316-1c4b-4281-b951-d872f2087c98
generated by cgit v1.1 at 2025-02-19 23:41:37 +0000