summaryrefslogtreecommitdiffstats
path: root/chrome/browser/extensions
Commit message (Collapse)AuthorAgeFilesLines
* Fix EOL inconsistency on extension_message_service.cc.maruel@chromium.org2009-09-171-1/+1
| | | | | | | | | | | | NO CODE CHANGE. The presubmit check should have warned you. Please listen to it. This causes breakage on the try slaves because SVN is too stupid to revert a file with inconsistent EOL, go figure. TBR=mpcomplete TEST=none BUG=none git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26439 0039d316-1c4b-4281-b951-d872f2087c98
* Reduce severity of alert level when extension installation fails.pamg@google.com2009-09-161-1/+1
| | | | | | | | BUG=19907 TEST=as described in bug Review URL: http://codereview.chromium.org/204034 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26366 0039d316-1c4b-4281-b951-d872f2087c98
* Add a bare-bones extension shelf that displays extension items on OS X.thakis@chromium.org2009-09-162-7/+17
| | | | | | | | | | | | | | | | | | | This brings our extension support to about the level it has on linux. One issue is that the toolstrips are webpages with a background image that just happens to look like the shelf they are on. But the background images are not updated on key->nonkey window changes, so the toolstrip backgrounds look slightly off in one of the two cases. If we decide to keep the shelf, we should fix this, but see the bug for erikkay's stance on this. Also, the NTP is only loaded after all toolstrips have been loaded for some reason. That's what happens on the other platforms too, I believe. The extension shelf uses the DownloadShelfView as background view for now. Screenie: http://imgur.com/wSHgU.png BUG=19073 TEST=Extensions that live in the shelf should show up. They should be clickable, resize correctly (e.g. the build status extension), and the shelf should interact in a sane way with the status bubble. Review URL: http://codereview.chromium.org/175025 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26311 0039d316-1c4b-4281-b951-d872f2087c98
* Handle mole/toolstrip URLs properly.erikkay@chromium.org2009-09-152-7/+32
| | | | | | | | | | | | | * expand/collapse to chrome-extension://crashme no longer crashes * expand/collapse to a relative URL now works BUG=20412,21905 TEST=browser_tests ExtensionApi.Toolstrip (note that the test doesn't actually exercise these changes due to 21905) Review URL: http://codereview.chromium.org/195093 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26266 0039d316-1c4b-4281-b951-d872f2087c98
* Address ExtensionApiTest.Tabs flakinessrafaelw@chromium.org2009-09-151-2/+1
| | | | | | | | | | | | This addresses two problems. (1) relativeUrlTabsUpdate could fail because it was depending on testTabId getting set from relativeUrlTabsCreate, which may have happened out of order. I have refactored the callback blocking so additional blocks can be created with chrome.test.callbackAdded(). (2) tabs.update({url:}) is still failing intermitantly. This changes addeds valid html files in the extension which can be navitation targets (previously, non-existent urls had been used), in the hopes that the random failures had to do with load errors. BUG=20828 Review URL: http://codereview.chromium.org/195090 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26258 0039d316-1c4b-4281-b951-d872f2087c98
* ExtensionShelf now uses the BookmarkExtensionBackground, just like the ↵finnur@chromium.org2009-09-152-19/+49
| | | | | | | | | | | | | | | | | | | | | | | | | | | BookmarkBarView. Changed the WebKit API to add an optional |id| parameter to the insertStyleText, which is needed to be able to replace style sheets that have been previously added. Added an interface that both BookmarkBarView and ExtensionShelf implement. This new interface tells us whether we are located at the top or at the bottom and whether we are detached from the frame or not. Factored out some of the duplicate painting-related code to a namespace of its own. Not happy with the name (welcome suggestions). Moved the check for whether extensions are on top to new class and now cache the value for the lifetime of the process. Toolstrip text color values are no longer hard-coded but use the color specified in the theme. Decreased the timeouts for showing and hiding the toolstrip handle. Replaced the pressed background image and the hover background image for the toolstrip to match what the bookmark bar uses. Known issues: Some themes expose the fact that: - The background for the extension shelf when in detached mode (and located on the bottom) does not seamlessly blend in with background of new tab page. Still works surprisingly well when it breaks, though. - Didn't spend much time theming the shelf handle (just used the solid color from the theme). - When extension shelf is merged with the bookmark bar, there is a painting artifact (horizontal dotted line) that appears (apparently it was known to appear before this change). BUG=18452, 21272, 21273 TEST=Install a theme for Chrome and make sure everything looks correct and is updated on a theme change. Also make sure painting problems in bugs 21272 and 21273 are fixed. Review URL: http://codereview.chromium.org/204022 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26227 0039d316-1c4b-4281-b951-d872f2087c98
* Disable flaky test ExtensionApiTest.Tabs.maruel@chromium.org2009-09-151-1/+2
| | | | | | | | | | | TBR=asargent BUG=20828 TEST=ExtensionApiTest.Tabs random failure Review URL: http://codereview.chromium.org/205009 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26218 0039d316-1c4b-4281-b951-d872f2087c98
* Revert change 26184, 26181 and 26178 to fixnsylvain@chromium.org2009-09-152-49/+19
| | | | | | | | | | the compile error on the toolkit builder. TBR:finnur Review URL: http://codereview.chromium.org/203064 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26186 0039d316-1c4b-4281-b951-d872f2087c98
* ExtensionShelf now uses the BookmarkExtensionBackground, just like the ↵finnur@chromium.org2009-09-142-19/+49
| | | | | | | | | | | | | | | | | | | | | | | | | BookmarkBarView. Changed the WebKit API to add an optional |id| parameter to the insertStyleText, which is needed to be able to replace style sheets that have been previously added. Added an interface that both BookmarkBarView and ExtensionShelf implement. This new interface tells us whether we are located at the top or at the bottom and whether we are detached from the frame or not. Factored out some of the duplicate painting-related code to a namespace of its own. Not happy with the name (welcome suggestions). Moved the check for whether extensions are on top to new class and now cache the value for the lifetime of the process. Toolstrip text color values are no longer hard-coded but use the color specified in the theme. Decreased the timeouts for showing and hiding the toolstrip handle. Replaced the pressed background image and the hover background image for the toolstrip to match what the bookmark bar uses. Known issues: Some themes expose the fact that: - The background for the extension shelf when in detached mode (and located on the bottom) does not seamlessly blend in with background of new tab page. Still works surprisingly well when it breaks, though. - Didn't spend much time theming the shelf handle (just used the solid color from the theme). BUG=18452, 21272, 21273 TEST=Install a theme for Chrome and make sure everything looks correct and is updated on a theme change. Also make sure painting problems in bugs 21272 and 21273 are fixed. Review URL: http://codereview.chromium.org/203034 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26178 0039d316-1c4b-4281-b951-d872f2087c98
* Do not send or store cookies for extensions autoupdate http requests.asargent@chromium.org2009-09-123-2/+15
| | | | | | | | | BUG=18641 TEST=none Review URL: http://codereview.chromium.org/196097 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26054 0039d316-1c4b-4281-b951-d872f2087c98
* Extension apis: windows.create({url:}) now supports relative paths.rafaelw@chromium.org2009-09-111-7/+24
| | | | | | | | | | tabs.update() & tabs.move() now return full Tab object. BUG=17665 Review URL: http://codereview.chromium.org/203042 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26052 0039d316-1c4b-4281-b951-d872f2087c98
* ExternalTabcontainer browser to initial URLamit@chromium.org2009-09-111-23/+22
| | | | | | | | | | | | | Browse the newly created external tab to the specified initial URL if present, to about:blank otherwise. Also send information about SSL status when sending navigation updates to the automation client. BUG=none TEST=CreateExternalTabWithUrl UI test Review URL: http://codereview.chromium.org/193054 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26037 0039d316-1c4b-4281-b951-d872f2087c98
* Add button number to page action event reply object. Fix outdated page ↵mattm@chromium.org2009-09-114-2/+9
| | | | | | | | action docs. Review URL: http://codereview.chromium.org/194082 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26006 0039d316-1c4b-4281-b951-d872f2087c98
* Update ExtensionApiTest.Tabs and re-enablerafaelw@chromium.org2009-09-111-2/+1
| | | | | | | | BUG=20828 Review URL: http://codereview.chromium.org/199091 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26002 0039d316-1c4b-4281-b951-d872f2087c98
* Force page-action views to update after reloading an extension, by deletingpam@chromium.org2009-09-114-11/+69
| | | | | | | | | | | | | | | them all. Otherwise, since the view count is unchanged, the views continue to use stale extension information and the page-action icon fails to be displayed. Fix excessive timeout logging in WaitForPageActionVisibilityChangeTo(). BUG=http://crbug.com/21324 TEST=write page-action extension, load as unpacked, reload, verify that icon is shown on a matching page. Also covered by browser_tests unit test. Review URL: http://codereview.chromium.org/202027 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25996 0039d316-1c4b-4281-b951-d872f2087c98
* Add api tests for cross-origin XHR.aa@chromium.org2009-09-111-0/+11
| | | | | | Review URL: http://codereview.chromium.org/199092 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25994 0039d316-1c4b-4281-b951-d872f2087c98
* add mole collapse/expand events. convert mappy to use this.erikkay@chromium.org2009-09-114-0/+96
| | | | | | | | | BUG=15494 TEST=browser_tests.exe --gtest_filter=ExtensionApiTest.Toolstrip Review URL: http://codereview.chromium.org/203023 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25976 0039d316-1c4b-4281-b951-d872f2087c98
* Don't allow updating tabs to javascript URLs without hostaa@chromium.org2009-09-117-14/+62
| | | | | | | | | | | | | | | | | | | | | | | | permissions to that tab. Cleaned up a few things along the way: - added a GetExtension() method to ExtensionFunctionDispatcher and ExtensionFunction since it was used in more than one place. - Removed first param from chrome.test.failCallback() since it wasn't used anywhere. - Added a convenience CanAccessHost() method to Extension, since it seems likely to be commonly used. - Refactored setup of mock host resolver in browsertest, since the way it was, you could only customize it at the testsuite level, not the test level. Review URL: http://codereview.chromium.org/199074 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25971 0039d316-1c4b-4281-b951-d872f2087c98
* Linux: implement Page Actions support.mattm@chromium.org2009-09-103-2/+22
| | | | | | | | | BUG=11973 TEST=load an extension with page actions, it should work like on windows. Review URL: http://codereview.chromium.org/195050 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25934 0039d316-1c4b-4281-b951-d872f2087c98
* Make extensions use ViewMsg_EnableIntrinsicWidthChangedMode.mpcomplete@chromium.org2009-09-101-0/+3
| | | | | | | | | BUG=11974 TEST=no Review URL: http://codereview.chromium.org/194064 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25928 0039d316-1c4b-4281-b951-d872f2087c98
* Move StringPiece into the base namespace. It is collidingtony@chromium.org2009-09-105-17/+20
| | | | | | | | | | with the StringPiece class in icu4.2, which is a problem when trying to use the system version of icu. Review URL: http://codereview.chromium.org/193072 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25920 0039d316-1c4b-4281-b951-d872f2087c98
* Added chrome.i18n extension API.xji@chromium.org2009-09-094-0/+92
| | | | | | | | | | | | | | | | | | The API proposal doc is http://sites.google.com/a/chromium.org/dev/developers/design-documents/extensions/i18n-api This CL only adds the getter of accept languages: chrome.i18n.getAcceptLanguages(). The setter of accept languages will be added in a separate CL. BUG=http://crbug.com/14574 TEST=TEST=There is an extension in chrome\test\data\extensions\samples\i18n. Load this extension. It creates a toolstrip button. Click this button, you should get chrome's accept languages. Review URL: http://codereview.chromium.org/174116 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25810 0039d316-1c4b-4281-b951-d872f2087c98
* Simple fix of extension_l10n_util that allows folders in form ".some_name" ↵cira@chromium.org2009-09-093-2/+31
| | | | | | | | | | to exist in _locales folder. It helps testing/loading extensions from svn tree (skips .svn folder, doesn't fail). Review URL: http://codereview.chromium.org/196029 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25779 0039d316-1c4b-4281-b951-d872f2087c98
* Don't send the channel-disconnect message if the recipient is in the processmpcomplete@chromium.org2009-09-092-7/+15
| | | | | | | | | | | | | of closing. This is an attempt to fix a crash bug. TEST=no BUG=21201 Review URL: http://codereview.chromium.org/197054 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25767 0039d316-1c4b-4281-b951-d872f2087c98
* Add a disable button to the Extension management UI.mpcomplete@chromium.org2009-09-084-7/+71
| | | | | | | | | TEST=Try installing and/or loading some extensions, and toggling between enable and disable in the management UI (chrome://extensions). BUG=12122 Review URL: http://codereview.chromium.org/199018 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25659 0039d316-1c4b-4281-b951-d872f2087c98
* Plumb the DragOperation through all the layers between the platform ↵snej@chromium.org2009-09-082-4/+9
| | | | | | | | | | | | | Drag-n-drop code and WebCore. This allows the HTML5 DataTransfer effectAllowed and dropEffect properties to be set correctly in JS handlers, as per the HTML5 spec. (The drag-dropeffect test isn't in WebKit yet -- it's part of a separate WebKit patch that's been in review for weeks.) R=darin,pink BUG=http://code.google.com/p/chromium/issues/detail?id=14654, http://code.google.com/p/chromium/issues/detail?id=20985 TEST=LayoutTests/fast/events/drag-dropeffect.html, LayoutTests/editing/pasteboard/files-during-page-drags.html Review URL: http://codereview.chromium.org/174364 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25629 0039d316-1c4b-4281-b951-d872f2087c98
* finished testing functions and added events to bookmark tests.erikkay@chromium.org2009-09-082-4/+0
| | | | | | | | added infrastructure to better support events and cleaned up callback testing. Review URL: http://codereview.chromium.org/192028 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25623 0039d316-1c4b-4281-b951-d872f2087c98
* Make sure theme loading bubble is cancelled when extension install is cancelled.mirandac@chromium.org2009-09-041-0/+5
| | | | | | | | | BUG= http://crbug.com/21096 TEST= Install theme. Cancel install at dialog box. Note disappearance of "loading" bubble. Review URL: http://codereview.chromium.org/201019 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25521 0039d316-1c4b-4281-b951-d872f2087c98
* Re-disable ExtensionApiTest.Tabs (flakey)rafaelw@chromium.org2009-09-041-1/+1
| | | | | | | | TBR=asargent,phajdan.jr Review URL: http://codereview.chromium.org/200016 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25430 0039d316-1c4b-4281-b951-d872f2087c98
* Try again to fix bug 20968, this time not breaking browseraa@chromium.org2009-09-031-1/+2
| | | | | | | | | | | tests. This is kinda a janky hack to get the browser test to keep working but I couldn't think of anything better. Review URL: http://codereview.chromium.org/196015 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25402 0039d316-1c4b-4281-b951-d872f2087c98
* Fix loading bubble not disappearing with corrupt theme image.mirandac@chromium.org2009-09-031-0/+7
| | | | | | | | | BUG= http://crbug.com/21044 TEST= try installing a theme with a corrupt image. note that loading bubble disappears. Review URL: http://codereview.chromium.org/196016 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25401 0039d316-1c4b-4281-b951-d872f2087c98
* Add some DCHECKS and asserts to debug why ExtensionApiTest.Tabs is flakey ↵rafaelw@chromium.org2009-09-032-1/+3
| | | | | | | | | | and Reenable. BUG=20828 Review URL: http://codereview.chromium.org/193013 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25394 0039d316-1c4b-4281-b951-d872f2087c98
* Add "loading..." message to theme install to counter jank.mirandac@chromium.org2009-09-031-0/+5
| | | | | | | | | BUG= http://crbug.com/17696 TEST= Install a theme. Note that a "loading" message appears to notify you that a theme is loading. Review URL: http://codereview.chromium.org/191011 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25383 0039d316-1c4b-4281-b951-d872f2087c98
* Remove obsolete comment about a test being disabled.asargent@chromium.org2009-09-031-1/+0
| | | | | | | | | BUG=16106 TEST=none Review URL: http://codereview.chromium.org/176016 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25341 0039d316-1c4b-4281-b951-d872f2087c98
* Revert "Revert "Allow DOMUI pages to call window.open(), giving DOMUI ↵mpcomplete@chromium.org2009-09-033-2/+76
| | | | | | | | | | | | privileges to the new"" Second attempt at r25250. The tests were broken in Release mode due to a race. Should be fixed. BUG=17636 Review URL: http://codereview.chromium.org/172120 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25329 0039d316-1c4b-4281-b951-d872f2087c98
* Disable flaky ExtensionApi tests. #1 source of flakiness.phajdan.jr@chromium.org2009-09-032-2/+4
| | | | | | | | | TEST=none http://crbug.com/19866, http://crbug.com/20828 Review URL: http://codereview.chromium.org/195003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25314 0039d316-1c4b-4281-b951-d872f2087c98
* Add an auto-update now button to chrome://extensions pageasargent@chromium.org2009-09-035-6/+31
| | | | | | | | | | | | BUG=http://crbug.com/17853 TEST=Install an old version of an extension with an available update, then go to chrome://extensions and hit the auto-update now button. The extension should update. Review URL: http://codereview.chromium.org/184005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25293 0039d316-1c4b-4281-b951-d872f2087c98
* Fix to ensure IO thread is created when ExtensionUpdater needs it.asargent@chromium.org2009-09-031-1/+2
| | | | | | | | | | | | In some cases on MacOS it turned out that the IO Thread hadn't been created at the time we were asking for it. BUG=http://crbug.com/20794 TEST=none Review URL: http://codereview.chromium.org/184024 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25277 0039d316-1c4b-4281-b951-d872f2087c98
* Attempt at a fix for ExtensionBrowserTest.MessagingContentScript.mpcomplete@chromium.org2009-09-022-3/+4
| | | | | | | | | BUG=20795 TEST=no Review URL: http://codereview.chromium.org/191010 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25273 0039d316-1c4b-4281-b951-d872f2087c98
* Revert r25250: "Allow DOMUI pages to call window.open(), giving DOMUI ↵mpcomplete@chromium.org2009-09-023-90/+2
| | | | | | | | privileges to the new" Review URL: http://codereview.chromium.org/171127 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25256 0039d316-1c4b-4281-b951-d872f2087c98
* Fix crash on Mac by passing an owning window to SelectFile() when loadingpamg@google.com2009-09-021-1/+2
| | | | | | | | | | an unpacked extension from chrome://extensions. BUG=20860 TEST=go to chrome://extensions on Mac, click "Load unpacked extensions...", don't crash Review URL: http://codereview.chromium.org/171121 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25253 0039d316-1c4b-4281-b951-d872f2087c98
* Allow DOMUI pages to call window.open(), giving DOMUI privileges to the newmpcomplete@chromium.org2009-09-023-2/+90
| | | | | | | | | | | window (assuming it is on the same site instance). BUG=17636 TEST=no Review URL: http://codereview.chromium.org/173649 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25250 0039d316-1c4b-4281-b951-d872f2087c98
* Fix two tests that leak temporary files.thestig@chromium.org2009-09-021-9/+7
| | | | | | | | BUG=none TEST=Run ExtensionsServiceTest and SessionBackendTest, make sure they don't leave extra temp files behind. Review URL: http://codereview.chromium.org/180068 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25149 0039d316-1c4b-4281-b951-d872f2087c98
* Split ExtraRequestInfo out of ResourceDispatcherHost so it isn't cluttering upbrettw@chromium.org2009-09-021-5/+6
| | | | | | | | | | | that header file. I added documentation and split out the accessors according to Google-style. BUG=none TEST=none Review URL: http://codereview.chromium.org/179046 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25133 0039d316-1c4b-4281-b951-d872f2087c98
* Revert accidental commits: r25115 and r25116mpcomplete@chromium.org2009-09-013-58/+2
| | | | | | Review URL: http://codereview.chromium.org/183045 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25120 0039d316-1c4b-4281-b951-d872f2087c98
* formattingmpcomplete@chromium.org2009-09-011-1/+3
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25116 0039d316-1c4b-4281-b951-d872f2087c98
* Merge branch 'api' of /src/chrome/src into apimpcomplete@chromium.org2009-09-013-2/+56
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25115 0039d316-1c4b-4281-b951-d872f2087c98
* GTK Themes: The Theme Installed Infobar's "Undo" button should work with GTK ↵erg@google.com2009-09-015-3/+84
| | | | | | | | | | Themes. http://crbug.com/20629 Review URL: http://codereview.chromium.org/181022 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25050 0039d316-1c4b-4281-b951-d872f2087c98
* Disable MessagingContentScript test due to flakinessdglazkov@chromium.org2009-09-011-1/+1
| | | | | | | | | | TBR=mpcomplete BUG=20795 TEST=none Review URL: http://codereview.chromium.org/176061 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25046 0039d316-1c4b-4281-b951-d872f2087c98
* more bookmark tests, plus fix a couple of API bugserikkay@chromium.org2009-09-015-16/+26
| | | | | | | | | BUG=19099,17288 TEST=browser_tests.exe --gtest_filter=ExtensionApiTest.Bookmarks Review URL: http://codereview.chromium.org/183020 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25036 0039d316-1c4b-4281-b951-d872f2087c98