| Commit message (Collapse) | Author | Age | Files | Lines |
... | |
|
|
|
|
|
|
|
|
|
|
| |
The checks were added very recently, and apparently can fail sometimes.
Added a TODO to investigate later.
TBR=vtl
Review URL: http://codereview.chromium.org/1585025
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@43992 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
TEST=none
TBR=rafaelw
BUG=none
Review URL: http://codereview.chromium.org/1589023
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@43986 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=21072
TEST=ExtensionAPIClientTest.CaptureVisibleTab
Review URL: http://codereview.chromium.org/1527015
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@43985 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
later revisions. Rolling to this one because I believe 57215 caused
a perf/memory regression and I'd like to be sure.
Review URL: http://codereview.chromium.org/1605018
TBR=ojan@chromium.org
Review URL: http://codereview.chromium.org/1629009
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@43974 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
later revisions. Rolling to this one because I believe 57215 caused
a perf/memory regression and I'd like to be sure.
Review URL: http://codereview.chromium.org/1605018
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@43964 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
[original revert broke compile; will disable tests in another CL instead]
use more ui_test_utils functions to simplify the code
expose more consistent and powerful utilities in ui_test_utils
minor style improvements
move some tests from DISABLED to FLAKY so we don't lose coverage
remove redundant timeouts
check more return values
TEST=browser_tests
BUG=none
Review URL: http://codereview.chromium.org/1571002
TBR=phajdan.jr@chromium.org
Review URL: http://codereview.chromium.org/1520026
TBR=viettrungluu@chromium.org, phajdan.jr@chromium.org
Review URL: http://codereview.chromium.org/1518020
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@43951 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
use more ui_test_utils functions to simplify the code
expose more consistent and powerful utilities in ui_test_utils
minor style improvements
move some tests from DISABLED to FLAKY so we don't lose coverage
remove redundant timeouts
check more return values
TEST=browser_tests
BUG=none
Review URL: http://codereview.chromium.org/1571002
TBR=phajdan.jr@chromium.org
Review URL: http://codereview.chromium.org/1520026
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@43950 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
- use timeouts correctly
- use more automation methods to make test code more clear
- use more reliable ways of waiting
- remove unnecessary automation calls
TEST=none
BUG=none
Review URL: http://codereview.chromium.org/1553016
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@43932 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
- use more ui_test_utils functions to simplify the code
- expose more consistent and powerful utilities in ui_test_utils
- minor style improvements
- move some tests from DISABLED to FLAKY so we don't lose coverage
- remove redundant timeouts
- check more return values
TEST=browser_tests
BUG=none
Review URL: http://codereview.chromium.org/1571002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@43931 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
This reverts commit 5c19b0409f047111de901755b5670efa5a2d4e8c.
Review URL: http://codereview.chromium.org/1517020
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@43863 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/1545023
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@43861 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=None
TEST=Tests that all popups (select popup, autofill, browser actions, bookmark bubble...)
work as expected and get the focus correctly.
Review URL: http://codereview.chromium.org/1523013
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@43845 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This moves where we were storing the blacklist last ping day so that we aren't
storing an invalid extension id in the prefs, and adds code to keep invalid ids
from being stored. It also removes some warnings in cases that aren't errors,
and finally adds some unit tests for extension_prefs to try and keep similar
problems from happening in the future.
BUG=40017
TEST=Should not get any DCHECK failures in Debug builds when you do an
extension update manually (via the chrome://extensions page) and then restart
the browser.
Review URL: http://codereview.chromium.org/1596008
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@43782 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=40588
Review URL: http://codereview.chromium.org/1527014
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@43765 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
plugins, by ensuring that an extension's plugins are shut down and unloaded when the extension unloads.
BUG=34670
BUG=32806
Review URL: http://codereview.chromium.org/1596009
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@43756 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=38352
TEST=none
Review URL: http://codereview.chromium.org/1120006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@43715 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
generate menu item notifications for gtk menus.
The code to generate menu open and close events is a little more complicated
and will come in a future patch.
BUG=none
TEST=navigated menus with keyboard, watched notifications fire
Review URL: http://codereview.chromium.org/1585011
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@43707 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=None
TEST=None
Review URL: http://codereview.chromium.org/1594006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@43632 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
There are two xibs in this change.
ExtensionInstallPrompt.xib: This handles the more common case of installing an extension with one or more permission warnings. There is an NSBox with room for the warnings which are separated by \n\n.
ExtensionInstallPromptNoWarnings.xib: It is also possible to install an extension with zero permission warnings. This is currently rare, but we hope to make it more common in the coming quarters. In this case, there is no NSBox and the layout is slightly different.
BUG=29633
Review URL: http://codereview.chromium.org/1540013
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@43575 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
notifications and storage permissions as "access to your
browsing history".
Review URL: http://codereview.chromium.org/1526007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@43573 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
time.
BUG=37567
Review URL: http://codereview.chromium.org/1602005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@43530 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
Additionally, in the extension and tabs api, compute & report UMA histogram data for relative URL use in API calls so we can decide if it's possible to change the behavior of relative url resolution to use the calling frame's url rather than the extension's base url.
Review URL: http://codereview.chromium.org/1605005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@43523 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
- make the toolbar size restore properly when the toolbar is created before the model is loaded
- allow the user to right click menu items in the overflow menu
BUG=40068 (sorta)
TEST=manual
Review URL: http://codereview.chromium.org/1602003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@43515 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Adds a new API to the experimental.bookmarkManager namespace
getSubtree(id, foldersOnly, callback)
Which returns any subtree, and if foldersOnly is true, only returns the folders.
At this point, only the bookmark tree is using the new call.
BUG=39877
TEST=ExtensionBookmarksTest.*
Review URL: http://codereview.chromium.org/1611001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@43461 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
linux.
BUG=39746,37387
Review URL: http://codereview.chromium.org/1540010
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@43393 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
page.
BUG=32362
TEST=ExtensionApiTest.History, ExtensionApiTest.Overrides, manual testing.
Review URL: http://codereview.chromium.org/1530002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@43387 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=40141
TEST=None
Review URL: http://codereview.chromium.org/1575015
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@43384 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
Properly disables ExtensionApiTest.IncognitoPopup and BrowserActionApiTest.IncognitoBasic on Mac. Adds BrowserActionApiTest.BrowserActionAddPopup to the list of disabled tests on mac.
BUG=42002
TEST=No test for you!
Review URL: http://codereview.chromium.org/1603003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@43370 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
Patch stolen from Evan and a translatable string added:
<http://codereview.chromium.org/490019>.
BUG=40113
TEST=Run Chromium with --no-sandbox; should get an infobar warning that you're going to die young.
Review URL: http://codereview.chromium.org/1599010
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@43361 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
We should also consider whether to revert the original change
so this doesn't get onto trunk.
TBR=asargent@chromium.org
BUG=40017
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@43354 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
Tests of chrome.tab.captureVisibleTab() fail on mac 10.6, and disabling all tab tests because of this is unfortunate. Breaking the test this way makes the 10.6 failure easier to debug.
BUG=37387
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=43101
Review URL: http://codereview.chromium.org/1520005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@43349 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
current url and fetches the smallish icon if the extension is found.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/1576006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@43345 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=39808
TEST=run browser with & withou --disable-geolocaiton.
Review URL: http://codereview.chromium.org/1534008
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@43337 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
WorkerWebSocketLayoutTests).
These tests were not worked well, because of some bugs in websocket server
implementation for tests, in Windows XP.
This was fixed in webkit r56614 and r56774.
BUG=38225,33247,36630
TEST=pass ExtensionApiTest.WebSocket and WorkerWebSocketLayoutTests
Review URL: http://codereview.chromium.org/1575003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@43324 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
action will not be visible.
BUG=39763
Review URL: http://codereview.chromium.org/1535007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@43291 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=None
TEST=None
TBR=dmaclach
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@43262 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
DCHECK if the extension doesn't have an image for a particular
resource.
BUG=none
TEST=none
TBR=aa
Review URL: http://codereview.chromium.org/1559010
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@43255 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
BUG=40017
TBR=evan@chromium.org
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@43251 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=None
TEST=None
TBR=mpcomplete
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@43250 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
BUG=33284
TEST=Install a theme that uses white fonts and make
sure popup text for extension HCalendar is visible.
Tiesto theme:
https://tools.google.com/chrome/intl/en/themes/theme_at_djtiesto.html
Review URL: http://codereview.chromium.org/1517008
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@43247 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
ExtensionApiTest.IncognitoPopup on Mac since they crash intermittingly.
BUG=40002
TEST=None
TBR=dmaclach
Review URL: http://codereview.chromium.org/1558008
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@43236 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
ExtensionApiTest.IncognitoPopup
BrowserActionApiTest.IncognitoBasic
BUG=40002
TEST=None
TBR=dmaclach
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@43225 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Also fixing a bug where the wrong window id was returned
back after creating the infobar, and changing html path param
when calling show() from htlpPath to path as requrested by aa.
TEST=See chrome_tests.gypi
BUG=26463
Review URL: http://codereview.chromium.org/1561003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@43176 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This is the chromium side of a change which will wait to land on the webkit side landing. (https://bugs.webkit.org/show_bug.cgi?id=36625)
It changes the NotificationPresenter to pass the sourceURL, rather than the SecurityOrigin in checking permission.
The full URL is required to match the app extent.
BUG=32361, 31024
TEST=NONE
Review URL: http://codereview.chromium.org/1383001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@43162 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
TBR=aa@chromium.org
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/1512006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@43159 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=29633
TEST=manual
Review URL: http://codereview.chromium.org/1513002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@43144 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=39745
TEST=Extension update in general, and blacklisting, should still work normally.
Review URL: http://codereview.chromium.org/1540003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@43142 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
Adds ability for ImageLoadingTracker to cache images.
BUG=none
TEST=none
TBR=aa@chromium.org
Review URL: http://codereview.chromium.org/1534006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@43130 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
when enabling an extension to run in incognito mode.
BUG=39355
Review URL: http://codereview.chromium.org/1569003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@43110 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
ExtensionApiTest.Tabs.
Tests of chrome.tab.captureVisibleTab() fail on mac 10.6, and disabling all tab tests because of this is unfortunate. Breaking the test this way makes the 10.6 failure easier to debug.
BUG=37387
Review URL: http://codereview.chromium.org/1520005
TBR=skerner@chromium.org
Review URL: http://codereview.chromium.org/1577002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@43109 0039d316-1c4b-4281-b951-d872f2087c98
|