summaryrefslogtreecommitdiffstats
path: root/chrome/browser/favicon/favicon_handler.cc
Commit message (Collapse)AuthorAgeFilesLines
* Componentize FaviconService and FaviconHandlersdefresne2015-03-161-693/+0
| | | | | | | | | | | | | Move FaviconService and FaviconHandler into //components/favicon/core/browser as they have no problematic dependencies anymore. Update DEPS and dependencies of favicon component. BUG=359514,359513 Review URL: https://codereview.chromium.org/983043003 Cr-Commit-Position: refs/heads/master@{#320738}
* Reload favicon from HTTP cache on Ctrl+Refreshpkotwicz2015-03-161-3/+9
| | | | | | | | | | | | This CL adds a new parameter to WebContents::DownloadImage() to indicate whether the request should bypass the cache. BUG=455383 TEST=FaviconTabHelperTest.ReloadIgnoringCache Review URL: https://codereview.chromium.org/934693002 Cr-Commit-Position: refs/heads/master@{#320691}
* Refactor favicon to use C++11 loop and fix style violationsdefresne2015-03-131-22/+25
| | | | | | | | | | | | | | | | | | Add DISALLOW_COPY_AND_ASSIGN to abstract base class FaviconClient and FaviconDriver and turn the destructor virtual and protected. Use C++11 for loop construct to make the reduce boilerplate and make the code simpler to read. Remove unnecessary virtual destructor in non-derived test classes. Use C++11 nullptr instead of NULL. BUG=None Review URL: https://codereview.chromium.org/987113005 Cr-Commit-Position: refs/heads/master@{#320489}
* Remove FaviconClient::GetFaviconServicesdefresne2015-03-131-29/+28
| | | | | | | | | | | | | FaviconClient usage should be restricted to favicon component implementation which can instead directly access the FaviconService. Remove the method and port all code to use FaviconServiceFactory to access the FaviconService instead. BUG=359513 Review URL: https://codereview.chromium.org/985033002 Cr-Commit-Position: refs/heads/master@{#320475}
* Make download_largest_favicon and touch icon use same code pathmichaelbai2014-11-101-7/+12
| | | | | | | | | | | | In the patch (https://crrev.com/498547a3a74cbd304593305a5166a114000ef9b6) , we stopped updating active favicon when download_largest_favicon_ is True, but download_largest_favicon still ran into the code path which calls GetActiveFaviconValidity() and GetActiveFaviconURL(), this make the download_largest_favicon in weird status. This patch changes download_largest_favicon to use touch icon's code path which doesn't depend on active favicon. BUG=428218 Review URL: https://codereview.chromium.org/706663003 Cr-Commit-Position: refs/heads/master@{#303521}
* This patch added Observer in FaviconTabHelper, so the favicon retrieved by ↵michaelbai2014-11-041-28/+30
| | | | | | | | | | FaviconHandler could be used right away. BUG=428218 Review URL: https://codereview.chromium.org/684983003 Cr-Commit-Position: refs/heads/master@{#302700}
* Currently, we only download icon which isn't larger than maximal size in ↵michaelbai2014-10-151-52/+41
| | | | | | | | | | | | Android, but there are web site has larger favicon, we still want to download it and save the scaled down one. This patch removes the download limitation in FaviconHandler, and relies on the renderer to scale down to the size we want, this behavior is same for all platform now. BUG=420356 Review URL: https://codereview.chromium.org/640473002 Cr-Commit-Position: refs/heads/master@{#299616}
* Refactor FaviconService API to take in a desired pixel size instead of apkotwicz@chromium.org2014-07-121-2/+3
| | | | | | | | | | | desired size in DIP pixels and a desired scale. BUG=None TEST=None Review URL: https://codereview.chromium.org/331163003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@282840 0039d316-1c4b-4281-b951-d872f2087c98
* Cleanup: favicon: Remove some chrome/ includes from favicon_handler.tfarina@chromium.org2014-07-121-4/+3
| | | | | | | | | | BUG=359514 TEST=None R=blundell@chromium.org Review URL: https://codereview.chromium.org/373463004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@282819 0039d316-1c4b-4281-b951-d872f2087c98
* Create ImageSkia for favicons that can be scaled to one that is not in ↵oshima@chromium.org2014-06-241-5/+4
| | | | | | | | | | | | | | | resource scales. Replaces SelectFaviconFrames with new function because new ImageSkia instance should be able to handle all cases. This depends on https://codereview.chromium.org/335233003/. BUG=376367,381601 TEST=WIP Review URL: https://codereview.chromium.org/346013002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@279507 0039d316-1c4b-4281-b951-d872f2087c98
* Convert ui::ScaleFactor -> float in favicon/history codeoshima@chromium.org2014-06-201-11/+8
| | | | | | | | | | | | | First stop to fix favicon for fractional scale factor. I'll convert the rest of ui::ScaleFactor in 38 BUG=376367,381601 R=pkotwicz@chromium.org, sky@chromium.org Review URL: https://codereview.chromium.org/335233003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@278853 0039d316-1c4b-4281-b951-d872f2087c98
* Move favicon_util to favicon_base componentoshima@chromium.org2014-06-161-8/+8
| | | | | | | | | BUG=None TBR=sky@chromium.org Review URL: https://codereview.chromium.org/333803010 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@277501 0039d316-1c4b-4281-b951-d872f2087c98
* Renameoshima@chromium.org2014-06-141-11/+11
| | | | | | | | | | | | | | * FaviconBitmapXxx to FaviconRawBitmapXxx * FaviconRawCallback to FaviconRawBitmapCallback * FaviconService::GetXXXForPage to FaviconService::GetXxxcForPageURL BUG=None R=pkotwicz@chromium.org TBR=sky@chromium.org Review URL: https://codereview.chromium.org/330603004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@277142 0039d316-1c4b-4281-b951-d872f2087c98
* Remove ui::GetImageScaleoshima@chromium.org2014-06-111-1/+1
| | | | | | | | | | | | * and replace it with ui::GetScaleForScaleFactor * Minor simplification of if blocks in FaviconService BUG=372212 R=ananta@chromium.org Review URL: https://codereview.chromium.org/326143002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@276421 0039d316-1c4b-4281-b951-d872f2087c98
* [Favicon] Add a check for empty list before calling ProcessCurrentUrlmathp@chromium.org2014-06-051-9/+7
| | | | | | | | | | | A DCHECK (now on line 373) was firing consistently for a certain situation where the image_urls_ list was pruned to zero entries (by SortAndPruneImageUrls) before ProcessCurrentUrl was called. BUG=380668 TEST=FaviconHandlerTest passes Review URL: https://codereview.chromium.org/319443002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@275098 0039d316-1c4b-4281-b951-d872f2087c98
* Move favicon callbacks to favicon_basejiangj@opera.com2014-05-221-3/+4
| | | | | | | | | | | | | | | | | | | | Move FaviconImageCallback, FaviconResultsCallback and FaviconRawCallback to favicon_base, those types are shared between favicon and history components (methods are declared in FaviconService, but it delegates the work to HistoryService) and only uses types from base:: and favicon_base:: namespaces. Also BookmarkClient::FaviconImageCallback is a copy of FaviconService::FaviconImageCallback, replace it with favicon_base:: version. BUG=372321 TBR=thakis for //chrome outside of //chrome/browser/history, //chrome/browser/favicon Review URL: https://codereview.chromium.org/291643002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@272065 0039d316-1c4b-4281-b951-d872f2087c98
* Replace content's faviconURL with components/favicon'sjif@chromium.org2014-05-191-36/+15
| | | | | | | | BUG=359586 Review URL: https://codereview.chromium.org/285293005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@271367 0039d316-1c4b-4281-b951-d872f2087c98
* Removes usage of NavigationEntry from favicon_handler.*jif@chromium.org2014-05-121-49/+39
| | | | | | | | BUG=359598 Review URL: https://codereview.chromium.org/261403003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@269871 0039d316-1c4b-4281-b951-d872f2087c98
* Remove page IDs from three WebContentsObserver APIs that don't need it.creis@chromium.org2014-05-051-1/+0
| | | | | | | | | | | | | | Page IDs are not safe to use on their own, without knowing which SiteInstance they correspond to. BUG=369661 TEST=Dead code, no behavior change. TBR=jam TBR=mkosiba Review URL: https://codereview.chromium.org/266053003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@268312 0039d316-1c4b-4281-b951-d872f2087c98
* Renamed FaviconHandlerDelegate to FaviconDriver.jif@chromium.org2014-04-281-9/+9
| | | | | | | | | | | | | | Note: Currently FaviconTabHelper implements both FaviconClient and FaviconDriver. A follow up CL will create a ContentFaviconDriver class that implements FaviconDriver. FaviconTabHelper will then own an instance of the ContentFaviconDriver, instead of inheriting from FaviconDriver. BUG=362074 Review URL: https://codereview.chromium.org/255843002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@266551 0039d316-1c4b-4281-b951-d872f2087c98
* Moves SelectFaviconFrames from history to the favicon_base component.jif@chromium.org2014-04-281-1/+1
| | | | | | | | | | | | In order to create a favicon component, we are removing dependencies on chrome/. TBR=bsalomon1 BUG=359592 NOTRY=true Review URL: https://codereview.chromium.org/246893004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@266547 0039d316-1c4b-4281-b951-d872f2087c98
* Remove usage of profile in FaviconHandler.jif@chromium.org2014-04-221-5/+1
| | | | | | | | BUG=359095 Review URL: https://codereview.chromium.org/247043004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@265415 0039d316-1c4b-4281-b951-d872f2087c98
* Take advantage of FaviconURL.icon_sizes to download largest favicon first.michaelbai@chromium.org2014-04-171-21/+137
| | | | | | | | BUG=349039 Review URL: https://codereview.chromium.org/212063002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@264630 0039d316-1c4b-4281-b951-d872f2087c98
* Moved favicon_types to favicon_base component.jif@chromium.org2014-04-171-62/+59
| | | | | | | | | | | | | | | | The move caused includes, DEPS, and gyp to change. This CL also adds droger as a temporary owner to the favicon and favicon_base components. Reasoning behind the creation of a favicon_base component: Bookmarks and History code do not fundamentally depend on the Favicon code, so we should be able to build those components without building the Favicon code. Deep inside the Bookmarks and History code base there's usage of certain favicon types. Those typedefs are moved to a separate component to break the dependency between the Bookmark/History components and the Favicon component. BUG=362481 Review URL: https://codereview.chromium.org/234893002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@264555 0039d316-1c4b-4281-b951-d872f2087c98
* Abstract dependency on bookmarks from FaviconHandler.jif@chromium.org2014-04-151-4/+1
| | | | | | | | BUG=359104 Review URL: https://codereview.chromium.org/238823003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@263980 0039d316-1c4b-4281-b951-d872f2087c98
* Moves knowledge of Profile out of FaviconHandler, into FaviconTabHelper.jif@chromium.org2014-04-101-17/+16
| | | | | | | | | | | | This CL introduces an interface that will be used to access all of chrome/ API. It is implemented by the FaviconTabHelper, and allows moving the GetFaviconService() method out of the FaviconHandler. BUG=359095 Review URL: https://codereview.chromium.org/228783002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@262960 0039d316-1c4b-4281-b951-d872f2087c98
* Remove dependency on Profile's IsOffTheRecord in favicon_handler.jif@chromium.org2014-04-091-2/+2
| | | | | | | | | | Have FaviconTabHelper supports IsOffTheRecord to move knowledge of Profile out of favicon_handler. BUG=359095 Review URL: https://codereview.chromium.org/227153007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@262709 0039d316-1c4b-4281-b951-d872f2087c98
* Minor cleanup of FaviconHandlersky@chromium.org2014-04-031-64/+49
| | | | | | | | | | | | | Nothing substantial here, just some name changes and other random cleanup. BUG=none TEST=none R=pkotwicz@chromium.org Review URL: https://codereview.chromium.org/215973006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@261508 0039d316-1c4b-4281-b951-d872f2087c98
* Move CancelableTaskTracker to //base/task/CancelableTaskTracker.blundell@chromium.org2014-02-061-3/+3
| | | | | | | | | | | | CancelableTaskTracker is used by //chrome code that is due to componentized. This CL moves the class to //base/task and wraps it in the ::base::task namespace. BUG=335135 TBR=thakis Review URL: https://codereview.chromium.org/137263007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@249397 0039d316-1c4b-4281-b951-d872f2087c98
* Make FaviconService() use Profile as parametermichaelbai@chromium.org2013-11-051-2/+2
| | | | | | | | BUG=308153 Review URL: https://codereview.chromium.org/56143002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@232939 0039d316-1c4b-4281-b951-d872f2087c98
* Download and store large favicon for Android.michaelbai@chromium.org2013-10-251-10/+10
| | | | | | | | BUG=298446 Review URL: https://codereview.chromium.org/28943004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@231074 0039d316-1c4b-4281-b951-d872f2087c98
* Remove dependency on ui::ScaleFactor from ui/gfxdavemoore@chromium.org2013-09-241-2/+2
| | | | | | | | | | | | | | | | | | | | | | | As part of the work to removed dependencies on ui/base from ui/gfx I have changed the public api to Canvas, ImageSkia, ImageSkiaRep and ImagePNGRep to take float scale values instead of ui::ScaleFactor. The notion of supported scale factors has been broken into 2 parts. ui::SetSupportedScaleFactors remains and calls the new ImageSkia::SetSupportedScales(). The initialization of the supported scale factors has been moved from layout.h into ResourceBundle, and is done explicitly in tests that don't use ResourceBundle. BUG=103304 R=ben@chromium.org, oshima@chromium.org, sky@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=224473 Review URL: https://codereview.chromium.org/24175004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@224876 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 224473 "Remove dependency on ui::ScaleFactor from ui/gfx"davemoore@chromium.org2013-09-201-2/+2
| | | | | | | | | | | | | | | | | | | | | | | | | | | > Remove dependency on ui::ScaleFactor from ui/gfx > > As part of the work to removed dependencies on ui/base from ui/gfx I have > changed the public api to Canvas, ImageSkia, ImageSkiaRep and ImagePNGRep > to take float scale values instead of ui::ScaleFactor. > > The notion of supported scale factors has been broken into 2 parts. > ui::SetSupportedScaleFactors remains and calls the > new ImageSkia::SetSupportedScales(). > > The initialization of the supported scale factors has been moved from layout.h > into ResourceBundle, and is done explicitly in tests that don't use > ResourceBundle. > > BUG=103304 > R=ben@chromium.org, oshima@chromium.org, sky@chromium.org > > Review URL: https://codereview.chromium.org/24175004 TBR=davemoore@chromium.org Review URL: https://codereview.chromium.org/24262008 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@224499 0039d316-1c4b-4281-b951-d872f2087c98
* Remove dependency on ui::ScaleFactor from ui/gfxdavemoore@chromium.org2013-09-201-2/+2
| | | | | | | | | | | | | | | | | | | | | As part of the work to removed dependencies on ui/base from ui/gfx I have changed the public api to Canvas, ImageSkia, ImageSkiaRep and ImagePNGRep to take float scale values instead of ui::ScaleFactor. The notion of supported scale factors has been broken into 2 parts. ui::SetSupportedScaleFactors remains and calls the new ImageSkia::SetSupportedScales(). The initialization of the supported scale factors has been moved from layout.h into ResourceBundle, and is done explicitly in tests that don't use ResourceBundle. BUG=103304 R=ben@chromium.org, oshima@chromium.org, sky@chromium.org Review URL: https://codereview.chromium.org/24175004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@224473 0039d316-1c4b-4281-b951-d872f2087c98
* This CL:pkotwicz@chromium.org2013-09-181-14/+19
| | | | | | | | | | | | | | | - Passes in ImageHostMsg_DidDownloadImage the original sizes of the bitmaps before they were resized as a result of the max size passed by ImageMsg_DownloadImage. This enables FaviconHandler to properly score the "goodness" of a bitmap. - Removes the unused "preferred size" parameters from the ImageMsg_DownloadImage and ImageHostMsg_DidDownloadImage messages - Adds a method in the anonymous namespace of FaviconUtil so that FaviconUtil::SelectFaviconFramesFromPNGs() does not use SelectFaviconFrames(). The old behavior is confusing because the call to SelectFaviconFrames() in FaviconUtil::SelectFaviconFramesFromPNGs() was operating on already resized bitmaps BUG=278457 TEST=FaviconHandlerTest.MultipleFavicons R=joth,cevans,jam,sky TBR=benwells (For trivial change to shell_window.*) Review URL: https://chromiumcodereview.appspot.com/23708024 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@223748 0039d316-1c4b-4281-b951-d872f2087c98
* This CL fixes two bugs:pkotwicz@chromium.org2013-06-221-1/+4
| | | | | | | | | | | | 1) Makes the favicons (tab, bookmarks) look the same in the browser UI as they do in the renderer). This fixes a regression (probably by one of my CLs) since https://codereview.chromium.org/6117006 2) Make the favicons in the tab strip look the same after refreshing. The difference is due to the conversions PNG -> NSImage and PNG -> SkBitmap -> NSImage producing visually different NSImages. In particular, the result is different when the input PNG data has no colorspace information specified. Cocoa defaults to the device colorspace when decoding PNG data with no colorspace information. The generic RGB colorspace is used for converting from SkBitmap to NSImage. BUG=242877 TEST=Manual, see bug Review URL: https://chromiumcodereview.appspot.com/16370006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@207990 0039d316-1c4b-4281-b951-d872f2087c98
* Resizing huge favicons when retrieving those.qsr@chromium.org2013-06-201-3/+29
| | | | | | | | | | | | | | | Favicons and touch icons have no reason to ever be larger than 114 pixels. As we need to re-encode those on the browser process, very large favicon have an impact on the CPU used on the browser process. It also means bigger messages passed from a process to the other. This CL add a parameter so that the browser process can specify the maximal size of the images it is interested in, so that the renderer can resize the images if none match the criteria. BUG=248561 Review URL: https://chromiumcodereview.appspot.com/17069002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@207303 0039d316-1c4b-4281-b951-d872f2087c98
* bookmarks: Get rid of the dependency on history_types.htfarina@chromium.org2013-05-161-40/+40
| | | | | | | | | | | | In order to do this we moved two structs (FaviconBitmapResult and FaviconImageResult) from history to favicon. BUG=144783 TBR=joi@chromium.org, sky@chromium.org Review URL: https://codereview.chromium.org/14699005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@200425 0039d316-1c4b-4281-b951-d872f2087c98
* Move files from c/b/a/bookmarks and c/b/a/sync back to c/bkaiwang@chromium.org2013-03-201-1/+1
| | | | | | | | | | | | This is because we changed the approach to componentize code into src/components. So c/b/api directory is depereated. ProfileSyncServiceBase is going to be folded into ProfileSyncService. I will have a followup change for this. BUG=138280 Review URL: https://chromiumcodereview.appspot.com/12614015 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@189273 0039d316-1c4b-4281-b951-d872f2087c98
* Add bool details to NOTIFICATION_FAVICON_UPDATED indicating whether the icon ↵pkotwicz@chromium.org2013-03-081-24/+26
| | | | | | | | | | | | | | | | | URL changed since the notification was last sent. FaviconTabHelper::NotifyFaviconUpdated() is not always called with a new icon URL. In particular, in the case where the favicon in history was expired and it was redownloaded from the web, the icon URL will be the same. The intention of this CL is to enable telling extensions more reliably as to whether the favicon URL was chosen / changed. BUG=180011 Test=FaviconHandlerTest.* R=stevenjb TBR=sky Review URL: https://chromiumcodereview.appspot.com/12344003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@186983 0039d316-1c4b-4281-b951-d872f2087c98
* Cleanup history favicon codepkotwicz@chromium.org2013-01-231-50/+30
| | | | | | | | | | | | | | | This removes the currently unused IconURLSizesMap. It also uses the 'expired' parameter in the 'favicon_bitmaps' table instead of the 'sizes' attribute in the 'favicons' table. Given that we are unlikely going to move to storing unresized bitmaps to the database due to perf problems when resizing the favicon each time it is requested, using the IconURLSizesMap is probably not the right solution in the future anyways. This CL should make the code in HistoryBackend less scary. BUG=None Test=No functionality change HistoryBackendTest.* Review URL: https://chromiumcodereview.appspot.com/11746010 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@178432 0039d316-1c4b-4281-b951-d872f2087c98
* bookmarks: Break the dependency on c/b/bookmarks from favicon.tfarina@chromium.org2013-01-151-5/+4
| | | | | | | | | | BUG=146851,144783 R=joi@chromium.org,sky@chromium.org TBR=sky@chromium.org Review URL: https://codereview.chromium.org/11852024 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@176887 0039d316-1c4b-4281-b951-d872f2087c98
* Remove redundant |errored| member from IconHostMsg_DidDownloadFaviconpkotwicz@chromium.org2013-01-101-2/+1
| | | | | | | | | | | Bug=None Test=None R=caitkp, sky TBR=jam Review URL: https://chromiumcodereview.appspot.com/11777009 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@176028 0039d316-1c4b-4281-b951-d872f2087c98
* Finish converting FaviconService to use CancelableTaskTracker.kaiwang@chromium.org2012-12-121-18/+19
| | | | | | | | | | | | | | | | | | | | | | | | | | | | This is continuation of https://codereview.chromium.org/11421188/ FaviconService functions converted: GetFaviconImage (used by c/b/ui/search_engines/template_url_table_model.cc) GetRawFavicon (used by c/b/ui/webui/favicon_source.cc) GetFavicon (used by c/b/favicon/favicon_handler.cc) UpdateFaviconMappingsAndFetch (used by c/b/favicon/favicon_handler.cc) GetLargestRawFaviconForID (used by c/b/history/android/sqlite_cursor.cc) -------- these functions depend on ------- HistoryService::GetFavicons HistoryService::UpdateFaviconMappingsAndFetch HistoryService::GetFaviconForID -------- which depends on ------- HistoryBackend::GetFavicons HistoryBackend::UpdateFaviconMappingsAndFetch HistoryBackend::GetFaviconForID BUG=155883 Review URL: https://chromiumcodereview.appspot.com/11489002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@172503 0039d316-1c4b-4281-b951-d872f2087c98
* Convert some FaviconService functions to use New CancelableTaskTrackerkaiwang@chromium.org2012-12-071-10/+14
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This CL converts: FaviconService::GetFaviconImageForURL FaviconService::GetRawFaviconForURL FaviconService::GetFaviconForURL ---------- They depends on --------- HistoryService::GetFaviconsForURL ---------- which depends on -------- HistoryBackend::GetFaviconsForURL So please review above changes first. ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ FaviconService::GetFaviconImageForURL ---------- is used by -------------- bookmarks/bookmark_model.cc ui/intents/web_intent_icon_loader.cc ui/cocoa/history_menu_bridge.mm ui/toolbar/recent_tabs_sub_menu_model.cc ui/toolbar/back_forward_menu_model.cc ui/webui/ntp/app_launcher_handler.cc jumplist_win.cc FaviconService::GetRawFaviconForURL ---------- is used by -------------- android/provider/chrome_browser_provider.cc bookmarks/bookmark_html_writer.cc sync/glue/session_model_associator.cc ui/webui/extensions/extension_icon_source.cc ui/webui/favicon_source.cc ui/webui/ntp/android/bookmarks_handler.cc ui/webui/ntp/favicon_webui_handler.cc FaviconService::GetFaviconForURL ---------- is used by -------------- favicon/favicon_handler.h BUG=155883 Review URL: https://chromiumcodereview.appspot.com/11421188 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@171675 0039d316-1c4b-4281-b951-d872f2087c98
* move favicon download code from chrome/ into content/caitkp@chromium.org2012-12-061-1/+1
| | | | | | | | | | | | | | | | | -chrome/renderer/favicon_helper.(h|cc) ->content/renderer/... -chrome/common/icon_messages.h -> content/common/icon_messages.h -favicon_download_helper.(h|cc) API incorporated into web_contents -chrome/browser/favicon/favicon_download_helper_delegate.h -> content/public/browser/favicon_download_delegate.h Depends on: https://codereview.chromium.org/11416179/ https://codereview.chromium.org/11421051/ BUG=160995 Review URL: https://chromiumcodereview.appspot.com/11411180 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@171411 0039d316-1c4b-4281-b951-d872f2087c98
* Fix wrong indentsimon.hong81@gmail.com2012-11-291-1/+1
| | | | | | | | | | BUG=None TEST=Compiles Review URL: https://chromiumcodereview.appspot.com/11413181 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@170131 0039d316-1c4b-4281-b951-d872f2087c98
* Remove DownloadImage method from FaviconTabHelpercaitkp@chromium.org2012-11-201-40/+7
| | | | | | Review URL: https://chromiumcodereview.appspot.com/11275214 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@168914 0039d316-1c4b-4281-b951-d872f2087c98
* Switch CreateAppShortcut to using FaviconDownloadHelpercaitkp@chromium.org2012-11-161-8/+5
| | | | | | | | | | | BUG=160995 TEST=No visible change Review URL: https://chromiumcodereview.appspot.com/11365117 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@168261 0039d316-1c4b-4281-b951-d872f2087c98
* This CL ensures that favicons alwayspkotwicz@chromium.org2012-11-161-6/+6
| | | | | | | | | | | | | | | | 1) Stores a 1x representation in history 2) Returns a 1x representation upon calling FaviconService::GetFaviconImageForURL() such that the 1x favicon can be pushed to sync. BUG=160503 Test=Manual, see instructions below 1) Go to http://www.corp.google.com/~pkotwicz/favicon_small_big/test.html on an iOS device and bookmark it. On the iOS device, the favicon should be red. 2) On a windows device, make sure that the favicon which is received via sync is blue Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=168079 Review URL: https://chromiumcodereview.appspot.com/11360233 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@168233 0039d316-1c4b-4281-b951-d872f2087c98
generated by cgit v1.1 at 2025-03-14 20:55:58 +0000