| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
|
|
|
|
|
| |
Dependencies updated.
BUG=374202
R=isherman@chromium.org, thestig@chromium.org
TBR=thestig@chromium.org
Review URL: https://codereview.chromium.org/289373007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@272234 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=359299
TEST=build works
Review URL: https://codereview.chromium.org/225183018
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@269152 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
Review URL: https://codereview.chromium.org/268593017
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@268349 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Chrome OS needs to have access to the metrics aggretion and serialization logic
to build a metric sender service replacing chrome. Protobuf definitions are
moved to components too.
The code remaining will be extrated in components/metrics and
components/variation during a refactoring later this year.
BUG=chromium:360183
TEST=run unittests
TBR=sky@chromium.org, benwells@chromium.org
Review URL: https://codereview.chromium.org/239093004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@267709 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
OS_CHROMEOS implies OS_LINUX, so OS_LINUX || OS_CHROMEOS can be simplified to OS_LINUX
BUG=none
Review URL: https://codereview.chromium.org/237673002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@263993 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
chrome::ShowFeedbackPage was dispatching an event to the feedback API
on the browser's current profile (or the global last used profile)
directly.
This can be an OTR profile and lead to bad behavior. App windows are
never hosted on OTR profiles, so the feedback app window will not keep
the OTR profile alive. The feedback app can therefore outlive the OTR profile
which launched it, resulting in operations on browser context services
(like FeedbackPrivateAPI, ExtensionSystem, ProcessManager, etc) which no
longer exist.
This change causes ShowFeedbackPage to resolve an OTR profile to its
original profile before dispatching an event to the feedback app.
BUG=354546
Review URL: https://codereview.chromium.org/210353002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@259781 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
To fix bugs 356324 and 356316. Please fix them with tests before submitting this code again.
> Refactor FeedbackData
>
> Split off common functionality that relies only on base/. The common code
> can be used to create a feedback service for Brillo.
>
> BUG=341554
> TEST=new unittests pass
>
> Review URL: https://codereview.chromium.org/177243017
TBR=achaulk@chromium.org
Review URL: https://codereview.chromium.org/212763005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@259635 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
This mirrors the existing metricsPrivate JS API.
BUG=341130
Review URL: https://codereview.chromium.org/195793026
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@258702 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
Split off common functionality that relies only on base/. The common code
can be used to create a feedback service for Brillo.
BUG=341554
TEST=new unittests pass
Review URL: https://codereview.chromium.org/177243017
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@258085 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Remove use of BrowserContext and BrowserThread from FeedbackReport and
FeedbackUpload. Moves net/ specific functionality into a new class
FeedbackUploadChrome, and moves using the browser context out of
the base classes.
CrOS should be able to directly use feedback_report.cc/h &
feedback_uploader.cc/h, providing a curl-based upload version.
BUG=341554
Review URL: https://codereview.chromium.org/186663011
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@257534 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
This patch moves the remaining clients of BCKS in //chrome/browser to use
KeyedService.
BUG=351704
TBR=jochen
Review URL: https://codereview.chromium.org/198883002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@256912 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
BUG=265753, 338338, 237249
TEST=content_unittests
R=jam@chromium.org
TBR=darin
Review URL: https://codereview.chromium.org/186883002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@256174 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
by the site's URL.
Code in content always gets it now from ContentClient::GetUserAgent. In Chrome, there's a GetUserAgent function which returns it.
BUG=338338
R=isherman@chromium.org, pauljensen@chromium.org, scottmg@chromium.org, tfarina@chromium.org
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=255858
Review URL: https://codereview.chromium.org/191093002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@255877 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
There are some browser_tests failures on the buildbots that don't reproduce locally. Reverting while I investigate.
> Simplify the user agent code some more since after r255534 it's not affected by the site's URL.
>
> Code in content always gets it now from ContentClient::GetUserAgent. In Chrome, there's a GetUserAgent function which returns it.
>
> BUG=338338
> R=isherman@chromium.org, pauljensen@chromium.org, scottmg@chromium.org, tfarina@chromium.org
>
> Review URL: https://codereview.chromium.org/191093002
TBR=jam@chromium.org
Review URL: https://codereview.chromium.org/192283002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@255867 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
by the site's URL.
Code in content always gets it now from ContentClient::GetUserAgent. In Chrome, there's a GetUserAgent function which returns it.
BUG=338338
R=isherman@chromium.org, pauljensen@chromium.org, scottmg@chromium.org, tfarina@chromium.org
Review URL: https://codereview.chromium.org/191093002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@255858 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
R=viettrungluu@chromium.org
TBR=viettrungluu
Review URL: https://codereview.chromium.org/184563006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@255418 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Move it to extensions/browser. (Not extensions/browser/api, since it's now being used not just by API implementations.)
This change is purely mechanical (some lines are more affected by clang-format than others).
BUG=309909
TBR=sky@chromium.org
Review URL: https://codereview.chromium.org/178193030
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@254999 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
It is possible that if the browser starts and shuts down really quickly, we may end up with a race where the context passed to LoadReports has been nullified. We can completely avoid this race by simply passing in the user directory to LoadReportsAndQueue since the method doesn't really need the context for anything else.
R=zork@chromium.org
BUG=345805
Review URL: https://codereview.chromium.org/185003005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@254314 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
> Revert 248648 "Cache feedback reports to disk in case of send fa..."
>
> BUG=345805
>
> > Cache feedback reports to disk in case of send failure.
> >
> > R=zork@chromium.org
> > BUG=249853
> >
> > Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=246992
> >
> > Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=247772
> >
> > Review URL: https://codereview.chromium.org/141433011
>
> TBR=rkc@chromium.org
>
> Review URL: https://codereview.chromium.org/174313005
TBR=vitalybuka@chromium.org
Review URL: https://codereview.chromium.org/181943004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@254249 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=330547
NOTRY=true
TBR=rkc@chromium.org
Review URL: https://codereview.chromium.org/178363002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@252951 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
BUG=345805
> Cache feedback reports to disk in case of send failure.
>
> R=zork@chromium.org
> BUG=249853
>
> Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=246992
>
> Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=247772
>
> Review URL: https://codereview.chromium.org/141433011
TBR=rkc@chromium.org
Review URL: https://codereview.chromium.org/174313005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@252669 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
Do some lint cleanups too.
Review URL: https://codereview.chromium.org/156703006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@251011 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
TBR=zork@chromium.org
BUG=None.
Review URL: https://codereview.chromium.org/154643002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@248787 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
R=msw@chromium.org, jam@chromium.org
BUG=None.
Review URL: https://codereview.chromium.org/132703003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@248652 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
R=zork@chromium.org
BUG=249853
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=246992
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=247772
Review URL: https://codereview.chromium.org/141433011
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@248648 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
> Cache feedback reports to disk in case of send failure.
>
> R=zork@chromium.org
> BUG=249853
>
> Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=246992
>
> Review URL: https://codereview.chromium.org/141433011
This introduced a race condition picked up by the TSAN bots.
BUG=339326
TBR=rkc@chromium.org
Review URL: https://codereview.chromium.org/149993002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@247816 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This moves ExtensionSystem to extensions/browser.
It also moves setting the channel for Features to ChromeExtensionsBrowserClient.
It also removes the duplicate ExtensionSystem::GetForBrowserContext.
BUG=337707
TBR=sky@chromium.org
Review URL: https://codereview.chromium.org/147923005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@247788 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
R=zork@chromium.org
BUG=249853
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=246992
Review URL: https://codereview.chromium.org/141433011
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@247772 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
(https://codereview.chromium.org/141433011/)
Reason for revert:
This change is causing memory error on this bot:
http://build.chromium.org/p/chromium.memory.fyi/builders/Windows%20Unit%20%28DrMemory%29/builds/15509
Original issue's description:
> Cache feedback reports to disk in case of send failure.
>
> R=zork@chromium.org
> BUG=249853
>
> Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=246992
TBR=zork@chromium.org,thestig@chromium.org,rkc@chromium.org
NOTREECHECKS=true
NOTRY=true
BUG=249853
Review URL: https://codereview.chromium.org/133193004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@247061 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
R=zork@chromium.org
BUG=249853
Review URL: https://codereview.chromium.org/141433011
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@246992 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
platforms, since the reason for disabling it was only failures on win_rel.
R=zork@chromium.org
BUG=None.
Review URL: https://codereview.chromium.org/132663005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@245755 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Fix the feedback uploader factory to return the correct browser context even when incognito. This needs to be it's own instance, matching the incognito profile behavior of the feedback API.
R=zork@chromium.org
BUG=334557
Review URL: https://codereview.chromium.org/135153005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@245735 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
on win_rel trybot
TBR=rkc@chromium.org
BUG=330547
NOTRY=true
Review URL: https://codereview.chromium.org/120533003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@242392 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This is the first part of the CL that will enable re-sending feedback reports that were sent when the user was offline, across sessions.
R=jcivelli@chromium.org, zork@chromium.org
BUG=249853
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=241962
Review URL: https://codereview.chromium.org/116863002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@242069 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
> Add feedback uploader to upload reports in a sequenced manner with retries.
> This is the first part of the CL that will enable re-sending feedback reports that were sent when the user was offline, across sessions.
>
> R=jcivelli@chromium.org, zork@chromium.org
> BUG=249853
>
> Review URL: https://codereview.chromium.org/116863002
TBR=rkc@chromium.org
Review URL: https://codereview.chromium.org/119453003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@241981 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
This is the first part of the CL that will enable re-sending feedback reports that were sent when the user was offline, across sessions.
R=jcivelli@chromium.org, zork@chromium.org
BUG=249853
Review URL: https://codereview.chromium.org/116863002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@241962 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
R=zork@chromium.org
BUG=None
Review URL: https://codereview.chromium.org/119573002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@241956 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Currently the system log gathering code is only limited to ChromeOS. Move the code out of ChromeOS so it can be used by regular Chrome.
The code has been refactored to leave the ChromeOS specific logs gathering code under the c/b/chromeos directory while moving the general system logs code under the c/b/feedback directory. We didn't move system_logs directory under c/b/ since system logs are mostly related with feedback and to keep the c/b/ clutter low.
Individual developers can add their own additional logs for Chrome under c/b/feedback/system_logs/log_sources following the *_log_source.* templates already there.
R=asargent@chromium.org, xiyuan@chromium.org
BUG=306532
Review URL: https://codereview.chromium.org/105873004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@241477 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
- Fix ZipString issue. Reverted feedback_utils.cc and h.
- In TracingManager convert trace data into the original feedback
format.
BUG=326350
Review URL: https://codereview.chromium.org/104713006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@239951 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
base namespace.
BUG=
R=viettrungluu@chromium.org
Review URL: https://codereview.chromium.org/102843002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@238465 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This reverts https://codereview.chromium.org/101543004/ which was created when
suspected the reason of failure of telemetry tests, but turned out not the real
reason. Reapply.
Reapply the following change:
> Revert "Revert 237280 "Remove TraceController""
>
> This reverts commit 6aa58b8599840160df945afa89e7482d14d1c4d4.
>
> Fixed double-close issue when ending recording.
>
> > Revert 237280 "Remove TraceController"
> >
> > Seems to have broken trace-based telemetry benchmarks on android.
> >
> > BUG=323749
> >
> > > Remove TraceController
> > >
> > > TraceController is obsoleted by TracingController.
> > > Changed all remaining clients to use TracingController.
> > >
> > > BUG=none
> > >
> > > Review URL: https://codereview.chromium.org/67683003
> >
> > TBR=wangxianzhu@chromium.org
> >
> > Review URL: https://codereview.chromium.org/89753004
> >
> > git-svn-id: svn://svn.chromium.org/chrome/trunk/src@237452 0039d316-1c4b-4281-b951-d872f2087c98
>
> TBR=wangxianzhu@chromium.org
>
> Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=238234
TBR=
Review URL: https://codereview.chromium.org/102003003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@238442 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=
Review URL: https://codereview.chromium.org/99923002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@238427 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
Reason for revert: Bug 323749 still unresolved
TBR=
NOTREECHECKS=true
NOTRY=true
Review URL: https://codereview.chromium.org/101543004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@238424 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This reverts commit 6aa58b8599840160df945afa89e7482d14d1c4d4.
Fixed double-close issue when ending recording.
> Revert 237280 "Remove TraceController"
>
> Seems to have broken trace-based telemetry benchmarks on android.
>
> BUG=323749
>
> > Remove TraceController
> >
> > TraceController is obsoleted by TracingController.
> > Changed all remaining clients to use TracingController.
> >
> > BUG=none
> >
> > Review URL: https://codereview.chromium.org/67683003
>
> TBR=wangxianzhu@chromium.org
>
> Review URL: https://codereview.chromium.org/89753004
>
> git-svn-id: svn://svn.chromium.org/chrome/trunk/src@237452 0039d316-1c4b-4281-b951-d872f2087c98
TBR=wangxianzhu@chromium.org
Review URL: https://codereview.chromium.org/99103004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@238234 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Seems to have broken trace-based telemetry benchmarks on android.
BUG=323749
> Remove TraceController
>
> TraceController is obsoleted by TracingController.
> Changed all remaining clients to use TracingController.
>
> BUG=none
>
> Review URL: https://codereview.chromium.org/67683003
TBR=wangxianzhu@chromium.org
Review URL: https://codereview.chromium.org/89753004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@237452 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
TraceController is obsoleted by TracingController.
Changed all remaining clients to use TracingController.
BUG=none
Review URL: https://codereview.chromium.org/67683003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@237280 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
Send the metrics in JSON format so they can be imported and displayed
by the histograms page (in a forthcoming CL).
BUG=237288
R=rkc@chromium.org, xiyuan@chromium.org
Review URL: https://codereview.chromium.org/55363003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@235981 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
R=rkc@chromium.org
BUG=314277
Review URL: https://codereview.chromium.org/56443004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@232826 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Reviews requested,
asargent@ - extension parts, owners review
zork@ - everything else
R=asargent@chromium.org, zork@chromium.org
BUG=307329
Review URL: https://codereview.chromium.org/32703007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@230355 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=303790
Review URL: https://codereview.chromium.org/26572009
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@228407 0039d316-1c4b-4281-b951-d872f2087c98
|