summaryrefslogtreecommitdiffstats
path: root/chrome/browser/file_select_helper.cc
Commit message (Collapse)AuthorAgeFilesLines
* Replace ToLower calls to the new formatbrettw2015-08-101-1/+1
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Replaces base::StringToLowerASCII(string) with base::ToLowerASCII(string) This form is 1:1 search and replace. A bunch of places did something like this: std::string foo(something_else); base::StringToLowerASCII(&foo); which became: foo = base::ToLowerASCII(something_else); A couple places really wanted in-place changing and they became: foo = base::ToLowerASCII(foo); There was pretty trivial cleanup in chrome_main_delegate.cc chrome/test/chromedriver/server/http_handler.cc (fix indenting). There was more cleanup in: chrome/installer/util/language_selector.cc and components/plugins/renderer/mobile_youtube_plugin.cc In components/history/core/browser/url_utils.cc I removed the call since it was calling ToLower on the host name out of a GURL, which is already guaranteed to be lower-case. NOPRESUBMIT=true (due to touching code with wstrings) Review URL: https://codereview.chromium.org/1279123004 Cr-Commit-Position: refs/heads/master@{#342659}
* [Extensions OOPI] Update extension functions to use RFH pt 1rdevlin.cronin2015-06-121-2/+6
| | | | | | | | | | | | Begin updating extension functions to use RenderFrameHost instead of RenderViewHost. TBR=thestig@chromium.org (small change in file_select_helper.cc) BUG=455776 Review URL: https://codereview.chromium.org/1181233002 Cr-Commit-Position: refs/heads/master@{#334276}
* Remove NOTIFICATION_RENDER_VIEW_HOST_CHANGED.lazyboy2015-05-151-24/+21
| | | | | | | | | | | | | Use WebContentsObserver::RenderViewHostChanged() instead. BUG=170921 Test=No behavioral change. Sanity checked with JS speech, whether WebContentsTracker class gets created and destroyed properly. Review URL: https://codereview.chromium.org/1132163004 Cr-Commit-Position: refs/heads/master@{#330213}
* DATE and FULL_PATH type sorts are not used anywhere. Date is not evenolli.syrjala2015-04-241-4/+2
| | | | | | | | | | tested anywhere. Removed those from all related files. Recursive is used only with NO_SORT so removed the option to use it in combination with sorting. Review URL: https://codereview.chromium.org/1096323003 Cr-Commit-Position: refs/heads/master@{#326754}
* Add existence checks for Profile to FileSelectHelper.hirono2014-11-071-3/+15
| | | | | | | | | | | | Previously FileSelectHelper may access |profile_| member after the |profile_| is deleted. BUG=427272 TEST=None Review URL: https://codereview.chromium.org/702773003 Cr-Commit-Position: refs/heads/master@{#303171}
* Files.app: Clean the callback of ↵hirono2014-10-231-13/+6
| | | | | | | | | | | | | | | ConvertSelectedFileInfoListTofileChooserFileInfoList. Previously ConvertSelectedFileInfoListTofileChooserFileInfoList passes the result by using scoped_ptr, but it does not need to. The CL cleans the function signature and removed unused wrapper function in FileSelectHelper. BUG=126902 TEST=None Review URL: https://codereview.chromium.org/673603003 Cr-Commit-Position: refs/heads/master@{#300856}
* Pass needLocalPath flag to file chooser dialog.hirono2014-10-221-0/+1
| | | | | | | | | | | | | | blink::WebFileChooserParams has a flag to show whether the receiver (WebFileChooserCompletion) needs local paths of files or not. The CL conveys the flag to the file chooser dialog so that the dialog does not create snapshot file when the receiver does not need local paths. BUG=126902 Review URL: https://codereview.chromium.org/663293002 Cr-Commit-Position: refs/heads/master@{#300648}
* Add non-native file handling in FileSelectorHelper class.hirono2014-10-211-21/+53
| | | | | | | | | | | In chrome OS, the file chooser dialog box may return paths that does not point to a native file. The CL lets FileSelectorHelper handle for the non-native paths and generate FileChooserFileInfo that refers non-native files. BUG=126902 TEST=manually test to upload drive/local files Review URL: https://codereview.chromium.org/663473002 Cr-Commit-Position: refs/heads/master@{#300399}
* mac: Zip packages when they are selected by the file opener.erikchen2014-10-101-25/+66
| | | | | | | | | | | | | | | | | | | | | | | | When a package is selected in the file opener, it is automatically zipped, and the zipped file is passed to the render view host. This CL fixes 2 unrelated bugs in file_select_helper: - If the render_view_host_ was destroyed before the user finished with the file_select_helper, then Release() would never be called and the file_select_helper would leak. - If the render_view_host_ was destroyed before the user finished with the file_select_helper, the default directory would be updated if the user was opening multiple files, but it would not be updated if the user was opening a single file. Now both update the default directory. Note: When a large package is being zipped, the UI thread and renderer are still responsive, but display no indication of the ongoing work. BUG=33920 Review URL: https://codereview.chromium.org/634833003 Cr-Commit-Position: refs/heads/master@{#299143}
* Add non-native file support to the ViewMsg_RunFileChooserResponse message.hirono2014-10-081-4/+13
| | | | | | | | | | | | | | | | The CL adds properties needed for representing non-native files to the ViewMsg_RunFileChooserResponse message. Previously the SelectedFileInfo structure represents a file in the message. The structure is shared by many classes, so instead of modifying the structure, the CL introduces new FileChooserFileInfo structure. BUG=126902 TEST=None Review URL: https://codereview.chromium.org/633573003 Cr-Commit-Position: refs/heads/master@{#298688}
* Remove implicit conversions from scoped_refptr to T* in chrome/dcheng2014-08-261-1/+1
| | | | | | | | | | | This patch was generated by running the rewrite_scoped_refptr clang tool on a Linux build. BUG=110610 Review URL: https://codereview.chromium.org/511473002 Cr-Commit-Position: refs/heads/master@{#292012}
* Change base/file_utils.h includes to base/files/file_utils.h in chrome/thestig2014-08-261-1/+1
| | | | | | Review URL: https://codereview.chromium.org/486843004 Cr-Commit-Position: refs/heads/master@{#291880}
* Use a qualified path for chromium_strings, google_chrome_strings, and ↵thestig@chromium.org2014-08-221-1/+1
| | | | | | | | | | | generated_resources. (part 1) BUG=401588 Review URL: https://codereview.chromium.org/469993006 Cr-Commit-Position: refs/heads/master@{#291367} git-svn-id: svn://svn.chromium.org/chrome/trunk/src@291367 0039d316-1c4b-4281-b951-d872f2087c98
* Move StringToLowerASCII to base namespacebrettw@chromium.org2014-08-071-1/+1
| | | | | | | | TBR=sky Review URL: https://codereview.chromium.org/448853002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@288085 0039d316-1c4b-4281-b951-d872f2087c98
* Do not include directories to file listshashimoto@chromium.org2014-03-241-6/+4
| | | | | | | | | | This change is essentially a revert of https://codereview.chromium.org/6250118 BUG=353084 Review URL: https://codereview.chromium.org/206033002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@258848 0039d316-1c4b-4281-b951-d872f2087c98
* Failsafe in case ui::SelectFileDialog is not implementedtiago.vignatti@intel.com2014-03-201-0/+2
| | | | | | | | | | We need a proper Aura-only ui::SelectFileDialog implementation but in the mean time just failsafe here. In particular this was causing Ozone implementations to crash. BUG=130810 Review URL: https://codereview.chromium.org/200253005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@258276 0039d316-1c4b-4281-b951-d872f2087c98
* Move UTF16ToASCII, remove WideToASCII.brettw@chromium.org2014-03-141-1/+1
| | | | | | | | | | | | | | | | This removes WideToASCII and changes all callers to use UTF16ToASCII instead. Moves UTF16ToASCII from base/strings/string_util.h to base/strings/utf_string_conversions.h and into the base namespace. Convert a few related string_util functions to take a StringPiece16 instead of a string16. Remove IsStringASCII(std::wstring) which was unused. Updates callers' includes and namespace usage accordingly. TBR=sky Review URL: https://codereview.chromium.org/176843022 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@257200 0039d316-1c4b-4281-b951-d872f2087c98
* Move TrimWhitespace to the base namespace.brettw@chromium.org2014-03-031-1/+2
| | | | | | | | R=viettrungluu@chromium.org, viettrungluu Review URL: https://codereview.chromium.org/183853011 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@254521 0039d316-1c4b-4281-b951-d872f2087c98
* Replace string16 with base::string16 in chrome/browserbrettw@chromium.org2013-12-121-2/+2
| | | | | | | | TBR=sky Review URL: https://codereview.chromium.org/108123004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@240485 0039d316-1c4b-4281-b951-d872f2087c98
* Change the meaning of SelectFileDialog.support_drive: it means Drive-aware ↵kinaba@chromium.org2013-08-061-1/+0
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | callers. Previously, what the |support_drive| flag means is just to show Google Drive tab in the file dialog; it doesn't change other behaviors. Now, we are going to enable the "Google Drive" tab on Chrome OS for all call sites of the dialog, by adding a feature to Drive client to provide local snapshot so that callers need not care about Drive. On the other hand, the "create snapshot" trick is unnecessary for clients like Packaged app or extensions that implement fileBrowserHandler, which access files through HTML5 FileSystem API. So, for those clients I want to leave the |support_drive| flag to indicate that no special handling is needed. Here's the summary: Before: - support_drive, folder-dialog : show Drive tab. No special handling. - support_drive, open-dialog : show Drive tab. Create local snapshot. - support_drive, save-dialog : show Drive tab. No special handling. - !support_drive, folder-dialog : hide Drive tab. - !support_drive, open-dialog : hide Drive tab. (this mode is not used) - !support_drive, save-dialog : hide Drive tab. After: - support_drive, folder-dialog : show Drive tab. No special handling. - support_drive, open-dialog : show Drive tab. No special handling. - support_drive, save-dialog : show Drive tab. No special handling. - !support_drive, folder-dialog : *HIDE* Drive tab. (this is not supported yet) - !support_drive, open-dialog : Show Drive tab. Create local snapshot. - !support_drive, save-dialog : *HIDE* Drive tab. (VERY SOON switch to => "Show Drive tab. Create local snapshot.") BUG=140425 Review URL: https://chromiumcodereview.appspot.com/22165002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@215922 0039d316-1c4b-4281-b951-d872f2087c98
* Change dialog texts for folder upload to explicitly indicate it's for ↵kinuko@chromium.org2013-07-311-3/+3
| | | | | | | | | | | | | | | | | | | | | | | | | | | | 'Uploading' Currently we show the same dialog title and confirm button ('Select Folder' and 'OK' or 'Open') for folder upload, but it should more clearly tell that it's for 'uploading', so that the user can know s/he is exposing the folder content to the website. This patch makes following UI string changes to make it clear: * "Select a folder to upload" for dialog title on ChromeOS (original text is: "Select a folder to open") * "Select Folder to Upload" for dialog title on other platforms (original text is: "Select Folder") * "Upload" for dialog confirm button (original text is: "Open") The new string texts have gotten LGTM by UI team. BUG=252888 TEST=manual R=avi@chromium.org, jamesr@chromium.org, sky@chromium.org, yoshiki@chromium.org Review URL: https://codereview.chromium.org/18627002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@214588 0039d316-1c4b-4281-b951-d872f2087c98
* Update the child process security policy to use explicit permission grants.gbillock@chromium.org2013-07-111-27/+9
| | | | | | | | | | | | | | | This replaces the method taking generic permissions with specific interface methods. This makes using particular platform file flags an implementation detail, as well as restricting the kinds of permissions bundles client code can request to particular use bundles under the control of the security policy. R=vandebo@chromium.org BUG=None Review URL: https://chromiumcodereview.appspot.com/18129002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@211018 0039d316-1c4b-4281-b951-d872f2087c98
* Update the HTML Media Capture implementation.raphael.kubo.da.costa@intel.com2013-07-091-2/+3
| | | | | | | | | | | | | | | | | | | | | | | | | | | | In the latest version of the spec, the `capture' attribute is now a boolean which simply indicates whether the device's capabilities should be used or not (choosing between cameras, microphones etc is up to the user agent based on the contents of the `accept' attribute). This particular patch updates the type of the `capture' member of content::FileChooserParams by passing an std::pair consisting of a vector of MIME types passed to the `accept' attribute of the <input> tag and a boolean corresponding to the `capture' attribute. The behavior in Android has been slightly changed due to how the spec change. Namely: o Sites that specify only the "capture" attribute setting the "accept" attribute will now get a generic picker. o Sites that specify the "capture" attribute and pass "*/*" to "accept" will now get a generic picker. o Sites that specify the "capture" and multiple MIME types for the "accept" attribute will now get a generic picker. R=abarth@chromium.org,beverloo@chromium.org,bulach@chromium.org,tedchoc@chromium.org,eseidel@chromium.org BUG=240252 Review URL: https://chromiumcodereview.appspot.com/14758008 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@210553 0039d316-1c4b-4281-b951-d872f2087c98
* Use a direct include of strings headers in chrome/browser/e*-h*/.avi@chromium.org2013-06-101-1/+1
| | | | | | | | | | BUG=247723 TEST=none TBR=ben@chromium.org Review URL: https://chromiumcodereview.appspot.com/16703006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@205319 0039d316-1c4b-4281-b951-d872f2087c98
* Move FileEnumerator to its own file, do some refactoring.brettw@chromium.org2013-06-081-1/+2
| | | | | | | | | | | | | | It creates a class FileInfo to contain the details rather than using a platform-specific typedef. This allows the accessors GetName, GetSize, etc. to be moved directly to this class (previously they were static helpers on the FileEnumerator class) which makes a bunch of code much cleaner. It also gives reasonable getting and initialization which the previous version lacked. BUG=175002 Reland of 198820 and 298824 Original review = https://codereview.chromium.org/13165005 R=rvargas@chromium.org Review URL: https://codereview.chromium.org/16392011 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@205019 0039d316-1c4b-4281-b951-d872f2087c98
* Use a direct include of utf_string_conversions.h in chrome/browser/, part 2.avi@chromium.org2013-06-071-1/+1
| | | | | | | | | | BUG=none TEST=none TBR=ben@chromium.org Review URL: https://chromiumcodereview.appspot.com/16561007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@204977 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 198820 "Move FileEnumerator to its own file, do some refa..."dbeam@chromium.org2013-05-081-2/+1
| | | | | | | | | | | | | | | | | | | | | | | | | | | Broke both windows clobber and official builders' compile with this error: 771>Link: 771> Creating library ..\..\..\build\Release\lib\gcp_portmon64.lib and object ..\..\..\build\Release\lib\gcp_portmon64.exp 771>base.lib(path_service.obj) : fatalerror LNK1112: module machine type 'X86' conflicts with target machine type 'x64' 771> 771>Build FAILED. > Move FileEnumerator to its own file, do some refactoring. > > It creates a class FileInfo to contain the details rather than using a platform-specific typedef. This allows the accessors GetName, GetSize, etc. to be moved directly to this class (previously they were static helpers on the FileEnumerator class) which makes a bunch of code much cleaner. It also gives reasonable getting and initialization which the previous version lacked. > > BUG=175002 > R=rvargas@chromium.org > > Review URL: https://codereview.chromium.org/13165005 TBR=brettw@chromium.org Review URL: https://codereview.chromium.org/14824006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@198850 0039d316-1c4b-4281-b951-d872f2087c98
* Move FileEnumerator to its own file, do some refactoring.brettw@chromium.org2013-05-071-1/+2
| | | | | | | | | | | It creates a class FileInfo to contain the details rather than using a platform-specific typedef. This allows the accessors GetName, GetSize, etc. to be moved directly to this class (previously they were static helpers on the FileEnumerator class) which makes a bunch of code much cleaner. It also gives reasonable getting and initialization which the previous version lacked. BUG=175002 R=rvargas@chromium.org Review URL: https://codereview.chromium.org/13165005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@198820 0039d316-1c4b-4281-b951-d872f2087c98
* Rewrite std::string("") to std::string(), Linux edition.dcheng@chromium.org2013-04-091-3/+4
| | | | | | | | | | | | | | | | | | | This patch was generated by running the empty_string clang tool across the Chromium Linux compilation database. Implicitly or explicitly constructing std::string() with a "" argument is inefficient as the caller needs to emit extra instructions to pass an argument, and the constructor needlessly copies a byte into internal storage. Rewriting these instances to simply call the default constructor appears to save ~14-18 kilobytes on an optimized release build. BUG=none Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=193020 Review URL: https://codereview.chromium.org/13145003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@193040 0039d316-1c4b-4281-b951-d872f2087c98
* Revert "Rewrite std::string("") to std::string(), Linux edition."dcheng@chromium.org2013-04-091-4/+3
| | | | | | | | | | | | | | This reverts commit e59558b78e8c6a1b0bd916a724724b638c3c91b6. Revert "Fix build after r193020." This reverts commit 558a35897f6b3ffbcaefde927c1f150b815d140a. Revert "Really fix build after r193020." This reverts commit e3748a79b523a8d365d4a33ef986eebb4186fa78. git-svn-id: svn://svn.chromium.org/chrome/trunk/src@193030 0039d316-1c4b-4281-b951-d872f2087c98
* Really fix build after r193020.dcheng@chromium.org2013-04-091-1/+1
| | | | | | | | | | | Argh. Macros are evil. BUG= TBR=darin Review URL: https://codereview.chromium.org/13937002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@193029 0039d316-1c4b-4281-b951-d872f2087c98
* Rewrite std::string("") to std::string(), Linux edition.dcheng@chromium.org2013-04-091-3/+4
| | | | | | | | | | | | | | | | | This patch was generated by running the empty_string clang tool across the Chromium Linux compilation database. Implicitly or explicitly constructing std::string() with a "" argument is inefficient as the caller needs to emit extra instructions to pass an argument, and the constructor needlessly copies a byte into internal storage. Rewriting these instances to simply call the default constructor appears to save ~14-18 kilobytes on an optimized release build. BUG=none Review URL: https://codereview.chromium.org/13145003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@193020 0039d316-1c4b-4281-b951-d872f2087c98
* chrome: Update include paths of string_split.h to its new location.tfarina@chromium.org2013-02-281-1/+1
| | | | | | | | | | BUG=175186 TBR=brettw@chromium.org Review URL: https://chromiumcodereview.appspot.com/12378016 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@185315 0039d316-1c4b-4281-b951-d872f2087c98
* Rename ui::SelectFileDialog::FileTypeInfo::support_gdata to support_drive.kinaba@chromium.org2013-02-201-1/+1
| | | | | | | | | | | We're deprecating the name 'gdata' preferring 'drive'. (https://code.google.com/p/chromium/issues/list?can=1&q=gdata+drive+rename) BUG=none Review URL: https://chromiumcodereview.appspot.com/12298016 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@183526 0039d316-1c4b-4281-b951-d872f2087c98
* Merge branch 'master' into file_path_browserbrettw@chromium.org2013-02-101-12/+14
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | version control markers Merge branch 'master' into file_path_browser remove version control Fix typo Merge branch 'master' into file_path_browser Conflicts: chrome/browser/intents/native_services_browsertest.cc chrome/browser/ui/intents/native_file_picker_service.cc Merge branch 'master' into file_path_browser Conflicts: chrome/browser/chromeos/drive/drive_file_system.cc chrome/browser/chromeos/drive/drive_file_system.h chrome/browser/chromeos/drive/drive_file_system_interface.h chrome/browser/chromeos/drive/drive_file_system_unittest.cc chrome/browser/chromeos/drive/file_system/drive_operations.cc chrome/browser/chromeos/login/wallpaper_manager.cc chrome/browser/chromeos/login/wallpaper_manager.h chrome/browser/chromeos/login/wallpaper_manager_browsertest.cc chrome/browser/extensions/api/sync_file_system/extension_sync_event_observer.cc chrome/browser/google_apis/gdata_wapi_operations.cc chrome/browser/google_apis/gdata_wapi_operations.h chrome/browser/google_apis/gdata_wapi_operations_unittest.cc chrome/browser/profiles/off_the_record_profile_impl.cc chrome/browser/profiles/off_the_record_profile_impl.h chrome/browser/profiles/profile_impl.cc chrome/browser/profiles/profile_impl.h chrome/browser/profiles/profile_impl_io_data.cc chrome/browser/profiles/profile_impl_io_data.h chrome/browser/sync_file_system/drive_file_sync_client_unittest.cc chrome/browser/ui/webui/options/manage_profile_handler.cc Long lines long lines some long lines. long lines long lines Beginning of lines. Rename FilePath -> base::FilePath in chrome/browser git-svn-id: svn://svn.chromium.org/chrome/trunk/src@181638 0039d316-1c4b-4281-b951-d872f2087c98
* Bring back the file dialogs for chrome AURA. ananta@chromium.org2013-01-171-1/+1
| | | | | | | | | | | | | | | | | | | | The AURA specific changes have been isolated in select_file_dialog_win.cc where we retrieve the top level window handle from the AURA root window. As per a discussion with Ben fixed the layering violation where in ui\base was depending on gfx::NativeView/NativeWindow which led to a layering violation on AURA. This was via ui\base\dialogs Moved the files out of ui\base\dialogs into a new gypi file shell_dialogs.gypi which lives in ui. It is included by ui.gyp The relevant code in chrome browser now depends on the shell_dialogs target created by shell_dialogs.gypi. The ui/base/dialogs folder will be deleted in a subsequent change. There were problems applying this patch on the try bots when I added the deletes to this change. BUG=170483 Review URL: https://codereview.chromium.org/11956031 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@177533 0039d316-1c4b-4281-b951-d872f2087c98
* Remove BrowserThread dependency from PrefMember.joi@chromium.org2012-10-241-0/+1
| | | | | | | | | | TBR=ben@chromium.org BUG=155525 Review URL: https://chromiumcodereview.appspot.com/11189130 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@163914 0039d316-1c4b-4281-b951-d872f2087c98
* Upstreaming SelectFileDialog for Androidaurimas@chromium.org2012-09-181-1/+7
| | | | | | | | | | | | Upstreaming the Select File Dialog and its dependencies needed for Chrome on Android BUG=116131 Review URL: https://chromiumcodereview.appspot.com/10916160 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@157424 0039d316-1c4b-4281-b951-d872f2087c98
* [cros] disable GDrive option on certain file pickersestade@chromium.org2012-09-151-8/+11
| | | | | | | | | | | | This disables the GDrive folder for features that don't support reading/writing gdata. See bug for complete list. BUG=149184 TEST=manual (all pickers listed on bug under "doesn't work", no longer shows gdrive, others still do) Review URL: https://chromiumcodereview.appspot.com/10908262 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@157012 0039d316-1c4b-4281-b951-d872f2087c98
* Allows GetExtensionsForMimeType to support mime types like "foo/*"thorogood@chromium.org2012-09-101-9/+7
| | | | | | | | | | | Additionally, removes the prescriptive methods Get{Image,Audio,Video}Extension methods: it's less specific to just support "image/*", "audio/*", and "video/*", respectively. BUG=145112 Review URL: https://chromiumcodereview.appspot.com/10908006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@155673 0039d316-1c4b-4281-b951-d872f2087c98
* Make saving files from flash less annoying.tsepez@chromium.org2012-08-151-3/+4
| | | | | | | | | | Resolves missing or relative suggested paths relative to the last opened directory, and when the path is a directory itself, browse files under it rather than itself under its parent. Determining the latter takes a file system interrogation because the syntax isn't sufficient. BUG=140799 Review URL: https://chromiumcodereview.appspot.com/10697010 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@151738 0039d316-1c4b-4281-b951-d872f2087c98
* Clean-up inline members of nested classes (chrome/)hans@chromium.org2012-08-101-0/+9
| | | | | | | | | | | | | | | | Due to a bug, the Clang-plugin style checker failed to warn about inline constructors, destructors, non-empty virtual methods, etc. for nested classes. The plugin has been fixed, and this patch is part of a clean-up of all the code that now causes the plugin to issue errors. BUG=139346 Review URL: https://chromiumcodereview.appspot.com/10855075 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@151135 0039d316-1c4b-4281-b951-d872f2087c98
* Remove redirection header and add "ui::" before all SelectFileDialog usage.erg@chromium.org2012-07-311-13/+15
| | | | | | | | | | BUG=134529 TEST=compiles Review URL: https://chromiumcodereview.appspot.com/10820034 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@149111 0039d316-1c4b-4281-b951-d872f2087c98
* Fix open dialog not remembering last opened folder on drive tbarzic@chromium.org2012-07-261-12/+10
| | | | | | | | | | | | | | | | | The problem is dialog passes file's local cache path in FileSelected. Last selected directory paths get set to cache dir, which file manager does not understand, so it opens default dir. In order to properly remember last selected dir, we should also pass file's drive path to dialog listeners and use it to remember last selected dir. BUG=126923 TEST=manual Review URL: https://chromiumcodereview.appspot.com/10804026 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@148492 0039d316-1c4b-4281-b951-d872f2087c98
* Reapply: Start consolidating cross-port file selection code into ↵erg@google.com2012-07-021-3/+3
| | | | | | | | | | | | | | | | ui/base/dialogs. Part 2: Split the chrome specific policy code into a chrome class that implements a general interface. In the next patch, we'll actually move SelectFileDialog to ui/base/dialogs/. BUG=134529 TEST=none TBR=sky,jam First Review URL: https://chromiumcodereview.appspot.com/10667026 Review URL: https://chromiumcodereview.appspot.com/10704046 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@145156 0039d316-1c4b-4281-b951-d872f2087c98
* Breaks compile on Linux Auraabodenha@chromium.org2012-06-291-3/+3
| | | | | | | | | | | | | | | | | | Revert 144938 - Start consolidating cross-port file selection code into ui/base/dialogs. Part 2: Split the chrome specific policy code into a chrome class that implements a general interface. In the next patch, we'll actually move SelectFileDialog to ui/base/dialogs/. BUG=134529 TEST=none Review URL: https://chromiumcodereview.appspot.com/10667026 TBR=erg@chromium.org Review URL: https://chromiumcodereview.appspot.com/10698053 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@144945 0039d316-1c4b-4281-b951-d872f2087c98
* Start consolidating cross-port file selection code into ui/base/dialogs.erg@chromium.org2012-06-291-3/+3
| | | | | | | | | | | | | Part 2: Split the chrome specific policy code into a chrome class that implements a general interface. In the next patch, we'll actually move SelectFileDialog to ui/base/dialogs/. BUG=134529 TEST=none Review URL: https://chromiumcodereview.appspot.com/10667026 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@144938 0039d316-1c4b-4281-b951-d872f2087c98
* Reland: Start consolidating non-port specific code to ui/base/dialogs.erg@google.com2012-06-261-12/+12
| | | | | | | | | | | | | | | | | | | (All that's changed is moving the implementations out of headers and into dedicated source files. The win_aura trybots now pass.) This moves content::SelectedFileInfo (what the select dialog outputs) and BaseShellDialog to ui/base/dialogs/. (This was split off from https://chromiumcodereview.appspot.com/10667026/ because that patch is getting huge.) BUG=134529 TEST=none TBR=sky,jam First Review URL: https://chromiumcodereview.appspot.com/10669023 Review URL: https://chromiumcodereview.appspot.com/10665050 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@144261 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 144199 - win_aura failure -Start consolidating non-port specific code ↵erg@google.com2012-06-261-12/+12
| | | | | | | | | | | | | | | | | | | | to ui/base/dialogs. This moves content::SelectedFileInfo (what the select dialog outputs) and BaseShellDialog to ui/base/dialogs/. (This was split off from https://chromiumcodereview.appspot.com/10667026/ because that patch is getting huge.) BUG=134529 TEST=none Review URL: https://chromiumcodereview.appspot.com/10669023 TBR=erg@google.com Review URL: https://chromiumcodereview.appspot.com/10666056 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@144202 0039d316-1c4b-4281-b951-d872f2087c98
* Start consolidating non-port specific code to ui/base/dialogs.erg@google.com2012-06-261-12/+12
| | | | | | | | | | | | | | | This moves content::SelectedFileInfo (what the select dialog outputs) and BaseShellDialog to ui/base/dialogs/. (This was split off from https://chromiumcodereview.appspot.com/10667026/ because that patch is getting huge.) BUG=134529 TEST=none Review URL: https://chromiumcodereview.appspot.com/10669023 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@144199 0039d316-1c4b-4281-b951-d872f2087c98
generated by cgit v1.1 at 2025-05-08 07:45:19 +0000