summaryrefslogtreecommitdiffstats
path: root/chrome/browser/file_select_helper.h
Commit message (Collapse)AuthorAgeFilesLines
* Remove straggling TabContents references.avi@chromium.org2012-12-141-1/+1
| | | | | | | | | BUG=107201 TEST=no visible change Review URL: https://codereview.chromium.org/11577020 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@173207 0039d316-1c4b-4281-b951-d872f2087c98
* [cros] disable GDrive option on certain file pickersestade@chromium.org2012-09-151-2/+2
| | | | | | | | | | | | This disables the GDrive folder for features that don't support reading/writing gdata. See bug for complete list. BUG=149184 TEST=manual (all pickers listed on bug under "doesn't work", no longer shows gdrive, others still do) Review URL: https://chromiumcodereview.appspot.com/10908262 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@157012 0039d316-1c4b-4281-b951-d872f2087c98
* Clean-up inline members of nested classes (chrome/)hans@chromium.org2012-08-101-6/+2
| | | | | | | | | | | | | | | | Due to a bug, the Clang-plugin style checker failed to warn about inline constructors, destructors, non-empty virtual methods, etc. for nested classes. The plugin has been fixed, and this patch is part of a clean-up of all the code that now causes the plugin to issue errors. BUG=139346 Review URL: https://chromiumcodereview.appspot.com/10855075 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@151135 0039d316-1c4b-4281-b951-d872f2087c98
* Move ExtensionHost into extensions namespacerdevlin.cronin@chromium.org2012-07-311-2/+2
| | | | | | | | | BUG=139042,117261 Review URL: https://chromiumcodereview.appspot.com/10824030 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@149295 0039d316-1c4b-4281-b951-d872f2087c98
* Remove redirection header and add "ui::" before all SelectFileDialog usage.erg@chromium.org2012-07-311-6/+6
| | | | | | | | | | BUG=134529 TEST=compiles Review URL: https://chromiumcodereview.appspot.com/10820034 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@149111 0039d316-1c4b-4281-b951-d872f2087c98
* Part 3 of Move SelectFileDialog implementation to ui/base/dialogs/erg@google.com2012-07-181-0/+1
| | | | | | | | | | | | | | | - Actually move the SelectFileDialog class to ui::, leaving a compatibility header in the interim. - Because of linking reasons, create a factory interface for the SelectFileDialogExtension to use to inject itself from chrome/browser/views/ui/ - Because of linking reasons, move SelectFileDialogWin in this patch. - wstring code moved to win only files. BUG=134529 TEST=none First Review URL: https://chromiumcodereview.appspot.com/10695066 Review URL: https://chromiumcodereview.appspot.com/10698168 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@147263 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 146382 - Part 3 of Move SelectFileDialog implementation to ui/base/dialoerg@google.com2012-07-121-1/+0
| | | | | | | | | | | | | | | | | | | | | gs/ Reverting due to window build break. -Actually move the SelectFileDialog class to ui::, leaving a compatibility header in the interim. - Because of linking reasons, create a factory interface for the SelectFileDialogExtension to use to inject itself from chrome/browser/views/ui/ - wstring code moved to win only files. BUG=134529 TEST=none Review URL: https://chromiumcodereview.appspot.com/10695066 TBR=erg@google.com Review URL: https://chromiumcodereview.appspot.com/10693167 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@146386 0039d316-1c4b-4281-b951-d872f2087c98
* Part 3 of Move SelectFileDialog implementation to ui/base/dialogs/erg@google.com2012-07-121-0/+1
| | | | | | | | | | | | | | -Actually move the SelectFileDialog class to ui::, leaving a compatibility header in the interim. - Because of linking reasons, create a factory interface for the SelectFileDialogExtension to use to inject itself from chrome/browser/views/ui/ - wstring code moved to win only files. BUG=134529 TEST=none Review URL: https://chromiumcodereview.appspot.com/10695066 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@146382 0039d316-1c4b-4281-b951-d872f2087c98
* Remove the rest of #pragma once in one big CL.ajwong@chromium.org2012-07-111-1/+0
| | | | | | | | | For context see this thread: https://groups.google.com/a/chromium.org/forum/?fromgroups#!topic/chromium-dev/RMcVNGjB4II TBR=thakis,pkasting,jam git-svn-id: svn://svn.chromium.org/chrome/trunk/src@146163 0039d316-1c4b-4281-b951-d872f2087c98
* Reland: Start consolidating non-port specific code to ui/base/dialogs.erg@google.com2012-06-261-2/+5
| | | | | | | | | | | | | | | | | | | (All that's changed is moving the implementations out of headers and into dedicated source files. The win_aura trybots now pass.) This moves content::SelectedFileInfo (what the select dialog outputs) and BaseShellDialog to ui/base/dialogs/. (This was split off from https://chromiumcodereview.appspot.com/10667026/ because that patch is getting huge.) BUG=134529 TEST=none TBR=sky,jam First Review URL: https://chromiumcodereview.appspot.com/10669023 Review URL: https://chromiumcodereview.appspot.com/10665050 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@144261 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 144199 - win_aura failure -Start consolidating non-port specific code ↵erg@google.com2012-06-261-5/+2
| | | | | | | | | | | | | | | | | | | | to ui/base/dialogs. This moves content::SelectedFileInfo (what the select dialog outputs) and BaseShellDialog to ui/base/dialogs/. (This was split off from https://chromiumcodereview.appspot.com/10667026/ because that patch is getting huge.) BUG=134529 TEST=none Review URL: https://chromiumcodereview.appspot.com/10669023 TBR=erg@google.com Review URL: https://chromiumcodereview.appspot.com/10666056 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@144202 0039d316-1c4b-4281-b951-d872f2087c98
* Start consolidating non-port specific code to ui/base/dialogs.erg@google.com2012-06-261-2/+5
| | | | | | | | | | | | | | | This moves content::SelectedFileInfo (what the select dialog outputs) and BaseShellDialog to ui/base/dialogs/. (This was split off from https://chromiumcodereview.appspot.com/10667026/ because that patch is getting huge.) BUG=134529 TEST=none Review URL: https://chromiumcodereview.appspot.com/10669023 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@144199 0039d316-1c4b-4281-b951-d872f2087c98
* Modified the pepper file chooser API to support filtering files by extensions.raymes@chromium.org2012-05-301-1/+8
| | | | | | | | | | | | | | Previously you could filter only by MIME type. This adds support for filtering by specific extensions as well, e.g. .txt,.html. This change is aligned with the web platform which now allows filtering by file extension for <input> elements (http://www.whatwg.org/specs/web-apps/current-work/multipage/states-of-the-type-attribute.html#attr-input-accept). This also changes the linux implementation of the file dialog (SelectFileDialogImplGTK). In the past, it would turn file extensions to filter into MIME types. However this is a bit silly because in FileSelectHelper we do the reverse (turn MIME types into a list of file extensions to filter by). It also prevents us from filtering by a specific extensions when this is really what is desired. BUG=129251 TEST= Review URL: https://chromiumcodereview.appspot.com/10414085 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@139434 0039d316-1c4b-4281-b951-d872f2087c98
* Move RunFileChooserHelper and EnumerateDirectoryHelper out of Browser.mihaip@chromium.org2012-05-221-7/+13
| | | | | | | | R=sky@chromium.org Review URL: https://chromiumcodereview.appspot.com/10411064 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@138296 0039d316-1c4b-4281-b951-d872f2087c98
* filechooser: Add SelectedFileInfo class to pass display names to WebKitsatorux@chromium.org2012-03-141-1/+9
| | | | | | | | | | | | | | | | | | | Files on gdata are cached locally with human unreadable names like /blah/gdata/cache/d41d8cd98f00b204e9800998ecf8427e. When these files are selected from the file chooser for uploading from <form>, we should pass display names, in addition to real paths, to WebKit, so the proper names are shown in web pages, and used for uploading. This patch simply adds SelectedFileInfo with minimal code changes. There should be no behavior changes. The file selection code for Chrome OS will be changed in a separate patch. BUG=chromium-os:27222 TEST=try bots. Review URL: https://chromiumcodereview.appspot.com/9651028 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@126606 0039d316-1c4b-4281-b951-d872f2087c98
* Move Render(View|Widget)Host and associated classes to content namespace.joi@chromium.org2012-03-071-5/+5
| | | | | | | | | TBR=jam@chromium.org BUG=98716 Review URL: https://chromiumcodereview.appspot.com/9600036 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@125388 0039d316-1c4b-4281-b951-d872f2087c98
* Convert a bunch of WebContentsObservers to use web_contents() instead of ↵jam@chromium.org2011-12-251-3/+3
| | | | | | | | | | tab_contents(), as well as all the dependent code. BUG=98716 TBR=joi Review URL: http://codereview.chromium.org/8982008 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@115777 0039d316-1c4b-4281-b951-d872f2087c98
* Move TabContentsObserver to content/public, rename it to ↵jam@chromium.org2011-12-221-1/+0
| | | | | | | | | | WebContentsObserver, and put it into the content namespace. BUG=98716 TBR=tburkard Review URL: http://codereview.chromium.org/9026011 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@115599 0039d316-1c4b-4281-b951-d872f2087c98
* Get rid of view_messages.h include from chrome since TabContentsDelegate ↵jam@chromium.org2011-11-221-4/+6
| | | | | | | | | | used a struct from it (ViewHostMsg_RunFileChooser_Params). Moved that to a struct in content/public/common. BUG=98716 Review URL: http://codereview.chromium.org/8622005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@111086 0039d316-1c4b-4281-b951-d872f2087c98
* Add OVERRIDE to chrome/browser/.avi@chromium.org2011-11-211-2/+2
| | | | | | | | | BUG=104314 TEST=no change Review URL: http://codereview.chromium.org/8612007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@110939 0039d316-1c4b-4281-b951-d872f2087c98
* Standardize naming of SelectFileDialog implementation files.jamescook@chromium.org2011-11-151-1/+1
| | | | | | | | | | | | | | | * Rename shell_dialogs.* to select_file_dialog.* * Rename file_manager_dialog.* to select_file_dialog_webui.* * Also rename win/mac/aura/gtk/kde variants. No functional changes. BUG=104155 TEST=compiles Review URL: http://codereview.chromium.org/8555016 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@110125 0039d316-1c4b-4281-b951-d872f2087c98
* Use WebFileChooserParams::accpetMIMETypes instead of acceptTypes.tkent@chromium.org2011-11-021-1/+2
| | | | | | | | | | | | acceptMIMETypes is a list of valid lowercased MIME types. We can remove spliting, lowercasing, and stripping code in GetFileTypesFromAcceptType(). BUG=none TEST=none because this doesn't make any behavior change. Review URL: http://codereview.chromium.org/8401030 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@108252 0039d316-1c4b-4281-b951-d872f2087c98
* Move NotificationObserver, NotificationSource, and NotificationDetails to ↵jam@chromium.org2011-10-191-7/+7
| | | | | | | | | | | content/public/browser. This patch got way bigger than I wanted, but once I moved NotificationDetails, I figured I might as well mvoe the others since they're in the same files. In hindsight, I should have converted a subset of files at a time by leaving a using statement in the header. BUG=98716 TBR=joi git-svn-id: svn://svn.chromium.org/chrome/trunk/src@106196 0039d316-1c4b-4281-b951-d872f2087c98
* Fix crash when running the file chooser dialog from PPAPI.BUG=97637TEST=manualbbudge@chromium.org2011-09-291-4/+22
| | | | | | Review URL: http://codereview.chromium.org/7994015 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@103325 0039d316-1c4b-4281-b951-d872f2087c98
* Handle the ViewHostMsg_RunFileChooser and ViewHostMsg_EnumerateDirectory IPC ↵ananta@chromium.org2011-08-241-21/+0
| | | | | | | | | | | | messages which are sent by content(renderer) via the TabContentsDelegate. We eventually want to get rid of the pattern of sending IPC messages from content and handling them in chrome and vice versa. BUG=87335 Review URL: http://codereview.chromium.org/7721003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@98081 0039d316-1c4b-4281-b951-d872f2087c98
* Moving notification types which are chrome specific to a new header file ↵ananta@chromium.org2011-07-101-1/+1
| | | | | | | | | | | | | chrome_notification_types.h. This file lives in chrome\common. The chrome specific notifications start from NOTIFICATION_CONTENT_END which defines the end of the enum used by content to define notification types. The notificaton_type.h file in content\common has been renamed to content_notification_types.h BUG=76698 Review URL: http://codereview.chromium.org/7327007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@91972 0039d316-1c4b-4281-b951-d872f2087c98
* Virtual destructors should have virtual keyword.hans@chromium.org2011-05-251-3/+3
| | | | | | | | | | | | | | | | | Make sure user-declared virtual destructors always have the virtual keyword. The Clang style-check plugin will check for this soon. No functionality change: virtual is only added to destructors that are already implicitly virtual. Also fix a couple of in-line destructor definitions. BUG=83408 TEST=none Review URL: http://codereview.chromium.org/7064033 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@86587 0039d316-1c4b-4281-b951-d872f2087c98
* Policy to manage file selection dialogs.pastarmovj@chromium.org2011-04-151-0/+5
| | | | | | | | | | | | | | | | Adds a policy to allow/disallow file selection dialogs from wherever they can be launched (Save Link As, Import Bookmarks, etc.). In case file selection dialogs are disallowed by policy a InfoBar informs the user whenever he triggers a file selection dialog. BUG=73174 TEST=Manually set the policy and check if the corresponding file selection are not shown and the InfoBar appears. Review URL: http://codereview.chromium.org/6814011 Patch from Sandro Feuz <sfeuz@google.com>. git-svn-id: svn://svn.chromium.org/chrome/trunk/src@81804 0039d316-1c4b-4281-b951-d872f2087c98
* Fix clang build.johnnyg@chromium.org2011-04-121-6/+1
| | | | | | Review URL: http://codereview.chromium.org/6821061 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@81196 0039d316-1c4b-4281-b951-d872f2087c98
* Add a path for a web page to request the enumeration of a directory. This, ↵johnnyg@chromium.org2011-04-121-15/+55
| | | | | | | | | | together with a WebKit change, will allow a drag-and-drop on a Directory Upload control (<input type=file webkitdirectory>) which provides only the path to the renderer, to correctly populate the control as if the user had selected that directory in a file picker. BUG=58977 TEST=drag-and-drop on directory upload control (with upstream change) Review URL: http://codereview.chromium.org/6623015 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@81183 0039d316-1c4b-4281-b951-d872f2087c98
* Pull the file picker code out of TabContents.avi@chromium.org2011-03-111-13/+34
| | | | | | | | | BUG=71097 TEST=hammer on the HTML file selection dialogs. No visible change; no crashes, nothing. Review URL: http://codereview.chromium.org/6680002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@77835 0039d316-1c4b-4281-b951-d872f2087c98
* Update a bunch of files to the new location of notification files.tfarina@chromium.org2011-03-091-3/+3
| | | | | | | | | | | Second part of the remaining files. BUG=None TEST=None Review URL: http://codereview.chromium.org/6639008 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@77396 0039d316-1c4b-4281-b951-d872f2087c98
* Carnitas: move browser/shell_dialogs.{h,cc} to browser/uiestade@chromium.org2011-02-111-1/+1
| | | | | | | | | BUG=none TEST=compile Review URL: http://codereview.chromium.org/6485017 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@74658 0039d316-1c4b-4281-b951-d872f2087c98
* Get rid of a few more interfaces from RenderViewHostDelegate that aren't needed.jam@chromium.org2011-01-251-5/+3
| | | | | | Review URL: http://codereview.chromium.org/6374009 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@72522 0039d316-1c4b-4281-b951-d872f2087c98
* Input file type now supported in extension popups.jcivelli@chromium.org2010-09-101-0/+85
To do this, this CL generalize the TabContentsFileSelectHelper (renamed FileSelectHelper) so it is associated with a RenderViewHost rather than a TabContents. This allows the extension popups which don't use a TabContents to use it. As part of that, I also moved GetTopLevelNativeWindow() from TabContentsView to TabContent, as it can be implemented in a non-platform specific way. BUG=28829 TEST=Make sure you can still open file on web pages (such as http://www.cs.tut.fi/~jkorpela/forms/file.html. Create an extension with a popup that contains an input file tag. Make sure it does open a file dialog and lets you choose a file. Review URL: http://codereview.chromium.org/3209002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@59105 0039d316-1c4b-4281-b951-d872f2087c98
generated by cgit v1.1 at 2025-02-15 04:19:09 +0000