summaryrefslogtreecommitdiffstats
path: root/chrome/browser/find_bar_controller.cc
Commit message (Collapse)AuthorAgeFilesLines
* Once you search for something in a tab, you are very likely to search for ↵finnur@chromium.org2009-04-131-1/+8
| | | | | | | | | | the same thing in another tab. Therefore, if you haven't searched for anything within that tab then Chrome should prepopulate the Find box with the last string you searched for (in any tab). BUG=876 TEST=Open google.com, Ctrl+F, search for 'e'. Open a new tab/new window/open a link in a new window. In all of those new tabs the Find box should be prepopulated with 'e' that is selected (for easy overwriting). Review URL: http://codereview.chromium.org/67066 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13613 0039d316-1c4b-4281-b951-d872f2087c98
* Bug 2220 lists two cases where the inactive highlighting doesn't reappear on ↵finnur@chromium.org2009-04-021-4/+9
| | | | | | | | | | FindNext. This is a simple fix for one of those cases (user presses Refresh after Find). BUG=2220 TEST=Open google.com, press Find, press e, press Refresh, press F3 (or FindNext button in UI). Then make sure the inactive matches are highlighted (not just the active match). Review URL: http://codereview.chromium.org/56193 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13028 0039d316-1c4b-4281-b951-d872f2087c98
* Fixing a few minor issues found during static analysis of the Chromium codebase.finnur@chromium.org2009-03-181-1/+0
| | | | | | | | | | | | | | | | | | | | | | find_bar_controller.cc: Unused local variable created. hwnd_view.cc: The local definition of parent overshadows param passed in. google_update.cc: Uninitialized member variable. webframe_impl.cc: The if was overly constrained. At the top of the function there is an if (reset) { ... return; } so we don't need to check for !reset in the next if statement. This functionality is covered by a ui_test, which passes with this change. Review URL: http://codereview.chromium.org/42321 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11964 0039d316-1c4b-4281-b951-d872f2087c98
* Some work in refactoring FindBarWin/FindBarView sotc@google.com2009-03-121-0/+136
we can share code across platforms. See http://code.google.com/p/chromium/wiki/FindBarRefactoring for more information about the design. Review URL: http://codereview.chromium.org/42057 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11544 0039d316-1c4b-4281-b951-d872f2087c98