summaryrefslogtreecommitdiffstats
path: root/chrome/browser/first_run
Commit message (Collapse)AuthorAgeFilesLines
* Merge 120450 - Revise logic to show the first-run bubble at the first ↵msw@chromium.org2012-02-042-4/+93
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | appropriate opportunity. Add static function FirstRunBubbleLauncher::ShowFirstRunBubbleSoon. A FirstRunBubbleLauncher instance acts as a NotificationObserver and manages its own lifetime. Show the bubble on the first NOTIFICATION_LOAD_COMPLETED_MAIN_FRAME when conditions permit. Also, make NTPLoginHandler::HandleLoginMessageSeen set the new NewTabUI::showing_sync_bubble_. The bubble will be delayed if: A) The First-Run Bubble has already been shown. B) The Sync Promo is being shown. C) The NTP Sync Promo Bubble will be shown. D) A Global Error Bubble is pending. Later attempts to show the bubble may succeed. The bubble shows as expected on Win/Mac/Gtk first runs: -When the sync promo is not shown. -On the first new tab/window/navigation ignoring the sync promo. -On clicking "Skip for now" from the sync promo. -On the first new tab/window/navigation after the "Sign in" NTP sync promo bubble. BUG=100299,107005 TEST=Ensure the first-run bubble shows when expected; but not with the sync promo, ntp sign-in sync promo bubble, with global errors, nor ever shown a second time (without the --first-run commandline argument). Review URL: https://chromiumcodereview.appspot.com/9288049 TBR=msw@chromium.org Review URL: https://chromiumcodereview.appspot.com/9317106 git-svn-id: svn://svn.chromium.org/chrome/branches/1025/src@120452 0039d316-1c4b-4281-b951-d872f2087c98
* Fix the memory leak issue in FirstRun::LoadMasterPrefs().jennyz@chromium.org2012-01-311-1/+3
| | | | | | | | | | BUG=111922 TEST=NONE Review URL: http://codereview.chromium.org/9159042 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@119843 0039d316-1c4b-4281-b951-d872f2087c98
* Set the ShortcutCreated pref for when shortcuts are created on first run.stevet@chromium.org2012-01-311-3/+6
| | | | | | | | | BUG=111519 TEST=Verify 111519. Review URL: http://codereview.chromium.org/9288077 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@119778 0039d316-1c4b-4281-b951-d872f2087c98
* Test out a new more compact, simpler attrition experiment toast bubble.finnur@chromium.org2012-01-302-27/+58
| | | | | | | | | | | | | | | | | | | | | | | | | | | Old bubble: --------------------------------------------- There's a new safer version of Google Chrome [x] Try it out [ ] Uninstall [OK] [Don't Bug Me] {Why am I seeing this?} --------------------------------------------- Newer, more compact bubble: --------------------------------------------- There's a new safer version of Google Chrome [x] Try it out [ ] Don't Bug Me [OK] --------------------------------------------- BUG=None TEST=This should be tested like any other attrition toast experiment, but needs a special branded build. Review URL: https://chromiumcodereview.appspot.com/9129021 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@119655 0039d316-1c4b-4281-b951-d872f2087c98
* Progressively refactor FirstRun code to first_run namespace(part 5). This cl ↵jennyz@chromium.org2012-01-283-105/+155
| | | | | | | | | | | | | | | | | | | | refactors: MasterPrefs and some long code block into functions: LoadMasterPrefs CopyPrefFile SetupMasterPrefsFromInstallPrefs This helps to make FirstRun::ProcessMasterPreferences() become shorter and reduce the code duplication when we refactor ProcessMasterPreferences to different platforms in the next step. BUG=108137 TEST=NONE Review URL: http://codereview.chromium.org/9296021 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@119567 0039d316-1c4b-4281-b951-d872f2087c98
* Remove the first-run search engine dialog/ballot.msw@chromium.org2012-01-267-45/+6
| | | | | | | | | | | | | | | | | | | No changes to the Gtk and Mac first-run (reporting & default browser) dialog. Tested optionally with GYP_DEFINES="branding=Chrome" and "--first-run --organic". Chromium (all platforms): Shows the browser window directly (no dialog). Chrome (Windows): Shows the browser window directly (no dialog). Chrome (Linux and Mac): Shows the first-run (reporting & default browser) dialog before the browser window. TODO(msw): Close crbug.com/111062 for removed test. TODO(msw): Remove search engine icon/image resources (TemplateURL::logo_id_). BUG=107005 TEST=No more standalone search engine selection dialog/ballot, Gtk and Mac first-run dialog works as before. Review URL: http://codereview.chromium.org/9285002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@119189 0039d316-1c4b-4281-b951-d872f2087c98
* Restricting test to run on Windows only, since test harness on Mac and Linux ↵finnur@chromium.org2012-01-201-0/+11
| | | | | | | | | | times out if the browser exits too early. BUG=45115 TEST=None Review URL: https://chromiumcodereview.appspot.com/9233007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@118436 0039d316-1c4b-4281-b951-d872f2087c98
* Converting Toast crasher test from UI test to browser test. finnur@chromium.org2012-01-201-0/+24
| | | | | | | | | | The old UI test would just hang due to limitations in our test framework, but the browser test catches the crash that we currently have in our codebase (a crash due to recent refactoring). BUG=45115 TEST=None, this is to add a new test for a disabled one. Review URL: https://chromiumcodereview.appspot.com/9250010 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@118430 0039d316-1c4b-4281-b951-d872f2087c98
* Preliminary implementation of Google-style dialogs in ↵benrg@chromium.org2012-01-181-2/+2
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | ash::internal::DialogFrameView This code is only compiled into Aura and only used if the "Google-style dialogs" flag is specified (--aura-google-dialog-frames). Remaining issues: * Constrained windows are still broken -- see issue 109138. * Title and body text should be #222, not black. This CL only affects the title, and currently leaves it at black to match the body text. * The shadow and border stroke are not up to spec. Fixing this would require adding new image assets or rewriting the drawing code entirely. * Some dialogs look pretty bad, such as the certificate viewer (which has a tab bar with the wrong look). * The close button placement on medium- and small-sized dialogs may be wrong; there are no examples in the spec. * There are sizing/positioning issues with various dialogs (for example, in Javascript popups the title bar is not always long enough to hold the title). BUG=none TEST=none TBR=estade@chromium.org Review URL: http://codereview.chromium.org/9187061 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@118136 0039d316-1c4b-4281-b951-d872f2087c98
* Check the browser distribution when determining whether or not we should ↵stevet@chromium.org2012-01-171-1/+1
| | | | | | | | | | | create desktop shortcuts, rather than the no-first-run flag. BUG=108362 TEST=Ensure that installing Chrome Frame and visiting a Chrome Frame enabled page does not create any desktop shortcuts in Windows. Ensure that running a pyauto test that runs the OpenNewBrowserWindowWithNewProfile hook also creates desktop shortcuts. Review URL: http://codereview.chromium.org/9227010 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@117910 0039d316-1c4b-4281-b951-d872f2087c98
* Implement the new first run bubble, clean up old bubbles.msw@chromium.org2012-01-123-74/+11
| | | | | | | | | | | | | | | | | | | Remove large/minimal/oem bubble types, use a single bubble. Update strings, remove unused code, add Change link/button. Point Change link to chrome://settings/searchEngines for now. Old string: "Search using Google from right here" New string: "You can search from here with Google!" New link/button text: "Change" Mac xib changes: Add 'Change' button, widen bubble to fit. BUG=107005 TEST=First run search engine bubble now says "You can search from here with Google!" TBR=pkasting Review URL: http://codereview.chromium.org/9016036 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@117521 0039d316-1c4b-4281-b951-d872f2087c98
* Progressively refacto FirstRun class to first_run namespace(part 4).jennyz@chromium.org2012-01-116-45/+38
| | | | | | | | | | BUG=108137 TEST=NONE Review URL: http://codereview.chromium.org/9153008 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@117266 0039d316-1c4b-4281-b951-d872f2087c98
* Refactor FirstRun class to first_run namespace progressively(part 3). This ↵jennyz@chromium.org2012-01-077-140/+153
| | | | | | | | | | | | | | | | | | | cl refactors: ImportFromBrowser ImportBookmarks ImportFromFile ImportNow Remove GetFirstRunSentinelFilePath from first_run.h, which was missed from the previous refactoring cl. BUG=108137 TEST=NONE Review URL: http://codereview.chromium.org/9108026 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@116804 0039d316-1c4b-4281-b951-d872f2087c98
* use the linux version of IsOrganicFirstRun() on OS_BSD toorobert.nagy@gmail.com2012-01-051-1/+1
| | | | | | | | | | BUG= TEST= Review URL: http://codereview.chromium.org/9109016 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@116525 0039d316-1c4b-4281-b951-d872f2087c98
* Refactor FirstRun class to first_run namespace progressively. This cl refactors:jennyz@chromium.org2012-01-058-397/+493
| | | | | | | | | | | | | | | | | | | | IsOrganicFirstRun() AutoImport() ImportSettings() SetShowFirstRunBubblePref() SetMinimalFirstRunBubblePref() SetShowWelcomePagePref() SetPersonalDataManagerFirstRunPref() PlatformSetup() BUG=108137 TEST=NONE Review URL: http://codereview.chromium.org/9016051 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@116423 0039d316-1c4b-4281-b951-d872f2087c98
* Refactor FirstRun class code into namespace first_run progressively. This cl ↵jennyz@chromium.org2011-12-286-84/+189
| | | | | | | | | | | | | | | | | | | refactors: IsChromeFirstRun() CreateSentinel() RemoveSentinel() GetFirstRunSentinelFilePath() It also fixed an issue that chromeos first run won't create sentinel file, and the following runs always think it is a first run. BUG=108137 TEST=None Review URL: http://codereview.chromium.org/8989043 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@115925 0039d316-1c4b-4281-b951-d872f2087c98
* Remove aura stub of FirstRun code.jennyz@chromium.org2011-12-205-102/+11
| | | | | | | | | | BUG=102138 TEST=NONE Review URL: http://codereview.chromium.org/8996022 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@115064 0039d316-1c4b-4281-b951-d872f2087c98
* Split UserMetrics into API vs. implementation. Move API to content/public.joi@chromium.org2011-12-142-3/+7
| | | | | | | | | TBR=davemoore@chromium.org BUG=98716 Review URL: http://codereview.chromium.org/8919017 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@114416 0039d316-1c4b-4281-b951-d872f2087c98
* Badge Windows profile shortcuts with multi-user avatar.stevet@chromium.org2011-12-061-0/+2
| | | | | | | | | BUG=105110 TEST=Ensure that when Chrome on Windows creates a desktop icon for a new Profile, the icon image has the user avatar in it. Ensure that changing the Avatar changes the image in the icon. TBR=rsesek Review URL: http://codereview.chromium.org/8785006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@113104 0039d316-1c4b-4281-b951-d872f2087c98
* views: Move the remaining files to ui/views/controls/.tfarina@chromium.org2011-11-291-1/+1
| | | | | | | | | | BUG=104039 R=ben@chromium.org TBR=stevenjb@chromium.org Review URL: http://codereview.chromium.org/8687031 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@112014 0039d316-1c4b-4281-b951-d872f2087c98
* views: Move label and link files to ui/views/controls/.tfarina@chromium.org2011-11-292-2/+2
| | | | | | | | | | BUG=104039 R=ben@chromium.org TBR=stevenjb@chromium.org Review URL: http://codereview.chromium.org/8729013 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@111917 0039d316-1c4b-4281-b951-d872f2087c98
* views: Move button directory to ui/views/controls/.tfarina@chromium.org2011-11-282-4/+4
| | | | | | | | | | BUG=104039 R=maruel@chromium.org TBR=ben@chromium.org Review URL: http://codereview.chromium.org/8716001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@111669 0039d316-1c4b-4281-b951-d872f2087c98
* Add Windows desktop shortcut for multiple profiles.mirandac@chromium.org2011-11-221-0/+2
| | | | | | | | BUG=87770 TEST=new unit tests added with this CL. Review URL: http://codereview.chromium.org/8502033 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@111156 0039d316-1c4b-4281-b951-d872f2087c98
* views: Move widget/ directory to ui/views.tfarina@chromium.org2011-11-221-1/+1
| | | | | | | | | | | BUG=104039 R=ben@chromium.org Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=110949 Review URL: http://codereview.chromium.org/8598031 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@111077 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 110949 - views: Move widget/ directory to ui/views.wez@chromium.org2011-11-211-1/+1
| | | | | | | | | | | | BUG=104039 R=ben@chromium.org Review URL: http://codereview.chromium.org/8598031 TBR=tfarina@chromium.org Review URL: http://codereview.chromium.org/8547015 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@110953 0039d316-1c4b-4281-b951-d872f2087c98
* views: Move widget/ directory to ui/views.tfarina@chromium.org2011-11-211-1/+1
| | | | | | | | | BUG=104039 R=ben@chromium.org Review URL: http://codereview.chromium.org/8598031 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@110949 0039d316-1c4b-4281-b951-d872f2087c98
* views: Delete bubble, events, focus, layout directories and its stubbed files.tfarina@chromium.org2011-11-181-2/+2
| | | | | | | | | BUG=104039 R=ben@chromium.org Review URL: http://codereview.chromium.org/8566052 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@110787 0039d316-1c4b-4281-b951-d872f2087c98
* Review URL: http://codereview.chromium.org/8357020mirandac@chromium.org2011-10-262-3/+3
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@107344 0039d316-1c4b-4281-b951-d872f2087c98
* Review URL: http://codereview.chromium.org/8393025mirandac@chromium.org2011-10-262-18/+1
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@107302 0039d316-1c4b-4281-b951-d872f2087c98
* Move resource_codes to content/public/common.jam@chromium.org2011-10-252-2/+2
| | | | | | | BUG=98716 Review URL: http://codereview.chromium.org/8382021 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@107061 0039d316-1c4b-4281-b951-d872f2087c98
* Make NotificationService an interface in the content namespace, and switch ↵jam@chromium.org2011-10-191-3/+3
| | | | | | | | | callers to use it. Move the implementation to content/browser. Stop creating it in all child processes since it's only used in the browser. BUG=98716 Review URL: http://codereview.chromium.org/8342048 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@106403 0039d316-1c4b-4281-b951-d872f2087c98
* Move NotificationObserver, NotificationSource, and NotificationDetails to ↵jam@chromium.org2011-10-191-6/+8
| | | | | | | | | | | content/public/browser. This patch got way bigger than I wanted, but once I moved NotificationDetails, I figured I might as well mvoe the others since they're in the same files. In hindsight, I should have converted a subset of files at a time by leaving a using statement in the header. BUG=98716 TBR=joi git-svn-id: svn://svn.chromium.org/chrome/trunk/src@106196 0039d316-1c4b-4281-b951-d872f2087c98
* Suppress first run search box for sync promosail@chromium.org2011-10-182-4/+2
| | | | | | | | | | | | This change disables the first run search box while we display the sync promo. BUG=100299 TEST= Review URL: http://codereview.chromium.org/8313004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@106034 0039d316-1c4b-4281-b951-d872f2087c98
* Move brand code related function to a common place for all platforms. Theserogerta@chromium.org2011-10-075-31/+16
| | | | | | | | | | are Google specific APIs. BUG=None TEST=Make sure RLZ still uses correct brand code. Review URL: http://codereview.chromium.org/8136006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@104479 0039d316-1c4b-4281-b951-d872f2087c98
* Removed code duplication on test for search engine selector on first run.joaodasilva@chromium.org2011-09-202-2/+12
| | | | | | | | | | | | | | Also fixes the test logic on the mac, which currently is ignoring SearchEngineSelectorDisallowed() if the default search provider is not managed, which is the most common case. BUG=None TEST=The search engine selection dialog shows on first run, except when the default search provider is managed by policy or the dialog is disallowed. Review URL: http://codereview.chromium.org/7936009 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@101877 0039d316-1c4b-4281-b951-d872f2087c98
* Aura under Linux is enabled with:saintlou@chromium.org2011-09-182-33/+52
| | | | | | | | | | | 'use_aura': 1, BUG=none TEST=none Review URL: http://codereview.chromium.org/7850026 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@101704 0039d316-1c4b-4281-b951-d872f2087c98
* Fix first run issue.mirandac@chromium.org2011-09-161-0/+4
| | | | | | Review URL: http://codereview.chromium.org/7922009 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@101586 0039d316-1c4b-4281-b951-d872f2087c98
* Get chrome to link with USE_AURAben@chromium.org2011-09-071-0/+82
| | | | | | | | | | http://crbug.com/93947 TEST=none R=sadrul TBR=jabdelmalek for the content/webkit stubs Review URL: http://codereview.chromium.org/7841012 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@99993 0039d316-1c4b-4281-b951-d872f2087c98
* Enable brand codes and master preferences on the Mac.avi@chromium.org2011-08-305-28/+63
| | | | | | | | | BUG=93421 TEST=alter brand codes and master prefs files; should be read Review URL: http://codereview.chromium.org/7655056 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@98811 0039d316-1c4b-4281-b951-d872f2087c98
* Added group policies to enable/disable importing of data from other browsers.simo@google.com2011-08-161-26/+94
| | | | | | | | | | | | These are now proper user policies and disable/enable import settings even after the first run. There are separate policies for bookmarks, history, saved passwords, search engines and homepage. BUG=71080 TEST= Review URL: http://codereview.chromium.org/7390027 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@96921 0039d316-1c4b-4281-b951-d872f2087c98
* Move in_process_browser_test and ui_test_utils to chrome/test/basephajdan.jr@chromium.org2011-07-291-2/+2
| | | | | | | BUG=90905 Review URL: http://codereview.chromium.org/7532034 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@94720 0039d316-1c4b-4281-b951-d872f2087c98
* Take two at splitting result codes between content and chrome.dpranke@chromium.org2011-07-192-6/+6
| | | | | | | | | | | | content/common/result_codes.h contains only the codes defined in content. chrome/common/chrome_result_codes.h contains the codes defined in chrome and also includes (for convenience) the content header. R=jam@chromium.org BUG=76699 TEST=everything compiles Review URL: http://codereview.chromium.org/7397004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@93082 0039d316-1c4b-4281-b951-d872f2087c98
* Convert the remaining callers of LaunchApp to LaunchProcess.evan@chromium.org2011-07-181-1/+4
| | | | | | | | | | And delete temporary shims. BUG=88990 Review URL: http://codereview.chromium.org/7386010 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@92897 0039d316-1c4b-4281-b951-d872f2087c98
* Revert r92730, r92731, r92732 ... will land again once I ensure the win ↵dpranke@chromium.org2011-07-152-6/+6
| | | | | | | | | | | | | builds compile. TBR=jam@chromium.org BUG=none TEST= Review URL: http://codereview.chromium.org/7400002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@92733 0039d316-1c4b-4281-b951-d872f2087c98
* This change will split the result codes between content and chrome.dpranke@chromium.org2011-07-152-6/+6
| | | | | | | | | | | | | | | This adds a new file into chrome/common and does a lot of renaming. The current version is just a sketch of the headers, and nothing will compile. R=jam@chromium.org BUG=76699 TEST=everything still compiles and runs Review URL: http://codereview.chromium.org/7377010 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@92730 0039d316-1c4b-4281-b951-d872f2087c98
* Cause new_chrome.exe to always be written if Chrome Frame is in use, ↵robertshield@chromium.org2011-07-151-13/+42
| | | | | | | | | | resulting in updates being deferred. BUG=88589 TEST=NONE Review URL: http://codereview.chromium.org/7353030 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@92706 0039d316-1c4b-4281-b951-d872f2087c98
* Change base::LaunchProcess API slightlyevan@chromium.org2011-07-154-10/+6
| | | | | | | | | | | Rather than passing the out param process handle via the options, take it as a function argument. This simplifies many callers. BUG=88990 Review URL: http://codereview.chromium.org/7377012 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@92701 0039d316-1c4b-4281-b951-d872f2087c98
* importer: Trivial change that changes NONE_IMPORTER to TYPE_UNKNOWN.tfarina@chromium.org2011-07-151-1/+1
| | | | | | | | | | | | | So while I'm here clean up the other importer types to make them prettier. BUG=None TEST=None R=mirandac@chromium.org Review URL: http://codereview.chromium.org/7387005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@92696 0039d316-1c4b-4281-b951-d872f2087c98
* Clean up users of a deprecated base::LaunchApp API.evan@chromium.org2011-07-144-6/+12
| | | | | | | | BUG=88990 Review URL: http://codereview.chromium.org/7351003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@92598 0039d316-1c4b-4281-b951-d872f2087c98
* Prevent users from bypassing the EULA shown on first run by killing setup.exe.robertshield@chromium.org2011-07-131-1/+2
| | | | | | | | BUG=88542 TEST=NONE Review URL: http://codereview.chromium.org/7250013 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@92368 0039d316-1c4b-4281-b951-d872f2087c98
generated by cgit v1.1 at 2025-03-19 11:58:28 +0000