| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
|
|
|
|
| |
This is the type of bubble now used in organic installs, i.e. all Linux installs.
BUG=49705
TEST=run with --first-run
Review URL: http://codereview.chromium.org/3203013
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@57755 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
existing preferences file.
LGTM from Glen in http://codereview.chromium.org/3232001/show for patch to 472 branch.
BUG=53485
TEST=search engine dialog works and appears only when user does not have a previously existing user data directory. If user has already run Chrome and set up a user data directory, dialog should not appear, and search engines should be silently imported (in organic builds).
Review URL: http://codereview.chromium.org/3242004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@57685 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The first run checkbox that asks the user for their agreement to send stats and
crash reports to Google should be hidden if that decision has been made by the
administrator through configuration management. Also remove a DCHECK that
tested for the crash reporter not being initialized during first run, since it
may be present in case configuration management is in effect.
BUG=49917
TEST=Configure MetricsReportingEnabled policy and trigger a first run, check UI.
Review URL: http://codereview.chromium.org/3152050
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@57494 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
Rename includes, resort header include order in places where the rename
changed the order.
BUG=50548
TEST=compiles
Review URL: http://codereview.chromium.org/3203008
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@57434 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Factor out the common code so that Mac and Linux may share the new flow with Windows (e.g., import is done before the first run dialog appears).
Windows *should* be unaffected by this change. Linux has some non-user-visible changes. The user visible changes (showing the default search engine in the ballot, for example) are TODO.
BUG=49705,47651
TEST=launching chromium with --first-run works as expected, i.e. it imports stuff from your default browser (such as history); if that browser is firefox and firefox is open, the failure is silent.
Review URL: http://codereview.chromium.org/3171029
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@57421 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
(http://codereview.chromium.org/2903014/show), so that it will work with new first run sequence on Windows and Mac.
BUG=44901
TEST=in bug
Review URL: http://codereview.chromium.org/3148001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@57099 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=52378
TEST=organic first run should show welcome page. run with skip_first_run_ui should not show welcome page unless forced by master_preferences.
Review URL: http://codereview.chromium.org/3151026
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@56614 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
skip-first-run-ui preference has been set in master_preferences.
BUG=52632
TEST=test master_preferences import settings (import_search_engine, import_bookmarks, import_home_page, import_history). test with organic and non-organic builds, and with skip-first-run-ui turned on for non-organic builds. should follow pattern described in go/chromefirstrun.
Review URL: http://codereview.chromium.org/3186008
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@56574 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
in, if the default search engine imported is not included in the first three shown in the search engine dialog, it will appear as a fourth choice.
BUG=52496
TEST=search engines are imported in organic builds.
Review URL: http://codereview.chromium.org/3181019
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@56449 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
first_run was set to 1 from one unit test,
there is no way for other unit tests to change the first_run state regardless first_run_sentinel exists or not.
In this case, IsChromeFirstRun already return true which may not be desirable for some unit test such as Toolbar5ImporterTest::BookmarkParse.
The issue won't cause any problem if all unit tests were run separately instead of in a single unit_test.exe.
But the change itself is minimal, and allow future unit tests for IsChromeFirstRun itself.
Bug=None
Test=None
Review URL: http://codereview.chromium.org/3038024
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@56197 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=23581
TEST=builds and passes tests
Review URL: http://codereview.chromium.org/3117017
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@56187 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=builds
Review URL: http://codereview.chromium.org/3179017
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@56171 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
Make use of Environment::SetVar API to replace the calls to the
Windows function SetEnvironmentVariable.
BUG=None
TEST=trybots
Review URL: http://codereview.chromium.org/3076042
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@55993 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=48862
TEST=exceptions lists work for types besides images
Review URL: http://codereview.chromium.org/3035060
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@55515 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/2819094
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@55345 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/3057033
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@55176 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=50577
TEST= run chrome first_run with import while Firefox is default browser and open. Dialog should pop up telling user to close FF.
Review URL: http://codereview.chromium.org/2868077
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@54920 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/3005053
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@54856 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
TEST=none
BUG=none
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@54749 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
TEST=it compiles
BUG=none
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@54748 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
string_number_conversions.
TEST=it compiles
BUG=none
Review URL: http://codereview.chromium.org/3054036
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@54747 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/3066014
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@54437 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
Removes some wstrings.
BUG=24672
Review URL: http://codereview.chromium.org/2819080
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@54338 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
(Just a first step. I can't remove GetTempDir yet though.)
BUG=none
TEST=unit tests
http://codereview.chromium.org/3075008/show
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@54316 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
For this patch, I skipped over any instance where it wasn't a nearly trivial
change.
Review URL: http://codereview.chromium.org/3069014
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@54285 0039d316-1c4b-4281-b951-d872f2087c98
|
|
BUG=50548
Review URL: http://codereview.chromium.org/3043030
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@54226 0039d316-1c4b-4281-b951-d872f2087c98
|