summaryrefslogtreecommitdiffstats
path: root/chrome/browser/first_run
Commit message (Collapse)AuthorAgeFilesLines
* Refactoring the master_preferences functions.tommi@chromium.org2010-11-031-41/+48
| | | | | | | | | | | | | | | | | | | | | * Now there's a class named MasterPreferences that owns the json dictionary and supports methods that previously were global. * There's now a global object for the current process' master preference object, which avoids parsing the preference file multiple times. * Refactored the tests to be more data driven TEST=Run the installer util unit tests. Set the filter to *MasterPref* if you only want to run the tests affected by this change. BUG=none Review URL: http://codereview.chromium.org/4342001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@64945 0039d316-1c4b-4281-b951-d872f2087c98
* Fix type inconsistency with StartImportingWithUI and ProfileInfo.tfarina@chromium.org2010-11-021-1/+1
| | | | | | | | | BUG=28153 TEST=compiles locally and trybots Review URL: http://codereview.chromium.org/4282003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@64801 0039d316-1c4b-4281-b951-d872f2087c98
* Convert implicit scoped_refptr constructor calls to explicit ones, part 1thakis@chromium.org2010-11-011-1/+1
| | | | | | | | | | | This CL was created automatically by this clang rewriter: http://codereview.appspot.com/2776043/ . I manually fixed a few rough spots of the rewriter output (doh1-3) and fixed all presubmit errors. BUG=28083 TEST=None Review URL: http://codereview.chromium.org/4192012 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@64573 0039d316-1c4b-4281-b951-d872f2087c98
* Convert LOG(INFO) to VLOG(1) - misc. chrome/browser/*/*.pkasting@chromium.org2010-10-211-3/+3
| | | | | | | | BUG=none TEST=none Review URL: http://codereview.chromium.org/4009001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@63420 0039d316-1c4b-4281-b951-d872f2087c98
* If default search is managed, we should not asked the user to choose it at ↵jeanluc@google.com2010-10-193-7/+32
| | | | | | | | | | | | | | First Run. Make sure the minimum bubble is not showed if there is no default search. This is a re-issue of CL 3565013 without the extraneous change to search_engine_list_model.mm, to be done in a forthcoming CL> BUG=49306 TEST=Set a managed default search provider. Clear your Chromium user data directory (~/Library/Chromium, ~/.config/chromium, %localappdata%\Chromium) and the "First Run" file found next to the executable. Start Chrome. It should not ask you to choose a default search provider. Disable the default search provider via policy. Make sure the minimal bubble is not shown. Redo these tests for the GOOGLE_CHROME_BUILD to make sure that we still ask about usage stats. Review URL: http://codereview.chromium.org/3847006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@63024 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 63005 - If default search is managed, we should not asked the user to ↵tyoshino@chromium.org2010-10-193-32/+7
| | | | | | | | | | | | | | | choose it at First Run. Make sure the minimum bubble is not showed if there is no default search. BUG=49306 TEST=Set a managed default search provider. Clear your Chromium user data directory (~/Library/Chromium, ~/.config/chromium, %localappdata%\Chromium) and the "First Run" file found next to the executable. Start Chrome. It should not ask you to choose a default search provider. Disable the default search provider via policy. Make sure the minimal bubble is not shown. Redo these tests for the GOOGLE_CHROME_BUILD to make sure that we still ask about usage stats. Review URL: http://codereview.chromium.org/3565013 TBR=jeanluc@google.com Review URL: http://codereview.chromium.org/3747009 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@63016 0039d316-1c4b-4281-b951-d872f2087c98
* If default search is managed, we should not asked the user to choose it at ↵jeanluc@google.com2010-10-193-7/+32
| | | | | | | | | | | | First Run. Make sure the minimum bubble is not showed if there is no default search. BUG=49306 TEST=Set a managed default search provider. Clear your Chromium user data directory (~/Library/Chromium, ~/.config/chromium, %localappdata%\Chromium) and the "First Run" file found next to the executable. Start Chrome. It should not ask you to choose a default search provider. Disable the default search provider via policy. Make sure the minimal bubble is not shown. Redo these tests for the GOOGLE_CHROME_BUILD to make sure that we still ask about usage stats. Review URL: http://codereview.chromium.org/3565013 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@63005 0039d316-1c4b-4281-b951-d872f2087c98
* Move pe_image and registry from base to base/win and use the namespace. It ↵brettw@chromium.org2010-10-171-2/+2
| | | | | | | | | | | | removes windows_message_list which isn't used. This keeps a stub for registry in the old location until we can update that. TEST=it compiles BUG=none Review URL: http://codereview.chromium.org/3836005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@62888 0039d316-1c4b-4281-b951-d872f2087c98
* Move windows version-related stuff out of base/win_util and into ↵brettw@chromium.org2010-10-151-2/+2
| | | | | | | | | | | | | | base/win/windows_version. Many files now only need to include this instead of all of win_util. Remove a bunch of unused code from base/win_util. There was a surprising amount. Replace the AppUserModel property key with the one from the SDK now that we use the Win7 SDK. Move GetLogonSessionOnlyDACL from win_util to ipc since it's only used in that one place. TEST=it compiles BUG=none Review URL: http://codereview.chromium.org/3823002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@62694 0039d316-1c4b-4281-b951-d872f2087c98
* base: Move SplitString functions into the base namespace and update the callers.tfarina@chromium.org2010-10-141-1/+1
| | | | | | | | | BUG=None TEST=trybots Review URL: http://codereview.chromium.org/3750001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@62483 0039d316-1c4b-4281-b951-d872f2087c98
* Import locally saved IE Tolbar Autofill datageorgey@chromium.org2010-10-122-0/+20
| | | | | | | | BUG=49084 TEST=Should automatically import the data on fresh install of Chrome. Review URL: http://codereview.chromium.org/3367016 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@62232 0039d316-1c4b-4281-b951-d872f2087c98
* Initialize MasterPrefs structure.avi@chromium.org2010-10-061-1/+9
| | | | | | | | | | CID=13304 BUG=none TEST=none Review URL: http://codereview.chromium.org/3607009 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@61676 0039d316-1c4b-4281-b951-d872f2087c98
* FBTF: Continue fixing nits found by my automated source scanner.erg@google.com2010-10-052-3/+16
| | | | | | | | | | | (~1.3 megs off Debug linux .a files) BUG=none TEST=compiles Review URL: http://codereview.chromium.org/3556013 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@61587 0039d316-1c4b-4281-b951-d872f2087c98
* Wait for renaming chrome.exe to finish during shutdown forhuanr@chromium.org2010-09-281-14/+2
| | | | | | | | | | | | system level in use update. Also remove obsoleted code in this code path. BUG=55969 TEST=repro steps in BUG Review URL: http://codereview.chromium.org/3429029 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@60751 0039d316-1c4b-4281-b951-d872f2087c98
* Add search engine selection dialog for Mac, do new-style first-run.avi@chromium.org2010-09-274-204/+146
| | | | | | | | | | | | SearchEngineDialog.xib: creation FirstRunDialog.xib: removal of import and cancel UI elements BUG=47651 TEST=reset profile, run. Make sure goto/chromefirstrun is satisfied. Review URL: http://codereview.chromium.org/3223010 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@60699 0039d316-1c4b-4281-b951-d872f2087c98
* base: Finish moving the SplitString functions from string_util.h to ↵tfarina@chromium.org2010-09-241-0/+1
| | | | | | | | | | | string_split.h BUG=None TEST=trybos Review URL: http://codereview.chromium.org/3447008 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@60422 0039d316-1c4b-4281-b951-d872f2087c98
* Change the toast text and make sure errors are written tofinnur@chromium.org2010-09-101-8/+15
| | | | | | | | | | | | | | | | | | | HKLM too (not just success messages). The toast text changes are listed in the bug; basically we have 4 experiments that differ only in the text we display as a headline. I also fixed an issue raised by QA with error codes being written to HKCU as opposed to HKLM. This should fix that issue. BUG=http://crbug.com/54835, http://crbug.com/44378 TEST=Requires manual testing by QA. Review URL: http://codereview.chromium.org/3341026 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@59102 0039d316-1c4b-4281-b951-d872f2087c98
* Easy cleanup in first-run.avi@chromium.org2010-09-102-14/+2
| | | | | | | | | | BUG=none TEST=none Review URL: http://codereview.chromium.org/3290020 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@59090 0039d316-1c4b-4281-b951-d872f2087c98
* Moving file_util::FileInfo to base::PlatformFileInfo, and adding thedumi@chromium.org2010-09-031-1/+1
| | | | | | | | | | | | last_accessed and creation_time fields. BUG=none TEST=none Review URL: http://codereview.chromium.org/3347005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@58454 0039d316-1c4b-4281-b951-d872f2087c98
* Fix search engine import.mirandac@chromium.org2010-09-021-10/+11
| | | | | | | | | | | | | If the user has installed and then uninstalled Chrome, but not deleted their user data directory, a subsequent install will silently import default search engines, thus possibly giving the user a fresh install of Chrome with default search engine not Google. Fix: if the user has already set up a user data directory, don't import search engines. BUG=none TEST=import works for all the usual paths. also, specifically: install and then uninstall Chrome without deleting user data directory. set search engine in default browser to something other than Google. install Chrome again. search engines should not be imported, but should be whatever the user had been previously using in Chrome. Review URL: http://codereview.chromium.org/3315009 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@58391 0039d316-1c4b-4281-b951-d872f2087c98
* Set default browser AFTER import.mirandac@chromium.org2010-09-012-1/+12
| | | | | | | | | BUG=53655 TEST=set Firefox as default browser on Windows. Run Chrome with a fresh profile. Import from FF should occur. Review URL: http://codereview.chromium.org/3298004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@58176 0039d316-1c4b-4281-b951-d872f2087c98
* [GTK] implement minimal first run bubble.estade@chromium.org2010-08-281-3/+3
| | | | | | | | | | | This is the type of bubble now used in organic installs, i.e. all Linux installs. BUG=49705 TEST=run with --first-run Review URL: http://codereview.chromium.org/3203013 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@57755 0039d316-1c4b-4281-b951-d872f2087c98
* Modify search engine dialog to only appear if the user does not have an ↵mirandac@chromium.org2010-08-271-2/+7
| | | | | | | | | | | | | existing preferences file. LGTM from Glen in http://codereview.chromium.org/3232001/show for patch to 472 branch. BUG=53485 TEST=search engine dialog works and appears only when user does not have a previously existing user data directory. If user has already run Chrome and set up a user data directory, dialog should not appear, and search engines should be silently imported (in organic builds). Review URL: http://codereview.chromium.org/3242004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@57685 0039d316-1c4b-4281-b951-d872f2087c98
* [mac] Hide stats opt-in in first run if controlled by policymnissler@chromium.org2010-08-261-21/+14
| | | | | | | | | | | | | | | The first run checkbox that asks the user for their agreement to send stats and crash reports to Google should be hidden if that decision has been made by the administrator through configuration management. Also remove a DCHECK that tested for the crash reporter not being initialized during first run, since it may be present in case configuration management is in effect. BUG=49917 TEST=Configure MetricsReportingEnabled policy and trigger a first run, check UI. Review URL: http://codereview.chromium.org/3152050 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@57494 0039d316-1c4b-4281-b951-d872f2087c98
* Move prefs-related files under chrome/browser/ into a prefs/ subdir.evan@chromium.org2010-08-262-2/+2
| | | | | | | | | | | | Rename includes, resort header include order in places where the rename changed the order. BUG=50548 TEST=compiles Review URL: http://codereview.chromium.org/3203008 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@57434 0039d316-1c4b-4281-b951-d872f2087c98
* Refactor new first run control flow.estade@chromium.org2010-08-254-95/+210
| | | | | | | | | | | | | Factor out the common code so that Mac and Linux may share the new flow with Windows (e.g., import is done before the first run dialog appears). Windows *should* be unaffected by this change. Linux has some non-user-visible changes. The user visible changes (showing the default search engine in the ballot, for example) are TODO. BUG=49705,47651 TEST=launching chromium with --first-run works as expected, i.e. it imports stuff from your default browser (such as history); if that browser is firefox and firefox is open, the failure is silent. Review URL: http://codereview.chromium.org/3171029 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@57421 0039d316-1c4b-4281-b951-d872f2087c98
* Reworked Avi's patch for master prefs implemented on mac ↵mirandac@chromium.org2010-08-235-327/+298
| | | | | | | | | | | (http://codereview.chromium.org/2903014/show), so that it will work with new first run sequence on Windows and Mac. BUG=44901 TEST=in bug Review URL: http://codereview.chromium.org/3148001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@57099 0039d316-1c4b-4281-b951-d872f2087c98
* Open welcome page on first run.mirandac@chromium.org2010-08-181-0/+1
| | | | | | | | | BUG=52378 TEST=organic first run should show welcome page. run with skip_first_run_ui should not show welcome page unless forced by master_preferences. Review URL: http://codereview.chromium.org/3151026 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@56614 0039d316-1c4b-4281-b951-d872f2087c98
* Ensure that import works according to the chart in go/chromefirstrun when ↵mirandac@chromium.org2010-08-181-21/+47
| | | | | | | | | | | | skip-first-run-ui preference has been set in master_preferences. BUG=52632 TEST=test master_preferences import settings (import_search_engine, import_bookmarks, import_home_page, import_history). test with organic and non-organic builds, and with skip-first-run-ui turned on for non-organic builds. should follow pattern described in go/chromefirstrun. Review URL: http://codereview.chromium.org/3186008 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@56574 0039d316-1c4b-4281-b951-d872f2087c98
* Import search engines on first run in organic builds. Once this patch is ↵mirandac@chromium.org2010-08-171-30/+33
| | | | | | | | | | in, if the default search engine imported is not included in the first three shown in the search engine dialog, it will appear as a fourth choice. BUG=52496 TEST=search engines are imported in organic builds. Review URL: http://codereview.chromium.org/3181019 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@56449 0039d316-1c4b-4281-b951-d872f2087c98
* Fix a subtle issue/bug for unit tests to use IsChromeFirstRun. Once ↵jorlow@chromium.org2010-08-162-6/+15
| | | | | | | | | | | | | | | | | first_run was set to 1 from one unit test, there is no way for other unit tests to change the first_run state regardless first_run_sentinel exists or not. In this case, IsChromeFirstRun already return true which may not be desirable for some unit test such as Toolbar5ImporterTest::BookmarkParse. The issue won't cause any problem if all unit tests were run separately instead of in a single unit_test.exe. But the change itself is minimal, and allow future unit tests for IsChromeFirstRun itself. Bug=None Test=None Review URL: http://codereview.chromium.org/3038024 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@56197 0039d316-1c4b-4281-b951-d872f2087c98
* Remove deprecated wstring Get(As)String() methods from Value, etc.viettrungluu@chromium.org2010-08-162-5/+9
| | | | | | | | | BUG=23581 TEST=builds and passes tests Review URL: http://codereview.chromium.org/3117017 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@56187 0039d316-1c4b-4281-b951-d872f2087c98
* FBTF: Remove "obviously" unneeded standard C++ library #includes.viettrungluu@chromium.org2010-08-151-1/+0
| | | | | | | | | BUG=none TEST=builds Review URL: http://codereview.chromium.org/3179017 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@56171 0039d316-1c4b-4281-b951-d872f2087c98
* Use Environment::SetVar in more places.tfarina@chromium.org2010-08-131-3/+5
| | | | | | | | | | | | Make use of Environment::SetVar API to replace the calls to the Windows function SetEnvironmentVariable. BUG=None TEST=trybots Review URL: http://codereview.chromium.org/3076042 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@55993 0039d316-1c4b-4281-b951-d872f2087c98
* Content settings: generalize the exceptions lists for all settings types.estade@chromium.org2010-08-101-1/+4
| | | | | | | | | BUG=48862 TEST=exceptions lists work for types besides images Review URL: http://codereview.chromium.org/3035060 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@55515 0039d316-1c4b-4281-b951-d872f2087c98
* FBTF: Remove unneeded headers from base/ (part 4)thestig@chromium.org2010-08-071-0/+1
| | | | | | | | BUG=none TEST=none Review URL: http://codereview.chromium.org/2819094 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@55345 0039d316-1c4b-4281-b951-d872f2087c98
* Remove GetSwitchValue() from chrome/* where easy.evan@chromium.org2010-08-061-2/+2
| | | | | | Review URL: http://codereview.chromium.org/3057033 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@55176 0039d316-1c4b-4281-b951-d872f2087c98
* Fix Firefox import lock dialog on Windows.mirandac@chromium.org2010-08-042-15/+24
| | | | | | | | BUG=50577 TEST= run chrome first_run with import while Firefox is default browser and open. Dialog should pop up telling user to close FF. Review URL: http://codereview.chromium.org/2868077 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@54920 0039d316-1c4b-4281-b951-d872f2087c98
* Remove usage of GetSwitchValue for most of chrome/browser/.evan@chromium.org2010-08-041-8/+8
| | | | | | Review URL: http://codereview.chromium.org/3005053 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@54856 0039d316-1c4b-4281-b951-d872f2087c98
* Fix the Windows build again.brettw@chromium.org2010-08-031-0/+1
| | | | | | | TEST=none BUG=none git-svn-id: svn://svn.chromium.org/chrome/trunk/src@54749 0039d316-1c4b-4281-b951-d872f2087c98
* Fix the Windows build.brettw@chromium.org2010-08-031-3/+5
| | | | | | | TEST=it compiles BUG=none git-svn-id: svn://svn.chromium.org/chrome/trunk/src@54748 0039d316-1c4b-4281-b951-d872f2087c98
* Remove number conversion functions from string_util. These moved to ↵brettw@chromium.org2010-08-031-3/+4
| | | | | | | | | | string_number_conversions. TEST=it compiles BUG=none Review URL: http://codereview.chromium.org/3054036 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@54747 0039d316-1c4b-4281-b951-d872f2087c98
* Cleanup: Remove unneeded headers from app/ (part 2)thestig@chromium.org2010-07-311-1/+0
| | | | | | | | BUG=none TEST=none Review URL: http://codereview.chromium.org/3066014 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@54437 0039d316-1c4b-4281-b951-d872f2087c98
* Use a few more FilePaths in bookmark import.evan@chromium.org2010-07-303-11/+12
| | | | | | | | | | Removes some wstrings. BUG=24672 Review URL: http://codereview.chromium.org/2819080 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@54338 0039d316-1c4b-4281-b951-d872f2087c98
* Fix some bad uses of GetTempDir.agl@chromium.org2010-07-301-4/+5
| | | | | | | | | | | (Just a first step. I can't remove GetTempDir yet though.) BUG=none TEST=unit tests http://codereview.chromium.org/3075008/show git-svn-id: svn://svn.chromium.org/chrome/trunk/src@54316 0039d316-1c4b-4281-b951-d872f2087c98
* Convert a bunch of easy AppendSwitchWithValue to *ASCII.evan@chromium.org2010-07-302-14/+11
| | | | | | | | | For this patch, I skipped over any instance where it wasn't a nearly trivial change. Review URL: http://codereview.chromium.org/3069014 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@54285 0039d316-1c4b-4281-b951-d872f2087c98
* Move browser/first_run* into into a subdirectory.evan@chromium.org2010-07-297-0/+1995
BUG=50548 Review URL: http://codereview.chromium.org/3043030 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@54226 0039d316-1c4b-4281-b951-d872f2087c98
generated by cgit v1.1 at 2025-03-11 09:07:43 +0000