summaryrefslogtreecommitdiffstats
path: root/chrome/browser/first_run_win.cc
Commit message (Collapse)AuthorAgeFilesLines
* Remove more occurrences of FromWStringHack from code base.tfarina@chromium.org2010-05-311-7/+7
| | | | | | | | | BUG=24672 TEST=trybots Review URL: http://codereview.chromium.org/2401001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@48584 0039d316-1c4b-4281-b951-d872f2087c98
* Slight cleanup of some first-run/master-prefs stuff.viettrungluu@chromium.org2010-05-271-11/+6
| | | | | | | | | | | | | | | | | - let AddFirstRunNewTabs() run as elsewhere on Mac (the list of first-run tabs will be empty) - move various #if defined(OS_MACOSX) stuff to (existing!) Mac-specific files instead - remove an essentially-unused argument to FirstRun::ProcessMasterPreferences() (the location of the master prefs was never specified, so the standard location was always used) BUG=none TEST=everything still works Review URL: http://codereview.chromium.org/2077025 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@48345 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 47675.mirandac@chromium.org2010-05-201-1/+1
| | | | | | | | | | Instead of moving data types into common/, create a special class of IPC messages that live in the browser directory, specifically for importing browser-related data. BUG=18774 TEST=none Review URL: http://codereview.chromium.org/2095020 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@47827 0039d316-1c4b-4281-b951-d872f2087c98
* Move data types used in the importer process to common/, in preparation for ↵mirandac@chromium.org2010-05-191-1/+1
| | | | | | | | | | | import to run out of process. BUG= 18774 TEST= none. Review URL: http://codereview.chromium.org/2106015 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@47675 0039d316-1c4b-4281-b951-d872f2087c98
* Using different Version environment variable for SxS.huanr@chromium.org2010-05-191-1/+3
| | | | | | | | | | | BUG=44474 TEST=mini_installer.exe --chrome-sxs. The first run should start regardless what is set for CHROME_VERSION. Review URL: http://codereview.chromium.org/2101006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@47600 0039d316-1c4b-4281-b951-d872f2087c98
* Eliminate View::UILayoutIsRightToLeft() to standardize on ↵pkasting@chromium.org2010-05-101-3/+2
| | | | | | | | | | base::i18n::IsRTL(). Was only needed for EnableUIMirroringForRTLLanguages(), which was only used by Views::Label, which already had this capability via set_rtl_alignment_mode(). BUG=none TEST=none Review URL: http://codereview.chromium.org/1991002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@46869 0039d316-1c4b-4281-b951-d872f2087c98
* r46025 reverted r46023 which caused a build break on chromeos.prasadt@chromium.org2010-04-301-1/+14
| | | | | | | | | | | | | | | This change reverts r46025 and fixes the build break which is just a one line change in chrome/browser/first_run_gtk.cc to move the definition of Upgrade::new_command_line_ to be inside a #if. Details on the change and code review feedback for the original CL can be found at http://codereview.chromium.org/1633021. BUG=40975 TEST=none Review URL: http://codereview.chromium.org/1691022 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@46103 0039d316-1c4b-4281-b951-d872f2087c98
* Revert r46023: "Detect new instance of the browser when running in the ↵willchan@chromium.org2010-04-301-14/+1
| | | | | | | | | | background in persistent" Broke the build. Review URL: http://codereview.chromium.org/1718024 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@46025 0039d316-1c4b-4281-b951-d872f2087c98
* Detect new instance of the browser when running in the background in persistentprasadt@chromium.org2010-04-301-1/+14
| | | | | | | | | | | | | | | | | | mode, shutdown and restart the new instance. This is already done for Windows, this CL enables the functionality for Linux. We don't yet have a unit test for this. Local testing is done by: 1) Reducing the timer to 30 seconds. 2) Changing BrowserList::IsInPersistentMode to return true. 3) Setting BrowserProcessImpl::autoupdate_timer_ to 30 seconds interval. 4) Running "touch" command on chrome exe to pretend there is an update. BUG=40975 TEST=none Review URL: http://codereview.chromium.org/1633021 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@46023 0039d316-1c4b-4281-b951-d872f2087c98
* Check for proper locale before recording search engine data, or offering the ↵mirandac@chromium.org2010-04-211-1/+16
| | | | | | | | | | | search engine experimental dialog. BUG= 37564 TEST= none Review URL: http://codereview.chromium.org/1709003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@45129 0039d316-1c4b-4281-b951-d872f2087c98
* Add new search engine dialog for first run process.mirandac@chromium.org2010-04-131-5/+22
| | | | | | | | | | BUG= 37564 TEST= start Chrome with --first-run enabled -- you should see a new search engine selection dialog. Review URL: http://codereview.chromium.org/1586005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@44416 0039d316-1c4b-4281-b951-d872f2087c98
* Auto restart when update available while running in the background on windows.atwilson@chromium.org2010-04-091-0/+20
| | | | | | | | | | | | | | | | | | | | | | | | Landing on behalf of dbelenko@google.com. This is a new version of the older patch. Main changes include: 1. Rebased to a never Git revision to make things easier to land. 2. Chrome will now preserve the command line switches except for those that are blacklisted. 3. Fixed a race condition that would cause the browser to think it didn't exit cleanly after it's been restarted. 4. Fixed minor nits and omissions (indentation, etc). This patch adds a timer which fires every 6 hours and checks whether the browser is in the "persistent" (background) mode, and whether there's an update pending restart. If both conditions are true, the browser is restarted with blacklisted command line keys and all loose values stripped. In order to restart the browser in the background mode, the --long-lived-extensions key is also added to the command line. This change is Windows-only, and it won't become fully functional until Drew (atwilson) checks in his work that enables Chrome to go into background. Additionally, this addresses an issue where a restarted browser might load its profile data before the previous browser process exited - we now load the profile data *after* trying to contact the other browser. This exposed a race condition in SessionRestoreUITest.RestoreAfterClosingTabbedBrowserWithAppAndLaunching, so we disabled that test and logged http://crbug.com/40946. BUG=40975,40946 Review URL: http://codereview.chromium.org/1618012 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@44121 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 43989 - This is a new version of the older patch. Main changes include:atwilson@chromium.org2010-04-091-20/+0
| | | | | | | | | | | | | | | | | | | | | | | | | | 1. Rebased to a never Git revision to make things easier to land. 2. Chrome will now preserve the command line switches except for those that are blacklisted. 3. Fixed a race condition that would cause the browser to think it didn't exit cleanly after it's been restarted. 4. Fixed minor nits and omissions (indentation, etc). This patch adds a timer which fires every 6 hours and checks whether the browser is in the "persistent" (background) mode, and whether there's an update pending restart. If both conditions are true, the browser is restarted with blacklisted command line keys and all loose values stripped. In order to restart the browser in the background mode, the longlivedextensions key is also added to the command line. This change is Windowsonly, and it won't become fully functional until Drew (atwilson) checks in his work that enables Chrome to go into background. Review URL: http://codereview.chromium.org/1617001 TBR=atwilson@chromium.org Review URL: http://codereview.chromium.org/1517027 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@44041 0039d316-1c4b-4281-b951-d872f2087c98
* This is a new version of the older patch. Main changes include:atwilson@chromium.org2010-04-081-0/+20
| | | | | | | | | | | | | | | | | | | | | | | 1. Rebased to a never Git revision to make things easier to land. 2. Chrome will now preserve the command line switches except for those that are blacklisted. 3. Fixed a race condition that would cause the browser to think it didn't exit cleanly after it's been restarted. 4. Fixed minor nits and omissions (indentation, etc). This patch adds a timer which fires every 6 hours and checks whether the browser is in the "persistent" (background) mode, and whether there's an update pending restart. If both conditions are true, the browser is restarted with blacklisted command line keys and all loose values stripped. In order to restart the browser in the background mode, the --long-lived-extensions key is also added to the command line. This change is Windows-only, and it won't become fully functional until Drew (atwilson) checks in his work that enables Chrome to go into background. Review URL: http://codereview.chromium.org/1617001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@43989 0039d316-1c4b-4281-b951-d872f2087c98
* Port the option to import bookmarks from a file to Linuxevan@chromium.org2010-04-011-78/+1
| | | | | | | | | | | | | | | | | | | | | | | - Call ImportNow from browser_main.cc - Move necessary functions and a class from first_run_win.cc to first_run.cc and update first_run.h accordingly. - Add some #defines for different OSes and some TODO(port) comments. These changes will allow the use of the --import-from-file option to import bookmarks from a file at first run. I have built and tested this on Linux and Windows. BUG=32728 TEST=run with --import-from-file Patch from Brian G. Merrell <bgmerrell@gmail.com> Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=43277 Review URL: http://codereview.chromium.org/1515004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@43294 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 43277 - Port the option to import bookmarks from a file to Linuxarv@chromium.org2010-03-311-1/+78
| | | | | | | | | | | | | | | | | | | | | | | | | | | Call ImportNow from browser_main.cc Move necessary functions and a class from first_run_win.cc to first_run.cc and update first_run.h accordingly. Add some #defines for different OSes and some TODO(port) comments. These changes will allow the use of the importfromfile option to import bookmarks from a file at first run. I have built and tested this on Linux and Windows. BUG=32728 TEST=run with importfromfile Patch from Brian G. Merrell <bgmerrell@gmail.com> Review URL: http://codereview.chromium.org/1515004 TBR=evan@chromium.org This broke BookmarkBarGtkBrowserTest.ClickOnFloatingTest Review URL: http://codereview.chromium.org/1591005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@43285 0039d316-1c4b-4281-b951-d872f2087c98
* Port the option to import bookmarks from a file to Linuxevan@chromium.org2010-03-311-78/+1
| | | | | | | | | | | | | | | | | | | | | - Call ImportNow from browser_main.cc - Move necessary functions and a class from first_run_win.cc to first_run.cc and update first_run.h accordingly. - Add some #defines for different OSes and some TODO(port) comments. These changes will allow the use of the --import-from-file option to import bookmarks from a file at first run. I have built and tested this on Linux and Windows. BUG=32728 TEST=run with --import-from-file Patch from Brian G. Merrell <bgmerrell@gmail.com> Review URL: http://codereview.chromium.org/1515004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@43277 0039d316-1c4b-4281-b951-d872f2087c98
* Add import_bookmarks_from_file option to master pref thathuanr@chromium.org2010-03-241-5/+26
| | | | | | | | | | | sliently import bookmarks from file in first run. BUG=32728 TEST=unit test Review URL: http://codereview.chromium.org/1257001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42545 0039d316-1c4b-4281-b951-d872f2087c98
* Add the option of importing bookmarks from file to first run.huanr@chromium.org2010-03-221-1/+43
| | | | | | | | | BUG=32728 TEST=run with --import-from-file Review URL: http://codereview.chromium.org/1077007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42266 0039d316-1c4b-4281-b951-d872f2087c98
* Move importer data types into a separate file to prepare for moving importermirandac@chromium.org2010-03-221-6/+7
| | | | | | | | | | into its own process. BUG= 18774 TEST= none Review URL: http://codereview.chromium.org/1110005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42224 0039d316-1c4b-4281-b951-d872f2087c98
* Allow the use of the master_preferences file in Linux.tony@chromium.org2010-03-101-13/+2
| | | | | | | | | | | | | | | Also refactor FirstRunTabs to use GURL instead of wstring. BUG=none TEST=Add master_preferences file to directory containing the chrome binary and execute chrome with the --first-run option. Original patch by bgmerrell@gmail.com at http://codereview.chromium.org/551160 Review URL: http://codereview.chromium.org/796001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@41131 0039d316-1c4b-4281-b951-d872f2087c98
* Add support for auto-installing extensions at first run via master prefscpu@chromium.org2010-03-081-0/+56
| | | | | | | | | | | | | | | | | | This a even lower impact method, with no new fields added. This is how it works: 1- The extension pared down manifest goes into the master prefs 2- The master prefs become the prefs at first run 3- First run notices an extensions block, an triggers an extensions check 4- The full extension gets updated then BUG=37573 TEST=ut included, also see bug Review URL: http://codereview.chromium.org/669218 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@40914 0039d316-1c4b-4281-b951-d872f2087c98
* First part of the pre-set bookmarks featurecpu@chromium.org2010-02-261-22/+15
| | | | | | | | | | | | | | - master prefs format (just url) - defer actual bookmark fu, because early on the bookmarkmodel and other services are not yet running. - cleanup master prefs test, too much code duplication - cleanup ProcessMasterPreferences it had too many params BUG=32728 TEST=unit test included Review URL: http://codereview.chromium.org/660116 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@40150 0039d316-1c4b-4281-b951-d872f2087c98
* Fix for crash on early return from browser_main.cccpu@chromium.org2010-02-231-0/+5
| | | | | | | | | | | | | | | | BrowserImpl dtor assumes full construction of all sub-objects, this is not true at least in one case (the try chrome again toast). See bug for more details - Added a UI test to detect these shenaningans in all platforms - had to hack ui_tests a bit, I hope is palatable BUG=34799 TEST= UI test included Review URL: http://codereview.chromium.org/571017 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@39690 0039d316-1c4b-4281-b951-d872f2087c98
* Move pref_{member,service} and important_file_writer from chrome/commonphajdan.jr@chromium.org2010-02-191-1/+1
| | | | | | | | | | | | | to chrome/browser. This is a part of an effort to remove bad dependency of chrome/common on chrome/browser. TEST=unit_tests and ui_tests, just moving code BUG=none Review URL: http://codereview.chromium.org/621004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@39428 0039d316-1c4b-4281-b951-d872f2087c98
* Position the the inactive toast to the left in RTL machines.cpu@chromium.org2010-01-211-4/+8
| | | | | | | | | BUG=32474 TEST=see bug for details Review URL: http://codereview.chromium.org/545144 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@36762 0039d316-1c4b-4281-b951-d872f2087c98
* New headline for the inactive toast dialogcpu@chromium.org2010-01-191-1/+7
| | | | | | | | | | | - features extensions for US only installs. BUG=32474 TEST= see bug for details Review URL: http://codereview.chromium.org/553010 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@36529 0039d316-1c4b-4281-b951-d872f2087c98
* Fix a case where we try to get the homepage as a boolean value, whentony@chromium.org2009-12-101-2/+4
| | | | | | | | | it should be a string. Since we tried to get the pref as the wrong type, we never set the value homepage_defined so it's always false. Review URL: http://codereview.chromium.org/491008 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@34270 0039d316-1c4b-4281-b951-d872f2087c98
* Remove IsPrefRegistered function from PrefService API and fix the callers totony@chromium.org2009-12-071-1/+1
| | | | | | | | | | | | | | call FindPreference directly. BUG=None TEST=compiles and passes existing tests Original patch by Thiago Farina <thiago.farina@gmail.com> at http://codereview.chromium.org/460117/show Review URL: http://codereview.chromium.org/463044 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@34010 0039d316-1c4b-4281-b951-d872f2087c98
* Add -profile command line switchdavemoore@chromium.org2009-11-301-1/+1
| | | | | | Review URL: http://codereview.chromium.org/384062 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@33335 0039d316-1c4b-4281-b951-d872f2087c98
* Making the toast localizedcpu@chromium.org2009-11-191-69/+29
| | | | | | | | | | | Current code had 4 flavors of non-localized strings, now we have selected one and localized BUG=none TEST=start chrome with --try-chrome-again=0 and observe. Review URL: http://codereview.chromium.org/399102 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32552 0039d316-1c4b-4281-b951-d872f2087c98
* Fix style issues in View class.maruel@chromium.org2009-11-071-1/+1
| | | | | | | | | | | BUG=None TEST=None Patch contributed by thiago.farina@gmail.com Review URL: http://codereview.chromium.org/338011 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31360 0039d316-1c4b-4281-b951-d872f2087c98
* Use GetSwitchValueASCII.tony@chromium.org2009-11-061-3/+3
| | | | | | | | | | | | BUG=24672 TEST=None Original patch by Thiago Farina <thiago.farina@gmail.com> at http://codereview.chromium.org/296004 Review URL: http://codereview.chromium.org/373013 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31269 0039d316-1c4b-4281-b951-d872f2087c98
* Push the Omaha app guid into the browser distribution classes to remove ↵robertshield@chromium.org2009-11-051-1/+2
| | | | | | | | compile-time differences between Chrome Frame and Chrome. Review URL: http://codereview.chromium.org/361023 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31073 0039d316-1c4b-4281-b951-d872f2087c98
* Continue to remove CHROME_FRAME_BUILD define from code that goes into ↵robertshield@chromium.org2009-11-041-0/+10
| | | | | | | | | | | | | | | | | | | | | chrome.dll. This reworks the browser distribution code to use the ChromeFrameBrowserDistribution iff --chrome-frame is present on the command line. Also, * At startup, chrome.exe now uses the BrowserDistribution code to determine where the Chromium version key resides (instead of hard coding it). * The installer now propagates the presence of --verbose-logging to uninstalls. * The chrome_launcher now allows the --chrome-frame switch through to chrome. * The installer now accepts a --chrome-frame switch. * Remove almost all occurences of the CHROME_FRAME_BUILD define from the installer. BUG=26012, 26603 TEST=Chrome Frame still builds and runs correctly. Chrome Frame builds built without 'branding'='Chrome' now install correctly. Review URL: http://codereview.chromium.org/345021 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31015 0039d316-1c4b-4281-b951-d872f2087c98
* Remove deprecated CommandLine(std::wstring) ctor.evan@chromium.org2009-10-261-2/+2
| | | | | | | | | | | Add a ctor for creating a CommandLine for carrying arguments; convert all the users to either that or the FilePath version. BUG=24672 Review URL: http://codereview.chromium.org/329017 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30117 0039d316-1c4b-4281-b951-d872f2087c98
* Remove +x bit from files that shouldn't have it.evan@chromium.org2009-10-201-0/+0
| | | | | | Review URL: http://codereview.chromium.org/307007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29548 0039d316-1c4b-4281-b951-d872f2087c98
* Make importer obey import_search_engine preference even if FRUI is enabled.kuchhal@chromium.org2009-10-191-7/+26
| | | | | | | | | | | | With this change importer will give preference to the value specified in master preference for import_search_engine instead of ignoring it like before. BUG=23649 TEST=Specified in above bug. Review URL: http://codereview.chromium.org/274081 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29426 0039d316-1c4b-4281-b951-d872f2087c98
* Make GetDistroBooleanPreference return troolean value.kuchhal@chromium.org2009-10-191-9/+17
| | | | | | | | | BUG=23649 TEST=installer_util_unittests, setup_unittests Review URL: http://codereview.chromium.org/269107 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29423 0039d316-1c4b-4281-b951-d872f2087c98
* Re-try r29078: Remove some deprecated file_util wstring functions.estade@chromium.org2009-10-151-1/+1
| | | | | | | | | | | | | With the previous patch, the try bots failed with mysterious messages, so I ignored them, patched it into my windows box and tested it there manually, and found no problems. As it turns out, the try failures were real :(. But nsylvain and I found the problem: the behavior of file_util::GetDirectoryFromPath() differs from DirName() when the path is empty (officially, GetDirectoryFromPath is not supposed to support non-absolute paths, but that is not enforced). Here is a green win try result: http://build.chromium.org/buildbot/try-server/builders/win/builds/3705 mac: http://build.chromium.org/buildbot/try-server/builders/mac/builds/3491 linux: http://build.chromium.org/buildbot/try-server/builders/linux/builds/3466 I also applied this patch locally in Windows to test that it doesn't break the chrome frame compile or tests, since that's not covered by the trybots yet. Review URL: http://codereview.chromium.org/271099 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29094 0039d316-1c4b-4281-b951-d872f2087c98
* Revert wstring patch (r29078 and follow up commits). It is causing failures ↵estade@chromium.org2009-10-151-1/+1
| | | | | | | | | | on the buildbots. TBR=nsylvain Review URL: http://codereview.chromium.org/280004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29085 0039d316-1c4b-4281-b951-d872f2087c98
* Remove some deprecated file_util wstring functions.estade@chromium.org2009-10-151-1/+1
| | | | | | | | | | | death to the wstring TEST=trybots BUG=none Review URL: http://codereview.chromium.org/276016 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29078 0039d316-1c4b-4281-b951-d872f2087c98
* Fix a whole bunch of style nits.erg@google.com2009-10-131-1/+1
| | | | | | | | (Long term intention is to add a subset of cpplint.py to the presubmit script.) Review URL: http://codereview.chromium.org/276008 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28914 0039d316-1c4b-4281-b951-d872f2087c98
* Use ASCII strings for switch names.evan@chromium.org2009-10-131-2/+2
| | | | | | Review URL: http://codereview.chromium.org/270062 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28779 0039d316-1c4b-4281-b951-d872f2087c98
* Fix for crasher on toast UIcpu@chromium.org2009-09-241-1/+1
| | | | | | | | | | | | | | | | | | | - The order of: radio_button = new views::RadioButton(..) layout->AddView(radio_button) radio_button->SetChecked(true); Matters, if the last two statements are inverted we crash (??) BUG=none TEST=start chrome with --try-chrome-again=1 and it does not crash and you see a toast Review URL: http://codereview.chromium.org/225019 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27101 0039d316-1c4b-4281-b951-d872f2087c98
* Fix crash during import by checking for errors and exiting early.kuchhal@chromium.org2009-09-221-2/+7
| | | | | | | | BUG=22055 Review URL: http://codereview.chromium.org/204051 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26824 0039d316-1c4b-4281-b951-d872f2087c98
* Add 3 more flavors of the try chrome toastcpu@chromium.org2009-09-091-20/+72
| | | | | | | | | | | | | - Different strings, pretty much the same deal. - One case removes the radio buttons. BUG=none TEST=none Review URL: http://codereview.chromium.org/198038 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25769 0039d316-1c4b-4281-b951-d872f2087c98
* Remove unused ATL headers.jhawkins@chromium.org2009-09-091-2/+0
| | | | | | | | BUG=5027 TEST=none Review URL: http://codereview.chromium.org/194051 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25761 0039d316-1c4b-4281-b951-d872f2087c98
* Use ScopedComPtr instead of CComPtr to reduce a dependency on ATL.jhawkins@chromium.org2009-09-041-2/+3
| | | | | | | | BUG=5027 TEST=none Review URL: http://codereview.chromium.org/201012 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25498 0039d316-1c4b-4281-b951-d872f2087c98
* Fix 9867: Activating the previous/next buttons with the keyboard in the find ↵finnur@chromium.org2009-09-031-1/+1
| | | | | | | | | | | | | bar should not change the focus. Add param const Event& event to ButtonPressed, so that recipients can find out more about the event that generated the ButtonPress message. BUG=9687 TEST=Open www.google.com and open Find-in-page, search for 'e'. Press FindNext button with mouse and note that the focus should be on the textfield. Now press Tab twice to put focus on the FindNext button and press SpaceBar a few times. Note that the focus should stay on the FindNext button. Review URL: http://codereview.chromium.org/188016 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25367 0039d316-1c4b-4281-b951-d872f2087c98
generated by cgit v1.1 at 2025-02-15 01:21:58 +0000