summaryrefslogtreecommitdiffstats
path: root/chrome/browser/first_run_win.cc
Commit message (Collapse)AuthorAgeFilesLines
* Fix a case where we try to get the homepage as a boolean value, whentony@chromium.org2009-12-101-2/+4
| | | | | | | | | it should be a string. Since we tried to get the pref as the wrong type, we never set the value homepage_defined so it's always false. Review URL: http://codereview.chromium.org/491008 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@34270 0039d316-1c4b-4281-b951-d872f2087c98
* Remove IsPrefRegistered function from PrefService API and fix the callers totony@chromium.org2009-12-071-1/+1
| | | | | | | | | | | | | | call FindPreference directly. BUG=None TEST=compiles and passes existing tests Original patch by Thiago Farina <thiago.farina@gmail.com> at http://codereview.chromium.org/460117/show Review URL: http://codereview.chromium.org/463044 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@34010 0039d316-1c4b-4281-b951-d872f2087c98
* Add -profile command line switchdavemoore@chromium.org2009-11-301-1/+1
| | | | | | Review URL: http://codereview.chromium.org/384062 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@33335 0039d316-1c4b-4281-b951-d872f2087c98
* Making the toast localizedcpu@chromium.org2009-11-191-69/+29
| | | | | | | | | | | Current code had 4 flavors of non-localized strings, now we have selected one and localized BUG=none TEST=start chrome with --try-chrome-again=0 and observe. Review URL: http://codereview.chromium.org/399102 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32552 0039d316-1c4b-4281-b951-d872f2087c98
* Fix style issues in View class.maruel@chromium.org2009-11-071-1/+1
| | | | | | | | | | | BUG=None TEST=None Patch contributed by thiago.farina@gmail.com Review URL: http://codereview.chromium.org/338011 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31360 0039d316-1c4b-4281-b951-d872f2087c98
* Use GetSwitchValueASCII.tony@chromium.org2009-11-061-3/+3
| | | | | | | | | | | | BUG=24672 TEST=None Original patch by Thiago Farina <thiago.farina@gmail.com> at http://codereview.chromium.org/296004 Review URL: http://codereview.chromium.org/373013 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31269 0039d316-1c4b-4281-b951-d872f2087c98
* Push the Omaha app guid into the browser distribution classes to remove ↵robertshield@chromium.org2009-11-051-1/+2
| | | | | | | | compile-time differences between Chrome Frame and Chrome. Review URL: http://codereview.chromium.org/361023 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31073 0039d316-1c4b-4281-b951-d872f2087c98
* Continue to remove CHROME_FRAME_BUILD define from code that goes into ↵robertshield@chromium.org2009-11-041-0/+10
| | | | | | | | | | | | | | | | | | | | | chrome.dll. This reworks the browser distribution code to use the ChromeFrameBrowserDistribution iff --chrome-frame is present on the command line. Also, * At startup, chrome.exe now uses the BrowserDistribution code to determine where the Chromium version key resides (instead of hard coding it). * The installer now propagates the presence of --verbose-logging to uninstalls. * The chrome_launcher now allows the --chrome-frame switch through to chrome. * The installer now accepts a --chrome-frame switch. * Remove almost all occurences of the CHROME_FRAME_BUILD define from the installer. BUG=26012, 26603 TEST=Chrome Frame still builds and runs correctly. Chrome Frame builds built without 'branding'='Chrome' now install correctly. Review URL: http://codereview.chromium.org/345021 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31015 0039d316-1c4b-4281-b951-d872f2087c98
* Remove deprecated CommandLine(std::wstring) ctor.evan@chromium.org2009-10-261-2/+2
| | | | | | | | | | | Add a ctor for creating a CommandLine for carrying arguments; convert all the users to either that or the FilePath version. BUG=24672 Review URL: http://codereview.chromium.org/329017 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30117 0039d316-1c4b-4281-b951-d872f2087c98
* Remove +x bit from files that shouldn't have it.evan@chromium.org2009-10-201-0/+0
| | | | | | Review URL: http://codereview.chromium.org/307007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29548 0039d316-1c4b-4281-b951-d872f2087c98
* Make importer obey import_search_engine preference even if FRUI is enabled.kuchhal@chromium.org2009-10-191-7/+26
| | | | | | | | | | | | With this change importer will give preference to the value specified in master preference for import_search_engine instead of ignoring it like before. BUG=23649 TEST=Specified in above bug. Review URL: http://codereview.chromium.org/274081 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29426 0039d316-1c4b-4281-b951-d872f2087c98
* Make GetDistroBooleanPreference return troolean value.kuchhal@chromium.org2009-10-191-9/+17
| | | | | | | | | BUG=23649 TEST=installer_util_unittests, setup_unittests Review URL: http://codereview.chromium.org/269107 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29423 0039d316-1c4b-4281-b951-d872f2087c98
* Re-try r29078: Remove some deprecated file_util wstring functions.estade@chromium.org2009-10-151-1/+1
| | | | | | | | | | | | | With the previous patch, the try bots failed with mysterious messages, so I ignored them, patched it into my windows box and tested it there manually, and found no problems. As it turns out, the try failures were real :(. But nsylvain and I found the problem: the behavior of file_util::GetDirectoryFromPath() differs from DirName() when the path is empty (officially, GetDirectoryFromPath is not supposed to support non-absolute paths, but that is not enforced). Here is a green win try result: http://build.chromium.org/buildbot/try-server/builders/win/builds/3705 mac: http://build.chromium.org/buildbot/try-server/builders/mac/builds/3491 linux: http://build.chromium.org/buildbot/try-server/builders/linux/builds/3466 I also applied this patch locally in Windows to test that it doesn't break the chrome frame compile or tests, since that's not covered by the trybots yet. Review URL: http://codereview.chromium.org/271099 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29094 0039d316-1c4b-4281-b951-d872f2087c98
* Revert wstring patch (r29078 and follow up commits). It is causing failures ↵estade@chromium.org2009-10-151-1/+1
| | | | | | | | | | on the buildbots. TBR=nsylvain Review URL: http://codereview.chromium.org/280004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29085 0039d316-1c4b-4281-b951-d872f2087c98
* Remove some deprecated file_util wstring functions.estade@chromium.org2009-10-151-1/+1
| | | | | | | | | | | death to the wstring TEST=trybots BUG=none Review URL: http://codereview.chromium.org/276016 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29078 0039d316-1c4b-4281-b951-d872f2087c98
* Fix a whole bunch of style nits.erg@google.com2009-10-131-1/+1
| | | | | | | | (Long term intention is to add a subset of cpplint.py to the presubmit script.) Review URL: http://codereview.chromium.org/276008 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28914 0039d316-1c4b-4281-b951-d872f2087c98
* Use ASCII strings for switch names.evan@chromium.org2009-10-131-2/+2
| | | | | | Review URL: http://codereview.chromium.org/270062 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28779 0039d316-1c4b-4281-b951-d872f2087c98
* Fix for crasher on toast UIcpu@chromium.org2009-09-241-1/+1
| | | | | | | | | | | | | | | | | | | - The order of: radio_button = new views::RadioButton(..) layout->AddView(radio_button) radio_button->SetChecked(true); Matters, if the last two statements are inverted we crash (??) BUG=none TEST=start chrome with --try-chrome-again=1 and it does not crash and you see a toast Review URL: http://codereview.chromium.org/225019 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27101 0039d316-1c4b-4281-b951-d872f2087c98
* Fix crash during import by checking for errors and exiting early.kuchhal@chromium.org2009-09-221-2/+7
| | | | | | | | BUG=22055 Review URL: http://codereview.chromium.org/204051 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26824 0039d316-1c4b-4281-b951-d872f2087c98
* Add 3 more flavors of the try chrome toastcpu@chromium.org2009-09-091-20/+72
| | | | | | | | | | | | | - Different strings, pretty much the same deal. - One case removes the radio buttons. BUG=none TEST=none Review URL: http://codereview.chromium.org/198038 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25769 0039d316-1c4b-4281-b951-d872f2087c98
* Remove unused ATL headers.jhawkins@chromium.org2009-09-091-2/+0
| | | | | | | | BUG=5027 TEST=none Review URL: http://codereview.chromium.org/194051 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25761 0039d316-1c4b-4281-b951-d872f2087c98
* Use ScopedComPtr instead of CComPtr to reduce a dependency on ATL.jhawkins@chromium.org2009-09-041-2/+3
| | | | | | | | BUG=5027 TEST=none Review URL: http://codereview.chromium.org/201012 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25498 0039d316-1c4b-4281-b951-d872f2087c98
* Fix 9867: Activating the previous/next buttons with the keyboard in the find ↵finnur@chromium.org2009-09-031-1/+1
| | | | | | | | | | | | | bar should not change the focus. Add param const Event& event to ButtonPressed, so that recipients can find out more about the event that generated the ButtonPress message. BUG=9687 TEST=Open www.google.com and open Find-in-page, search for 'e'. Press FindNext button with mouse and note that the focus should be on the textfield. Now press Tab twice to put focus on the FindNext button and press SpaceBar a few times. Note that the focus should stay on the FindNext button. Review URL: http://codereview.chromium.org/188016 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25367 0039d316-1c4b-4281-b951-d872f2087c98
* Do not import homepage on First Run if a homepage is given in master ↵kuchhal@chromium.org2009-08-111-2/+7
| | | | | | | | | | preferences. BUG=9048 Review URL: http://codereview.chromium.org/164291 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23085 0039d316-1c4b-4281-b951-d872f2087c98
* Use alternate icon for Chrome shortcuts if specified in master preferences.kuchhal@chromium.org2009-08-031-2/+8
| | | | | | | | | | | This change depends on change 159539 that is currently under review and a new chrome2.ico that is yet to be added to the repository. BUG=12701 TEST=Specify an alternate icon in --installerdata file and make sure that icon is used for shortcuts and it not changed later by updates. Review URL: http://codereview.chromium.org/159618 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22314 0039d316-1c4b-4281-b951-d872f2087c98
* Refactoring of master preferences parsing before adding a new preference.kuchhal@chromium.org2009-08-031-22/+26
| | | | | | | | | | | | | Currently we are parsing master preferences file three time on startup. Since we only return an int bit mask flag after parsing preferences, it can not handle any preference other than boolean and we end up reading it again for first run tabs and ping delay. This change refactors all the preferences parsing logic to directly pass around DictionaryValue object around in Chrome as well as installer. No functional change but this will make adding a new preference for new icon more logical since we will not read the preferences file once again. BUG=12701 TEST=Make sure all the distribution preferences still work as before. Review URL: http://codereview.chromium.org/159539 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22284 0039d316-1c4b-4281-b951-d872f2087c98
* This CL adds accelerators to the Linux toolkit views.jcampan@chromium.org2009-07-311-1/+1
| | | | | | | | | | | The MessageLoop had to be modified to support Dispatchers on Linux. BUG=None TEST=On Windows and Linux, make sure the accelerators still work as expected. On Linux toolkit views, build and run the unit-tests. Review URL: http://codereview.chromium.org/159046 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22210 0039d316-1c4b-4281-b951-d872f2087c98
* Revert changes from r22198 to r22204 and r22194. None of these changes werekuchhal@chromium.org2009-07-311-26/+22
| | | | | | | | | supposed to be commited. Seems like git took all the temporary commits from the base branch and uploaded them to svn. Review URL: http://codereview.chromium.org/159736 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22206 0039d316-1c4b-4281-b951-d872f2087c98
* cleanupkuchhal@chromium.org2009-07-311-10/+10
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22200 0039d316-1c4b-4281-b951-d872f2087c98
* Refactoring of master preferences parsing before adding a new preference.kuchhal@chromium.org2009-07-311-22/+26
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22198 0039d316-1c4b-4281-b951-d872f2087c98
* There is no need for the browser process to have an accelerator handler.This ↵jcampan@chromium.org2009-07-291-1/+2
| | | | | | | | CL cleans this up.BUG=NoneTEST=Accelerator should work in Chrome and in the first run window. Review URL: http://codereview.chromium.org/160301 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22020 0039d316-1c4b-4281-b951-d872f2087c98
* Linux: Add first run search bubble.kuchhal@chromium.org2009-07-141-22/+0
| | | | | | Review URL: http://codereview.chromium.org/149501 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20625 0039d316-1c4b-4281-b951-d872f2087c98
* Some code had been removed from FirstRun::IsChromeFirstRun() so that it may ↵jcampan@chromium.org2009-07-081-2/+8
| | | | | | | | return true then false when later invoked.This caused a bug where we would show the info-bar warning that Chromium is not the default browser after the first run.This patch resurrects that code and changes the first run UI, as it was relying on that behavior.BUG=http://crbug.com/15833TEST=Make IE or Firefox your default browser. Open Chromium so it shows the 1st run UI. Unselect the "make chromium my default browser" button, then press start. When Chromium shows up, there should be no info-bar warning you Chromium is not your default browser. Also test that the first run UI still works as expected. Review URL: http://codereview.chromium.org/155168 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20151 0039d316-1c4b-4281-b951-d872f2087c98
* This CL removes the last (major) Windows specific part out of the focus ↵jcampan@chromium.org2009-06-301-1/+1
| | | | | | | | | | | | | | | | | | | | | | | manager. It was previously landed and reverted because it broke the reliability tests. http://codereview.chromium.org/125148 The breakage was caused by constrained windows not getting a hold of the FocusManager when in unparented tabs. The fix is to ensure unparented tab still have a way to access their FocusManager for proper closure. Files changed from the previous patch that need reviewing: native_tab_contents_container_win.cc tab_contents_view_win.h tab_contents_view_win.cc BUG=None TEST=Run all tests (unit, ui, interactive). Extensively test the focus in Chrome. Review URL: http://codereview.chromium.org/146093 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19617 0039d316-1c4b-4281-b951-d872f2087c98
* Replace std:;wstring with std::string and string16 in locale-name related APIs.jshin@chromium.org2009-06-241-1/+1
| | | | | | | | | | | | | | | 1. Change the locale param to be std::string because they're always ASCII and change call-sites accordingly. 2. Add GetStringFUTF16 to l10n_util. On Windows, they're inline helpers calling the correspondingGetStringF returning wstring while on Mac/Linux, they just return the result of |string16 GetStringF|without converting to wstring. This is part 1 of the fix for issue 8647. Some of newly introduced conversions are temporary and will be removed later (e.g. ASCIIToWide applied to the result of GetApplicationLocale in a few places). Note : this CL will be landed after http://codereview.chromium.org/147038 is landed. BUG=8647 (http://crbug.com/8647) TEST=Pass l10n_util_unittest and other unit tests Review URL: http://codereview.chromium.org/126223 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19183 0039d316-1c4b-4281-b951-d872f2087c98
* Revert :nsylvain@chromium.org2009-06-221-1/+1
| | | | | | | | | | | | | | | | | | Changed by: jcampan@chromium.org Changed at: Fri 19 Jun 2009 21:22:47 Branch: src Revision: 18889 Comments: Relanding focus manager refactoring with build fix, see:http://codereview.chromium.org/125148BUG=NoneTEST=NoneTBR=ben Review URL: http://codereview.chromium.org/141013 Because it creates hundreds of new reliability crashes. TBR:jcampan Review URL: http://codereview.chromium.org/140064 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18904 0039d316-1c4b-4281-b951-d872f2087c98
* Relanding focus manager refactoring with build fix, ↵jcampan@chromium.org2009-06-201-1/+1
| | | | | | | | see:http://codereview.chromium.org/125148BUG=NoneTEST=NoneTBR=ben Review URL: http://codereview.chromium.org/141013 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18889 0039d316-1c4b-4281-b951-d872f2087c98
* Reverting 18872.jcampan@chromium.org2009-06-191-1/+1
| | | | | | | | | | | | Broke the Windows build. BUG=None TEST=None TBR=ben Review URL: http://codereview.chromium.org/140023 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18873 0039d316-1c4b-4281-b951-d872f2087c98
* Removed the last Windows specific part out of the focus manager. HWNDs are ↵jcampan@chromium.org2009-06-191-1/+1
| | | | | | | | not subclassed anymore.The FocusManager is now created and owned by top-level WidgetWins.BUG=NoneTEST=Run the unit tests, UI tests, interactive UI tests. Fully test the focus behavior in the browser: activate/deactivate the browser windows, make sure focus is remembered. Switch tabs, make sure focus is remembered for each tab. make sure accelerators work as expected. Test focus traversal in a web page, in the option dialog. Review URL: http://codereview.chromium.org/125148 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18872 0039d316-1c4b-4281-b951-d872f2087c98
* Tweaks to the try chrome toastcpu@google.com2009-06-121-5/+13
| | | | | | | | | | | | | - Wire it to the cmdline param --try-chrome-again - Set window bounds so it looks nice on Vista - Enable the link to help center BUG=b/1484308 TEST=see the bug Review URL: http://codereview.chromium.org/126029 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18321 0039d316-1c4b-4281-b951-d872f2087c98
* Adds the ability to import the home page of the default browser. The import ↵gwilson@google.com2009-06-111-0/+2
| | | | | | | | | | | | always existed, but was never hooked up to an installerdata preference. R=cpu BUG=13752 TEST=Run the installer with a line in the distribution block of the installerdata that reads: "import_home_page" : true. The home page of the previous default browser should be imported. Review URL: http://codereview.chromium.org/118512 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18210 0039d316-1c4b-4281-b951-d872f2087c98
* Fix tree bustagecpu@google.com2009-06-101-1/+0
| | | | | | | | | | | TEST=none BUG=none TBR=nsylvain Review URL: http://codereview.chromium.org/120003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18096 0039d316-1c4b-4281-b951-d872f2087c98
* UI part of the try chrome toastcpu@google.com2009-06-101-1/+262
| | | | | | | | | | | | | - experimental. 'en' only - modal dialog is farily custom BUG=none TEST=none Review URL: http://codereview.chromium.org/118510 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18093 0039d316-1c4b-4281-b951-d872f2087c98
* Try to fix this file since it's constantly givingmaruel@chromium.org2009-06-101-2/+1
| | | | | | | | | | "svn: Inconsistent line ending style"... TEST=none BUG=none git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18062 0039d316-1c4b-4281-b951-d872f2087c98
* Refactor the FirstRun code into Windows-specific and portable.evan@chromium.org2009-05-221-81/+20
| | | | | | | | | BUG=11971 TEST=fresh install of Chrome should still bring up the first run dialog Review URL: http://codereview.chromium.org/115689 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16783 0039d316-1c4b-4281-b951-d872f2087c98
* Copy first_run.cc to first_run_win.cc for history preservation.evan@chromium.org2009-05-201-0/+667
| | | | | | | | A subsequent change will modify these files. (Retrying previous change.) git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16504 0039d316-1c4b-4281-b951-d872f2087c98
* Revert r16502.evan@chromium.org2009-05-201-667/+0
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16503 0039d316-1c4b-4281-b951-d872f2087c98
* Copy first_run.cc to first_run_win.cc for history preservation.evan@chromium.org2009-05-201-0/+667
A subsequent change will modify these files. git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16502 0039d316-1c4b-4281-b951-d872f2087c98
generated by cgit v1.1 at 2025-02-07 09:18:26 +0000