| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
|
| |
TEST=geolocation_settings_state_unittest.cc
Review URL: http://codereview.chromium.org/1540034
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@46911 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=42869
TEST=GeolocationPermissionContextTests.*
Review URL: http://codereview.chromium.org/1789012
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@46901 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
(WebKit change has rolled and a flaky test seems to be stable).
TEST=GeolocationBrowserTest.*
BUG=40099
Review URL: http://codereview.chromium.org/1687002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@45441 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
WebKit::WebGeolocationServiceBridgeImpl::stopUpdating().
(depends on the fix provided by http://trac.webkit.org/changeset/57335).
BUG=40660,40478
TEST=GeolocationBrowserTest.InvalidUrlRequest
Review URL: http://codereview.chromium.org/1626011
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@44346 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
Implements cancelGeolocationPermissionRequestForFrame()
Queues infobars.
BUG=39686,39804
TEST=geolocation_browsertest.cc
Review URL: http://codereview.chromium.org/1573002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@43368 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=40099
TEST=none
Review URL: http://codereview.chromium.org/1549009
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@43343 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
granted to use geolocaiton.
Also fixes a long standing todos/bugs that the host sent in the network request was not set correctly, and
location results were not always tagged against the correct source data in the cache.
BUG=39171
TEST=run with --geolocation-enabled and --log-level=0, check from logs that no location request sent until authorized.
Review URL: http://codereview.chromium.org/1541008
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@43339 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=39808
TEST=run browser with & withou --disable-geolocaiton.
Review URL: http://codereview.chromium.org/1534008
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@43337 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
- We try to find an associated window for the calling extension page.
- If there is none (bg pages), fallback to the topmost browser window.
- If the extension is enabled in incognito, include incognito windows in the
search for "topmost".
This fixes a bug where clicking a browser action in an incognito window might open a tab in a normal window, which is confusing.
BUG=39113
Review URL: http://codereview.chromium.org/1422001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42848 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
persist settings
This is a second try for http://codereview.chromium.org/1141004/show
Fixed the tests flakyness for the case where there's no infobar (that is, adding a geolocation watch will trigger a popup).
TEST=geolocation_browsertest.cc
Review URL: http://codereview.chromium.org/1415001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42796 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
GeolocationPermissionContext to persist settings.
TEST=geolocation_browsertest.cc
Review URL: http://codereview.chromium.org/1141004
TBR=bulach@chromium.org
Review URL: http://codereview.chromium.org/1394005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42759 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
persist settings.
TEST=geolocation_browsertest.cc
Review URL: http://codereview.chromium.org/1141004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42757 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This data structure and the notification flow will be used to populate the location bar icon and its bubble.
- this was originally part of http://codereview.chromium.org/650180
- Fully reviewed as http://codereview.chromium.org/1143002 I'm just landing on Marcus's behalf
TBR=bulach
BUG=11246
TEST=geolocation_browsertest.cc
Review URL: http://codereview.chromium.org/1320005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42594 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
Mark as "flaky" to analyze how it behaves, will fully enable it once it's proven stable.
Restructure the tests a bit in order to simplify the usage of mocks.
TEST=geolocation_browsertest.cc
Review URL: http://codereview.chromium.org/1081012
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42495 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/1082009
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42215 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
(follow on up http://codereview.chromium.org/1134001)
TEST=geolocation_browsertest.cc
Review URL: http://codereview.chromium.org/1149007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42214 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
Adds a disabled test waiting for rolling https://bugs.webkit.org/show_bug.cgi?id=36315
TEST=geolocation_browsertest.cc
Review URL: http://codereview.chromium.org/1134001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42212 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
to base::Time
BUG=http://code.google.com/p/chromium/issues/detail?id=37510
TEST=unit_tests --gtest_filter=geol*
Review URL: http://codereview.chromium.org/776001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@41722 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
TEST=geolocation_browsertest.cc
Review URL: http://codereview.chromium.org/661371
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@41581 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=http://crbug.com/37196
TEST=TODO
Review URL: http://codereview.chromium.org/667006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@40621 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Bolt the geolocation dispatcher host up to the location arbitrator
Introduces a new method for fetching a singleton default location arbitrator with minimal fuss.
Fix bug in the geolocation dispatcher where bridge id & route id were swapped on send.
BUG=http://crbug.com/11246
TEST=run browser with --enable-geolocaiton & Open http://maps.google.co.uk/maps/m
Review URL: http://codereview.chromium.org/658005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@40118 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
Note: they're disabled on Mac pending my investigation (it seems to be a similar issue to http://code.google.com/p/chromium/issues/detail?id=29424).
This will at least get some coverage for geolocation on win and linux for the time being.
TEST=geolocation_browsertest.cc
Review URL: http://codereview.chromium.org/650134
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@39885 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Adds IPC plumbing.
Adds Infobar buttons for requesting permission
TEST=geolocation_browsertest.cc
Review URL: http://codereview.chromium.org/548188
TBR=bulach@chromium.org
Review URL: http://codereview.chromium.org/646027
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@39374 0039d316-1c4b-4281-b951-d872f2087c98
|
|
Adds IPC plumbing.
Adds Infobar buttons for requesting permission
TEST=geolocation_browsertest.cc
Review URL: http://codereview.chromium.org/548188
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@39366 0039d316-1c4b-4281-b951-d872f2087c98
|