| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
|
| |
carving in some places. i.e. geolocation_permission_context.h needs to split into the interface part and the implementation part. access_token_store.h needs to drop the chrome factory function. arbitrator_dependency_factory.h needs to be split up into the interface and the default implementation. I've left all this to future changes per the other file moves, and since this is already pretty large.TBR=joth
Review URL: http://codereview.chromium.org/6591034
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@76228 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The NetworkManagerWlanApi class in wifi_data_provider_linux.cc was
using a shared dbus connection which was referenced as a GSource in
the glib message loop in the main thread, and also from the
WifiDataProviderCommon thread. When the dbus proxy object and connection
was unreferenced in the WifiDataCommon thread, the glib main loop in the
main thread could concurrently reference it during object destruction,
causing a crash.
We fix this by using a private dbus connection instead, referencing its
own glib main loop separate to that of the main thread.
BUG=59913
TEST=GeolocationWifiDataProviderPlatformTest.CreateAndDestroy
Review URL: http://codereview.chromium.org/4307001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@65185 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
This also converts a "const NSString*" to "NSString*" to remove a Clang warning.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/4005001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@63429 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
string_number_conversions.h
TEST=it compiles
BUG=none
Review URL: http://codereview.chromium.org/3013046
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@54454 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=44011
TEST=NoWifi and IntermittentWifi test fixtures in wifi_data_provider_common_unittest.cc
Review URL: http://codereview.chromium.org/2971006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@52901 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
Rather than scattering init calls through the code, just inititialize
it once. (In particular, the gnome-keyring support also needs this
function called, and I didn't want to copy it one more time.)
TEST=no threading-related crash during gnome-keyring startup
Review URL: http://codereview.chromium.org/2873015
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@50652 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=40803
TEST=run browser & use geolocation.
Review URL: http://codereview.chromium.org/1604023
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@44216 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
NetworkManager
NOTE: Adds a new build dependency on dbus-glib, on ubuntu you can meet this with:
$ sudo aptitude install dbus-glib-1-dev
BUG=http://crbug.com/37199
TEST=use browser with --enable-geolocation
Review URL: http://codereview.chromium.org/787003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@41430 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
http://src.chromium.org/viewvc/chrome?view=rev&revision=37989
Tidy up assertions to use CHECKs
(Already reviewed as part of above change)
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/578013
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@38203 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Original change:
Add tests for the geolocation network provider.
Also some small tidy up a few other files.
BUG=http://crbug.com/11246
TEST=unit_tests.exe gtest_filter=NetworkLocationProvider* gtest_break_on_failure
Review URL: http://codereview.chromium.org/556106
TBR=joth@chromium.org
Review URL: http://codereview.chromium.org/570006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@37992 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Also some small tidy up a few other files.
BUG=http://crbug.com/11246
TEST=unit_tests.exe --gtest_filter=NetworkLocationProvider* --gtest_break_on_failure
Review URL: http://codereview.chromium.org/556106
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@37989 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
Add wifi data provider to project.
Add tests for windows provider. (More to follow)
BUG=11246
TEST=unit_tests - wifi_data_provider_win_unittest.cc
Review URL: http://codereview.chromium.org/543174
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@37396 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
including DEPS exclusion)
These files are lifted from gears: http://code.google.com/p/gears/source/browse/trunk/gears/geolocation/
NOTE this is a direct copy of gears files; subsequent edits will be made to bring them into chrome style and add to gypi files and so on.
BUG=11246
TEST=None (just adding placeholder files; tests will follow in next change)
Review URL: http://codereview.chromium.org/556003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@37117 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Rolling back as it seems to have broken the Mac build
These files are lifted from gears: http://code.google.com/p/gears/source/browse/trunk/gears/geolocation/
NOTE this is a direct copy of gears files; subsequent edits will be made to bring them into chrome style and add to gypi files and so on.
BUG=11246
TEST=None (just adding placeholder files; tests will follow in next change)
Review URL: http://codereview.chromium.org/546116
TBR=joth@chromium.org
Review URL: http://codereview.chromium.org/553069
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@37015 0039d316-1c4b-4281-b951-d872f2087c98
|
|
These files are lifted from gears: http://code.google.com/p/gears/source/browse/trunk/gears/geolocation/
NOTE this is a direct copy of gears files; subsequent edits will be made to bring them into chrome style and add to gypi files and so on.
BUG=11246
TEST=None (just adding placeholder files; tests will follow in next change)
Review URL: http://codereview.chromium.org/546116
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@37009 0039d316-1c4b-4281-b951-d872f2087c98
|