summaryrefslogtreecommitdiffstats
path: root/chrome/browser/geolocation
Commit message (Collapse)AuthorAgeFilesLines
* Merge 143529 - Simplify overriding ShouldExpire() a bit by allowing classes ↵pkasting@chromium.org2012-07-101-17/+1
| | | | | | | | | | | | | | | to override ShouldExpireInternal() instead, which fits most uses. Also simplifies the geolocation infobar by adding a protected setter to the base class. BUG=none TEST=none Review URL: https://chromiumcodereview.appspot.com/10584038 TBR=pkasting@chromium.org Review URL: https://chromiumcodereview.appspot.com/10757015 git-svn-id: svn://svn.chromium.org/chrome/branches/1180/src@145825 0039d316-1c4b-4281-b951-d872f2087c98
* Upstream Geolocation global enable/disable preference.jknotten@chromium.org2012-06-185-3/+63
| | | | | | | | | | | | | | | | | | | | | | | | Chrome for Android presents a checkbox in its user interface to control whether sites may request access to the geolocation API. This requires a new preference, "geolocation.enabled" to model this global switch. When geolocation.enabled is true, Chrome for Android will prompt the user (with an infobar) to confirm whether access should be granted. Sites that have been previously authorised by the user will be granted access automatically. When geolocation.enabled is false, Chrome for Android should prevent any access to the geolocation API for all sites (even those sites previously authorised). BUG=None TEST=unit_test:GeolocationPermissionContextTests.GeolocationEnabledDisabled Review URL: https://chromiumcodereview.appspot.com/10532126 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@142679 0039d316-1c4b-4281-b951-d872f2087c98
* TabContentsWrapper -> TabContents, part 14.avi@chromium.org2012-06-083-28/+26
| | | | | | | | | | | | Geolocation. BUG=131026 TEST=no change Review URL: https://chromiumcodereview.appspot.com/10543079 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@141285 0039d316-1c4b-4281-b951-d872f2087c98
* TabContentsWrapper -> TabContents, part 2.avi@chromium.org2012-06-061-8/+8
| | | | | | | | | BUG=131026 TEST=no change Review URL: https://chromiumcodereview.appspot.com/10542010 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@140754 0039d316-1c4b-4281-b951-d872f2087c98
* Move the rest of the content\test headers that are used by embedders to ↵jam@chromium.org2012-06-041-2/+2
| | | | | | | | | | content\public\test. This way we can enforce that internal content headers don't leak to embedders. BUG=98716 TBR=phajdan.jr Review URL: https://chromiumcodereview.appspot.com/10483003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@140287 0039d316-1c4b-4281-b951-d872f2087c98
* Move test_browser_thread.h from content\test to content\public\test. This ↵jam@chromium.org2012-06-043-3/+3
| | | | | | | | | | way we can enforce that internal content headers don't leak to embedders. BUG=98716 TBR=phajdan.jr Review URL: https://chromiumcodereview.appspot.com/10500016 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@140254 0039d316-1c4b-4281-b951-d872f2087c98
* Move mock test headers from content\test to content\public\test. This way we ↵jam@chromium.org2012-06-031-1/+1
| | | | | | | | | | can enforce that internal content headers don't leak to embedders. BUG=98716 TBR=phajdan.jr Review URL: https://chromiumcodereview.appspot.com/10473016 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@140241 0039d316-1c4b-4281-b951-d872f2087c98
* Get rid of the RenderViewType concept in content, since it was only used by ↵jam@chromium.org2012-05-231-3/+2
| | | | | | | | | Chrome. Store the enum value in the WebContents' property bag. BUG=98716 Review URL: https://chromiumcodereview.appspot.com/10409088 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@138434 0039d316-1c4b-4281-b951-d872f2087c98
* Disable GeolocationBrowserTest.TwoWatchesInOneFrame on linux.zea@chromium.org2012-05-211-1/+7
| | | | | | | | | | TBR=bartfab@chromium.org BUG=129065 TEST= Review URL: https://chromiumcodereview.appspot.com/10420002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@138152 0039d316-1c4b-4281-b951-d872f2087c98
* Disable crashy geolcoation browser testszea@chromium.org2012-05-211-10/+14
| | | | | | | | | BUG=129065 TEST= Review URL: https://chromiumcodereview.appspot.com/10407076 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@138146 0039d316-1c4b-4281-b951-d872f2087c98
* Move Extension into extensions namespaceaa@chromium.org2012-05-211-1/+1
| | | | | | | | | BUG=117262 TBR=aa@chromium.org Review URL: https://chromiumcodereview.appspot.com/10375021 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@138074 0039d316-1c4b-4281-b951-d872f2087c98
* Update use of TimeDelta in chrome/browser/*, ui/views/*, and other places.tedvessenes@gmail.com2012-05-171-2/+2
| | | | | | | | | | R=ben@chromium.org BUG=108171 Review URL: https://chromiumcodereview.appspot.com/10026013 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@137682 0039d316-1c4b-4281-b951-d872f2087c98
* Moves methods for finding browsers to browser_finder.sky@chromium.org2012-05-161-2/+2
| | | | | | | | | | | BUG=none TEST=none R=ben@chromium.org TBR=tim@chromium.org, davemoore@chromium.org, scottbyer@chromium.org, keybuk@chromium.org Review URL: https://chromiumcodereview.appspot.com/10391158 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@137511 0039d316-1c4b-4281-b951-d872f2087c98
* Taking over issue 10006037.rlp@chromium.org2012-05-141-1/+12
| | | | | | | | | | | | | | | | | | | | | | | | | Moved WebDataService to ProfileKeyedService James: chrome\browser\ui\intents Peter: chrome\browser\ui\search_engines chrome\browser\search_engines Nicolas: chrome\browser\sync Rachel/Elliot: chrome\browser\profiles and the whole cl BUG=112234 TEST=unit-tests TBR=jhawkins@chromium.org,pkasting@chromium.org,zea@chromium.org,erg@chromium.org,isherman@chromium.org Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=136499 Review URL: https://chromiumcodereview.appspot.com/10185008 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@137014 0039d316-1c4b-4281-b951-d872f2087c98
* Remove VIEW_TYPE_WEB_CONTENTS and make default view type INVALID.aa@chromium.org2012-05-141-1/+2
| | | | | | | | | | | | | | The view type enum is supposed to represent the 'type of view' in the user sense, so 'tab', 'background page', 'popup', etc. A 'web contents' is not a type of view, it's an implementation detail of many different view types. This was essentially resulting in too many WebContents instances being treated as tabs. Review URL: https://chromiumcodereview.appspot.com/10387110 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@136835 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 136499 - Taking over issue 10006037.yusukes@google.com2012-05-111-12/+1
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Moved WebDataService to ProfileKeyedService James: chrome\browser\ui\intents Peter: chrome\browser\ui\search_engines chrome\browser\search_engines Nicolas: chrome\browser\sync Rachel/Elliot: chrome\browser\profiles and the whole cl BUG=112234 TEST=unit-tests TBR=jhawkins@chromium.org,pkasting@chromium.org,zea@chromium.org,erg@chromium.org,isherman@chromium.org Review URL: https://chromiumcodereview.appspot.com/10185008 Reason of the revert: The CL broke the following linux_chromeos browser_tests. EnterpriseLoginBlocksForEnterpriseUser_0 EnterpriseLoginBlocksForEnterpriseUser_1 EnterpriseLoginBlocksForEnterpriseUser_2 EnterpriseLoginBlocksForEnterpriseUser_3 EnterpriseLoginBlocksForEnterpriseUser_4 EnterpriseLoginBlocksForEnterpriseUser_5 EnterpriseLoginDoesntBlockForNormalUser NormalLoginDoesntBlock sample log: http://build.chromium.org/p/chromium.chromiumos/builders/Linux%20ChromiumOS%20Tests%20%28dbg%29%282%29/builds/1071/steps/browser_tests/logs/stdio [14648:14648:0510/212507:358430278:FATAL:web_data_service.cc(96)] Check failed: BrowserThread::IsWellKnownThread(BrowserThread::DB). Backtrace: base::debug::StackTrace::StackTrace() [0x7ff2e9b74e76] logging::LogMessage::~LogMessage() [0x7ff2e9ba6627] WebDataService::WebDataService() [0x144d7a7] TBR=rlp@chromium.org Review URL: https://chromiumcodereview.appspot.com/10382123 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@136522 0039d316-1c4b-4281-b951-d872f2087c98
* Taking over issue 10006037.rlp@chromium.org2012-05-111-1/+12
| | | | | | | | | | | | | | | | | | | | | | | Moved WebDataService to ProfileKeyedService James: chrome\browser\ui\intents Peter: chrome\browser\ui\search_engines chrome\browser\search_engines Nicolas: chrome\browser\sync Rachel/Elliot: chrome\browser\profiles and the whole cl BUG=112234 TEST=unit-tests TBR=jhawkins@chromium.org,pkasting@chromium.org,zea@chromium.org,erg@chromium.org,isherman@chromium.org Review URL: https://chromiumcodereview.appspot.com/10185008 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@136499 0039d316-1c4b-4281-b951-d872f2087c98
* RefCounted types should not have public destructors, chrome/browser/ part 6rsleevi@chromium.org2012-04-272-8/+12
| | | | | | | | | | BUG=123295 TEST=none Review URL: http://codereview.chromium.org/10071036 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@134218 0039d316-1c4b-4281-b951-d872f2087c98
* Geolocation support for chromedriver, browser-side only.kkania@chromium.org2012-04-252-30/+20
| | | | | | | | | | BUG=chromedriver:14 TEST=none Review URL: http://codereview.chromium.org/10070012 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@133988 0039d316-1c4b-4281-b951-d872f2087c98
* TabContents -> WebContentsImpl, part 18.avi@chromium.org2012-04-172-3/+3
| | | | | | | | | | | TabContents -> WebContents in chrome/, part 2. BUG=105875 TEST=no change Review URL: https://chromiumcodereview.appspot.com/10107002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@132568 0039d316-1c4b-4281-b951-d872f2087c98
* TabContents -> WebContentsImpl, part 15.avi@chromium.org2012-04-171-1/+1
| | | | | | | | | | | | | Switch VIEW_TYPE_TAB_CONTENTS to VIEW_TYPE_WEB_CONTENTS. Also removed all references in comments to TAB_CONTENTS_WEB. TAB_CONTENTS_WEB was a value of the enum TabContentsType, which was removed in r13730. BUG=105875 TEST=no change Review URL: https://chromiumcodereview.appspot.com/10091006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@132567 0039d316-1c4b-4281-b951-d872f2087c98
* Reenable GeolocationBrowserTest.TabDestroyed browser test.jknotten@chromium.org2012-04-051-2/+1
| | | | | | | | | | | | | | | | | This test started to crash and, as a result of fixing the crash, the geolocation infobar code was refactored and improved in http://codereview.chromium.org/9491009 . Hopefully as a result, this test also no longer be flaky. BUG=70588 TEST=GeolocationBrowserTest.TabDestroyed Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=129439 Review URL: http://codereview.chromium.org/9874016 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@130888 0039d316-1c4b-4281-b951-d872f2087c98
* Remove infobar from helper list before notifying observers.jknotten@chromium.org2012-03-311-1/+8
| | | | | | | | | | | | | | | | | | | | In https://chromiumcodereview.appspot.com/9491009/ the GeolocationInfoBarQueueController subscribes to the INFOBAR_REMOVED notification and calls back into the helper to show any pending infobar requests. In order to make this work correctly, it is important to erase the removed InfoBarDelegate from the InfoBarTabHelper's list before notifying the observers. Similarly, we should unregister the tab helper from content::NOTIFICATION_NAV_ENTRY_COMMITTED notifications (if necessary) before sending the notification. BUG=70588 TEST=GeolocationBrowserTest.DISABLED_TabDestroyed Review URL: http://codereview.chromium.org/9921009 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@130050 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 129439 - Reenable GeolocationBrowserTest.TabDestroyed browser test.abodenha@google.com2012-03-291-1/+2
| | | | | | | | | | | | | | | | | | This test started to crash and, as a result of fixing the crash, the geolocation infobar code was refactored and improved in http://codereview.chromium.org/9491009 . Hopefully as a result, this test also no longer be flaky. BUG=70588 TEST=GeolocationBrowserTest.TabDestroyed Review URL: http://codereview.chromium.org/9874016 TBR=jknotten@chromium.org Review URL: https://chromiumcodereview.appspot.com/9800002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@129538 0039d316-1c4b-4281-b951-d872f2087c98
* Reenable GeolocationBrowserTest.TabDestroyed browser test.jknotten@chromium.org2012-03-281-2/+1
| | | | | | | | | | | | | | | This test started to crash and, as a result of fixing the crash, the geolocation infobar code was refactored and improved in http://codereview.chromium.org/9491009 . Hopefully as a result, this test also no longer be flaky. BUG=70588 TEST=GeolocationBrowserTest.TabDestroyed Review URL: http://codereview.chromium.org/9874016 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@129439 0039d316-1c4b-4281-b951-d872f2087c98
* Show queued geolocation InfoBars when InfoBar is hidden.jknotten@chromium.org2012-03-272-120/+158
| | | | | | | | | | | | | | | | | | | | | This change should fix a crash in GeolocationBrowserTest.TabDestroyed browser test. Instead of showing queued info bars when the GeolocationConfirmInfobarDelegate is destroyed, show it in response to the INFOBAR_REMOVED notification. This will enable InfoBarTabHelper to successfully close all infobars. Consequently, we don't need to listen on WEB_CONTENTS_DESTROYED notification. BUG=70588 TEST=GeolocationBrowserTest.TabDestroyed Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=128467 Review URL: http://codereview.chromium.org/9491009 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@129186 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 128467 - Show queued geolocation InfoBars when InfoBar is hidden.jknotten@chromium.org2012-03-232-145/+115
| | | | | | | | | | | | | | | | | | | | | This change should fix a crash in GeolocationBrowserTest.TabDestroyed browser test. Instead of showing queued info bars when the GeolocationConfirmInfobarDelegate is destroyed, show it in response to the INFOBAR_REMOVED notification. This will enable InfoBarTabHelper to successfully close all infobars. Consequently, we don't need to listen on WEB_CONTENTS_DESTROYED notification. BUG=70588 TEST=GeolocationBrowserTest.TabDestroyed Review URL: http://codereview.chromium.org/9491009 TBR=jknotten@chromium.org Review URL: https://chromiumcodereview.appspot.com/9834049 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@128477 0039d316-1c4b-4281-b951-d872f2087c98
* Show queued geolocation InfoBars when InfoBar is hidden.jknotten@chromium.org2012-03-232-115/+145
| | | | | | | | | | | | | | | | | | | This change should fix a crash in GeolocationBrowserTest.TabDestroyed browser test. Instead of showing queued info bars when the GeolocationConfirmInfobarDelegate is destroyed, show it in response to the INFOBAR_REMOVED notification. This will enable InfoBarTabHelper to successfully close all infobars. Consequently, we don't need to listen on WEB_CONTENTS_DESTROYED notification. BUG=70588 TEST=GeolocationBrowserTest.TabDestroyed Review URL: http://codereview.chromium.org/9491009 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@128467 0039d316-1c4b-4281-b951-d872f2087c98
* Add abstractions that let embedders drive tests of WebContents, without ↵joi@chromium.org2012-03-221-2/+4
| | | | | | | | | | | | | | | exposing the internals of content/. A separate WebContentsTester interface is used. For reasons this approach was chosen, see comments on the interface. As part of this work, removed a bunch of references to TabContents from Chrome, some of which were true usages (leaked to Chrome via the test_tab_contents.h header), others of which were just forward declarations and never used. Also removed a chunk of code from autofill_manager.cc that isn't called from anywhere that referenced TabContents. TBR=ben@chromium.org BUG=98716 Review URL: https://chromiumcodereview.appspot.com/9706012 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@128198 0039d316-1c4b-4281-b951-d872f2087c98
* Use about:blank as the failback URL if the filter denies a navigation.cevans@chromium.org2012-03-211-2/+2
| | | | | | | BUG=117417 Review URL: https://chromiumcodereview.appspot.com/9794009 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@128057 0039d316-1c4b-4281-b951-d872f2087c98
* Move MockRenderProcessHost to content/test and put it into the content ↵tfarina@chromium.org2012-03-161-1/+2
| | | | | | | | | | | | namespace. BUG=98716 R=jam@chromium.org TBR=sky@chromium.org Review URL: https://chromiumcodereview.appspot.com/9699082 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@127163 0039d316-1c4b-4281-b951-d872f2087c98
* Introduce abstractions to allow embedders to test RenderViewHostjoi@chromium.org2012-03-121-1/+3
| | | | | | | | | | | | | | | | without knowing about content's internals. From the embedders' point of view, this is done by splitting the "tester" interface away from the RenderViewHost interface, rather than extending the parallel interface/implementation hierarchy; see comments on TestRenderViewHost for the rationale. TBR=ben@chromium.org BUG=98716 Review URL: https://chromiumcodereview.appspot.com/9645003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@126200 0039d316-1c4b-4281-b951-d872f2087c98
* Move Render(View|Widget)Host and associated classes to content namespace.joi@chromium.org2012-03-072-2/+2
| | | | | | | | | TBR=jam@chromium.org BUG=98716 Review URL: https://chromiumcodereview.appspot.com/9600036 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@125388 0039d316-1c4b-4281-b951-d872f2087c98
* Move RenderWidgetHost and RenderViewHost interfaces to their own files.joi@chromium.org2012-03-062-5/+6
| | | | | | | | | | | This also finishes breaking the Chrome dependency on RenderWidgetHostImpl and RenderViewHostImpl. TBR=jam@chromium.org BUG=98716 Review URL: https://chromiumcodereview.appspot.com/9599011 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@125166 0039d316-1c4b-4281-b951-d872f2087c98
* Extract minimal RenderViewHost interface for embedders, leavingjoi@chromium.org2012-03-051-3/+4
| | | | | | | | | | | | RenderViewHostImpl for content. TBR=darin@chromium.org BUG=98716 Review URL: http://codereview.chromium.org/9473001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@124941 0039d316-1c4b-4281-b951-d872f2087c98
* Coverity: Initialize member variables.jhawkins@chromium.org2012-02-081-2/+3
| | | | | | | | | | | | | CID_COUNT=13 CID=102812,102838,102863,102867,102875,102891,102906,102924,102947,102964, 103070,103246,103259 BUG=none TEST=none R=groby Review URL: https://chromiumcodereview.appspot.com/9307114 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@120913 0039d316-1c4b-4281-b951-d872f2087c98
* Move DOMAutomationController code from chrome to content. This is needed by ↵jam@chromium.org2012-02-031-7/+8
| | | | | | | | | | | interstitial pages which are in content, and also browser tests in content. In followup changes, I'll make interstitial pages not have to derive from a concrete class, and instead implement some sort of delegate interface like we did with WebUI. BUG=98716 Review URL: https://chromiumcodereview.appspot.com/9310094 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@120441 0039d316-1c4b-4281-b951-d872f2087c98
* Hide Geoposition from the one chrome browsertest file that was using it.jam@chromium.org2012-01-261-42/+37
| | | | | | | BUG=98716 Review URL: https://chromiumcodereview.appspot.com/9288044 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@119166 0039d316-1c4b-4281-b951-d872f2087c98
* Get rid of a bunch of geolocation includes in chrome tests. I've created a ↵jam@chromium.org2012-01-242-44/+27
| | | | | | | | | simple mock class that tests which use geolocation can use to wrap this complexity. BUG=98716 Review URL: https://chromiumcodereview.appspot.com/9285011 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@118850 0039d316-1c4b-4281-b951-d872f2087c98
* Hide geolocation_provider.h from chrome, and move ↵jam@chromium.org2012-01-242-20/+3
| | | | | | | | | geolocation_permission_context.h to content\public and into the content namespace. BUG=98716 Review URL: https://chromiumcodereview.appspot.com/9160008 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@118767 0039d316-1c4b-4281-b951-d872f2087c98
* Get rid of RenderViewHostManager usage in chrome.jam@chromium.org2012-01-111-2/+2
| | | | | | | BUG=98716 Review URL: http://codereview.chromium.org/9139007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@117327 0039d316-1c4b-4281-b951-d872f2087c98
* Get rid of TabContentsWrapper::tab_contents. Also make it use WebContents ↵jam@chromium.org2012-01-061-5/+6
| | | | | | | | | exclusively. This allows updating all the creaters of TCW to not include tab_contents.h as well, and use WebContents::Create instead. BUG=98716 Review URL: http://codereview.chromium.org/9108025 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@116600 0039d316-1c4b-4281-b951-d872f2087c98
* Get rid of a bunch of tab_contents.h includes from chrome. These are all ↵jam@chromium.org2012-01-041-13/+13
| | | | | | | | | trivial changes to use WebContents instead of TabContents. BUG=98716 Review URL: http://codereview.chromium.org/9030032 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@116392 0039d316-1c4b-4281-b951-d872f2087c98
* Get rid of content::NavigationController in cc file and use "using" instead.jam@chromium.org2012-01-041-6/+7
| | | | | | | | BUG=98716 TBR=joi Review URL: http://codereview.chromium.org/8983012 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@116328 0039d316-1c4b-4281-b951-d872f2087c98
* Convert WebContents to return a content::NavigationController instead of the ↵jam@chromium.org2012-01-041-1/+1
| | | | | | | | | | implementation. Update all the headers in chrome to use the interface only. In a subsequent cl, I'll rename the implementation to NavigationControllerImpl and also get rid of content::NavigationController everywhere. BUG=98716 TBR=joi Review URL: http://codereview.chromium.org/8983010 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@116244 0039d316-1c4b-4281-b951-d872f2087c98
* Fix build break after merge conflictjam@chromium.org2012-01-031-1/+2
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@116153 0039d316-1c4b-4281-b951-d872f2087c98
* Convert all the notifications which use NavigationController to ↵jam@chromium.org2012-01-031-5/+5
| | | | | | | | | | content::NavigationController. After this is done, we can then make WebContents return a content::NavigationEntry instead of the impl. BUG=98716 TBR=joi Review URL: http://codereview.chromium.org/9016047 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@116150 0039d316-1c4b-4281-b951-d872f2087c98
* Replace most of Browser::GetSelectedTabContents calls into ↵jam@chromium.org2012-01-031-15/+17
| | | | | | | | | | | | Browser::GetSelectedWebContents. I've converted the easy ones, I'll do the ones with more dependencies in a separate change to keep things trivial to review. I considered taking out GetSelectedTabContents altogether and having people just use GetSelectedTabContentsWrapper()->web_contents() per the existing comment in browser.h, but there are a lot of callers and it seemed too long to type. BUG=98716 TBR=joi Review URL: http://codereview.chromium.org/9015022 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@116122 0039d316-1c4b-4281-b951-d872f2087c98
* Rename NavigationController to NavigationControllerImpl and put it into the ↵jam@chromium.org2011-12-282-5/+5
| | | | | | | | | | content namespace. Also make all users of content::NavigationController interface use the "using" keyword so they don't have to put content:: everywhere (similar to other Content API and WebKit API classes). BUG=98716 TBR=joi Review URL: http://codereview.chromium.org/8956059 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@115916 0039d316-1c4b-4281-b951-d872f2087c98
* Remove the remaining usages of NavigationEntry in chrome by converting a few ↵jam@chromium.org2011-12-281-8/+10
| | | | | | | | | | more NavigationController methods to return the interface. In a followup, I'll rename NavigationEntry to NavigationEntryImpl, then create an interface for NavigationController. BUG=98716 TBR=joi Review URL: http://codereview.chromium.org/9004045 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@115900 0039d316-1c4b-4281-b951-d872f2087c98
generated by cgit v1.1 at 2025-05-11 09:20:34 +0000