summaryrefslogtreecommitdiffstats
path: root/chrome/browser/geolocation
Commit message (Collapse)AuthorAgeFilesLines
* [GTTF] Check the result value of StartHTTPServer to avoidphajdan.jr@chromium.org2010-05-151-17/+27
| | | | | | | | | | | | | | | test hangs in cases when the server fails to start. The tests will still fail in that case, obviously, but will no longer hang (or crash), which is an improvement. TEST=browser_tests BUG=none Review URL: http://codereview.chromium.org/2095004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@47362 0039d316-1c4b-4281-b951-d872f2087c98
* Update dynamic annotations and move them to base/third_partytimurrrr@chromium.org2010-05-141-1/+1
| | | | | | Review URL: http://codereview.chromium.org/1992005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@47252 0039d316-1c4b-4281-b951-d872f2087c98
* Geolocation: fixes leak on tests after r46910bulach@chromium.org2010-05-111-0/+10
| | | | | | | | | | | New tests weren't destroying the extra infobar: http://build.chromium.org/buildbot/memory/builders/Linux%20Heapcheck/builds/2066 TEST=GeolocationPermissionContextTests.* Review URL: http://codereview.chromium.org/2017009 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@46936 0039d316-1c4b-4281-b951-d872f2087c98
* Adds GeolocationSettingsStatebulach@chromium.org2010-05-115-17/+283
| | | | | | | | TEST=geolocation_settings_state_unittest.cc Review URL: http://codereview.chromium.org/1540034 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@46911 0039d316-1c4b-4281-b951-d872f2087c98
* Geolocation: checks pending requests with the same origin when receiving the ↵bulach@chromium.org2010-05-113-128/+343
| | | | | | | | | | | | | | infobar response. Moves GeolocationPermissionContext from GeolocationDispatcherHost up to profile. TEST=GeolocationPermissionContextTests.MultipleOrigins or manual: open two tabs from the same origin with geolocation. Check both info bars are created. Reply to only one of them, check the other is gone. BUG=40527 Review URL: http://codereview.chromium.org/1585036 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@46910 0039d316-1c4b-4281-b951-d872f2087c98
* Uses GetOrigin() when setting the Geolocation state for the tab.bulach@chromium.org2010-05-113-3/+23
| | | | | | | | | BUG=42869 TEST=GeolocationPermissionContextTests.* Review URL: http://codereview.chromium.org/1789012 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@46901 0039d316-1c4b-4281-b951-d872f2087c98
* Moved URLFetcher and related classes to chrome/common/net.sanjeevr@chromium.org2010-05-074-4/+4
| | | | | | | | BUG=None TEST=Build and Unittests Review URL: http://codereview.chromium.org/1995008 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@46739 0039d316-1c4b-4281-b951-d872f2087c98
* Remove svn:executable property from more files that don't need it.thestig@chromium.org2010-04-273-0/+0
| | | | | | Review URL: http://codereview.chromium.org/1723014 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@45659 0039d316-1c4b-4281-b951-d872f2087c98
* Add geolocation permission to extensions/apps.erikkay@chromium.org2010-04-261-1/+20
| | | | | | | | | BUG=41278 TEST=None Review URL: http://codereview.chromium.org/1695013 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@45590 0039d316-1c4b-4281-b951-d872f2087c98
* Removes obsolete geolocation-related files.bulach@chromium.org2010-04-234-341/+0
| | | | | | | | TEST=Compiles Review URL: http://codereview.chromium.org/1731006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@45443 0039d316-1c4b-4281-b951-d872f2087c98
* Re-enables some geolocation testsbulach@chromium.org2010-04-231-8/+5
| | | | | | | | | | | (WebKit change has rolled and a flaky test seems to be stable). TEST=GeolocationBrowserTest.* BUG=40099 Review URL: http://codereview.chromium.org/1687002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@45441 0039d316-1c4b-4281-b951-d872f2087c98
* Fix for OSX 10.6 wifi crash: can't call [CWInterface +interface] on a ↵joth@chromium.org2010-04-141-35/+48
| | | | | | | | | | | | | | machine that has no wifi adapter. Instead enumerate all adapters and open each one explicitly. Has the benefit that it will get more comprehensive results on a machine with multiple adapters BUG=41337 TEST=opened maps.google.com/maps/m on 10.6 desktop & laptop machines Review URL: http://codereview.chromium.org/1545035 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@44559 0039d316-1c4b-4281-b951-d872f2087c98
* Fix IDN urls in geolocation infobars and bubbles (but not exceptions dialog)joth@chromium.org2010-04-141-9/+13
| | | | | | | | | BUG=40278 TEST=As per adhoc method in the bug. Open infobar & bubble, check they show URL in arabic Review URL: http://codereview.chromium.org/1612017 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@44496 0039d316-1c4b-4281-b951-d872f2087c98
* Adds a browser test to exercise ↵bulach@chromium.org2010-04-131-4/+30
| | | | | | | | | | | | | WebKit::WebGeolocationServiceBridgeImpl::stopUpdating(). (depends on the fix provided by http://trac.webkit.org/changeset/57335). BUG=40660,40478 TEST=GeolocationBrowserTest.InvalidUrlRequest Review URL: http://codereview.chromium.org/1626011 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@44346 0039d316-1c4b-4281-b951-d872f2087c98
* Trivial: Change STL-container-is-empty check from "size() > 0" to "!empty()".pkasting@chromium.org2010-04-121-1/+1
| | | | | | | | | TBR=thakis BUG=none TEST=none Review URL: http://codereview.chromium.org/1575029 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@44259 0039d316-1c4b-4281-b951-d872f2087c98
* Deny geolocation access for invalid URL in geolocation_permission_context.bulach@chromium.org2010-04-122-0/+20
| | | | | | | | | | | | | | (this is to avoid triggering a DCHECK on geolocation_host_content_settings_map). Note: the bug will be fully fixed after we roll webkit to: http://trac.webkit.org/changeset/57335 BUG=40660 TEST=GeolocationPermissionContextTests.InvalidURL Review URL: http://codereview.chromium.org/1632006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@44256 0039d316-1c4b-4281-b951-d872f2087c98
* Work-around for DBus crash due to timers firing on the wrong thread.joth@chromium.org2010-04-111-0/+14
| | | | | | | | | BUG=40803 TEST=run browser & use geolocation. Review URL: http://codereview.chromium.org/1604023 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@44216 0039d316-1c4b-4281-b951-d872f2087c98
* Geo exceptions: Disable "Remove" button if no row is selected.thakis@chromium.org2010-04-101-1/+1
| | | | | | | | | BUG=40750 TEST=see bug Review URL: http://codereview.chromium.org/1542025 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@44186 0039d316-1c4b-4281-b951-d872f2087c98
* Simplify the geolocation content settings map: it's only ever used from the ↵joth@chromium.org2010-04-093-218/+98
| | | | | | | | | | | UI thread, so no need for it to cache a copy of the prefs values BUG=none TEST=GeolocationContentSettingsMapTests.* Review URL: http://codereview.chromium.org/1525018 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@44073 0039d316-1c4b-4281-b951-d872f2087c98
* Landing on behald of tfarina. Original review: ↵joth@chromium.org2010-04-081-37/+26
| | | | | | | | | | | | | | | | http://codereview.chromium.org/1593008/show geolocation: Implement a TODO to share a function with other copies. Instead, use the function from base/win_util.h that does the same thing. Also do some cleanups. BUG=None TEST=compiles TBR=thiago.farina@gmail.com git-svn-id: svn://svn.chromium.org/chrome/trunk/src@43955 0039d316-1c4b-4281-b951-d872f2087c98
* Make the prefs reading more robust to poorly formed URLsjoth@chromium.org2010-04-082-3/+44
| | | | | | | | | BUG=39685 TEST=GeolocationContentSettingsMapTests.IgnoreInvalidURLsInPrefs Review URL: http://codereview.chromium.org/1566027 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@43945 0039d316-1c4b-4281-b951-d872f2087c98
* Adds geolocation_permission_context_unittest.ccbulach@chromium.org2010-04-081-0/+256
| | | | | | | | | | | | | | (most of this code is already covered by the more complex geolocation_browsertest.cc which traverses far more layers. this is a more specific unittest). This fixes the valgrind issues with the previous attempt http://codereview.chromium.org/1596012/show (need to call InfoBarClosed() to actually destroy the infobar). TEST=geolocation_permission_context_unittest.cc BUG=40699 Review URL: http://codereview.chromium.org/1560017 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@43943 0039d316-1c4b-4281-b951-d872f2087c98
* Use ScopedPrefUpdate to correctly send out notifications when Geolocation ↵albertb@chromium.org2010-04-082-53/+112
| | | | | | | | | | | settings are updated. BUG=none TEST=GeolocationContentSettingsTest Review URL: http://codereview.chromium.org/1570015 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@43901 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 43836 - Adds geolocation_permission_context_unittest.ccbulach@chromium.org2010-04-071-250/+0
| | | | | | | | | | | | | (most of this code is already covered by the more complex geolocation_browsertest.cc which traverses far more layers. this is a more specific unittest). TEST=geolocation_permission_context_unittest.cc Valgrind error: http://build.chromium.org/buildbot/memory/builders/Linux%20Tests%20(valgrind)(1)/builds/3857/steps/valgrind%20test:%20unit/logs/stdio Review URL: http://codereview.chromium.org/1596012 TBR=bulach@chromium.org Review URL: http://codereview.chromium.org/1629006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@43849 0039d316-1c4b-4281-b951-d872f2087c98
* Adds geolocation_permission_context_unittest.ccbulach@chromium.org2010-04-071-0/+250
| | | | | | | | | | (most of this code is already covered by the more complex geolocation_browsertest.cc which traverses far more layers. this is a more specific unittest). TEST=geolocation_permission_context_unittest.cc Review URL: http://codereview.chromium.org/1596012 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@43836 0039d316-1c4b-4281-b951-d872f2087c98
* detect preferences errorserikkay@chromium.org2010-04-061-1/+1
| | | | | | | | | BUG=38352 TEST=none Review URL: http://codereview.chromium.org/1120006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@43715 0039d316-1c4b-4281-b951-d872f2087c98
* Geolocation exceptions window, Windows.pkasting@chromium.org2010-04-052-52/+170
| | | | | | | | | | This also makes some correctness/consistency fixes to the model that affect other OSes, e.g. we now allow "remove" on the selected exception set iff all selected exceptions are removable. BUG=39817 TEST=Geolocation exceptions window exists on windows, allows sorting by either column Review URL: http://codereview.chromium.org/1539021 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@43669 0039d316-1c4b-4281-b951-d872f2087c98
* Mac: Implement geolocation exceptions dialog.thakis@chromium.org2010-04-051-2/+2
| | | | | | | | | | | | | | | | xib changes: Content settings window: Enable & hook up "exceptions" button. The dialog is not "live" (i.e. if it's open while settings are deleted through the bubble, the window is only updated after closing & reopening it). It's not possible to do any editing in the window, only deleting. This matches windows/linux. http://imgur.com/q7qMK BUG=39818 TEST=Go to a few geolocation pages, click allow/deny. Then go to content settings->locations->exceptions, the visited pages should be listed. Review URL: http://codereview.chromium.org/1566015 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@43610 0039d316-1c4b-4281-b951-d872f2087c98
* Add TableModel for geolocation settings.mattm@chromium.org2010-04-024-0/+213
| | | | | | | | | BUG=39817,39820 TEST=manual Review URL: http://codereview.chromium.org/1534013 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@43454 0039d316-1c4b-4281-b951-d872f2087c98
* Follow-up on https://bugs.webkit.org/show_bug.cgi?id=35031:bulach@chromium.org2010-04-015-42/+208
| | | | | | | | | | | | Implements cancelGeolocationPermissionRequestForFrame() Queues infobars. BUG=39686,39804 TEST=geolocation_browsertest.cc Review URL: http://codereview.chromium.org/1573002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@43368 0039d316-1c4b-4281-b951-d872f2087c98
* Workaround for 40099 - disable failing testjoth@chromium.org2010-04-011-1/+2
| | | | | | | | | BUG=40099 TEST=none Review URL: http://codereview.chromium.org/1549009 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@43343 0039d316-1c4b-4281-b951-d872f2087c98
* Defer sending wifi data via the network provider until permission has been ↵joth@chromium.org2010-04-0114-108/+280
| | | | | | | | | | | | | | granted to use geolocaiton. Also fixes a long standing todos/bugs that the host sent in the network request was not set correctly, and location results were not always tagged against the correct source data in the cache. BUG=39171 TEST=run with --geolocation-enabled and --log-level=0, check from logs that no location request sent until authorized. Review URL: http://codereview.chromium.org/1541008 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@43339 0039d316-1c4b-4281-b951-d872f2087c98
* Flip the flag to enable geolocation by default.joth@chromium.org2010-04-011-6/+0
| | | | | | | | | BUG=39808 TEST=run browser with & withou --disable-geolocaiton. Review URL: http://codereview.chromium.org/1534008 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@43337 0039d316-1c4b-4281-b951-d872f2087c98
* Fix crash: geolocation arbitrator may get deleted on wrong thread.joth@chromium.org2010-03-292-5/+1
| | | | | | | | | | | | No need for permission context to hold scoped ref to the arbitrator, so I remvoed it. (Note this fix still reveals bug https://bugs.webkit.org/show_bug.cgi?id=36535) BUG=39405 TEST=open page with 2 embedded frames using geolocaiton, answer infobar prompts out of order. Should not crash Review URL: http://codereview.chromium.org/1542002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42957 0039d316-1c4b-4281-b951-d872f2087c98
* Fix the logic in extensions GetCurrentWindow:mpcomplete@chromium.org2010-03-261-1/+2
| | | | | | | | | | | | | | | - We try to find an associated window for the calling extension page. - If there is none (bg pages), fallback to the topmost browser window. - If the extension is enabled in incognito, include incognito windows in the search for "topmost". This fixes a bug where clicking a browser action in an incognito window might open a tab in a normal window, which is confusing. BUG=39113 Review URL: http://codereview.chromium.org/1422001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42848 0039d316-1c4b-4281-b951-d872f2087c98
* Uses GeolocationContentSettingsMap on GeolocationPermissionContext to ↵bulach@chromium.org2010-03-263-105/+117
| | | | | | | | | | | | | persist settings This is a second try for http://codereview.chromium.org/1141004/show Fixed the tests flakyness for the case where there's no infobar (that is, adding a geolocation watch will trigger a popup). TEST=geolocation_browsertest.cc Review URL: http://codereview.chromium.org/1415001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42796 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 42757 - Uses GeolocationContentSettingsMap on ↵bulach@chromium.org2010-03-263-70/+51
| | | | | | | | | | | | | GeolocationPermissionContext to persist settings. TEST=geolocation_browsertest.cc Review URL: http://codereview.chromium.org/1141004 TBR=bulach@chromium.org Review URL: http://codereview.chromium.org/1394005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42759 0039d316-1c4b-4281-b951-d872f2087c98
* Uses GeolocationContentSettingsMap on GeolocationPermissionContext to ↵bulach@chromium.org2010-03-263-51/+70
| | | | | | | | | | persist settings. TEST=geolocation_browsertest.cc Review URL: http://codereview.chromium.org/1141004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42757 0039d316-1c4b-4281-b951-d872f2087c98
* Possible fix / workaround for geolocation wifi hanging bugjoth@chromium.org2010-03-251-3/+19
| | | | | | | | | | | Also pre-emptively fixes a reported issue with NULL bss list being returned from WlanGetNetworkBssList BUG=39300 TEST=run browser on desktop with dodgy wifi adapter.... Review URL: http://codereview.chromium.org/1256005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42613 0039d316-1c4b-4281-b951-d872f2087c98
* Preparatory step for implementing http://crbug.com/39171joth@chromium.org2010-03-254-25/+55
| | | | | | | | | | | Refactor the way the location arbitrator is obtained by the dispatched host, so that it is co-ordinated by the permission context. BUG=39171 TEST=none Review URL: http://codereview.chromium.org/1283002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42603 0039d316-1c4b-4281-b951-d872f2087c98
* Adds GeolocationContentSettings on TabContents. joth@chromium.org2010-03-253-27/+69
| | | | | | | | | | | | | | | | This data structure and the notification flow will be used to populate the location bar icon and its bubble. - this was originally part of http://codereview.chromium.org/650180 - Fully reviewed as http://codereview.chromium.org/1143002 I'm just landing on Marcus's behalf TBR=bulach BUG=11246 TEST=geolocation_browsertest.cc Review URL: http://codereview.chromium.org/1320005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42594 0039d316-1c4b-4281-b951-d872f2087c98
* Tentative fix for geolocation test with iframes: loads frame one by one.bulach@chromium.org2010-03-241-123/+111
| | | | | | | | | | | | Mark as "flaky" to analyze how it behaves, will fully enable it once it's proven stable. Restructure the tests a bit in order to simplify the usage of mocks. TEST=geolocation_browsertest.cc Review URL: http://codereview.chromium.org/1081012 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42495 0039d316-1c4b-4281-b951-d872f2087c98
* Disables temporarily IFramesWithFreshPosition.bulach@chromium.org2010-03-221-1/+3
| | | | | | Review URL: http://codereview.chromium.org/1082009 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42215 0039d316-1c4b-4281-b951-d872f2087c98
* Disables Geolocation tests for macbulach@chromium.org2010-03-221-2/+11
| | | | | | | | | | (follow on up http://codereview.chromium.org/1134001) TEST=geolocation_browsertest.cc Review URL: http://codereview.chromium.org/1149007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42214 0039d316-1c4b-4281-b951-d872f2087c98
* Adds browser tests exercising multiple iframes for geolocation.bulach@chromium.org2010-03-221-18/+105
| | | | | | | | | | Adds a disabled test waiting for rolling https://bugs.webkit.org/show_bug.cgi?id=36315 TEST=geolocation_browsertest.cc Review URL: http://codereview.chromium.org/1134001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42212 0039d316-1c4b-4281-b951-d872f2087c98
* Uses GURL instead of host for requesting Geolocation permission.bulach@chromium.org2010-03-194-191/+36
| | | | | | | | | Tidy up GeolocationPermissionContext. (in preparation for http://codereview.chromium.org/1033004). Review URL: http://codereview.chromium.org/1074004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42099 0039d316-1c4b-4281-b951-d872f2087c98
* Add GeolocationContentSettingsMap, a geolocation-specific variant of ↵pkasting@chromium.org2010-03-193-0/+555
| | | | | | | | | | | | | HostContentSettingsMap. This was originally written by bulach and posted at http://codereview.chromium.org/1033004 ; modified and landed by me. BUG=37206 TEST=Tested by unittests TBR=bulach,joth Review URL: http://codereview.chromium.org/1084005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42064 0039d316-1c4b-4281-b951-d872f2087c98
* Finish implementing the geolocation infobar; adds a Learn more link pointing ↵joth@chromium.org2010-03-181-6/+22
| | | | | | | | | | | | | | | | | to the (placeholder) help center page. This extends ConfirmInfoBar to support to have optional link support (simple support, i.e. not the inserted mid-label link that LinkInfoBar sports) Note 1: this does not exactly match the mock; the allow/deny buttons and link are swapped. I think this looks nicer, is more consistent with other confirm infobars, and happens to be easier to code Note 2: linux & mac will need follow-up CLs, but will simply ignore the link in the meantime BUG=11246 TEST=browser_tests.exe --gtest_filter=Geol* Review URL: http://codereview.chromium.org/1037006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@41951 0039d316-1c4b-4281-b951-d872f2087c98
* Switch from using custom time / epoch handling code (inherited from gears) ↵joth@chromium.org2010-03-1610-46/+60
| | | | | | | | | | | to base::Time BUG=http://code.google.com/p/chromium/issues/detail?id=37510 TEST=unit_tests --gtest_filter=geol* Review URL: http://codereview.chromium.org/776001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@41722 0039d316-1c4b-4281-b951-d872f2087c98
* Adds host for Geolocation OnStartUpdating.bulach@chromium.org2010-03-152-5/+11
| | | | | | | | | | | This change blocks https://bugs.webkit.org/show_bug.cgi?id=36012 A follow-up will: + Remove the overloaded method (once WebKit lands). + Actually use the host. Review URL: http://codereview.chromium.org/848003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@41591 0039d316-1c4b-4281-b951-d872f2087c98
generated by cgit v1.1 at 2025-02-08 02:47:46 +0000