summaryrefslogtreecommitdiffstats
path: root/chrome/browser/geolocation
Commit message (Collapse)AuthorAgeFilesLines
* [InfoBar] remove unnecesary checks from some delegates.miguelg@chromium.org2013-11-061-5/+4
| | | | | | | | BUG=none Review URL: https://codereview.chromium.org/56123010 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@233383 0039d316-1c4b-4281-b951-d872f2087c98
* Confirm timvolodine as Geolocation owner and include the java files.mvanouwerkerk@chromium.org2013-10-311-2/+1
| | | | | | Review URL: https://codereview.chromium.org/52663002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@232111 0039d316-1c4b-4281-b951-d872f2087c98
* Move ScopedUserPrefUpdate to base/prefs.derat@chromium.org2013-10-301-1/+1
| | | | | | | | | | | | Move this outside of Chrome to enable moving ExtensionPrefs to the top-level extensions/ directory. BUG=313284 TBR=sky@chromium.org Review URL: https://codereview.chromium.org/46073004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@231905 0039d316-1c4b-4281-b951-d872f2087c98
* Gardening. Disable GeolocationBrowserTest.NoInfobarForSecondTab.hayato@chromium.org2013-10-171-1/+2
| | | | | | | | | BUG=308358 TBR=alecflett Review URL: https://codereview.chromium.org/27635003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@229020 0039d316-1c4b-4281-b951-d872f2087c98
* Geolocation: add UMA instrumentation to the infobar.mvanouwerkerk@chromium.org2013-10-173-2/+87
| | | | | | Review URL: https://codereview.chromium.org/26255002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@229019 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 228779 "Update defaults for InstantExtended."erg@chromium.org2013-10-151-8/+3
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Introduces crashes on the mac tests: http://build.chromium.org/p/chromium.mac/builders/Mac%2010.6%20Tests%20%28dbg%29%284%29/builds/34018/steps/unit_tests/logs/stdio Specifically, these tests now crash: TabStripControllerTest.TabCloseDuringDrag TabposeWindowTest.TestModelObserver TabposeWindowTest.TestShow And this test suite is referenced in this patch. > Update defaults for InstantExtended. > > Flip the InstantExtended New Tab page to on by default and remove the flags. > Add a separate flag to control query in the omnibox (which is still off by > default). > > Also fixes a ton of tests that needed adjusting for Instant Extended. Mostly > the changes stem from the fact that we're prerendering the Instant Extended > New Tab page which changes assumptions in a bunch of tests. > > BUG=297915 > > Review URL: https://codereview.chromium.org/24733003 TBR=samarth@chromium.org Review URL: https://codereview.chromium.org/27235010 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@228794 0039d316-1c4b-4281-b951-d872f2087c98
* Update defaults for InstantExtended.samarth@chromium.org2013-10-151-3/+8
| | | | | | | | | | | | | | | | Flip the InstantExtended New Tab page to on by default and remove the flags. Add a separate flag to control query in the omnibox (which is still off by default). Also fixes a ton of tests that needed adjusting for Instant Extended. Mostly the changes stem from the fact that we're prerendering the Instant Extended New Tab page which changes assumptions in a bunch of tests. BUG=297915 Review URL: https://codereview.chromium.org/24733003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@228779 0039d316-1c4b-4281-b951-d872f2087c98
* [Android] Update mobile "Learn More" URL on Geolocation infobar.kkimlabs@chromium.org2013-10-111-0/+2
| | | | | | | | | NOTRY=true BUG=298445 Review URL: https://codereview.chromium.org/25981002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@228213 0039d316-1c4b-4281-b951-d872f2087c98
* Make mvanouwerkerk@chromium.org a geolocation owner and reviewer.mvanouwerkerk@chromium.org2013-09-241-2/+4
| | | | | | | | Suggest timvolodine@chromium.org as additional reviewer. Review URL: https://chromiumcodereview.appspot.com/23556013 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@225045 0039d316-1c4b-4281-b951-d872f2087c98
* GeolocationPermissionContext: only use origin from embedder url.mvanouwerkerk@chromium.org2013-09-133-13/+44
| | | | | | | | | | | | Specifically for the bug being fixed, if the hash is not stripped, and it changes while the info bar is displayed, then an equality comparison will fail needlessly later. Also, use WebContents::GetLastCommittedURL instead of the deprecated GetURL. BUG=286667 Review URL: https://chromiumcodereview.appspot.com/23440030 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@223078 0039d316-1c4b-4281-b951-d872f2087c98
* Rename GeolocationArbitrator to LocationArbitrator.mvanouwerkerk@chromium.org2013-09-101-1/+0
| | | | | | | | It was generally referred to in file names as location_arbitrator, but the class was called GeolocationArbitrator. Review URL: https://chromiumcodereview.appspot.com/23844003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@222338 0039d316-1c4b-4281-b951-d872f2087c98
* [GeoLocation] Check for webcontents on the set permission delegate.miguelg@chromium.org2013-08-291-3/+5
| | | | | | | | BUG=278486 Review URL: https://chromiumcodereview.appspot.com/23545007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@220206 0039d316-1c4b-4281-b951-d872f2087c98
* Infobar for JavaScript APIs should invoke a callback on closingtoyoshim@chromium.org2013-08-212-0/+5
| | | | | | | | | | | | | | Currently, just closing infobar doesn't invoke any callback for JavaScript APIs, e.g., Geolocation, and Web MIDI. But, it is better to invoke a failure callback and not to cache the negative response. BUG=none TEST=manual TBR=joth@chromium.org, scherkus@chromium.org Review URL: https://chromiumcodereview.appspot.com/23307004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@218730 0039d316-1c4b-4281-b951-d872f2087c98
* Add some comments in geolocation_browsertest.cc.mvanouwerkerk@chromium.org2013-08-161-1/+22
| | | | | | Review URL: https://chromiumcodereview.appspot.com/23236003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@218067 0039d316-1c4b-4281-b951-d872f2087c98
* Enable NoInfobarForSecondTab and NoInfobarForDeniedOrigin.mvanouwerkerk@chromium.org2013-08-141-14/+2
| | | | | | | | | | These tests were hangy and crashy on Mac and Win at some point in the past. Much has changed since then, and some of that was specifically aimed at making the tests less flaky. BUG=44589 Review URL: https://chromiumcodereview.appspot.com/23056004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@217650 0039d316-1c4b-4281-b951-d872f2087c98
* Enable Geolocation tests that were flaky at some point.mvanouwerkerk@chromium.org2013-08-021-8/+3
| | | | | | | | | | A lot has changed since they were diabled and they may no longer be flaky. BUG=176291 Review URL: https://chromiumcodereview.appspot.com/21851003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@215361 0039d316-1c4b-4281-b951-d872f2087c98
* Web MIDI: implement permission infobartoyoshim@chromium.org2013-08-021-1/+1
| | | | | | | | | BUG=257618 TBR=jochen@chromium.org Review URL: https://chromiumcodereview.appspot.com/20990005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@215257 0039d316-1c4b-4281-b951-d872f2087c98
* Misc. cleanup part III:pkasting@chromium.org2013-07-241-4/+2
| | | | | | | | | | | | | | | | | | * Assertion changes: Tests should verify things that could fail, and not verify things that can't * Rename "infobar_delegate" to "infobar" to reduce refactor diff * Whitespace/comment tweaks * Move AppMetroInfoBarDelegateWin out of "chrome" namespace * Infobar -> InfoBar * Remove some erroneous header guards from a .cc file BUG=none TEST=none R=sky@chromium.org Review URL: https://codereview.chromium.org/19759006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@213517 0039d316-1c4b-4281-b951-d872f2087c98
* Make PermissionQueueController available from other content settingstoyoshim@chromium.org2013-07-2314-648/+66
| | | | | | | | | | | | | | Make these stuff available from other content settings, e.g. Web MIDI. This change still have dependency from PermissionQueueController to GeolocationInfoBarDelegate. It will be removed by the following change. TEST=PermissionQueueControllerTests BUG=257618 NOTRY=true Review URL: https://chromiumcodereview.appspot.com/19376004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@213063 0039d316-1c4b-4281-b951-d872f2087c98
* Move GeolocationSettingsState to ContentSettingsUsagesStatetoyoshim@chromium.org2013-07-234-190/+10
| | | | | | | | | | | | | GeolocationSettingsState is an useful class to be shared with other content settings, e.g. coming one for Web MIDI. TEST=ContentSettingsUsageStateTests.* BUG=257618 NOTRY=true Review URL: https://chromiumcodereview.appspot.com/19375002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@213057 0039d316-1c4b-4281-b951-d872f2087c98
* Remove unused WebKit includes and DEPS entries from chrome/browserjamesr@chromium.org2013-07-201-2/+0
| | | | | | | | | R=sky BUG=237267 Review URL: https://chromiumcodereview.appspot.com/19462014 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@212707 0039d316-1c4b-4281-b951-d872f2087c98
* More misc. cleanup:pkasting@chromium.org2013-07-196-155/+158
| | | | | | | | | | | | | | | | | | * Rename various things from "delegate" to "infobar", mostly to minimize the diff later when the underlying types change from InfoBarDelegate to InfoBar, also to be less confusing in some places. * Fix indenting * Hoist a dependency from GeolocationInfoBarDelegate() to Create() to make dependencies more direct and require fewer forward-declarations (will become necessary later when class no longer takes an InfoBarService*) BUG=none TEST=none R=bulach@chromium.org Review URL: https://codereview.chromium.org/19778007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@212649 0039d316-1c4b-4281-b951-d872f2087c98
* Clarify geolocation OWNERSjoth@chromium.org2013-07-191-1/+5
| | | | | | | | | | Add mvanouwerkerk as reviewer, but not yet an OWNER (as not yet a committer) NOTRY=true Review URL: https://chromiumcodereview.appspot.com/19494008 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@212596 0039d316-1c4b-4281-b951-d872f2087c98
* Remove ExtensionURLInfo, make security decisions in render processjamesr@chromium.org2013-07-181-3/+1
| | | | | | | | | | | | | | | | | | | When asking if an extension should have access to a given frame, we need to consider the frame's URL and also if the frame is sandboxed. We check the latter by asking if the frame's security origin is the unique origin. However, we can only usefully do this in the render process when examining a frame. In the browser process or other common code, there's no useful origin to use other than one that duplicates information in the URL. This does security checks in the render process before doing any URL-based lookups and then uses URLs from that point on. R=abarth, mpcomplete BUG=259982,237267 Review URL: https://chromiumcodereview.appspot.com/16625012 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@212302 0039d316-1c4b-4281-b951-d872f2087c98
* Use a direct include of the message_loop header in chrome/browser/, part 4.avi@chromium.org2013-07-181-1/+1
| | | | | | | | | | BUG=260807 TEST=none TBR=ben@chromium.org Review URL: https://chromiumcodereview.appspot.com/19556004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@212189 0039d316-1c4b-4281-b951-d872f2087c98
* Update some includes of chrome_notification_types.hjam@chromium.org2013-07-123-3/+3
| | | | | | | | TBR=brettw Review URL: https://codereview.chromium.org/19074002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@211285 0039d316-1c4b-4281-b951-d872f2087c98
* Clean up the geolocation code a little:pkasting@chromium.org2013-07-098-217/+198
| | | | | | | | | | | | | | | | | | * Fix wrong indenting * Style guide compliance, in particular: ** Enforce "no protected data members" in geolocation_browsertest.cc (use accessors instead) ** All .cc files including tests should declare the .h they're implementing/testing first * Shorten code in some places * Infobar -> InfoBar * Declare more destructors (makes it clearer if the class has a virtual destructor, makes it more obvious that the destructor doesn't need to do anything special) BUG=none TEST=none R=bulach@chromium.org Review URL: https://codereview.chromium.org/18338012 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@210622 0039d316-1c4b-4281-b951-d872f2087c98
* Allow Chrome OS login profile to have different default pref valuesbartfab@chromium.org2013-07-052-2/+2
| | | | | | | | | | | | | | | | | | | | | | | | | | This CL is a prerequisite for putting Chrome in charge of all power management settings. Since the power management defaults on the login screen differ from those during a user session, the default values of the power prefs should be set differently for the login profile. This CL has no functional changes. It just does the following: 1/ Split chrome::RegisterUserPrefs() into: * chrome::RegisterUserProfilePrefs() * chrome::RegisterLoginProfilePrefs() 2/ Rename all other RegisterUserPrefs() methods to RegisterProfilePrefs(). BUG=241794 TEST=Updated unit and browser tests TBR=jochen@chromium.org (blanket rename of RegisterUserPrefs() in chrome/) TBR=asargent@chromium.org (blanket rename of RegisterUserPrefs() in apps/) TBR=joi@chromium.org (blanket rename of RegisterUserPrefs() in components/) Review URL: https://chromiumcodereview.appspot.com/18199003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@210310 0039d316-1c4b-4281-b951-d872f2087c98
* chrome/browser: Migrate from googleurl/ includes to url/ ones. Part 1tfarina@chromium.org2013-07-023-5/+5
| | | | | | | | | BUG=229660 TBR=darin@chromium.org Review URL: https://chromiumcodereview.appspot.com/18054023 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@209705 0039d316-1c4b-4281-b951-d872f2087c98
* GTTF: convert some tests in chrome to use EmbeddedTestServer patch nr 1phajdan.jr@chromium.org2013-06-261-19/+16
| | | | | | | | | | | | This eliminates a whole class of problems with SpawnedTestServer failing to start. BUG=96594, 98194 R=asargent@chromium.org, rsleevi@chromium.org, sky@chromium.org Review URL: https://codereview.chromium.org/16268017 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@208784 0039d316-1c4b-4281-b951-d872f2087c98
* Update Blink include pathsabarth@chromium.org2013-06-171-1/+1
| | | | | | | | | | | | | This CL changes the majority of include paths from the old Source/WebKit/chromium/public to the new public/web directory. TBR=darin BUG=239545 NOTRY=true Review URL: https://chromiumcodereview.appspot.com/17148003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@206664 0039d316-1c4b-4281-b951-d872f2087c98
* Rename base/hash_tables to base/containers/hash_tables.brettw@chromium.org2013-06-111-1/+1
| | | | | | | | | | | Remove forwarding header BUG= R=avi@chromium.org Review URL: https://codereview.chromium.org/16667019 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@205584 0039d316-1c4b-4281-b951-d872f2087c98
* Use a direct include of strings headers in chrome/browser/e*-h*/.avi@chromium.org2013-06-103-3/+3
| | | | | | | | | | BUG=247723 TEST=none TBR=ben@chromium.org Review URL: https://chromiumcodereview.appspot.com/16703006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@205319 0039d316-1c4b-4281-b951-d872f2087c98
* Use a direct include of utf_string_conversions.h in chrome/browser/, part 2.avi@chromium.org2013-06-076-6/+6
| | | | | | | | | | BUG=none TEST=none TBR=ben@chromium.org Review URL: https://chromiumcodereview.appspot.com/16561007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@204977 0039d316-1c4b-4281-b951-d872f2087c98
* Add TestBrowserThreadBundle into RenderViewHostTestHarness. Kill some ↵ajwong@chromium.org2013-06-062-60/+14
| | | | | | | | | | | | | | | | | | | | | | | | | | unnecessary real threads. This CL creates a new class, TestBrowserThreadBundle, that creates a TestBrowserThread for the most commonly needed BrowserThreads. It also adds this thread bundle into RenderViewHostTestHarness because most tests that use this harness need these threads in order to run. To support TestBrowserThreadBundle, BrowserThreadImpl's test construction was also modified to understand a NULL message_loop. Aside from introducing the new class, this CL also removes: (1) unnecessary constructors in test (2) DISALLOW_COPY_AND_ASSIGNS in test fixtures* (3) now redundant TestBrowserThreads from tests (4) bad access-level changes for SetUp() and TearDown() (5) using declarations that root off the global scope (6) uses of MessageLoop's RunUntilIdle() and Quit() (7) as many real threads as possible There are also a changes to MediaCaptureDevicesDispatcher and OneClickSigninHelper that allow unittests to cut dependencies on IO thread activity. DesktopNotificationServiceTest (and a couple of others) were also made single threaded because the synchronization logic required for a non-flaky test meant the parallelism only really exercised the extra code in the test that forced the serialization. * DISALLOW_COPY_AND_ASSIGN does not serve much purpose in GTest fixture types. However, using it removes the compile-provided default constructor which forces the fixture writer to provide an empty default constructor. Since GTest recommends the default constructor as the preferred method to do setup for a test (as opposed to the SetUp() method), it's confusing to have bunch of classes with both SetUp() and a default constructor. It's simpler and uses less code to just remove the DISALLOW_COPY_AND_ASSIGN. An alternative would be to use the default constructor for initialization, but this is not possible because of our test harnesses are inheritance based which means it is impossible for a derived fixture to perform initialization before the harness if we use the GTest preferred default constructor initialization pattern. TBR=avi,battre,ben,benwells,brettw,dbeam,dimich,joi,joth,mad,marja,markusheintz,noelallen,phajdan,rdsmith,satorux,scherkus,sky,stevenjb,stuartmorgan,timsteele BUG=159193 Review URL: https://chromiumcodereview.appspot.com/14197014 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@204603 0039d316-1c4b-4281-b951-d872f2087c98
* Update chrome/ to use scoped_refptr<T>::get() rather than implicit "operator T*"rsleevi@chromium.org2013-06-021-1/+1
| | | | | | | | | | | Linux fixes, Part 3 of N BUG=110610 TBR=darin Review URL: https://chromiumcodereview.appspot.com/16296002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@203626 0039d316-1c4b-4281-b951-d872f2087c98
* Update refernces to Blink's Platform API (chrome)abarth@chromium.org2013-05-301-1/+1
| | | | | | | | | | | | | | These headers have moved from Source/Platform/chromium/public to public/platform. This CL updates chrome's references to the old location to point to the new location. After this CL lands, I'll remove the forwarding headers that are letting these references still work. TBR=jamesr@chromium.org BUG=239545 Review URL: https://chromiumcodereview.appspot.com/16109004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@203133 0039d316-1c4b-4281-b951-d872f2087c98
* chrome: Use base::MessageLoop. (Part 3)xhwang@chromium.org2013-05-285-7/+7
| | | | | | | | | | | | This CL updates chrome/browser/* other than chrome/browser/ui which is in another CL. BUG=236029 TBR=brettw Review URL: https://chromiumcodereview.appspot.com/14113053 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@202664 0039d316-1c4b-4281-b951-d872f2087c98
* Remove references to Profile from browser_context_keyed_service.phajdan.jr@chromium.org2013-05-222-8/+8
| | | | | | | | | BUG=227219 R=joi@chromium.org Review URL: https://codereview.chromium.org/15517005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@201634 0039d316-1c4b-4281-b951-d872f2087c98
* Move ProfileKeyedService infrastructure to a componentphajdan.jr@chromium.org2013-05-202-2/+2
| | | | | | | | | | | Renames of the classes and methods will follow in separate patch(es). BUG=227219 R=erg@chromium.org, joi@chromium.org Review URL: https://codereview.chromium.org/14743010 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@201167 0039d316-1c4b-4281-b951-d872f2087c98
* [InfoBar] Add InfoBarDelegate::GetIconID()dfalcantara@chromium.org2013-05-163-6/+4
| | | | | | | | | | | | | | | | | | | | | Splits apart the GetIcon() call to allow accessing the ID of the resource in addition to the loaded image. This is needed so that the Android port can determine which of the Java-side resources it needs to load for its UI. * GetIconID() is a function that gets overridden by subclasses instead of GetIcon(). GetIconID() returns the IDR_* tag that represents the icon that it would normally load. * GetIcon() now calls GetIconID() and shouldn't be overridden. * Small change to the SimpleAlertInfoBarDelegate::Create() call to account for invalid icon IDs (was NULL for bitmaps, 0 for non-existent icons). BUG=237034 Review URL: https://chromiumcodereview.appspot.com/15067008 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@200598 0039d316-1c4b-4281-b951-d872f2087c98
* Move SpawnedTestServer to its own subdirectory.phajdan.jr@chromium.org2013-05-071-1/+1
| | | | | | | | | | | | This is a part of replacing most usages of the Python test server with an in-process C++ test server that should be easier to debug. BUG=96594 R=rch@chromium.org Review URL: https://codereview.chromium.org/14691006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@198783 0039d316-1c4b-4281-b951-d872f2087c98
* Removes jknotten from OWNERS.bulach@chromium.org2013-05-071-1/+0
| | | | | | | | | BUG= TBR=joi@chromium.org,jam@chromium.org,digit@chromium.org Review URL: https://chromiumcodereview.appspot.com/14636005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@198755 0039d316-1c4b-4281-b951-d872f2087c98
* components: Move PrefRegistrySyncable into user_prefs namespace.tfarina@chromium.org2013-05-062-5/+7
| | | | | | | | | | BUG=180785 R=joi@chromium.org TBR=darin@chromium.org Review URL: https://chromiumcodereview.appspot.com/14622003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@198384 0039d316-1c4b-4281-b951-d872f2087c98
* Change GetProfileToUse method from Profile to content::BrowserContextphajdan.jr@chromium.org2013-05-032-10/+7
| | | | | | | | | | | | | | | This drops a dependency on Profile in the interface of ProfileKeyedService infrastructure, and adds helper functions that make it explicit what is being done (it's not obvious just from "return context" for example that this will result in the service having its own instance in Incognito mode instead of no instance). BUG=227219 R=erg@chromium.org, joi@chromium.org Review URL: https://codereview.chromium.org/13865012 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@198232 0039d316-1c4b-4281-b951-d872f2087c98
* GTTF: rename net::TestServer -> net::SpawnedTestServerphajdan.jr@chromium.org2013-05-031-1/+1
| | | | | | | | | | | | This is a part of replacing most usages of the Python test server with an in-process C++ test server that should be easier to debug. BUG=96594 R=rch@chromium.org Review URL: https://codereview.chromium.org/14702004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@198151 0039d316-1c4b-4281-b951-d872f2087c98
* Formatting cleanup. Should be no code change.pkasting@chromium.org2013-05-034-248/+309
| | | | | | | | | | | | | | | * Don't define complex functions inline * Use DISALLOW_COPY_AND_ASSIGN where appropriate * Make consistent the headers on sections of a class declaration or .cc file * Use two newlines between major sections of a .cc file BUG=none TEST=none R=sky@chromium.org Review URL: https://codereview.chromium.org/14619002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@198027 0039d316-1c4b-4281-b951-d872f2087c98
* Reorder pieces of code. No other changes.pkasting@chromium.org2013-04-305-44/+47
| | | | | | | | | | | | | | | | | * Make overriding functions as private as possible * Make declaration order match definition order * Fix a few other problems with section order not following the style guide * For consistency, list functions in order: virtuals, non-virtuals, macro-based declarations * In a few .cc files, try to keep class declarations and definitions together * In a few .cc files, move enums into the classes the use them BUG=none TEST=none R=sky@chromium.org Review URL: https://codereview.chromium.org/14383022 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@197198 0039d316-1c4b-4281-b951-d872f2087c98
* [components] Switch {RefCounted}ProfileKeyedService to use BrowserContextphajdan.jr@chromium.org2013-04-262-3/+4
| | | | | | | | | | instead of Profile. This will help move it out of chrome. BUG=227219 Review URL: https://codereview.chromium.org/14141006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@196777 0039d316-1c4b-4281-b951-d872f2087c98
* Add InfoBarDelegate::web_contents(). This is convenient for the number ofpkasting@chromium.org2013-04-241-2/+2
| | | | | | | | | | | | | | places that do owner()->web_contents() currently, and will also make the future transition to owners living on the InfoBar instead of the delegate easier. This also fixes a couple places that didn't use OpenURL() to navigate and removes one unnecessary override. BUG=none TEST=none Review URL: https://codereview.chromium.org/14327013 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@195982 0039d316-1c4b-4281-b951-d872f2087c98
generated by cgit v1.1 at 2025-02-08 06:11:14 +0000