| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
|
|
| |
BUG=69289
TEST=none
Review URL: http://codereview.chromium.org/6292009
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71877 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
(moved *.cc using 'svn mv' to preserve history)
(copied *.h using 'svn cp' to preserve history and stub out originals)
Stubbed out original headers in chrome/browser/gtk/
Update header guards & copyright dates in chrome/browser/ui/gtk/
Update .gypi files
Remove chrome/chrome_browser.gypi:4228 reference to nonexistant:
['include', '^browser/gtk/pk11_password_dialog.h'],
Remove stray header guard in:
chrome/browser/ui/gtk/bookmark_bar_instructions_gtk.cc
Add #pragma once to the following files:
chrome/browser/ui/gtk/instant_confirm_dialog_gtk.h
chrome/browser/ui/gtk/infobar_arrow_model.h
Ran the following to appease presubmit: 'svn pset svn:eol-style LF \
chrome/browser/ui/gtk/info_bubble_accelerators_gtk.cc \
chrome/browser/ui/gtk/gtk_custom_menu.cc \
chrome/browser/ui/gtk/info_bubble_accelerators_gtk.h \
chrome/browser/ui/gtk/gtk_custom_menu.h \
chrome/browser/ui/gtk/options/managed_prefs_banner_gtk.h \
chrome/browser/ui/gtk/chrome_gtk_frame.h \
chrome/browser/ui/gtk/chrome_gtk_frame.cc \
chrome/browser/ui/gtk/gtk_custom_menu_item.h \
chrome/browser/gtk/info_bubble_accelerators_gtk.h \
chrome/browser/gtk/gtk_custom_menu.h \
chrome/browser/gtk/options/managed_prefs_banner_gtk.h \
chrome/browser/gtk/chrome_gtk_frame.h \
chrome/browser/gtk/gtk_custom_menu_item.h'
BUG=69289
TEST=Compile&Trybots
Review URL: http://codereview.chromium.org/6251001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71397 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
This is upstreaming a Gentoo Linux patch.
BUG=13322
TEST=none
Review URL: http://codereview.chromium.org/4691001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@65507 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
buttons.
BUG=46652
TEST=Switch back and forth between themes that put the buttons on different sides of the window frame (try Ambiance and Clearlooks). Incognito windows should move the spy guy back and forth.
Review URL: http://codereview.chromium.org/4177007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@64307 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Slightly change the architecture of how icons are assigned to menu items. Also,
add stock icons for some additional menu items. And always show icons on
overflow menus.
BUG=59101
TEST=The major change here is architectural change, so there is little visible
change in functionality. But if you right click on a link, it should now show
an icon for the 'Open in new tab' menu.
patch by sadrul@chromium.org
original review: http://codereview.chromium.org/3714003/show
Review URL: http://codereview.chromium.org/3816002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@62461 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This patch adds nice little icons in the menus (both for context and window
menus). At this moment, only standard stock icons are used. It will be possible
to add new stock icons of Chrome's own for the items that currently don't have
any corresponding GTK+ stock icons.
BUG=None
TEST=Open the wrench menu, or context menu for the tab content/tab title etc.,
and you should see nice little icons on the left for many items.
Review URL: http://codereview.chromium.org/3619010
Patch from Sadrul Chowdhury <sadrul@chromium.org>.
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@61983 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=50273
TEST=everything still builds, build is 10% faster on windows, same speed on mac/linux
TBR: erg
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@53716 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=None
TEST=trybots and manually
Review URL: http://codereview.chromium.org/2448001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@48689 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
When running under GNOME, read the gconf key that defines the button placement
and lay the close, minimize and maximize buttons out. This can even handle
bizarre combinations like putting the close button on the left and the
minimize/maximize buttons on the right.
When running under anything else, use the default button ordering.
BUG=39406
TEST=none
Review URL: http://codereview.chromium.org/2095001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@47195 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
BUG=None
TEST=compiles
Patch from Thiago Farina <thiago.farina@gmail.com>
Review URL: http://codereview.chromium.org/1564011
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@43853 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
Consolidate all accelerators for browser commands into one place.
BUG=28212,27535
TEST=1. enable custom frame and a popup window and test that the popup contains all the same (non-system) menu items as windows.
2. all context menus still display the correct shortcuts and the shortcuts work
Review URL: http://codereview.chromium.org/551032
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@36527 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
trigger the bots to test r36104.)
TBR=oshima
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/542051
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@36105 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
- implement more MenuModel support for MenuGtk
- copy some accelerators around
TODO: centralize accelerator list (currently they are all listed twice)
TODO: get rid of standard_menus.cc (it is still used by the popup favicon menu)
BUG=NONE
TEST=page and app menus still work, still display accelerators, accelerators still work
Review URL: http://codereview.chromium.org/523105
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@35671 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
If the user right clicks on the maximize button, it will horizontally maximize the window, and if the user middle clicks on the maximize button it will vertically maximize the window.
At least on kde, the window manager supports more complicated behavior, e.g. right clicking on a window that is horizontally maximized will return it to its former size. It seems to keep track of multiple restored rects. However, we're not well equipped to replicate this behavior, so I just didn't add it. If the user wants it, they can disable the custom frame.
BUG=28881
Review URL: http://codereview.chromium.org/455012
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@33389 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=18181
Review URL: http://codereview.chromium.org/244029
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27666 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
views. Converts from using notification server to observer as
notification service is chrome only.
Also changes the pointer type used by window_gtk to be a left arrow.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/245016
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27398 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
BUG=19734
TEST=Run chrome --app=http://www.google.com/ . The task bar should
show the google favicon.
Review URL: http://codereview.chromium.org/174542
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@24513 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
http://crbug.com/18856
Review URL: http://codereview.chromium.org/174100
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23828 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
This reverts commit 872a67636100b790dd034fe502e585d6a6abe716
(r23734). Use of notifications is questionable.
TBR=estade
Review URL: http://codereview.chromium.org/174087
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23744 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
I'm pretty certain we'll never be able to match the text color on custom popup
windows, but at the very least make it legible. Tested in both light and dark
themes.
http://crbug.com/18856
Review URL: http://codereview.chromium.org/173061
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23734 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=18181
Review URL: http://codereview.chromium.org/160653
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22537 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/160593
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22515 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
app mode window or a popup window. The icon will become a
clockwise spinning throbber when pages are loading.
BUG=16049
TEST=Open a window using --app=http://google.com/ and click on a
few links.
Review URL: http://codereview.chromium.org/160427
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22157 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
TEST=none
BUG=1316
Review URL: http://codereview.chromium.org/155053
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20297 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
button's clickable area when maximized.
BUG= http://crbug.com/14646 and http://crbug.com/15628
TEST=maximize, turn on custom frame. The top right most pixel on the screen should be clickable and should close the window. There should be no border around the web contents.
Review URL: http://codereview.chromium.org/150078
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19567 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
browser is maximized.
TEST=maximize and enable custom frame
BUG=http://crbug.com/15431
Review URL: http://codereview.chromium.org/150072
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19551 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
RTL. Use this function for custom buttons and for the Off the Record avatar.
for reference, this will be a bit different than Views, which does it per class rather than per image: http://dev.chromium.org/developers/design-documents/ui-mirroring-infrastructure
Review URL: http://codereview.chromium.org/147157
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19309 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=go incognito, toggle custom frame drawing
Review URL: http://codereview.chromium.org/146122
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19220 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
browser window. This fixes a visual bug where the border looked
disconnected with the background. This matches what Windows does.
BUG=14884
Review URL: http://codereview.chromium.org/140078
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18954 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
I also switched from 3px borders to 4px borders because that's what they are
on windows. On linux, the borders look bigger because our webcontent area
doesn't drop a shadow.
For this to work for resizing on top, I had to remove the event box from
the browser titlebar and move the mouse event handling to the window.
BUG=14645
Review URL: http://codereview.chromium.org/140026
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18927 0039d316-1c4b-4281-b951-d872f2087c98
|
|
and cluttering up browser_window_gtk.
Fix a small painting bug when a menu is drawn over the titlebar background.
Also move the tab strip context menu into the titlebar background container
by adding an event box. Now the context menu appears e.g., below the
min/max/close buttons or above the tab strip.
Review URL: http://codereview.chromium.org/125078
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18328 0039d316-1c4b-4281-b951-d872f2087c98
|