summaryrefslogtreecommitdiffstats
path: root/chrome/browser/gtk/constrained_window_gtk.cc
Commit message (Collapse)AuthorAgeFilesLines
* [Gtk] add facility for constrained window delegate to control background color.estade@chromium.org2010-10-181-0/+15
| | | | | | | | | | | This makes modal html dialogs blend better (rather than having a white HTML background and a theme-colored border). BUG=none TEST=manual Review URL: http://codereview.chromium.org/3784006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@62968 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 61269 (broke lots of browser and ui tests, like on your try run) - ↵thakis@chromium.org2010-10-021-2/+5
| | | | | | | | | | | | | | | | [GTK] delay reference count check in OwnedWidgetGtk It's a common problem that a GtkWidget will be referenced by an event that's currently on the callstack. These ref holders ignore the "destroy" signal, so when we go to destroy the owned widget, the refcount == 1 DCHECK fails. This change delays that DCHECK until the current stack has unwound, so we don't have to keep running into this. BUG=none TEST=in debug builds, Escape in a constrained window doesn't DCHECK, dragging a tab doesn't cause a DCHECK, pressing the custom frame [x] in lucid doesn't DCHECK; in general, no additional DCHECKs Review URL: http://codereview.chromium.org/3416032 TBR=estade@chromium.org Review URL: http://codereview.chromium.org/3564007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@61283 0039d316-1c4b-4281-b951-d872f2087c98
* [GTK] delay reference count check in OwnedWidgetGtkestade@chromium.org2010-10-021-5/+2
| | | | | | | | | | | It's a common problem that a GtkWidget will be referenced by an event that's currently on the callstack. These ref holders ignore the "destroy" signal, so when we go to destroy the owned widget, the refcount == 1 DCHECK fails. This change delays that DCHECK until the current stack has unwound, so we don't have to keep running into this. BUG=none TEST=in debug builds, Escape in a constrained window doesn't DCHECK, dragging a tab doesn't cause a DCHECK, pressing the custom frame [x] in lucid doesn't DCHECK; in general, no additional DCHECKs Review URL: http://codereview.chromium.org/3416032 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@61269 0039d316-1c4b-4281-b951-d872f2087c98
* reland r57885 with a fix for the DCHECK failures observed by nsylvain.estade@chromium.org2010-09-041-34/+16
| | | | | | | | | | | Now we only delay shutdown of the constrained window in the escape case (see constrained_window_gtk.cc). Locally this fixes the DCHECKs in both manual testing and the login prompt ui tests. BUG=53242, 50799 TEST=ui_tests --gtest_filter=LoginPromptTest* Review URL: http://codereview.chromium.org/3351006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@58570 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 58259 - reland r57885 with a fix for linux/views.nsylvain@chromium.org2010-09-021-15/+36
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | We believe this caused a lot of login prompt auth tests to fail with : [5860:5871:2463125642585:FATAL:chrome/browser/gtk/owned_widget_gtk.cc(39)] Check failed: ((((GObject*) g_type_check_instance_cast ((GTypeInstance*) ((widget)), (((GType) ((20) << (2))))))))->ref_count == 1U (3 vs. 1) Backtrace: StackTrace::StackTrace() [0x8b2d896] logging::LogMessage::~LogMessage() [0x8b47321] OwnedWidgetGtk::Destroy() [0x81b2536] LoginHandlerGtk::~LoginHandlerGtk() [0x860a419] base::RefCountedThreadSafe<>::DeleteInternal() [0x82911a4] base::DefaultRefCountedThreadSafeTraits<>::Destruct() [0x82911b7] base::RefCountedThreadSafe<>::Release() [0x8291215] ------ Original message: [GTK] a couple of constrained window fixes: 1) don't grab focus when the parent tab isn't showing. Grab the focus when the tab is brought to the front. 2) handle escape via normal key handling rather than accelerator keys 3) don't allow the content view to take focus (via tab) when the constrained window is showing. BUG=53242, 50799 TEST=see bugs. Also, tabbing between constrained window and url bar should work as expected. Review URL: http://codereview.chromium.org/3235010 TBR=estade@chromium.org Review URL: http://codereview.chromium.org/3293005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@58308 0039d316-1c4b-4281-b951-d872f2087c98
* reland r57885 with a fix for linux/views.estade@chromium.org2010-09-011-36/+15
| | | | | | | | | | | | | | | [GTK] a couple of constrained window fixes: 1) don't grab focus when the parent tab isn't showing. Grab the focus when the tab is brought to the front. 2) handle escape via normal key handling rather than accelerator keys 3) don't allow the content view to take focus (via tab) when the constrained window is showing. BUG=53242, 50799 TEST=see bugs. Also, tabbing between constrained window and url bar should work as expected. Review URL: http://codereview.chromium.org/3235010 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@58259 0039d316-1c4b-4281-b951-d872f2087c98
* Reverting to fix Chromium Arm compile failures. Please reland after fixing.ananta@chromium.org2010-08-301-15/+36
| | | | | | | | | | | | | | | | | | Revert 57885 - [GTK] a couple of constrained window fixes: 1) don't grab focus when the parent tab isn't showing. Grab the focus when the tab is brought to the front. 2) handle escape via normal key handling rather than accelerator keys 3) don't allow the content view to take focus (via tab) when the constrained window is showing. BUG=53242, 50799 TEST=see bugs. Also, tabbing between constrained window and url bar should work as expected. Review URL: http://codereview.chromium.org/3227003 TBR=estade@chromium.org Review URL: http://codereview.chromium.org/3257005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@57891 0039d316-1c4b-4281-b951-d872f2087c98
* [GTK] a couple of constrained window fixes:estade@chromium.org2010-08-301-36/+15
| | | | | | | | | | | | | 1) don't grab focus when the parent tab isn't showing. Grab the focus when the tab is brought to the front. 2) handle escape via normal key handling rather than accelerator keys 3) don't allow the content view to take focus (via tab) when the constrained window is showing. BUG=53242, 50799 TEST=see bugs. Also, tabbing between constrained window and url bar should work as expected. Review URL: http://codereview.chromium.org/3227003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@57885 0039d316-1c4b-4281-b951-d872f2087c98
* More gtk signal handler macro conversion.estade@chromium.org2010-05-071-1/+4
| | | | | | | | | BUG=none TEST=none Review URL: http://codereview.chromium.org/1981006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@46652 0039d316-1c4b-4281-b951-d872f2087c98
* Fix for LoginPromptTesti.CancelRedundantAuths and related tests on linux views.zelidrag@chromium.org2010-04-141-3/+5
| | | | | | | | | BUG=27585 TEST=run ui_test for linux views build Review URL: http://codereview.chromium.org/1599030 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@44580 0039d316-1c4b-4281-b951-d872f2087c98
* Fixed ESC handling on constrained dialogs on GTK. We used to stop the entire ↵zelidrag@chromium.org2010-04-141-1/+36
| | | | | | | | | | | page navigation previously instead of continuing with other page elements if some can't be loaded. This change makes GTK implementation consistent with other platforms. BUG=27585 TEST=go to http://www/~thakis/cgi-bin/test.html, press ESC when login dialog appears, observe broken image #1, press ESC on the next dialog, observe broken image #2. Review URL: http://codereview.chromium.org/1627022 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@44527 0039d316-1c4b-4281-b951-d872f2087c98
* Next part of bad dependency removal (chrome/common -> chrome/browser)phajdan.jr@chromium.org2010-03-021-1/+1
| | | | | | | | | | | This change introduces one more dependency on chrome/browser, but it seems simpler to move gtk_util first and then fix it. TEST=none BUG=none Review URL: http://codereview.chromium.org/661271 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@40369 0039d316-1c4b-4281-b951-d872f2087c98
* Tab-modal dialog improvements:zelidrag@google.com2010-01-151-5/+11
| | | | | | | | | | | | | | | | - treat constrained dialogs as tab-modal - only one shows at the time - added visual indication (tab pulsing) to the tab strip when a tab is blocked by a tab-modal dialog - blocked all UI activity from rendrer host and forced refocusing on constrained (tab-modal) dialogs This CL reverts http://codereview.chromium.org/384113 and instead incorporates the changes from http://codereview.chromium.org/392018. BUG=456,27585,27620 TEST=Go to http://www/~thakis/cgi-bin/test.html, hit esc. Review URL: http://codereview.chromium.org/541056 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@36415 0039d316-1c4b-4281-b951-d872f2087c98
* Linux: convert classes GtkUtil/GtkTreeUtil back to namespaces ↵mdm@chromium.org2009-07-311-2/+2
| | | | | | | | | | | gtk_util/gtk_tree_util. BUG=none TEST=none Review URL: http://codereview.chromium.org/160417 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22130 0039d316-1c4b-4281-b951-d872f2087c98
* Linux: convert namespace gtk_util to class GtkUtil to meet style guidelines.mdm@chromium.org2009-07-301-2/+2
| | | | | | | | | BUG=none TEST=none Review URL: http://codereview.chromium.org/160371 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22036 0039d316-1c4b-4281-b951-d872f2087c98
* GTK: Polish HTTP Auth UI. Adds standard border and word wraps the label.erg@google.com2009-06-221-5/+3
| | | | | | | | http://crbug.com/11512 Review URL: http://codereview.chromium.org/140076 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18930 0039d316-1c4b-4281-b951-d872f2087c98
* GTK: HTTP Auth dialogs under linux.erg@google.com2009-06-191-0/+63
- Implements a ConstrainedWindowGtk which positions itself in the center of its corresponding TabContentsViewGtk. - Implements LoginPromptGtk. HTTP Auth now works under Linux. - Renames ConstrainedWindowImpl to ConstrainedWindowWin http://crbug.com/11512 Review URL: http://codereview.chromium.org/132047 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18864 0039d316-1c4b-4281-b951-d872f2087c98
generated by cgit v1.1 at 2025-05-20 04:03:19 +0000