summaryrefslogtreecommitdiffstats
path: root/chrome/browser/gtk/dialogs_gtk.cc
Commit message (Collapse)AuthorAgeFilesLines
* Rename ChromeThread to BrowserThread Part20:tfarina@chromium.org2010-10-121-1/+1
| | | | | | | | | | | - Include browser_thread.h instead of chrome_thread.h in more 70 files. BUG=56926 TEST=trybots Review URL: http://codereview.chromium.org/3734002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@62276 0039d316-1c4b-4281-b951-d872f2087c98
* Rename ChromeThread to BrowserThread Part11:tfarina@chromium.org2010-10-101-2/+2
| | | | | | | | | | | - Rename entries under geolocation, google, gtk, history and importer. BUG=56926 TEST=trybots Review URL: http://codereview.chromium.org/3646002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@62106 0039d316-1c4b-4281-b951-d872f2087c98
* Convert occurrences of WideToUTF{8,16}(l10n_util::GetString...() ...viettrungluu@chromium.org2010-08-081-2/+2
| | | | | | | | | | | ... to l10n::GetString...UTF{8,16}(). BUG=23581 TEST=builds and tests pass Review URL: http://codereview.chromium.org/3054052 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@55371 0039d316-1c4b-4281-b951-d872f2087c98
* GTK: More signal overhaul.erg@chromium.org2010-05-051-54/+43
| | | | | | | | | BUG=none TEST=none Review URL: http://codereview.chromium.org/1920002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@46423 0039d316-1c4b-4281-b951-d872f2087c98
* chrome 4: string_util.h -> utf_string_conversions.h fix.jhawkins@chromium.org2010-03-081-1/+1
| | | | | | | | BUG=none TEST=none Review URL: http://codereview.chromium.org/671019 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@40960 0039d316-1c4b-4281-b951-d872f2087c98
* Remove redundant casts in g_signal_connect() throughout all gtk code we have.erg@chromium.org2010-02-101-4/+4
| | | | | | | | | BUG=none TEST=none Review URL: http://codereview.chromium.org/600033 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@38629 0039d316-1c4b-4281-b951-d872f2087c98
* linux: prompt before overwriting a file in downloadsevan@chromium.org2010-01-091-0/+2
| | | | | | | | | | | | We rename implicit downloads so they don't conflict with existing files, but we should prompt if you manually type in an existing filename. BUG=26117 Review URL: http://codereview.chromium.org/537005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@35859 0039d316-1c4b-4281-b951-d872f2087c98
* Fix crash on opening a file save dialog when the parent tab has no content ↵kinuko@chromium.org2009-12-171-7/+11
| | | | | | | | | | | | on Mac/Linux BUG=29213 TEST=Check 'Ask where to save each file before downloading' in 'Under the Hood' preferences. Open a page that has links to downloadable items (like http://ftp.sunet.se/pub/Linux/kernels/v1.0/). Right-click on one of the item and choose 'Open Link in New Tab'. Make sure an empty tab opens and a dialog appears for asking where to save the file. Make sure the dialog does not disappear immediately. Make sure that closing the empty tab do not crash the browser. Review URL: http://codereview.chromium.org/507024 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@34820 0039d316-1c4b-4281-b951-d872f2087c98
* Ninth patch in making destructors of refcounted objects private.jam@chromium.org2009-11-071-1/+2
| | | | | | | | BUG=26749 Review URL: http://codereview.chromium.org/372013 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31357 0039d316-1c4b-4281-b951-d872f2087c98
* Keep track of when file dialogs are destroyed.thestig@chromium.org2009-11-041-14/+23
| | | | | | | | BUG=none TEST=Open two windows, open a file dialog in one, quit the browser in other. There should not be any GTK assertion errors. Review URL: http://codereview.chromium.org/339096 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30930 0039d316-1c4b-4281-b951-d872f2087c98
* Third patch in getting rid of caching MessageLoop pointers and always using ↵jam@chromium.org2009-11-021-4/+3
| | | | | | | | | | ChromeThread instead. BUG=25354 Review URL: http://codereview.chromium.org/342068 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30687 0039d316-1c4b-4281-b951-d872f2087c98
* Do not allow GTK File Chooser dialogs to return directories. This is ↵thestig@chromium.org2009-10-291-14/+66
| | | | | | | | | | probably a regression in newer versions of GTK. BUG=23595 TEST=In Jaunty, attempt to attach /usr/bin in Gmail. Review URL: http://codereview.chromium.org/306060 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30425 0039d316-1c4b-4281-b951-d872f2087c98
* Fix a couple gtk file chooser crashers.estade@chromium.org2009-10-221-7/+13
| | | | | | | | | BUG=25493 BUG=25490 Review URL: http://codereview.chromium.org/324002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29816 0039d316-1c4b-4281-b951-d872f2087c98
* GTK: make sure to delete any remaining dialogs when the SelectFileDialogImpl ↵estade@chromium.org2009-10-071-0/+11
| | | | | | | | | | | | | | | | | | | | | | object goes out of scope. The control flow was as follows: 1. user initiates a save page command 2. user initiates a second save page command 3. tab contents creates a SavePackage, shows dialog 4. tab contents gets second OnSavePage, deletes old SavePackage, which deletes its SelectFileDialogImpl 5. At this point two dialogs are visible. 6. User dismisses second dialog. 7. User dismisses first dialog, and calls us back with pointer to freed SelectFileDialogImpl. 8. Bad stuff. BUG=23817 TEST=I put a sleep in Browser::SavePage, then hit ctrl+s twice quickly. Only one dialog appeared. Review URL: http://codereview.chromium.org/243117 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28213 0039d316-1c4b-4281-b951-d872f2087c98
* GTK: Implement folder chooser dialog.estade@chromium.org2009-09-041-6/+43
| | | | | | | | | | Also, found another gtk bug: http://bugzilla.gnome.org/show_bug.cgi?id=594089 We can't write a suppression for this bug because the warning message is too generic, but it shouldn't be much of a problem in release builds. BUG=20940 Review URL: http://codereview.chromium.org/196014 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25485 0039d316-1c4b-4281-b951-d872f2087c98
* GTK file picker: Use mime type filters instead of shell-style glob filters.estade@chromium.org2009-09-031-12/+9
| | | | | | | | BUG=12347 Review URL: http://codereview.chromium.org/192011 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25377 0039d316-1c4b-4281-b951-d872f2087c98
* GTK: Change file chooser dialogs to prefer the suggested path (somewhatly ↵estade@chromium.org2009-08-141-18/+28
| | | | | | | | | | | | erroneously known as "default_path") over the last selected path. Also respect default_path for file save dialogs. This fixes a DCHECK we could hit from <upload> elements (as it turns out, there was no Release-mode crash). BUG=19267 Review URL: http://codereview.chromium.org/170014 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23485 0039d316-1c4b-4281-b951-d872f2087c98
* Make some default file dialog titles for linux.estade@chromium.org2009-07-251-3/+12
| | | | | | | | | | | Seems Windows only lets you set some text inside the dialog above the tree view, and not in the titlebar. BUG=16890 TEST=should be obvious Review URL: http://codereview.chromium.org/159326 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21600 0039d316-1c4b-4281-b951-d872f2087c98
* Make GTK file dialog box modal for parent window, instead of for the entireestade@chromium.org2009-07-211-6/+7
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | application. This works by adding the top-level GtkWindow objects, such as BrowserWindowGtk and BookmarkManagerGtk, to their own unique window groups. Without this change, all top-level windows are added to a default application-wide window group. This ensures that all grabs created with gtk_grab_add(...) only affect the window group of the grabbed widget, as opposed to the entire application. Note that gtk_window_set_modal(...) is implemented with gtk_grab_add(...) and therefore is only modal to a specific window group. In order for this to work correctly, changes were also made to the info bubble and render widget popup (<select> tag) code. Since these widgets also call gtk_grab_add(...), they must be added to the top level window group to work correctly. Test 1: - Open two new chrome window: A and B - Open "Save file as..." dialog in window A - Verify that window A does not respond to keyboard or mouse events. - Verify that window B does responde to keyboard and mouse events. - Open "Save file as..." dialog in window B - Verify that window B does not respond to keyboard or mouse events. - Cancel dialog on window A. - Verify that window A starts responding to keyboard and mouse events. - Cancel dialog on window B. - Verify that window B starts responding to keyboard and mouse events. Test 2: - Verify that <select> tag allows for correct selection of items. Test 3: - Click bookmark star and verify that info bubble works correctly. BUG=8727 TEST=none patch by Mohit Muthanna Cheppudira <mohit.muthanna [at] gmail> original review url: <http://codereview.chromium.org/155852> Review URL: http://codereview.chromium.org/159147 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21207 0039d316-1c4b-4281-b951-d872f2087c98
* Revert r20667, which broke dropdown menus.estade@chromium.org2009-07-151-8/+6
| | | | | | | | TBR=evan Review URL: http://codereview.chromium.org/155557 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20717 0039d316-1c4b-4281-b951-d872f2087c98
* Make GTK file dialog box modal for parent window, instead of for the entireestade@chromium.org2009-07-141-6/+8
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | application. This works by adding the GtkWindow in BrowserWindowGtk to its own GtkWindowGroup and adding the SelectFile dialog to the same group. The following call to gtk_grab_add(...) makes the SelectFile dialog modal, but only to the windows within the same group. Similarly, the bookmark manager window is also added to its own unique GtkWindowGroup, so the import/export dialogs behave correctly. If I'm understanding things correctly, the GtkWindowGroup objects are reference counted once the have windows attached to them, and will delete themselves after all references to them are destroyed. I'm not sure how to verify this. Test: - Open two new chrome window: A and B - Open "Save file as..." dialog in window A - Verify that window A does not respond to keyboard or mouse events. - Verify that window B does responde to keyboard and mouse events. - Open "Save file as..." dialog in window B - Verify that window B does not respond to keyboard or mouse events. - Cancel dialog on window A. - Verify that window A starts responding to keyboard and mouse events. - Cancel dialog on window B. - Verify that window B starts responding to keyboard and mouse events. BUG=8727 patch by Mohit Muthanna <mmuthanna@google.com> original review URL: http://codereview.chromium.org/149548 Review URL: http://codereview.chromium.org/155518 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20667 0039d316-1c4b-4281-b951-d872f2087c98
* GTK: Preview images in file chooser.estade@chromium.org2009-07-031-0/+36
| | | | | | | | | BUG=http://crbug.com/15500 TEST=select an image in a file chooser Review URL: http://codereview.chromium.org/151100 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19874 0039d316-1c4b-4281-b951-d872f2087c98
* Linux: reject empty file filters for file chooser dialogs.estade@chromium.org2009-05-201-3/+10
| | | | | | | | | | Note that this is temporary in that, in the long run, we should be using mime type filters rather than shell-style globs. TEST=right click/save as on a link. There should be no "*." filter. Review URL: http://codereview.chromium.org/113660 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16533 0039d316-1c4b-4281-b951-d872f2087c98
* Linux: remember user's last selected path for select file dialogs.estade@chromium.org2009-05-061-7/+50
| | | | | | | | | | | | | Note that paths are remembered separately for save and open. This is *not* the same behavior as windows chrome/linux firefox, which remember the same path for both save and open. My justification is the following scenario: 1. User presses ctrl-o, and selects a file from the desktop. 2. One hour later, user presses ctrl-s to save a webpage. 3. User expects to be saving to his default download dir, but instead gets the desktop. 4. Huh? Review URL: http://codereview.chromium.org/115007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15430 0039d316-1c4b-4281-b951-d872f2087c98
* Move l10n_util to app/ben@chromium.org2009-05-051-1/+1
| | | | | | | http://crbug.com/11387 Review URL: http://codereview.chromium.org/109043 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15352 0039d316-1c4b-4281-b951-d872f2087c98
* Gtk file selection filters, first cut.estade@chromium.org2009-04-241-4/+76
| | | | | | Review URL: http://codereview.chromium.org/92153 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@14502 0039d316-1c4b-4281-b951-d872f2087c98
* Add a Cocoa file picker.avi@google.com2009-04-141-4/+1
| | | | | | Review URL: http://codereview.chromium.org/73044 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13695 0039d316-1c4b-4281-b951-d872f2087c98
* Refactoring; switch the |filter| parameter into something that is more ↵avi@chromium.org2009-04-121-14/+15
| | | | | | | | | | amenable to cross-platform implementation. BUG=9852 Review URL: http://codereview.chromium.org/63093 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13573 0039d316-1c4b-4281-b951-d872f2087c98
* First pass of refactoring dialogs.avi@chromium.org2009-04-061-20/+14
| | | | | | Review URL: http://codereview.chromium.org/60110 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13168 0039d316-1c4b-4281-b951-d872f2087c98
* A file I left out of rietveld issue 56153estade@chromium.org2009-04-021-1/+1
| | | | | | | | TBR=paul Review URL: http://codereview.chromium.org/56182 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13019 0039d316-1c4b-4281-b951-d872f2087c98
* Remove Windows "Save As" dialogs from Save Page code.In this change:- ↵paulg@google.com2009-03-301-1/+3
| | | | | | | | convert SavePackage to use async SelectFileDialog- return the chosen filter index in the FileSelected callback- some clean up of save_package.ccBUG=8691 (http://crbug.com/8691) Review URL: http://codereview.chromium.org/45048 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@12799 0039d316-1c4b-4281-b951-d872f2087c98
* Implement 2 more gtk dialogs: open file and open multiple files.estade@chromium.org2009-03-131-25/+138
| | | | | | | | | | | Test for single file dialog: - <html><body><input type=file></body></html> Test for multiple files dialog: - <html><body><input type=file multiple></body></html> Review URL: http://codereview.chromium.org/46024 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11677 0039d316-1c4b-4281-b951-d872f2087c98
* Gtk dialogs, first cut.estade@chromium.org2009-03-121-0/+182
Only the Save As file selection dialog is implemented for now. Review URL: http://codereview.chromium.org/42152 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11594 0039d316-1c4b-4281-b951-d872f2087c98
generated by cgit v1.1 at 2025-02-15 04:08:14 +0000